Skip to content

QUIC ALPN list narrowing down scenario test - #86659

Merged
liveans merged 9 commits into
dotnet:mainfrom
liveans:quic_alpn_change_test
Jun 22, 2023
Merged

QUIC ALPN list narrowing down scenario test#86659
liveans merged 9 commits into
dotnet:mainfrom
liveans:quic_alpn_change_test

Conversation

@liveans

@liveansliveans commented May 23, 2023

Copy link
Copy Markdown
Contributor

Fixes#49423

@ghostghost assigned liveansMay 23, 2023
@liveans
liveans requested a review from wfurtMay 23, 2023 19:55
@ghost

ghost commented May 23, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #49423

Author:liveans
Assignees:-
Labels:

area-System.Net.Quic

Milestone:-

@liveans
liveans requested a review from ManickaPMay 23, 2023 19:55
CarnaViire
CarnaViire reviewed May 23, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/tests/FunctionalTests/QuicListenerTests.cs Outdated
CarnaViire
CarnaViire reviewed May 23, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/tests/FunctionalTests/QuicListenerTests.cs Outdated
CarnaViire
CarnaViire reviewed May 23, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/tests/FunctionalTests/QuicListenerTests.cs Outdated
Ahmet Ibrahim Aksoy@CarnaViire
Update src/libraries/System.Net.Quic/tests/FunctionalTests/QuicListen…
9ca6e7c
…erTests.cs
Co-authored-by: Natalia Kondratyeva <knatalia@microsoft.com>
@build-analysisbuild-analysisBot mentioned this pull request May 24, 2023
Closed
rzikm
rzikm reviewed May 24, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/tests/FunctionalTests/QuicListenerTests.cs
@build-analysisbuild-analysisBot mentioned this pull request May 24, 2023
Closed
rzikm
rzikm approved these changes May 25, 2023
View reviewed changes

@rzikmrzikm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo existing comments

ManickaP
ManickaP approved these changes May 25, 2023
View reviewed changes

@ManickaPManickaP left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comments, thanks!

Comment threadsrc/libraries/System.Net.Quic/tests/FunctionalTests/QuicListenerTests.cs Outdated
Comment threadsrc/libraries/System.Net.Quic/tests/FunctionalTests/QuicListenerTests.cs Outdated
Comment threadsrc/libraries/System.Net.Quic/tests/FunctionalTests/QuicListenerTests.cs Outdated
@build-analysisbuild-analysisBot mentioned this pull request May 25, 2023
Closed
@liveansliveans mentioned this pull request Jun 2, 2023
Merged
@liveansliveans mentioned this pull request Jun 12, 2023
Closed
@liveans
liveans merged commit 5bc65b0 into dotnet:mainJun 22, 2023
@karelzkarelz added this to the 8.0.0 milestone Jul 3, 2023
@ghostghost locked as resolved and limited conversation to collaborators Aug 2, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@CarnaViireCarnaViireCarnaViire left review comments
@ManickaPManickaPManickaP approved these changes
@rzikmrzikmrzikm approved these changes
@wfurtwfurtAwaiting requested review from wfurt

Assignees

@liveansliveans

Labels

area-System.Net.Quic

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

QUIC: Validate SslServerAuthenticationOptions set on QuicListenerOptions

6 participants

@liveans@CarnaViire@ManickaP@wfurt@rzikm@karelz