StreamOnSqlBytes Read/Write on Spans

[hrrrrustic]

Close#69921

[ghost]

Tagging subscribers to this area: @roji, @ajcvickers
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Close #69921

Author:	hrrrrustic
Assignees:	-
Labels:	area-System.Data, community-contribution
Milestone:	-

[gfoidl]

Instead of the null-forgiving operator I'd prefer a Debug.Assert(_rgbBuf is not null), as in case it's actually null, then in CI the assert fails.
Same on other places.

Except it's really 100 % sure that it can't be null here, then ignore this comment.

[hrrrrustic]

I copied all of ! from old array-based methods so I assume we are 100% sure

[stephentoub]

Please remove the ! and add the assert. The ! was ok when this was in the Read method that was also checking IsNull and throwing, but now this is reachable from an internal method that has no such check.

[hrrrrustic]

But internal method also has IsNull check under your comment about arguments order 🤔

[stephentoub]

Please remove the ! and add the assert. The ! was ok when this was in the Read method that was also checking IsNull and throwing, but now this is reachable from an internal method that has no such check.

[danmoseley]

@stephentoub do you have other feedback here?

@ajcvickers is there someone from code owners that can review it ?

[stephentoub]

All test failures are known

[hrrrrustic]

Close#69921

[ghost]

Tagging subscribers to this area: @roji, @ajcvickers
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Close #69921

Author:	hrrrrustic
Assignees:	-
Labels:	area-System.Data, community-contribution
Milestone:	-

[gfoidl]

Instead of the null-forgiving operator I'd prefer a Debug.Assert(_rgbBuf is not null), as in case it's actually null, then in CI the assert fails.
Same on other places.

Except it's really 100 % sure that it can't be null here, then ignore this comment.

[hrrrrustic]

I copied all of ! from old array-based methods so I assume we are 100% sure

[stephentoub]

Please remove the ! and add the assert. The ! was ok when this was in the Read method that was also checking IsNull and throwing, but now this is reachable from an internal method that has no such check.

[hrrrrustic]

But internal method also has IsNull check under your comment about arguments order 🤔

[stephentoub]

Please remove the ! and add the assert. The ! was ok when this was in the Read method that was also checking IsNull and throwing, but now this is reachable from an internal method that has no such check.

[danmoseley]

@stephentoub do you have other feedback here?

@ajcvickers is there someone from code owners that can review it ?

[stephentoub]

All test failures are known

[hrrrrustic]

Close#69921

[ghost]

Tagging subscribers to this area: @roji, @ajcvickers
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Close #69921

Author:	hrrrrustic
Assignees:	-
Labels:	area-System.Data, community-contribution
Milestone:	-

[gfoidl]

Instead of the null-forgiving operator I'd prefer a Debug.Assert(_rgbBuf is not null), as in case it's actually null, then in CI the assert fails.
Same on other places.

Except it's really 100 % sure that it can't be null here, then ignore this comment.

[hrrrrustic]

I copied all of ! from old array-based methods so I assume we are 100% sure

[stephentoub]

Please remove the ! and add the assert. The ! was ok when this was in the Read method that was also checking IsNull and throwing, but now this is reachable from an internal method that has no such check.

[hrrrrustic]

But internal method also has IsNull check under your comment about arguments order 🤔

[stephentoub]

Please remove the ! and add the assert. The ! was ok when this was in the Read method that was also checking IsNull and throwing, but now this is reachable from an internal method that has no such check.

[danmoseley]

@stephentoub do you have other feedback here?

@ajcvickers is there someone from code owners that can review it ?

[stephentoub]

All test failures are known

[hrrrrustic]

Close#69921

[ghost]

Tagging subscribers to this area: @roji, @ajcvickers
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Close #69921

Author:	hrrrrustic
Assignees:	-
Labels:	area-System.Data, community-contribution
Milestone:	-

[gfoidl]

Instead of the null-forgiving operator I'd prefer a Debug.Assert(_rgbBuf is not null), as in case it's actually null, then in CI the assert fails.
Same on other places.

Except it's really 100 % sure that it can't be null here, then ignore this comment.

[hrrrrustic]

I copied all of ! from old array-based methods so I assume we are 100% sure

[stephentoub]

Please remove the ! and add the assert. The ! was ok when this was in the Read method that was also checking IsNull and throwing, but now this is reachable from an internal method that has no such check.

[hrrrrustic]

But internal method also has IsNull check under your comment about arguments order 🤔

[stephentoub]

Please remove the ! and add the assert. The ! was ok when this was in the Read method that was also checking IsNull and throwing, but now this is reachable from an internal method that has no such check.

[danmoseley]

@stephentoub do you have other feedback here?

@ajcvickers is there someone from code owners that can review it ?

[stephentoub]

All test failures are known

[hrrrrustic]

Close#69921

[ghost]

Tagging subscribers to this area: @roji, @ajcvickers
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Close #69921

Author:	hrrrrustic
Assignees:	-
Labels:	area-System.Data, community-contribution
Milestone:	-

[gfoidl]

Instead of the null-forgiving operator I'd prefer a Debug.Assert(_rgbBuf is not null), as in case it's actually null, then in CI the assert fails.
Same on other places.

Except it's really 100 % sure that it can't be null here, then ignore this comment.

[hrrrrustic]

I copied all of ! from old array-based methods so I assume we are 100% sure

[stephentoub]

Please remove the ! and add the assert. The ! was ok when this was in the Read method that was also checking IsNull and throwing, but now this is reachable from an internal method that has no such check.

[hrrrrustic]

But internal method also has IsNull check under your comment about arguments order 🤔

[stephentoub]

Please remove the ! and add the assert. The ! was ok when this was in the Read method that was also checking IsNull and throwing, but now this is reachable from an internal method that has no such check.

[danmoseley]

@stephentoub do you have other feedback here?

@ajcvickers is there someone from code owners that can review it ?

[stephentoub]

All test failures are known

[hrrrrustic]

Close#69921

[ghost]

Tagging subscribers to this area: @roji, @ajcvickers
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Close #69921

Author:	hrrrrustic
Assignees:	-
Labels:	area-System.Data, community-contribution
Milestone:	-

[gfoidl]

Instead of the null-forgiving operator I'd prefer a Debug.Assert(_rgbBuf is not null), as in case it's actually null, then in CI the assert fails.
Same on other places.

Except it's really 100 % sure that it can't be null here, then ignore this comment.

[hrrrrustic]

I copied all of ! from old array-based methods so I assume we are 100% sure

[stephentoub]

Please remove the ! and add the assert. The ! was ok when this was in the Read method that was also checking IsNull and throwing, but now this is reachable from an internal method that has no such check.

[hrrrrustic]

But internal method also has IsNull check under your comment about arguments order 🤔

[stephentoub]

Please remove the ! and add the assert. The ! was ok when this was in the Read method that was also checking IsNull and throwing, but now this is reachable from an internal method that has no such check.

[danmoseley]

@stephentoub do you have other feedback here?

@ajcvickers is there someone from code owners that can review it ?

[stephentoub]

All test failures are known

[hrrrrustic]

Close#69921

[ghost]

Tagging subscribers to this area: @roji, @ajcvickers
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Close #69921

Author:	hrrrrustic
Assignees:	-
Labels:	area-System.Data, community-contribution
Milestone:	-

[gfoidl]

Instead of the null-forgiving operator I'd prefer a Debug.Assert(_rgbBuf is not null), as in case it's actually null, then in CI the assert fails.
Same on other places.

Except it's really 100 % sure that it can't be null here, then ignore this comment.

[hrrrrustic]

I copied all of ! from old array-based methods so I assume we are 100% sure

[stephentoub]

Please remove the ! and add the assert. The ! was ok when this was in the Read method that was also checking IsNull and throwing, but now this is reachable from an internal method that has no such check.

[hrrrrustic]

But internal method also has IsNull check under your comment about arguments order 🤔

[stephentoub]

Please remove the ! and add the assert. The ! was ok when this was in the Read method that was also checking IsNull and throwing, but now this is reachable from an internal method that has no such check.

[danmoseley]

@stephentoub do you have other feedback here?

@ajcvickers is there someone from code owners that can review it ?

[stephentoub]

All test failures are known

[hrrrrustic]

Close#69921

[ghost]

Tagging subscribers to this area: @roji, @ajcvickers
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Close #69921

Author:	hrrrrustic
Assignees:	-
Labels:	area-System.Data, community-contribution
Milestone:	-

[gfoidl]

Instead of the null-forgiving operator I'd prefer a Debug.Assert(_rgbBuf is not null), as in case it's actually null, then in CI the assert fails.
Same on other places.

Except it's really 100 % sure that it can't be null here, then ignore this comment.

[hrrrrustic]

I copied all of ! from old array-based methods so I assume we are 100% sure

[stephentoub]

Please remove the ! and add the assert. The ! was ok when this was in the Read method that was also checking IsNull and throwing, but now this is reachable from an internal method that has no such check.

[hrrrrustic]

But internal method also has IsNull check under your comment about arguments order 🤔

[stephentoub]

Please remove the ! and add the assert. The ! was ok when this was in the Read method that was also checking IsNull and throwing, but now this is reachable from an internal method that has no such check.

[danmoseley]

@stephentoub do you have other feedback here?

@ajcvickers is there someone from code owners that can review it ?

[stephentoub]

All test failures are known