Uh oh!
There was an error while loading. Please reload this page.
Add some more testing around shadowing, inheritance, and project boundaries. - #86732
Conversation
ghost
commented
May 24, 2023
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsInitially this was meant to be a test suite to catch #86662, but now it's just regression tests for it and behavior validation tests for other scenarios I thought of at the time.
|
Uh oh!
There was an error while loading. Please reload this page.
| test.SolutionTransforms.Add((sln, _) => | ||
| { | ||
| var additionalProject = sln.Projects.First(proj => proj.Name == "Other"); | ||
| return additionalProject.WithCompilationOptions(new CSharpCompilationOptions(OutputKind.DynamicallyLinkedLibrary, allowUnsafe: true)).Solution; | ||
| }); |
There was a problem hiding this comment.
Do you think it's worth it to make a new Test subclass for tests with AdditionProjects?
There was a problem hiding this comment.
No, I think doing it manually for the cases where we need it is okay. It's not a lot of packages and it's easy to mess with.
Also I'll probably fix this issue in the Roslyn-SDK at some point and then we can get rid of the solution transform.
jkoritzinsky
commented
May 25, 2023
Failures are all known. |
Initially this was meant to be a test suite to catch #86662, but now it's just regression tests for it and behavior validation tests for other scenarios I thought of at the time.