Address Metrics APIs issues by tarekgh · Pull Request #86740 · dotnet/runtime

tarekgh · 2023-05-25T01:32:00Z

The changes here addressing the following issues:

To ensure the factory owns the meter's lifetime, the factory's created meter should have a no-op disposal operation. [Tracking] Figure out how we should handle the disposing of the meters created from meter factory #86592
Ignore the order of the tags when caching instruments and meters to make them order insensitive. [Tracking] Decide if the tags order matter when creating meter or instrument #86614
Remove the scope parameter from the IMeterFactory extension Create method.
Throw exception when the user calls IMeterFactory passing MeterOptions with non-null scope and not equal to IMeterFactory instance. DefaultMeterFactory.Create and MeterOptions.Scope #86684
Moved the IMeterFactory Create method from Microsoft.Extensions.Diagnostics to Microsoft.Extensions.Diagnostics.Abstraction library.
Remove the added dependency on the System.Linq in the system.Diagnostics.DiagnosticSource library.

ghost · 2023-05-25T01:32:06Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

stephentoub · 2023-05-25T01:34:10Z

 internal static class DiagnosticsHelper
 {
- internal static bool CompareTags(IEnumerable<KeyValuePair<string, object?>>? tags1, IEnumerable<KeyValuePair<string, object?>>? tags2)
+ // This is similar to System.Linq ToArray. We are not using System.Linq here to avoid the dependency.


Why is the dependency problematic?

The auto-instrumentation can force loading higher version of System.Diagnostics.DiagnosticSource than the version of the one that app built with. Increasing the dependency of System.Diagnostics.DiagnosticSource can increase the risk of breaking the auto-instrumentation. Here is some related issue talking about similar thing #42244

tarekgh · 2023-05-25T02:49:49Z

#86567
#77514

noahfalk

Mostly looked good. I think I spotted two bugs and a few other suggestions inline.

tarekgh · 2023-05-25T01:32:00Z

The changes here addressing the following issues:

To ensure the factory owns the meter's lifetime, the factory's created meter should have a no-op disposal operation. [Tracking] Figure out how we should handle the disposing of the meters created from meter factory #86592
Ignore the order of the tags when caching instruments and meters to make them order insensitive. [Tracking] Decide if the tags order matter when creating meter or instrument #86614
Remove the scope parameter from the IMeterFactory extension Create method.
Throw exception when the user calls IMeterFactory passing MeterOptions with non-null scope and not equal to IMeterFactory instance. DefaultMeterFactory.Create and MeterOptions.Scope #86684
Moved the IMeterFactory Create method from Microsoft.Extensions.Diagnostics to Microsoft.Extensions.Diagnostics.Abstraction library.
Remove the added dependency on the System.Linq in the system.Diagnostics.DiagnosticSource library.

ghost · 2023-05-25T01:32:06Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

stephentoub · 2023-05-25T01:34:10Z

 internal static class DiagnosticsHelper
 {
- internal static bool CompareTags(IEnumerable<KeyValuePair<string, object?>>? tags1, IEnumerable<KeyValuePair<string, object?>>? tags2)
+ // This is similar to System.Linq ToArray. We are not using System.Linq here to avoid the dependency.


Why is the dependency problematic?

The auto-instrumentation can force loading higher version of System.Diagnostics.DiagnosticSource than the version of the one that app built with. Increasing the dependency of System.Diagnostics.DiagnosticSource can increase the risk of breaking the auto-instrumentation. Here is some related issue talking about similar thing #42244

tarekgh · 2023-05-25T02:49:49Z

#86567
#77514

noahfalk

Mostly looked good. I think I spotted two bugs and a few other suggestions inline.

tarekgh · 2023-05-25T01:32:00Z

The changes here addressing the following issues:

To ensure the factory owns the meter's lifetime, the factory's created meter should have a no-op disposal operation. [Tracking] Figure out how we should handle the disposing of the meters created from meter factory #86592
Ignore the order of the tags when caching instruments and meters to make them order insensitive. [Tracking] Decide if the tags order matter when creating meter or instrument #86614
Remove the scope parameter from the IMeterFactory extension Create method.
Throw exception when the user calls IMeterFactory passing MeterOptions with non-null scope and not equal to IMeterFactory instance. DefaultMeterFactory.Create and MeterOptions.Scope #86684
Moved the IMeterFactory Create method from Microsoft.Extensions.Diagnostics to Microsoft.Extensions.Diagnostics.Abstraction library.
Remove the added dependency on the System.Linq in the system.Diagnostics.DiagnosticSource library.

ghost · 2023-05-25T01:32:06Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

stephentoub · 2023-05-25T01:34:10Z

 internal static class DiagnosticsHelper
 {
- internal static bool CompareTags(IEnumerable<KeyValuePair<string, object?>>? tags1, IEnumerable<KeyValuePair<string, object?>>? tags2)
+ // This is similar to System.Linq ToArray. We are not using System.Linq here to avoid the dependency.


Why is the dependency problematic?

The auto-instrumentation can force loading higher version of System.Diagnostics.DiagnosticSource than the version of the one that app built with. Increasing the dependency of System.Diagnostics.DiagnosticSource can increase the risk of breaking the auto-instrumentation. Here is some related issue talking about similar thing #42244

tarekgh · 2023-05-25T02:49:49Z

#86567
#77514

noahfalk

Mostly looked good. I think I spotted two bugs and a few other suggestions inline.

tarekgh · 2023-05-25T01:32:00Z

The changes here addressing the following issues:

To ensure the factory owns the meter's lifetime, the factory's created meter should have a no-op disposal operation. [Tracking] Figure out how we should handle the disposing of the meters created from meter factory #86592
Ignore the order of the tags when caching instruments and meters to make them order insensitive. [Tracking] Decide if the tags order matter when creating meter or instrument #86614
Remove the scope parameter from the IMeterFactory extension Create method.
Throw exception when the user calls IMeterFactory passing MeterOptions with non-null scope and not equal to IMeterFactory instance. DefaultMeterFactory.Create and MeterOptions.Scope #86684
Moved the IMeterFactory Create method from Microsoft.Extensions.Diagnostics to Microsoft.Extensions.Diagnostics.Abstraction library.
Remove the added dependency on the System.Linq in the system.Diagnostics.DiagnosticSource library.

ghost · 2023-05-25T01:32:06Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

stephentoub · 2023-05-25T01:34:10Z

 internal static class DiagnosticsHelper
 {
- internal static bool CompareTags(IEnumerable<KeyValuePair<string, object?>>? tags1, IEnumerable<KeyValuePair<string, object?>>? tags2)
+ // This is similar to System.Linq ToArray. We are not using System.Linq here to avoid the dependency.


Why is the dependency problematic?

The auto-instrumentation can force loading higher version of System.Diagnostics.DiagnosticSource than the version of the one that app built with. Increasing the dependency of System.Diagnostics.DiagnosticSource can increase the risk of breaking the auto-instrumentation. Here is some related issue talking about similar thing #42244

tarekgh · 2023-05-25T02:49:49Z

#86567
#77514

noahfalk

Mostly looked good. I think I spotted two bugs and a few other suggestions inline.

tarekgh · 2023-05-25T01:32:00Z

The changes here addressing the following issues:

To ensure the factory owns the meter's lifetime, the factory's created meter should have a no-op disposal operation. [Tracking] Figure out how we should handle the disposing of the meters created from meter factory #86592
Ignore the order of the tags when caching instruments and meters to make them order insensitive. [Tracking] Decide if the tags order matter when creating meter or instrument #86614
Remove the scope parameter from the IMeterFactory extension Create method.
Throw exception when the user calls IMeterFactory passing MeterOptions with non-null scope and not equal to IMeterFactory instance. DefaultMeterFactory.Create and MeterOptions.Scope #86684
Moved the IMeterFactory Create method from Microsoft.Extensions.Diagnostics to Microsoft.Extensions.Diagnostics.Abstraction library.
Remove the added dependency on the System.Linq in the system.Diagnostics.DiagnosticSource library.

ghost · 2023-05-25T01:32:06Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

stephentoub · 2023-05-25T01:34:10Z

 internal static class DiagnosticsHelper
 {
- internal static bool CompareTags(IEnumerable<KeyValuePair<string, object?>>? tags1, IEnumerable<KeyValuePair<string, object?>>? tags2)
+ // This is similar to System.Linq ToArray. We are not using System.Linq here to avoid the dependency.


Why is the dependency problematic?

The auto-instrumentation can force loading higher version of System.Diagnostics.DiagnosticSource than the version of the one that app built with. Increasing the dependency of System.Diagnostics.DiagnosticSource can increase the risk of breaking the auto-instrumentation. Here is some related issue talking about similar thing #42244

tarekgh · 2023-05-25T02:49:49Z

#86567
#77514

noahfalk

Mostly looked good. I think I spotted two bugs and a few other suggestions inline.

tarekgh · 2023-05-25T01:32:00Z

The changes here addressing the following issues:

To ensure the factory owns the meter's lifetime, the factory's created meter should have a no-op disposal operation. [Tracking] Figure out how we should handle the disposing of the meters created from meter factory #86592
Ignore the order of the tags when caching instruments and meters to make them order insensitive. [Tracking] Decide if the tags order matter when creating meter or instrument #86614
Remove the scope parameter from the IMeterFactory extension Create method.
Throw exception when the user calls IMeterFactory passing MeterOptions with non-null scope and not equal to IMeterFactory instance. DefaultMeterFactory.Create and MeterOptions.Scope #86684
Moved the IMeterFactory Create method from Microsoft.Extensions.Diagnostics to Microsoft.Extensions.Diagnostics.Abstraction library.
Remove the added dependency on the System.Linq in the system.Diagnostics.DiagnosticSource library.

ghost · 2023-05-25T01:32:06Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

stephentoub · 2023-05-25T01:34:10Z

 internal static class DiagnosticsHelper
 {
- internal static bool CompareTags(IEnumerable<KeyValuePair<string, object?>>? tags1, IEnumerable<KeyValuePair<string, object?>>? tags2)
+ // This is similar to System.Linq ToArray. We are not using System.Linq here to avoid the dependency.


Why is the dependency problematic?

The auto-instrumentation can force loading higher version of System.Diagnostics.DiagnosticSource than the version of the one that app built with. Increasing the dependency of System.Diagnostics.DiagnosticSource can increase the risk of breaking the auto-instrumentation. Here is some related issue talking about similar thing #42244

tarekgh · 2023-05-25T02:49:49Z

#86567
#77514

noahfalk

Mostly looked good. I think I spotted two bugs and a few other suggestions inline.

tarekgh · 2023-05-25T01:32:00Z

The changes here addressing the following issues:

To ensure the factory owns the meter's lifetime, the factory's created meter should have a no-op disposal operation. [Tracking] Figure out how we should handle the disposing of the meters created from meter factory #86592
Ignore the order of the tags when caching instruments and meters to make them order insensitive. [Tracking] Decide if the tags order matter when creating meter or instrument #86614
Remove the scope parameter from the IMeterFactory extension Create method.
Throw exception when the user calls IMeterFactory passing MeterOptions with non-null scope and not equal to IMeterFactory instance. DefaultMeterFactory.Create and MeterOptions.Scope #86684
Moved the IMeterFactory Create method from Microsoft.Extensions.Diagnostics to Microsoft.Extensions.Diagnostics.Abstraction library.
Remove the added dependency on the System.Linq in the system.Diagnostics.DiagnosticSource library.

ghost · 2023-05-25T01:32:06Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

stephentoub · 2023-05-25T01:34:10Z

 internal static class DiagnosticsHelper
 {
- internal static bool CompareTags(IEnumerable<KeyValuePair<string, object?>>? tags1, IEnumerable<KeyValuePair<string, object?>>? tags2)
+ // This is similar to System.Linq ToArray. We are not using System.Linq here to avoid the dependency.


Why is the dependency problematic?

The auto-instrumentation can force loading higher version of System.Diagnostics.DiagnosticSource than the version of the one that app built with. Increasing the dependency of System.Diagnostics.DiagnosticSource can increase the risk of breaking the auto-instrumentation. Here is some related issue talking about similar thing #42244

tarekgh · 2023-05-25T02:49:49Z

#86567
#77514

noahfalk

Mostly looked good. I think I spotted two bugs and a few other suggestions inline.

tarekgh · 2023-05-25T01:32:00Z

The changes here addressing the following issues:

To ensure the factory owns the meter's lifetime, the factory's created meter should have a no-op disposal operation. [Tracking] Figure out how we should handle the disposing of the meters created from meter factory #86592
Ignore the order of the tags when caching instruments and meters to make them order insensitive. [Tracking] Decide if the tags order matter when creating meter or instrument #86614
Remove the scope parameter from the IMeterFactory extension Create method.
Throw exception when the user calls IMeterFactory passing MeterOptions with non-null scope and not equal to IMeterFactory instance. DefaultMeterFactory.Create and MeterOptions.Scope #86684
Moved the IMeterFactory Create method from Microsoft.Extensions.Diagnostics to Microsoft.Extensions.Diagnostics.Abstraction library.
Remove the added dependency on the System.Linq in the system.Diagnostics.DiagnosticSource library.

ghost · 2023-05-25T01:32:06Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

stephentoub · 2023-05-25T01:34:10Z

 internal static class DiagnosticsHelper
 {
- internal static bool CompareTags(IEnumerable<KeyValuePair<string, object?>>? tags1, IEnumerable<KeyValuePair<string, object?>>? tags2)
+ // This is similar to System.Linq ToArray. We are not using System.Linq here to avoid the dependency.


Why is the dependency problematic?

The auto-instrumentation can force loading higher version of System.Diagnostics.DiagnosticSource than the version of the one that app built with. Increasing the dependency of System.Diagnostics.DiagnosticSource can increase the risk of breaking the auto-instrumentation. Here is some related issue talking about similar thing #42244

tarekgh · 2023-05-25T02:49:49Z

#86567
#77514

noahfalk

Mostly looked good. I think I spotted two bugs and a few other suggestions inline.

Address Metrics APIs issues
d251229

ghost added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels May 25, 2023

ghost assigned tarekgh May 25, 2023

tarekgh requested a review from noahfalk May 25, 2023 01:32

tarekgh added area-System.Diagnostics.Metric and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 25, 2023

tarekgh added this to the 8.0.0 milestone May 25, 2023

stephentoub reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated

stephentoub reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated

stephentoub reviewed May 25, 2023
View reviewed changes

Comment thread...ibraries/Microsoft.Extensions.Diagnostics.Abstractions/src/Metrics/MeterFactoryExtensions.cs

stephentoub reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated

Address the feedback
f477374

build-analysisBot mentioned this pull request May 25, 2023
Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637
Closed

Fix the correct thrown exception name.
69e5efe

noahfalk approved these changes May 26, 2023
View reviewed changes

tarekgh added 3 commits May 26, 2023 11:00

Address the feedback
ea3b81d

Address the feedback
587408c

remove empty line
14e3331

tarekgh merged commit 813a46d into dotnet:mainMay 26, 2023

tarekgh deleted the MetricsAPIsFollowUpDelta branch May 26, 2023 23:34

This was referenced May 26, 2023
DefaultMeterFactory.Create and MeterOptions.Scope #86684
Closed
[Tracking] Decide if the tags order matter when creating meter or instrument #86614
Closed
[Tracking] Figure out how we should handle the disposing of the meters created from meter factory #86592
Closed

IDisposable mentioned this pull request May 30, 2023
Cleanup BitMapper sizeof type #86881
Merged

tarekgh mentioned this pull request Jun 5, 2023
What's new in .NET 8 Preview 5 [WIP] dotnet/core#8436
Closed
3 tasks

ghost locked as resolved and limited conversation to collaborators Jun 26, 2023

Address Metrics APIs issues
d251229

ghost added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels May 25, 2023

ghost assigned tarekgh May 25, 2023

tarekgh requested a review from noahfalk May 25, 2023 01:32

tarekgh added area-System.Diagnostics.Metric and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 25, 2023

tarekgh added this to the 8.0.0 milestone May 25, 2023

stephentoub reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated

stephentoub reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated

stephentoub reviewed May 25, 2023
View reviewed changes

Comment thread...ibraries/Microsoft.Extensions.Diagnostics.Abstractions/src/Metrics/MeterFactoryExtensions.cs

stephentoub reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated

Address the feedback
f477374

build-analysisBot mentioned this pull request May 25, 2023
Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637
Closed

Fix the correct thrown exception name.
69e5efe

noahfalk approved these changes May 26, 2023
View reviewed changes

tarekgh added 3 commits May 26, 2023 11:00

Address the feedback
ea3b81d

Address the feedback
587408c

remove empty line
14e3331

tarekgh merged commit 813a46d into dotnet:mainMay 26, 2023

tarekgh deleted the MetricsAPIsFollowUpDelta branch May 26, 2023 23:34

This was referenced May 26, 2023
DefaultMeterFactory.Create and MeterOptions.Scope #86684
Closed
[Tracking] Decide if the tags order matter when creating meter or instrument #86614
Closed
[Tracking] Figure out how we should handle the disposing of the meters created from meter factory #86592
Closed

IDisposable mentioned this pull request May 30, 2023
Cleanup BitMapper sizeof type #86881
Merged

tarekgh mentioned this pull request Jun 5, 2023
What's new in .NET 8 Preview 5 [WIP] dotnet/core#8436
Closed
3 tasks

ghost locked as resolved and limited conversation to collaborators Jun 26, 2023

Address Metrics APIs issues
d251229

ghost added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels May 25, 2023

ghost assigned tarekgh May 25, 2023

tarekgh requested a review from noahfalk May 25, 2023 01:32

tarekgh added area-System.Diagnostics.Metric and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 25, 2023

tarekgh added this to the 8.0.0 milestone May 25, 2023

stephentoub reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated

stephentoub reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated

stephentoub reviewed May 25, 2023
View reviewed changes

Comment thread...ibraries/Microsoft.Extensions.Diagnostics.Abstractions/src/Metrics/MeterFactoryExtensions.cs

stephentoub reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated

Address the feedback
f477374

build-analysisBot mentioned this pull request May 25, 2023
Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637
Closed

Fix the correct thrown exception name.
69e5efe

noahfalk approved these changes May 26, 2023
View reviewed changes

tarekgh added 3 commits May 26, 2023 11:00

Address the feedback
ea3b81d

Address the feedback
587408c

remove empty line
14e3331

tarekgh merged commit 813a46d into dotnet:mainMay 26, 2023

tarekgh deleted the MetricsAPIsFollowUpDelta branch May 26, 2023 23:34

This was referenced May 26, 2023
DefaultMeterFactory.Create and MeterOptions.Scope #86684
Closed
[Tracking] Decide if the tags order matter when creating meter or instrument #86614
Closed
[Tracking] Figure out how we should handle the disposing of the meters created from meter factory #86592
Closed

IDisposable mentioned this pull request May 30, 2023
Cleanup BitMapper sizeof type #86881
Merged

tarekgh mentioned this pull request Jun 5, 2023
What's new in .NET 8 Preview 5 [WIP] dotnet/core#8436
Closed
3 tasks

ghost locked as resolved and limited conversation to collaborators Jun 26, 2023

Address Metrics APIs issues
d251229

ghost added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels May 25, 2023

ghost assigned tarekgh May 25, 2023

tarekgh requested a review from noahfalk May 25, 2023 01:32

tarekgh added area-System.Diagnostics.Metric and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 25, 2023

tarekgh added this to the 8.0.0 milestone May 25, 2023

stephentoub reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated

stephentoub reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated

stephentoub reviewed May 25, 2023
View reviewed changes

Comment thread...ibraries/Microsoft.Extensions.Diagnostics.Abstractions/src/Metrics/MeterFactoryExtensions.cs

stephentoub reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated

Address the feedback
f477374

build-analysisBot mentioned this pull request May 25, 2023
Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637
Closed

Fix the correct thrown exception name.
69e5efe

noahfalk approved these changes May 26, 2023
View reviewed changes

tarekgh added 3 commits May 26, 2023 11:00

Address the feedback
ea3b81d

Address the feedback
587408c

remove empty line
14e3331

tarekgh merged commit 813a46d into dotnet:mainMay 26, 2023

tarekgh deleted the MetricsAPIsFollowUpDelta branch May 26, 2023 23:34

This was referenced May 26, 2023
DefaultMeterFactory.Create and MeterOptions.Scope #86684
Closed
[Tracking] Decide if the tags order matter when creating meter or instrument #86614
Closed
[Tracking] Figure out how we should handle the disposing of the meters created from meter factory #86592
Closed

IDisposable mentioned this pull request May 30, 2023
Cleanup BitMapper sizeof type #86881
Merged

tarekgh mentioned this pull request Jun 5, 2023
What's new in .NET 8 Preview 5 [WIP] dotnet/core#8436
Closed
3 tasks

ghost locked as resolved and limited conversation to collaborators Jun 26, 2023

Address Metrics APIs issues
d251229

ghost added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels May 25, 2023

ghost assigned tarekgh May 25, 2023

tarekgh requested a review from noahfalk May 25, 2023 01:32

tarekgh added area-System.Diagnostics.Metric and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 25, 2023

tarekgh added this to the 8.0.0 milestone May 25, 2023

stephentoub reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated

stephentoub reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated

stephentoub reviewed May 25, 2023
View reviewed changes

Comment thread...ibraries/Microsoft.Extensions.Diagnostics.Abstractions/src/Metrics/MeterFactoryExtensions.cs

stephentoub reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated

Address the feedback
f477374

build-analysisBot mentioned this pull request May 25, 2023
Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637
Closed

Fix the correct thrown exception name.
69e5efe

noahfalk approved these changes May 26, 2023
View reviewed changes

tarekgh added 3 commits May 26, 2023 11:00

Address the feedback
ea3b81d

Address the feedback
587408c

remove empty line
14e3331

tarekgh merged commit 813a46d into dotnet:mainMay 26, 2023

tarekgh deleted the MetricsAPIsFollowUpDelta branch May 26, 2023 23:34

This was referenced May 26, 2023
DefaultMeterFactory.Create and MeterOptions.Scope #86684
Closed
[Tracking] Decide if the tags order matter when creating meter or instrument #86614
Closed
[Tracking] Figure out how we should handle the disposing of the meters created from meter factory #86592
Closed

IDisposable mentioned this pull request May 30, 2023
Cleanup BitMapper sizeof type #86881
Merged

tarekgh mentioned this pull request Jun 5, 2023
What's new in .NET 8 Preview 5 [WIP] dotnet/core#8436
Closed
3 tasks

ghost locked as resolved and limited conversation to collaborators Jun 26, 2023

Address Metrics APIs issues
d251229

ghost added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels May 25, 2023

ghost assigned tarekgh May 25, 2023

tarekgh requested a review from noahfalk May 25, 2023 01:32

tarekgh added area-System.Diagnostics.Metric and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 25, 2023

tarekgh added this to the 8.0.0 milestone May 25, 2023

stephentoub reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated

stephentoub reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated

stephentoub reviewed May 25, 2023
View reviewed changes

Comment thread...ibraries/Microsoft.Extensions.Diagnostics.Abstractions/src/Metrics/MeterFactoryExtensions.cs

stephentoub reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated

Address the feedback
f477374

build-analysisBot mentioned this pull request May 25, 2023
Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637
Closed

Fix the correct thrown exception name.
69e5efe

noahfalk approved these changes May 26, 2023
View reviewed changes

tarekgh added 3 commits May 26, 2023 11:00

Address the feedback
ea3b81d

Address the feedback
587408c

remove empty line
14e3331

tarekgh merged commit 813a46d into dotnet:mainMay 26, 2023

tarekgh deleted the MetricsAPIsFollowUpDelta branch May 26, 2023 23:34

This was referenced May 26, 2023
DefaultMeterFactory.Create and MeterOptions.Scope #86684
Closed
[Tracking] Decide if the tags order matter when creating meter or instrument #86614
Closed
[Tracking] Figure out how we should handle the disposing of the meters created from meter factory #86592
Closed

IDisposable mentioned this pull request May 30, 2023
Cleanup BitMapper sizeof type #86881
Merged

tarekgh mentioned this pull request Jun 5, 2023
What's new in .NET 8 Preview 5 [WIP] dotnet/core#8436
Closed
3 tasks

ghost locked as resolved and limited conversation to collaborators Jun 26, 2023

Address Metrics APIs issues
d251229

ghost added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels May 25, 2023

ghost assigned tarekgh May 25, 2023

tarekgh requested a review from noahfalk May 25, 2023 01:32

tarekgh added area-System.Diagnostics.Metric and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 25, 2023

tarekgh added this to the 8.0.0 milestone May 25, 2023

stephentoub reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated

stephentoub reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated

stephentoub reviewed May 25, 2023
View reviewed changes

Comment thread...ibraries/Microsoft.Extensions.Diagnostics.Abstractions/src/Metrics/MeterFactoryExtensions.cs

stephentoub reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated

Address the feedback
f477374

build-analysisBot mentioned this pull request May 25, 2023
Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637
Closed

Fix the correct thrown exception name.
69e5efe

noahfalk approved these changes May 26, 2023
View reviewed changes

tarekgh added 3 commits May 26, 2023 11:00

Address the feedback
ea3b81d

Address the feedback
587408c

remove empty line
14e3331

tarekgh merged commit 813a46d into dotnet:mainMay 26, 2023

tarekgh deleted the MetricsAPIsFollowUpDelta branch May 26, 2023 23:34

This was referenced May 26, 2023
DefaultMeterFactory.Create and MeterOptions.Scope #86684
Closed
[Tracking] Decide if the tags order matter when creating meter or instrument #86614
Closed
[Tracking] Figure out how we should handle the disposing of the meters created from meter factory #86592
Closed

IDisposable mentioned this pull request May 30, 2023
Cleanup BitMapper sizeof type #86881
Merged

tarekgh mentioned this pull request Jun 5, 2023
What's new in .NET 8 Preview 5 [WIP] dotnet/core#8436
Closed
3 tasks

ghost locked as resolved and limited conversation to collaborators Jun 26, 2023

Address Metrics APIs issues
d251229

ghost added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels May 25, 2023

ghost assigned tarekgh May 25, 2023

tarekgh requested a review from noahfalk May 25, 2023 01:32

tarekgh added area-System.Diagnostics.Metric and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 25, 2023

tarekgh added this to the 8.0.0 milestone May 25, 2023

stephentoub reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated

stephentoub reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated

stephentoub reviewed May 25, 2023
View reviewed changes

Comment thread...ibraries/Microsoft.Extensions.Diagnostics.Abstractions/src/Metrics/MeterFactoryExtensions.cs

stephentoub reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated

Address the feedback
f477374

build-analysisBot mentioned this pull request May 25, 2023
Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637
Closed

Fix the correct thrown exception name.
69e5efe

noahfalk approved these changes May 26, 2023
View reviewed changes

tarekgh added 3 commits May 26, 2023 11:00

Address the feedback
ea3b81d

Address the feedback
587408c

remove empty line
14e3331

tarekgh merged commit 813a46d into dotnet:mainMay 26, 2023

tarekgh deleted the MetricsAPIsFollowUpDelta branch May 26, 2023 23:34

This was referenced May 26, 2023
DefaultMeterFactory.Create and MeterOptions.Scope #86684
Closed
[Tracking] Decide if the tags order matter when creating meter or instrument #86614
Closed
[Tracking] Figure out how we should handle the disposing of the meters created from meter factory #86592
Closed

IDisposable mentioned this pull request May 30, 2023
Cleanup BitMapper sizeof type #86881
Merged

tarekgh mentioned this pull request Jun 5, 2023
What's new in .NET 8 Preview 5 [WIP] dotnet/core#8436
Closed
3 tasks

ghost locked as resolved and limited conversation to collaborators Jun 26, 2023

Uh oh!

Conversation

tarekgh commented May 25, 2023

Uh oh!

ghost commented May 25, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tarekgh commented May 25, 2023

Uh oh!

noahfalk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

tarekgh commented May 25, 2023

Uh oh!

ghost commented May 25, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tarekgh commented May 25, 2023

Uh oh!

noahfalk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

tarekgh commented May 25, 2023

Uh oh!

ghost commented May 25, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!