Uh oh!
There was an error while loading. Please reload this page.
[release/8.0-preview5] Use fully qualified type names for parameters and don't copy parameter attributes - #86899
Conversation
…r attributes The issue dotnet/source-build#3483 looks similar to the issues I found before fixing in #86731. The relevant changes were in ComMethodContext.cs. If it's the same issue I was hitting, the attribute syntax was being copied over without adding 'using' statements or changing the attribute name to be fully qualified. I haven't validated yet, but this should fix it by just not copying the attributes for the parameters since they're not strictly necessary.
ghost
commented
May 30, 2023
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsThe issue dotnet/source-build#3483 looks similar to the issues I found before fixing in #86731. The relevant changes were in ComMethodContext.cs. If it's the same issue I was hitting, the attribute syntax was being copied over without adding 'using' statements or changing the attribute name to be fully qualified. I haven't validated yet, but this should fix it by just not copying the attributes for the parameters since they're not strictly necessary.
|
jkoritzinsky
left a comment
There was a problem hiding this comment.
Can we add a test to make sure we've fixed the issue?
carlossanlop
commented
May 30, 2023
@jtschuster@jkoritzinsky@mthalman I see the test was added. There were test failures. Let me know if they are not related and if this is ready to merge. |
jtschuster
commented
May 30, 2023
The failures look like unrelated internet issues. I'll let @jkoritzinsky confirm, but it should be ready to merge. |
lewing
commented
May 30, 2023
yeah wasm failure doesn't look related |
The CI got reset with the branch merge. But since the CI passed before, I'll merge. |
jkoritzinsky
commented
May 30, 2023
/backport to main |
Started backporting to main: https://github.com/dotnet/runtime/actions/runs/5126550773 |
Fixesdotnet/source-build#3483 by not copying the attributes for the parameters on generated base implementation methods since they're not strictly necessary.