Add managed entry points for raising Contention events by kouvel · Pull Request #87087 · dotnet/runtime

kouvel · 2023-06-03T02:53:02Z

Added the events similarly to how the PortableThreadPool events are currently set up
The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

ghost · 2023-06-03T02:53:20Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

Added the events similarly to how the PortableThreadPool events are currently set up
The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

Author:	kouvel
Assignees:	kouvel
Labels:	`area-System.Threading`
Milestone:	8.0.0

stephentoub · 2023-06-05T14:59:09Z

The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

Do we expect to raise these as well from SpinLock? What about other managed lock types, like ReaderWriterLockSlim?

kouvel · 2023-06-06T01:43:06Z

Do we expect to raise these as well from SpinLock? What about other managed lock types, like ReaderWriterLockSlim?

It would be nice to in the future, though I haven't seen much desire for it. For doing that though, could maybe consider adding an enum field that indicates what type caused the contention for easier filtering. Although the ContentionStart event has stacks, stack tracing can be missed sometimes. Or maybe they can be different events for each type, that would make it easier to identify quickly from a profile, but then there's also a question about whether Monitor.LockContentionCount should include contention from all of those types or if we should have different contention properties on the appropriate types, and what the dotnet-monitor contention count would show. My inclination currently is to evaluate expanding it based on need.

davmason

LGTM

lateralusX · 2023-06-08T07:16:18Z

This file was not included previously if FeaturePortableThreadPool wasn't true and never on Mono/CoreCLR, now it looks like this will always be included if FeaturePerfTracing != 'true' and that is at least the case for TargetsBrowser (WASM).

Previously the file contained events that would only be raised by the portable thread pool. I reused the same file for contention events and they could be raised from anywhere. Some thread pool events too may be raised from different implementations in the future.
The condition that enables FeaturePortableThreadPool in Mono is currently similar to the one that enables FeaturePerfTracing. I believe the correct condition would be just '$(FeaturePerfTracing)' != 'true', as FeaturePerfTracing seems to be the one used to set up eventing (and using genRuntimeEventSources.py). In NativeAOT, currently FeaturePerfTracing is true but the eventing stuff appears to not be set up yet, so I modified the conditions so that the same file as before would for now be included in NativeAOT.

- Added the events similarly to how the PortableThreadPool events are currently set up. They may need further tweaking to make them work from NativeAOT. - The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

kouvel · 2023-06-03T02:53:02Z

Added the events similarly to how the PortableThreadPool events are currently set up
The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

ghost · 2023-06-03T02:53:20Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

Added the events similarly to how the PortableThreadPool events are currently set up
The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

Author:	kouvel
Assignees:	kouvel
Labels:	`area-System.Threading`
Milestone:	8.0.0

stephentoub · 2023-06-05T14:59:09Z

The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

Do we expect to raise these as well from SpinLock? What about other managed lock types, like ReaderWriterLockSlim?

kouvel · 2023-06-06T01:43:06Z

Do we expect to raise these as well from SpinLock? What about other managed lock types, like ReaderWriterLockSlim?

It would be nice to in the future, though I haven't seen much desire for it. For doing that though, could maybe consider adding an enum field that indicates what type caused the contention for easier filtering. Although the ContentionStart event has stacks, stack tracing can be missed sometimes. Or maybe they can be different events for each type, that would make it easier to identify quickly from a profile, but then there's also a question about whether Monitor.LockContentionCount should include contention from all of those types or if we should have different contention properties on the appropriate types, and what the dotnet-monitor contention count would show. My inclination currently is to evaluate expanding it based on need.

davmason

LGTM

lateralusX · 2023-06-08T07:16:18Z

This file was not included previously if FeaturePortableThreadPool wasn't true and never on Mono/CoreCLR, now it looks like this will always be included if FeaturePerfTracing != 'true' and that is at least the case for TargetsBrowser (WASM).

Previously the file contained events that would only be raised by the portable thread pool. I reused the same file for contention events and they could be raised from anywhere. Some thread pool events too may be raised from different implementations in the future.
The condition that enables FeaturePortableThreadPool in Mono is currently similar to the one that enables FeaturePerfTracing. I believe the correct condition would be just '$(FeaturePerfTracing)' != 'true', as FeaturePerfTracing seems to be the one used to set up eventing (and using genRuntimeEventSources.py). In NativeAOT, currently FeaturePerfTracing is true but the eventing stuff appears to not be set up yet, so I modified the conditions so that the same file as before would for now be included in NativeAOT.

- Added the events similarly to how the PortableThreadPool events are currently set up. They may need further tweaking to make them work from NativeAOT. - The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

kouvel · 2023-06-03T02:53:02Z

Added the events similarly to how the PortableThreadPool events are currently set up
The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

ghost · 2023-06-03T02:53:20Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

Added the events similarly to how the PortableThreadPool events are currently set up
The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

Author:	kouvel
Assignees:	kouvel
Labels:	`area-System.Threading`
Milestone:	8.0.0

stephentoub · 2023-06-05T14:59:09Z

The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

Do we expect to raise these as well from SpinLock? What about other managed lock types, like ReaderWriterLockSlim?

kouvel · 2023-06-06T01:43:06Z

Do we expect to raise these as well from SpinLock? What about other managed lock types, like ReaderWriterLockSlim?

It would be nice to in the future, though I haven't seen much desire for it. For doing that though, could maybe consider adding an enum field that indicates what type caused the contention for easier filtering. Although the ContentionStart event has stacks, stack tracing can be missed sometimes. Or maybe they can be different events for each type, that would make it easier to identify quickly from a profile, but then there's also a question about whether Monitor.LockContentionCount should include contention from all of those types or if we should have different contention properties on the appropriate types, and what the dotnet-monitor contention count would show. My inclination currently is to evaluate expanding it based on need.

davmason

LGTM

lateralusX · 2023-06-08T07:16:18Z

This file was not included previously if FeaturePortableThreadPool wasn't true and never on Mono/CoreCLR, now it looks like this will always be included if FeaturePerfTracing != 'true' and that is at least the case for TargetsBrowser (WASM).

Previously the file contained events that would only be raised by the portable thread pool. I reused the same file for contention events and they could be raised from anywhere. Some thread pool events too may be raised from different implementations in the future.
The condition that enables FeaturePortableThreadPool in Mono is currently similar to the one that enables FeaturePerfTracing. I believe the correct condition would be just '$(FeaturePerfTracing)' != 'true', as FeaturePerfTracing seems to be the one used to set up eventing (and using genRuntimeEventSources.py). In NativeAOT, currently FeaturePerfTracing is true but the eventing stuff appears to not be set up yet, so I modified the conditions so that the same file as before would for now be included in NativeAOT.

- Added the events similarly to how the PortableThreadPool events are currently set up. They may need further tweaking to make them work from NativeAOT. - The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

kouvel · 2023-06-03T02:53:02Z

Added the events similarly to how the PortableThreadPool events are currently set up
The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

ghost · 2023-06-03T02:53:20Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

Added the events similarly to how the PortableThreadPool events are currently set up
The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

Author:	kouvel
Assignees:	kouvel
Labels:	`area-System.Threading`
Milestone:	8.0.0

stephentoub · 2023-06-05T14:59:09Z

The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

Do we expect to raise these as well from SpinLock? What about other managed lock types, like ReaderWriterLockSlim?

kouvel · 2023-06-06T01:43:06Z

Do we expect to raise these as well from SpinLock? What about other managed lock types, like ReaderWriterLockSlim?

It would be nice to in the future, though I haven't seen much desire for it. For doing that though, could maybe consider adding an enum field that indicates what type caused the contention for easier filtering. Although the ContentionStart event has stacks, stack tracing can be missed sometimes. Or maybe they can be different events for each type, that would make it easier to identify quickly from a profile, but then there's also a question about whether Monitor.LockContentionCount should include contention from all of those types or if we should have different contention properties on the appropriate types, and what the dotnet-monitor contention count would show. My inclination currently is to evaluate expanding it based on need.

davmason

LGTM

lateralusX · 2023-06-08T07:16:18Z

This file was not included previously if FeaturePortableThreadPool wasn't true and never on Mono/CoreCLR, now it looks like this will always be included if FeaturePerfTracing != 'true' and that is at least the case for TargetsBrowser (WASM).

Previously the file contained events that would only be raised by the portable thread pool. I reused the same file for contention events and they could be raised from anywhere. Some thread pool events too may be raised from different implementations in the future.
The condition that enables FeaturePortableThreadPool in Mono is currently similar to the one that enables FeaturePerfTracing. I believe the correct condition would be just '$(FeaturePerfTracing)' != 'true', as FeaturePerfTracing seems to be the one used to set up eventing (and using genRuntimeEventSources.py). In NativeAOT, currently FeaturePerfTracing is true but the eventing stuff appears to not be set up yet, so I modified the conditions so that the same file as before would for now be included in NativeAOT.

- Added the events similarly to how the PortableThreadPool events are currently set up. They may need further tweaking to make them work from NativeAOT. - The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

kouvel · 2023-06-03T02:53:02Z

Added the events similarly to how the PortableThreadPool events are currently set up
The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

ghost · 2023-06-03T02:53:20Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

Added the events similarly to how the PortableThreadPool events are currently set up
The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

Author:	kouvel
Assignees:	kouvel
Labels:	`area-System.Threading`
Milestone:	8.0.0

stephentoub · 2023-06-05T14:59:09Z

The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

Do we expect to raise these as well from SpinLock? What about other managed lock types, like ReaderWriterLockSlim?

kouvel · 2023-06-06T01:43:06Z

Do we expect to raise these as well from SpinLock? What about other managed lock types, like ReaderWriterLockSlim?

It would be nice to in the future, though I haven't seen much desire for it. For doing that though, could maybe consider adding an enum field that indicates what type caused the contention for easier filtering. Although the ContentionStart event has stacks, stack tracing can be missed sometimes. Or maybe they can be different events for each type, that would make it easier to identify quickly from a profile, but then there's also a question about whether Monitor.LockContentionCount should include contention from all of those types or if we should have different contention properties on the appropriate types, and what the dotnet-monitor contention count would show. My inclination currently is to evaluate expanding it based on need.

davmason

LGTM

lateralusX · 2023-06-08T07:16:18Z

This file was not included previously if FeaturePortableThreadPool wasn't true and never on Mono/CoreCLR, now it looks like this will always be included if FeaturePerfTracing != 'true' and that is at least the case for TargetsBrowser (WASM).

Previously the file contained events that would only be raised by the portable thread pool. I reused the same file for contention events and they could be raised from anywhere. Some thread pool events too may be raised from different implementations in the future.
The condition that enables FeaturePortableThreadPool in Mono is currently similar to the one that enables FeaturePerfTracing. I believe the correct condition would be just '$(FeaturePerfTracing)' != 'true', as FeaturePerfTracing seems to be the one used to set up eventing (and using genRuntimeEventSources.py). In NativeAOT, currently FeaturePerfTracing is true but the eventing stuff appears to not be set up yet, so I modified the conditions so that the same file as before would for now be included in NativeAOT.

- Added the events similarly to how the PortableThreadPool events are currently set up. They may need further tweaking to make them work from NativeAOT. - The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

kouvel · 2023-06-03T02:53:02Z

Added the events similarly to how the PortableThreadPool events are currently set up
The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

ghost · 2023-06-03T02:53:20Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

Added the events similarly to how the PortableThreadPool events are currently set up
The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

Author:	kouvel
Assignees:	kouvel
Labels:	`area-System.Threading`
Milestone:	8.0.0

stephentoub · 2023-06-05T14:59:09Z

The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

Do we expect to raise these as well from SpinLock? What about other managed lock types, like ReaderWriterLockSlim?

kouvel · 2023-06-06T01:43:06Z

Do we expect to raise these as well from SpinLock? What about other managed lock types, like ReaderWriterLockSlim?

It would be nice to in the future, though I haven't seen much desire for it. For doing that though, could maybe consider adding an enum field that indicates what type caused the contention for easier filtering. Although the ContentionStart event has stacks, stack tracing can be missed sometimes. Or maybe they can be different events for each type, that would make it easier to identify quickly from a profile, but then there's also a question about whether Monitor.LockContentionCount should include contention from all of those types or if we should have different contention properties on the appropriate types, and what the dotnet-monitor contention count would show. My inclination currently is to evaluate expanding it based on need.

davmason

LGTM

lateralusX · 2023-06-08T07:16:18Z

This file was not included previously if FeaturePortableThreadPool wasn't true and never on Mono/CoreCLR, now it looks like this will always be included if FeaturePerfTracing != 'true' and that is at least the case for TargetsBrowser (WASM).

Previously the file contained events that would only be raised by the portable thread pool. I reused the same file for contention events and they could be raised from anywhere. Some thread pool events too may be raised from different implementations in the future.
The condition that enables FeaturePortableThreadPool in Mono is currently similar to the one that enables FeaturePerfTracing. I believe the correct condition would be just '$(FeaturePerfTracing)' != 'true', as FeaturePerfTracing seems to be the one used to set up eventing (and using genRuntimeEventSources.py). In NativeAOT, currently FeaturePerfTracing is true but the eventing stuff appears to not be set up yet, so I modified the conditions so that the same file as before would for now be included in NativeAOT.

- Added the events similarly to how the PortableThreadPool events are currently set up. They may need further tweaking to make them work from NativeAOT. - The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

kouvel · 2023-06-03T02:53:02Z

Added the events similarly to how the PortableThreadPool events are currently set up
The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

ghost · 2023-06-03T02:53:20Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

Added the events similarly to how the PortableThreadPool events are currently set up
The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

Author:	kouvel
Assignees:	kouvel
Labels:	`area-System.Threading`
Milestone:	8.0.0

stephentoub · 2023-06-05T14:59:09Z

The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

Do we expect to raise these as well from SpinLock? What about other managed lock types, like ReaderWriterLockSlim?

kouvel · 2023-06-06T01:43:06Z

Do we expect to raise these as well from SpinLock? What about other managed lock types, like ReaderWriterLockSlim?

It would be nice to in the future, though I haven't seen much desire for it. For doing that though, could maybe consider adding an enum field that indicates what type caused the contention for easier filtering. Although the ContentionStart event has stacks, stack tracing can be missed sometimes. Or maybe they can be different events for each type, that would make it easier to identify quickly from a profile, but then there's also a question about whether Monitor.LockContentionCount should include contention from all of those types or if we should have different contention properties on the appropriate types, and what the dotnet-monitor contention count would show. My inclination currently is to evaluate expanding it based on need.

davmason

LGTM

lateralusX · 2023-06-08T07:16:18Z

This file was not included previously if FeaturePortableThreadPool wasn't true and never on Mono/CoreCLR, now it looks like this will always be included if FeaturePerfTracing != 'true' and that is at least the case for TargetsBrowser (WASM).

Previously the file contained events that would only be raised by the portable thread pool. I reused the same file for contention events and they could be raised from anywhere. Some thread pool events too may be raised from different implementations in the future.
The condition that enables FeaturePortableThreadPool in Mono is currently similar to the one that enables FeaturePerfTracing. I believe the correct condition would be just '$(FeaturePerfTracing)' != 'true', as FeaturePerfTracing seems to be the one used to set up eventing (and using genRuntimeEventSources.py). In NativeAOT, currently FeaturePerfTracing is true but the eventing stuff appears to not be set up yet, so I modified the conditions so that the same file as before would for now be included in NativeAOT.

- Added the events similarly to how the PortableThreadPool events are currently set up. They may need further tweaking to make them work from NativeAOT. - The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

kouvel · 2023-06-03T02:53:02Z

Added the events similarly to how the PortableThreadPool events are currently set up
The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

ghost · 2023-06-03T02:53:20Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

Added the events similarly to how the PortableThreadPool events are currently set up
The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

Author:	kouvel
Assignees:	kouvel
Labels:	`area-System.Threading`
Milestone:	8.0.0

stephentoub · 2023-06-05T14:59:09Z

The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

Do we expect to raise these as well from SpinLock? What about other managed lock types, like ReaderWriterLockSlim?

kouvel · 2023-06-06T01:43:06Z

Do we expect to raise these as well from SpinLock? What about other managed lock types, like ReaderWriterLockSlim?

It would be nice to in the future, though I haven't seen much desire for it. For doing that though, could maybe consider adding an enum field that indicates what type caused the contention for easier filtering. Although the ContentionStart event has stacks, stack tracing can be missed sometimes. Or maybe they can be different events for each type, that would make it easier to identify quickly from a profile, but then there's also a question about whether Monitor.LockContentionCount should include contention from all of those types or if we should have different contention properties on the appropriate types, and what the dotnet-monitor contention count would show. My inclination currently is to evaluate expanding it based on need.

davmason

LGTM

lateralusX · 2023-06-08T07:16:18Z

This file was not included previously if FeaturePortableThreadPool wasn't true and never on Mono/CoreCLR, now it looks like this will always be included if FeaturePerfTracing != 'true' and that is at least the case for TargetsBrowser (WASM).

Previously the file contained events that would only be raised by the portable thread pool. I reused the same file for contention events and they could be raised from anywhere. Some thread pool events too may be raised from different implementations in the future.
The condition that enables FeaturePortableThreadPool in Mono is currently similar to the one that enables FeaturePerfTracing. I believe the correct condition would be just '$(FeaturePerfTracing)' != 'true', as FeaturePerfTracing seems to be the one used to set up eventing (and using genRuntimeEventSources.py). In NativeAOT, currently FeaturePerfTracing is true but the eventing stuff appears to not be set up yet, so I modified the conditions so that the same file as before would for now be included in NativeAOT.

- Added the events similarly to how the PortableThreadPool events are currently set up. They may need further tweaking to make them work from NativeAOT. - The events are not raised anywhere from the managed side yet, it's expected that they will eventually be raised by a new Lock type and at least by NativeAOT's Lock

kouvel added the area-System.Threading label Jun 3, 2023

kouvel added this to the 8.0.0 milestone Jun 3, 2023

kouvel requested review from LakshanF and davmason June 3, 2023 02:53

kouvel requested a review from lateralusX as a code owner June 3, 2023 02:53

kouvel self-assigned this Jun 3, 2023

kouvel requested review from MichalStrehovsky, lambdageek, marek-safar, thaystg and vargaz as code owners June 3, 2023 02:53

build-analysisBot mentioned this pull request Jun 3, 2023
Tracking issue for CI build timeouts #76454
Closed

kouvel closed this Jun 6, 2023

kouvel reopened this Jun 6, 2023

build-analysisBot mentioned this pull request Jun 7, 2023
Unable to load Analyzer assembly .../Microsoft.CodeAnalysis.Analyzers.dll : Not a valid assembly #85082
Closed

lateralusX reviewed Jun 7, 2023
View reviewed changes

Comment thread...ate.CoreLib/src/System/Diagnostics/Tracing/NativeRuntimeEventSource.Threading.NativeSinks.cs Outdated

davmason approved these changes Jun 7, 2023
View reviewed changes

lateralusX reviewed Jun 8, 2023
View reviewed changes

Comment threadsrc/mono/mono/eventpipe/gen-eventing-event-inc.lst Outdated

lateralusX reviewed Jun 8, 2023
View reviewed changes

Koundinya Veluri added 8 commits June 14, 2023 19:59

Fix a couple of issues
8c7733a

Fix an issue
8a8c172

Fix an issue
4333657

Fix build and address feedback
4461c08

Fix build
c96519b

Fix build
cbf853f

Fix an issue
3c4fa97

Fix an issue
e5a85d1

build-analysisBot mentioned this pull request Jun 15, 2023
Could not load file or assembly 'Microsoft.CodeAnalysis.NetAnalyzers #84995
Closed

kouvel merged commit 4302b80 into dotnet:mainJun 15, 2023

kouvel deleted the ContentionEvents branch June 15, 2023 13:36

mthalman mentioned this pull request Jun 19, 2023
Mono-built SDK has error loading System.Reflection.MetadataLoadContext from MSBuild dotnet/source-build#3528
Closed

LakshanF mentioned this pull request Jun 26, 2023
Setup support for managed runtime events #87785
Merged

ghost locked as resolved and limited conversation to collaborators Jul 15, 2023

kouvel added the area-System.Threading label Jun 3, 2023

kouvel added this to the 8.0.0 milestone Jun 3, 2023

kouvel requested review from LakshanF and davmason June 3, 2023 02:53

kouvel requested a review from lateralusX as a code owner June 3, 2023 02:53

kouvel self-assigned this Jun 3, 2023

kouvel requested review from MichalStrehovsky, lambdageek, marek-safar, thaystg and vargaz as code owners June 3, 2023 02:53

build-analysisBot mentioned this pull request Jun 3, 2023
Tracking issue for CI build timeouts #76454
Closed

kouvel closed this Jun 6, 2023

kouvel reopened this Jun 6, 2023

build-analysisBot mentioned this pull request Jun 7, 2023
Unable to load Analyzer assembly .../Microsoft.CodeAnalysis.Analyzers.dll : Not a valid assembly #85082
Closed

lateralusX reviewed Jun 7, 2023
View reviewed changes

Comment thread...ate.CoreLib/src/System/Diagnostics/Tracing/NativeRuntimeEventSource.Threading.NativeSinks.cs Outdated

davmason approved these changes Jun 7, 2023
View reviewed changes

lateralusX reviewed Jun 8, 2023
View reviewed changes

Comment threadsrc/mono/mono/eventpipe/gen-eventing-event-inc.lst Outdated

lateralusX reviewed Jun 8, 2023
View reviewed changes

Koundinya Veluri added 8 commits June 14, 2023 19:59

Fix a couple of issues
8c7733a

Fix an issue
8a8c172

Fix an issue
4333657

Fix build and address feedback
4461c08

Fix build
c96519b

Fix build
cbf853f

Fix an issue
3c4fa97

Fix an issue
e5a85d1

build-analysisBot mentioned this pull request Jun 15, 2023
Could not load file or assembly 'Microsoft.CodeAnalysis.NetAnalyzers #84995
Closed

kouvel merged commit 4302b80 into dotnet:mainJun 15, 2023

kouvel deleted the ContentionEvents branch June 15, 2023 13:36

mthalman mentioned this pull request Jun 19, 2023
Mono-built SDK has error loading System.Reflection.MetadataLoadContext from MSBuild dotnet/source-build#3528
Closed

LakshanF mentioned this pull request Jun 26, 2023
Setup support for managed runtime events #87785
Merged

ghost locked as resolved and limited conversation to collaborators Jul 15, 2023

kouvel added the area-System.Threading label Jun 3, 2023

kouvel added this to the 8.0.0 milestone Jun 3, 2023

kouvel requested review from LakshanF and davmason June 3, 2023 02:53

kouvel requested a review from lateralusX as a code owner June 3, 2023 02:53

kouvel self-assigned this Jun 3, 2023

kouvel requested review from MichalStrehovsky, lambdageek, marek-safar, thaystg and vargaz as code owners June 3, 2023 02:53

build-analysisBot mentioned this pull request Jun 3, 2023
Tracking issue for CI build timeouts #76454
Closed

kouvel closed this Jun 6, 2023

kouvel reopened this Jun 6, 2023

build-analysisBot mentioned this pull request Jun 7, 2023
Unable to load Analyzer assembly .../Microsoft.CodeAnalysis.Analyzers.dll : Not a valid assembly #85082
Closed

lateralusX reviewed Jun 7, 2023
View reviewed changes

Comment thread...ate.CoreLib/src/System/Diagnostics/Tracing/NativeRuntimeEventSource.Threading.NativeSinks.cs Outdated

davmason approved these changes Jun 7, 2023
View reviewed changes

lateralusX reviewed Jun 8, 2023
View reviewed changes

Comment threadsrc/mono/mono/eventpipe/gen-eventing-event-inc.lst Outdated

lateralusX reviewed Jun 8, 2023
View reviewed changes

Koundinya Veluri added 8 commits June 14, 2023 19:59

Fix a couple of issues
8c7733a

Fix an issue
8a8c172

Fix an issue
4333657

Fix build and address feedback
4461c08

Fix build
c96519b

Fix build
cbf853f

Fix an issue
3c4fa97

Fix an issue
e5a85d1

build-analysisBot mentioned this pull request Jun 15, 2023
Could not load file or assembly 'Microsoft.CodeAnalysis.NetAnalyzers #84995
Closed

kouvel merged commit 4302b80 into dotnet:mainJun 15, 2023

kouvel deleted the ContentionEvents branch June 15, 2023 13:36

mthalman mentioned this pull request Jun 19, 2023
Mono-built SDK has error loading System.Reflection.MetadataLoadContext from MSBuild dotnet/source-build#3528
Closed

LakshanF mentioned this pull request Jun 26, 2023
Setup support for managed runtime events #87785
Merged

ghost locked as resolved and limited conversation to collaborators Jul 15, 2023

kouvel added the area-System.Threading label Jun 3, 2023

kouvel added this to the 8.0.0 milestone Jun 3, 2023

kouvel requested review from LakshanF and davmason June 3, 2023 02:53

kouvel requested a review from lateralusX as a code owner June 3, 2023 02:53

kouvel self-assigned this Jun 3, 2023

kouvel requested review from MichalStrehovsky, lambdageek, marek-safar, thaystg and vargaz as code owners June 3, 2023 02:53

build-analysisBot mentioned this pull request Jun 3, 2023
Tracking issue for CI build timeouts #76454
Closed

kouvel closed this Jun 6, 2023

kouvel reopened this Jun 6, 2023

build-analysisBot mentioned this pull request Jun 7, 2023
Unable to load Analyzer assembly .../Microsoft.CodeAnalysis.Analyzers.dll : Not a valid assembly #85082
Closed

lateralusX reviewed Jun 7, 2023
View reviewed changes

Comment thread...ate.CoreLib/src/System/Diagnostics/Tracing/NativeRuntimeEventSource.Threading.NativeSinks.cs Outdated

davmason approved these changes Jun 7, 2023
View reviewed changes

lateralusX reviewed Jun 8, 2023
View reviewed changes

Comment threadsrc/mono/mono/eventpipe/gen-eventing-event-inc.lst Outdated

lateralusX reviewed Jun 8, 2023
View reviewed changes

Koundinya Veluri added 8 commits June 14, 2023 19:59

Fix a couple of issues
8c7733a

Fix an issue
8a8c172

Fix an issue
4333657

Fix build and address feedback
4461c08

Fix build
c96519b

Fix build
cbf853f

Fix an issue
3c4fa97

Fix an issue
e5a85d1

build-analysisBot mentioned this pull request Jun 15, 2023
Could not load file or assembly 'Microsoft.CodeAnalysis.NetAnalyzers #84995
Closed

kouvel merged commit 4302b80 into dotnet:mainJun 15, 2023

kouvel deleted the ContentionEvents branch June 15, 2023 13:36

mthalman mentioned this pull request Jun 19, 2023
Mono-built SDK has error loading System.Reflection.MetadataLoadContext from MSBuild dotnet/source-build#3528
Closed

LakshanF mentioned this pull request Jun 26, 2023
Setup support for managed runtime events #87785
Merged

ghost locked as resolved and limited conversation to collaborators Jul 15, 2023

kouvel added the area-System.Threading label Jun 3, 2023

kouvel added this to the 8.0.0 milestone Jun 3, 2023

kouvel requested review from LakshanF and davmason June 3, 2023 02:53

kouvel requested a review from lateralusX as a code owner June 3, 2023 02:53

kouvel self-assigned this Jun 3, 2023

kouvel requested review from MichalStrehovsky, lambdageek, marek-safar, thaystg and vargaz as code owners June 3, 2023 02:53

build-analysisBot mentioned this pull request Jun 3, 2023
Tracking issue for CI build timeouts #76454
Closed

kouvel closed this Jun 6, 2023

kouvel reopened this Jun 6, 2023

build-analysisBot mentioned this pull request Jun 7, 2023
Unable to load Analyzer assembly .../Microsoft.CodeAnalysis.Analyzers.dll : Not a valid assembly #85082
Closed

lateralusX reviewed Jun 7, 2023
View reviewed changes

Comment thread...ate.CoreLib/src/System/Diagnostics/Tracing/NativeRuntimeEventSource.Threading.NativeSinks.cs Outdated

davmason approved these changes Jun 7, 2023
View reviewed changes

lateralusX reviewed Jun 8, 2023
View reviewed changes

Comment threadsrc/mono/mono/eventpipe/gen-eventing-event-inc.lst Outdated

lateralusX reviewed Jun 8, 2023
View reviewed changes

Koundinya Veluri added 8 commits June 14, 2023 19:59

Fix a couple of issues
8c7733a

Fix an issue
8a8c172

Fix an issue
4333657

Fix build and address feedback
4461c08

Fix build
c96519b

Fix build
cbf853f

Fix an issue
3c4fa97

Fix an issue
e5a85d1

build-analysisBot mentioned this pull request Jun 15, 2023
Could not load file or assembly 'Microsoft.CodeAnalysis.NetAnalyzers #84995
Closed

kouvel merged commit 4302b80 into dotnet:mainJun 15, 2023

kouvel deleted the ContentionEvents branch June 15, 2023 13:36

mthalman mentioned this pull request Jun 19, 2023
Mono-built SDK has error loading System.Reflection.MetadataLoadContext from MSBuild dotnet/source-build#3528
Closed

LakshanF mentioned this pull request Jun 26, 2023
Setup support for managed runtime events #87785
Merged

ghost locked as resolved and limited conversation to collaborators Jul 15, 2023

kouvel added the area-System.Threading label Jun 3, 2023

kouvel added this to the 8.0.0 milestone Jun 3, 2023

kouvel requested review from LakshanF and davmason June 3, 2023 02:53

kouvel requested a review from lateralusX as a code owner June 3, 2023 02:53

kouvel self-assigned this Jun 3, 2023

kouvel requested review from MichalStrehovsky, lambdageek, marek-safar, thaystg and vargaz as code owners June 3, 2023 02:53

build-analysisBot mentioned this pull request Jun 3, 2023
Tracking issue for CI build timeouts #76454
Closed

kouvel closed this Jun 6, 2023

kouvel reopened this Jun 6, 2023

build-analysisBot mentioned this pull request Jun 7, 2023
Unable to load Analyzer assembly .../Microsoft.CodeAnalysis.Analyzers.dll : Not a valid assembly #85082
Closed

lateralusX reviewed Jun 7, 2023
View reviewed changes

Comment thread...ate.CoreLib/src/System/Diagnostics/Tracing/NativeRuntimeEventSource.Threading.NativeSinks.cs Outdated

davmason approved these changes Jun 7, 2023
View reviewed changes

lateralusX reviewed Jun 8, 2023
View reviewed changes

Comment threadsrc/mono/mono/eventpipe/gen-eventing-event-inc.lst Outdated

lateralusX reviewed Jun 8, 2023
View reviewed changes

Koundinya Veluri added 8 commits June 14, 2023 19:59

Fix a couple of issues
8c7733a

Fix an issue
8a8c172

Fix an issue
4333657

Fix build and address feedback
4461c08

Fix build
c96519b

Fix build
cbf853f

Fix an issue
3c4fa97

Fix an issue
e5a85d1

build-analysisBot mentioned this pull request Jun 15, 2023
Could not load file or assembly 'Microsoft.CodeAnalysis.NetAnalyzers #84995
Closed

kouvel merged commit 4302b80 into dotnet:mainJun 15, 2023

kouvel deleted the ContentionEvents branch June 15, 2023 13:36

mthalman mentioned this pull request Jun 19, 2023
Mono-built SDK has error loading System.Reflection.MetadataLoadContext from MSBuild dotnet/source-build#3528
Closed

LakshanF mentioned this pull request Jun 26, 2023
Setup support for managed runtime events #87785
Merged

ghost locked as resolved and limited conversation to collaborators Jul 15, 2023

kouvel added the area-System.Threading label Jun 3, 2023

kouvel added this to the 8.0.0 milestone Jun 3, 2023

kouvel requested review from LakshanF and davmason June 3, 2023 02:53

kouvel requested a review from lateralusX as a code owner June 3, 2023 02:53

kouvel self-assigned this Jun 3, 2023

kouvel requested review from MichalStrehovsky, lambdageek, marek-safar, thaystg and vargaz as code owners June 3, 2023 02:53

build-analysisBot mentioned this pull request Jun 3, 2023
Tracking issue for CI build timeouts #76454
Closed

kouvel closed this Jun 6, 2023

kouvel reopened this Jun 6, 2023

build-analysisBot mentioned this pull request Jun 7, 2023
Unable to load Analyzer assembly .../Microsoft.CodeAnalysis.Analyzers.dll : Not a valid assembly #85082
Closed

lateralusX reviewed Jun 7, 2023
View reviewed changes

Comment thread...ate.CoreLib/src/System/Diagnostics/Tracing/NativeRuntimeEventSource.Threading.NativeSinks.cs Outdated

davmason approved these changes Jun 7, 2023
View reviewed changes

lateralusX reviewed Jun 8, 2023
View reviewed changes

Comment threadsrc/mono/mono/eventpipe/gen-eventing-event-inc.lst Outdated

lateralusX reviewed Jun 8, 2023
View reviewed changes

Koundinya Veluri added 8 commits June 14, 2023 19:59

Fix a couple of issues
8c7733a

Fix an issue
8a8c172

Fix an issue
4333657

Fix build and address feedback
4461c08

Fix build
c96519b

Fix build
cbf853f

Fix an issue
3c4fa97

Fix an issue
e5a85d1

build-analysisBot mentioned this pull request Jun 15, 2023
Could not load file or assembly 'Microsoft.CodeAnalysis.NetAnalyzers #84995
Closed

kouvel merged commit 4302b80 into dotnet:mainJun 15, 2023

kouvel deleted the ContentionEvents branch June 15, 2023 13:36

mthalman mentioned this pull request Jun 19, 2023
Mono-built SDK has error loading System.Reflection.MetadataLoadContext from MSBuild dotnet/source-build#3528
Closed

LakshanF mentioned this pull request Jun 26, 2023
Setup support for managed runtime events #87785
Merged

ghost locked as resolved and limited conversation to collaborators Jul 15, 2023

kouvel added the area-System.Threading label Jun 3, 2023

kouvel added this to the 8.0.0 milestone Jun 3, 2023

kouvel requested review from LakshanF and davmason June 3, 2023 02:53

kouvel requested a review from lateralusX as a code owner June 3, 2023 02:53

kouvel self-assigned this Jun 3, 2023

kouvel requested review from MichalStrehovsky, lambdageek, marek-safar, thaystg and vargaz as code owners June 3, 2023 02:53

build-analysisBot mentioned this pull request Jun 3, 2023
Tracking issue for CI build timeouts #76454
Closed

kouvel closed this Jun 6, 2023

kouvel reopened this Jun 6, 2023

build-analysisBot mentioned this pull request Jun 7, 2023
Unable to load Analyzer assembly .../Microsoft.CodeAnalysis.Analyzers.dll : Not a valid assembly #85082
Closed

lateralusX reviewed Jun 7, 2023
View reviewed changes

Comment thread...ate.CoreLib/src/System/Diagnostics/Tracing/NativeRuntimeEventSource.Threading.NativeSinks.cs Outdated

davmason approved these changes Jun 7, 2023
View reviewed changes

lateralusX reviewed Jun 8, 2023
View reviewed changes

Comment threadsrc/mono/mono/eventpipe/gen-eventing-event-inc.lst Outdated

lateralusX reviewed Jun 8, 2023
View reviewed changes

Koundinya Veluri added 8 commits June 14, 2023 19:59

Fix a couple of issues
8c7733a

Fix an issue
8a8c172

Fix an issue
4333657

Fix build and address feedback
4461c08

Fix build
c96519b

Fix build
cbf853f

Fix an issue
3c4fa97

Fix an issue
e5a85d1

build-analysisBot mentioned this pull request Jun 15, 2023
Could not load file or assembly 'Microsoft.CodeAnalysis.NetAnalyzers #84995
Closed

kouvel merged commit 4302b80 into dotnet:mainJun 15, 2023

kouvel deleted the ContentionEvents branch June 15, 2023 13:36

mthalman mentioned this pull request Jun 19, 2023
Mono-built SDK has error loading System.Reflection.MetadataLoadContext from MSBuild dotnet/source-build#3528
Closed

LakshanF mentioned this pull request Jun 26, 2023
Setup support for managed runtime events #87785
Merged

ghost locked as resolved and limited conversation to collaborators Jul 15, 2023

Uh oh!

Conversation

kouvel commented Jun 3, 2023

Uh oh!

ghost commented Jun 3, 2023

Uh oh!

stephentoub commented Jun 5, 2023

Uh oh!

kouvel commented Jun 6, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

davmason left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

kouvel commented Jun 3, 2023

Uh oh!

ghost commented Jun 3, 2023

Uh oh!

stephentoub commented Jun 5, 2023

Uh oh!

kouvel commented Jun 6, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

davmason left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

kouvel commented Jun 3, 2023

Uh oh!

ghost commented Jun 3, 2023

Uh oh!

stephentoub commented Jun 5, 2023

Uh oh!

kouvel commented Jun 6, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

davmason left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

kouvel commented Jun 6, 2023•
edited
Loading

kouvel commented Jun 6, 2023•
edited
Loading

kouvel commented Jun 6, 2023•
edited
Loading

kouvel commented Jun 6, 2023•
edited
Loading