Skip to content

[wasm] Introduce <InvariantTimezone> build flag - #87284

Merged
pavelsavara merged 10 commits into
dotnet:mainfrom
pavelsavara:wasm_invariant_timezone
Jul 1, 2023
Merged

[wasm] Introduce <InvariantTimezone> build flag#87284
pavelsavara merged 10 commits into
dotnet:mainfrom
pavelsavara:wasm_invariant_timezone

Conversation

@pavelsavara

@pavelsavarapavelsavara commented Jun 8, 2023•
edited
Loading

Copy link
Copy Markdown
Member

In Net8 we bundle the timezone database into .wasm file by default. It's not separate download anymore.

To to make download size of browser/wasi application smaller, we could link it out.
The runtime would behave as if there was no timezones in the database and use UTC.
For WASI, it doesn't try to load it from host FS unless you also set TZDIR env variable.

In the project file

<InvariantTimezone>true</InvariantTimezone>

Requires re-linking with wasm workload.

Also backward compatible with BlazorEnableTimeZoneSupport but with workload.

Fixes#37973 for wasm

@pavelsavarapavelsavara added arch-wasm WebAssembly architecture area-Build-mono size-reduction Issues impacting final app size primary for size sensitive workloads labels Jun 8, 2023
@pavelsavarapavelsavara added this to the 8.0.0 milestone Jun 8, 2023
@pavelsavarapavelsavara self-assigned this Jun 8, 2023
@ghost

ghost commented Jun 8, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

In Net8 we bundle the timezone database into .wasm file by default. It's not separate download anymore.

To to make download size of wasm/wasi application smaller, we could link it out.
The runtime would behave as if there was no timezones in the database and use UTC.
For WASI, it not try to load it from host FS unless you also set TZDIR env variable.

In the project file

<InvariantTimezone>true</InvariantTimezone>

Requires re-linking with wasm workload.

Also backward compatible with BlazorEnableTimeZoneSupport but with workload.

Fixes #37973 for wasm

Author:pavelsavara
Assignees:pavelsavara
Labels:

arch-wasm, area-Build-mono, size-reduction

Milestone:8.0.0

@maraf

maraf commented Jun 8, 2023

Copy link
Copy Markdown
Member

Is it the right time to have two WASM flavors/files in the runtime pack and choose between them during client app build?

@pavelsavara

pavelsavara commented Jun 8, 2023

Copy link
Copy Markdown
MemberAuthor

I don't have bandwidth to implement it.

@pavelsavarapavelsavara mentioned this pull request Jun 12, 2023
Merged
@marafmaraf mentioned this pull request Jun 21, 2023
Closed
@pavelsavara
pavelsavaraforce-pushed the wasm_invariant_timezone branch from 756d84c to cda65dbCompareJune 26, 2023 15:15
@pavelsavara

pavelsavara commented Jun 26, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Jun 26, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara

pavelsavara commented Jun 26, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Jun 26, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@build-analysisbuild-analysisBot mentioned this pull request Jun 26, 2023
Closed
@pavelsavara
Merge branch 'main' into wasm_invariant_timezone
37b89ac
@pavelsavara
WBT
75a14d1
@pavelsavara
Merge branch 'main' into wasm_invariant_timezone
d6aa491
# Conflicts:
#	src/mono/sample/wasm/browser-advanced/Wasm.Advanced.Sample.csproj
@pavelsavara

pavelsavara commented Jun 28, 2023

Copy link
Copy Markdown
MemberAuthor

image

@pavelsavara
pavelsavara marked this pull request as ready for review June 28, 2023 07:04
radical
radical reviewed Jun 28, 2023
View reviewed changes
Comment threadsrc/mono/wasm/Wasm.Build.Tests/InvariantTimezoneTests.cs
radical
radical reviewed Jun 28, 2023
View reviewed changes
Comment threadsrc/mono/wasi/runtime/driver.c
maraf
maraf reviewed Jun 28, 2023
View reviewed changes
Comment threadsrc/mono/wasm/Wasm.Build.Tests/InvariantTimezoneTests.cs Outdated
@pavelsavara

pavelsavara commented Jun 28, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm-optional

@azure-pipelines

azure-pipelinesBot commented Jun 28, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

maraf
maraf approved these changes Jun 28, 2023
View reviewed changes

@marafmaraf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@kg

kg commented Jun 28, 2023

Copy link
Copy Markdown
Contributor

How big is the size savings from this? Just curious

kg
kg reviewed Jun 28, 2023
View reviewed changes
Comment threaddocs/design/features/timezone-invariant-mode.md Outdated

Author: [Pavel Savara](https://github.com/pavelsavara)

It's currently only available for Browser OS

@kgkgJun 28, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe specifically call out that it strips the tz data from the binary

kg
kg reviewed Jun 28, 2023
View reviewed changes
Comment threadsrc/mono/wasm/build/WasmApp.targets Outdated
kg
kg approved these changes Jun 28, 2023
View reviewed changes
@pavelsavara

pavelsavara commented Jun 29, 2023

Copy link
Copy Markdown
MemberAuthor

How big is the size savings from this? Just curious

over 200KB

@pavelsavara
Merge branch 'main' into wasm_invariant_timezone
28bdd49
# Conflicts:
#	src/mono/wasm/build/WasmApp.targets
@pavelsavara
whitespace
30fc179
@pavelsavara
pavelsavara merged commit d388585 into dotnet:mainJul 1, 2023
@ghostghost locked as resolved and limited conversation to collaborators Jul 31, 2023
@pavelsavara
pavelsavara deleted the wasm_invariant_timezone branch September 2, 2024 15:31
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radicalradicalradical left review comments
@mdh1418mdh1418mdh1418 left review comments
@marafmarafmaraf approved these changes
@ilonatommyilonatommyilonatommy approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar
+1 more reviewer
@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-Build-monosize-reductionIssues impacting final app size primary for size sensitive workloads

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Add feature-switch for invariant TimeZone support

6 participants

@pavelsavara@maraf@kg@radical@mdh1418@ilonatommy