Skip to content

Revise how we set tiering and pgo options for spmi benchmark collections - #87292

Merged
AndyAyersMS merged 2 commits into
dotnet:mainfrom
AndyAyersMS:ReviseSPMIBenchmarkPgo2
Jun 9, 2023
Merged

Revise how we set tiering and pgo options for spmi benchmark collections#87292
AndyAyersMS merged 2 commits into
dotnet:mainfrom
AndyAyersMS:ReviseSPMIBenchmarkPgo2

Conversation

@AndyAyersMS

@AndyAyersMSAndyAyersMS commented Jun 8, 2023

Copy link
Copy Markdown
Member

Don't set these in the BDN environment; set them via the BDN command line so they only impact the process being benchmarked.

Fixes#86410

@AndyAyersMS
Revise how we set tiering and pgo options for spmi benchmark collections
7f94aa5
Don't set these in the BDN environment; set them via the BDN command line
so they only impact the process being benchmarked.
Fixesdotnet#86410
@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 8, 2023
@ghostghost assigned AndyAyersMSJun 8, 2023
@ghost

ghost commented Jun 8, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Don't set these in the BDN environment; set them via the BDN command line so they only impact the process being benchmarked.

Fixes #86410

Author:AndyAyersMS
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@AndyAyersMS

AndyAyersMS commented Jun 8, 2023

Copy link
Copy Markdown
MemberAuthor

@kunalspathak PTAL
cc @dotnet/jit-contrib

Internal pipeline run with this new script: green save unrelated OSX failure.

https://dev.azure.com/dnceng/internal/_build/results?buildId=2196191&view=results

kunalspathak
kunalspathak suggested changes Jun 8, 2023
View reviewed changes
Comment threadsrc/coreclr/scripts/superpmi_benchmarks.py
"--iterationCount 1 --warmupCount 0 --invocationCount 1 --unrollFactor 1 --strategy ColdStart --logBuildOutput " \
f"--envVars DOTNET_JitName:{shim_name} DOTNET_ZapDisable:1 DOTNET_ReadyToRun:0"

if coreclr_args.tiered_pgo:

@kunalspathakkunalspathakJun 8, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind also pulling the --iterationCount 1 --warmupCount 0 --invocationCount 1 --unrollFactor 1 --strategy ColdStart in common case?

Also, shouldn't you be passing iterationCount, etc. if for tiered/pgo runs? And a note about DOTNET_ZapDisable:1 DOTNET_ReadyToRun:0 too. Do we still want them for tiered/pgo runs?

@AndyAyersMSAndyAyersMSJun 8, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no common case right now, are you saying I should factor the common aspects out (or at least the common trailing elements)?

I wasn't planning on changing how we collect at this point. I would have to study the impact of altering BDN strategy to see if it adds value.

@kunalspathakkunalspathakJun 8, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no common case right now, are you saying I should factor the common aspects out (or at least the common trailing elements)?

Yes, that's what I meant.

I wasn't planning on changing how we collect at this point. I would have to study the impact of altering BDN strategy to see if it adds value.

Sure, we can limit this PR for just the changes you have currently and rethink about longer term strategy of how we should collect them in a later PR.

@ghostghost added needs-author-action An issue or pull request that requires more info or actions from the author. and removed needs-author-action An issue or pull request that requires more info or actions from the author. labels Jun 8, 2023
@kunalspathak

kunalspathak commented Jun 8, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Internal pipeline run with this new script: green save unrelated OSX failure.

Typically to test out things, I comment out all the unrelated collections in yml file and that way we just do the collection for type we are testing for. E.g. https://dev.azure.com/dnceng/internal/_build/results?buildId=2193577&view=results that just ran real-world collection.

@AndyAyersMS

AndyAyersMS commented Jun 9, 2023

Copy link
Copy Markdown
MemberAuthor

https://dev.azure.com/dnceng/internal/_build/results?buildId=2196878&view=results is the revised run -- benchmark runs were all happy, though a test build failed (will restart it once I am able).

@AndyAyersMSAndyAyersMS mentioned this pull request Jun 9, 2023
Closed
@AndyAyersMS
AndyAyersMS merged commit 9b7db0f into dotnet:mainJun 9, 2023
@ghostghost locked as resolved and limited conversation to collaborators Jul 9, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@EgorBoEgorBoEgorBo approved these changes
+1 more reviewer
@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@AndyAyersMSAndyAyersMS

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

revise how we pass config settings to benchmarkdotnet for SPMI collections

3 participants

@AndyAyersMS@kunalspathak@EgorBo
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Revise how we set tiering and pgo options for spmi benchmark collections by AndyAyersMS · Pull Request #87292 · dotnet/runtime · GitHub
Skip to content
Revise how we set tiering and pgo options for spmi benchmark collections - #87292
Merged
AndyAyersMS merged 2 commits into
dotnet:mainfrom 
AndyAyersMS:ReviseSPMIBenchmarkPgo2
Jun 9, 2023
Merged
Revise how we set tiering and pgo options for spmi benchmark collections#87292
AndyAyersMS merged 2 commits into
dotnet:mainfrom 
AndyAyersMS:ReviseSPMIBenchmarkPgo2
Conversation
@AndyAyersMS
@AndyAyersMSAndyAyersMS
commented
Jun 8, 2023

Copy link


Copy Markdown

Member
Don't set these in the BDN environment; set them via the BDN command line so they only impact the process being benchmarked.
Fixes#86410
@AndyAyersMS
Revise how we set tiering and pgo options for spmi benchmark collections
7f94aa5
Don't set these in the BDN environment; set them via the BDN command line
so they only impact the process being benchmarked.
Fixesdotnet#86410
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 8, 2023
@ghostghost
assigned AndyAyersMSJun 8, 2023
@ghost
ghost
commented
Jun 8, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
Don't set these in the BDN environment; set them via the BDN command line so they only impact the process being benchmarked.
Fixes #86410
Author:AndyAyersMS
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@AndyAyersMS
AndyAyersMS
commented
Jun 8, 2023

Copy link


Copy Markdown

MemberAuthor
@kunalspathak PTAL

cc @dotnet/jit-contrib
Internal pipeline run with this new script: green save unrelated OSX failure.
https://dev.azure.com/dnceng/internal/_build/results?buildId=2196191&view=results
kunalspathak
kunalspathak
suggested changes
Jun 8, 2023
View reviewed changes
Comment threadsrc/coreclr/scripts/superpmi_benchmarks.py
 "--iterationCount 1 --warmupCount 0 --invocationCount 1 --unrollFactor 1 --strategy ColdStart --logBuildOutput " \
 f"--envVars DOTNET_JitName:{shim_name} DOTNET_ZapDisable:1 DOTNET_ReadyToRun:0"

 if coreclr_args.tiered_pgo:
@kunalspathakkunalspathakJun 8, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind also pulling the --iterationCount 1 --warmupCount 0 --invocationCount 1 --unrollFactor 1 --strategy ColdStart in common case?
Also, shouldn't you be passing iterationCount, etc. if for tiered/pgo runs? And a note about DOTNET_ZapDisable:1 DOTNET_ReadyToRun:0 too. Do we still want them for tiered/pgo runs?
@AndyAyersMSAndyAyersMSJun 8, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no common case right now, are you saying I should factor the common aspects out (or at least the common trailing elements)?
I wasn't planning on changing how we collect at this point. I would have to study the impact of altering BDN strategy to see if it adds value.
@kunalspathakkunalspathakJun 8, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no common case right now, are you saying I should factor the common aspects out (or at least the common trailing elements)?
Yes, that's what I meant.
I wasn't planning on changing how we collect at this point. I would have to study the impact of altering BDN strategy to see if it adds value.
Sure, we can limit this PR for just the changes you have currently and rethink about longer term strategy of how we should collect them in a later PR.
@ghostghost
added

needs-author-action
An issue or pull request that requires more info or actions from the author.
and removed

needs-author-action
An issue or pull request that requires more info or actions from the author.
labels
Jun 8, 2023
@kunalspathak
kunalspathak
commented
Jun 8, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Internal pipeline run with this new script: green save unrelated OSX failure.
Typically to test out things, I comment out all the unrelated collections in yml file and that way we just do the collection for type we are testing for. E.g. https://dev.azure.com/dnceng/internal/_build/results?buildId=2193577&view=results that just ran real-world collection.
@AndyAyersMS
AndyAyersMS
commented
Jun 9, 2023

Copy link


Copy Markdown

MemberAuthor
https://dev.azure.com/dnceng/internal/_build/results?buildId=2196878&view=results is the revised run -- benchmark runs were all happy, though a test build failed (will restart it once I am able).
@AndyAyersMSAndyAyersMS
mentioned this pull request
Jun 9, 2023

Closed

@AndyAyersMS
AndyAyersMS
merged commit 9b7db0f
into
dotnet:mainJun 9, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Jul 9, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes

+1 more reviewer

@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@AndyAyersMSAndyAyersMS

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

revise how we pass config settings to benchmarkdotnet for SPMI collections


3 participants

@AndyAyersMS@kunalspathak@EgorBo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Revise how we set tiering and pgo options for spmi benchmark collections by AndyAyersMS · Pull Request #87292 · dotnet/runtime · GitHub
Skip to content
Revise how we set tiering and pgo options for spmi benchmark collections - #87292
Merged
AndyAyersMS merged 2 commits into
dotnet:mainfrom 
AndyAyersMS:ReviseSPMIBenchmarkPgo2
Jun 9, 2023
Merged
Revise how we set tiering and pgo options for spmi benchmark collections#87292
AndyAyersMS merged 2 commits into
dotnet:mainfrom 
AndyAyersMS:ReviseSPMIBenchmarkPgo2
Conversation
@AndyAyersMS
@AndyAyersMSAndyAyersMS
commented
Jun 8, 2023

Copy link


Copy Markdown

Member
Don't set these in the BDN environment; set them via the BDN command line so they only impact the process being benchmarked.
Fixes#86410
@AndyAyersMS
Revise how we set tiering and pgo options for spmi benchmark collections
7f94aa5
Don't set these in the BDN environment; set them via the BDN command line
so they only impact the process being benchmarked.
Fixesdotnet#86410
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 8, 2023
@ghostghost
assigned AndyAyersMSJun 8, 2023
@ghost
ghost
commented
Jun 8, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
Don't set these in the BDN environment; set them via the BDN command line so they only impact the process being benchmarked.
Fixes #86410
Author:AndyAyersMS
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@AndyAyersMS
AndyAyersMS
commented
Jun 8, 2023

Copy link


Copy Markdown

MemberAuthor
@kunalspathak PTAL

cc @dotnet/jit-contrib
Internal pipeline run with this new script: green save unrelated OSX failure.
https://dev.azure.com/dnceng/internal/_build/results?buildId=2196191&view=results
kunalspathak
kunalspathak
suggested changes
Jun 8, 2023
View reviewed changes
Comment threadsrc/coreclr/scripts/superpmi_benchmarks.py
 "--iterationCount 1 --warmupCount 0 --invocationCount 1 --unrollFactor 1 --strategy ColdStart --logBuildOutput " \
 f"--envVars DOTNET_JitName:{shim_name} DOTNET_ZapDisable:1 DOTNET_ReadyToRun:0"

 if coreclr_args.tiered_pgo:
@kunalspathakkunalspathakJun 8, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind also pulling the --iterationCount 1 --warmupCount 0 --invocationCount 1 --unrollFactor 1 --strategy ColdStart in common case?
Also, shouldn't you be passing iterationCount, etc. if for tiered/pgo runs? And a note about DOTNET_ZapDisable:1 DOTNET_ReadyToRun:0 too. Do we still want them for tiered/pgo runs?
@AndyAyersMSAndyAyersMSJun 8, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no common case right now, are you saying I should factor the common aspects out (or at least the common trailing elements)?
I wasn't planning on changing how we collect at this point. I would have to study the impact of altering BDN strategy to see if it adds value.
@kunalspathakkunalspathakJun 8, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no common case right now, are you saying I should factor the common aspects out (or at least the common trailing elements)?
Yes, that's what I meant.
I wasn't planning on changing how we collect at this point. I would have to study the impact of altering BDN strategy to see if it adds value.
Sure, we can limit this PR for just the changes you have currently and rethink about longer term strategy of how we should collect them in a later PR.
@ghostghost
added

needs-author-action
An issue or pull request that requires more info or actions from the author.
and removed

needs-author-action
An issue or pull request that requires more info or actions from the author.
labels
Jun 8, 2023
@kunalspathak
kunalspathak
commented
Jun 8, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Internal pipeline run with this new script: green save unrelated OSX failure.
Typically to test out things, I comment out all the unrelated collections in yml file and that way we just do the collection for type we are testing for. E.g. https://dev.azure.com/dnceng/internal/_build/results?buildId=2193577&view=results that just ran real-world collection.
@AndyAyersMS
AndyAyersMS
commented
Jun 9, 2023

Copy link


Copy Markdown

MemberAuthor
https://dev.azure.com/dnceng/internal/_build/results?buildId=2196878&view=results is the revised run -- benchmark runs were all happy, though a test build failed (will restart it once I am able).
@AndyAyersMSAndyAyersMS
mentioned this pull request
Jun 9, 2023

Closed

@AndyAyersMS
AndyAyersMS
merged commit 9b7db0f
into
dotnet:mainJun 9, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Jul 9, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes

+1 more reviewer

@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@AndyAyersMSAndyAyersMS

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

revise how we pass config settings to benchmarkdotnet for SPMI collections


3 participants

@AndyAyersMS@kunalspathak@EgorBo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Revise how we set tiering and pgo options for spmi benchmark collections by AndyAyersMS · Pull Request #87292 · dotnet/runtime · GitHub
Skip to content
Revise how we set tiering and pgo options for spmi benchmark collections - #87292
Merged
AndyAyersMS merged 2 commits into
dotnet:mainfrom 
AndyAyersMS:ReviseSPMIBenchmarkPgo2
Jun 9, 2023
Merged
Revise how we set tiering and pgo options for spmi benchmark collections#87292
AndyAyersMS merged 2 commits into
dotnet:mainfrom 
AndyAyersMS:ReviseSPMIBenchmarkPgo2
Conversation
@AndyAyersMS
@AndyAyersMSAndyAyersMS
commented
Jun 8, 2023

Copy link


Copy Markdown

Member
Don't set these in the BDN environment; set them via the BDN command line so they only impact the process being benchmarked.
Fixes#86410
@AndyAyersMS
Revise how we set tiering and pgo options for spmi benchmark collections
7f94aa5
Don't set these in the BDN environment; set them via the BDN command line
so they only impact the process being benchmarked.
Fixesdotnet#86410
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 8, 2023
@ghostghost
assigned AndyAyersMSJun 8, 2023
@ghost
ghost
commented
Jun 8, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
Don't set these in the BDN environment; set them via the BDN command line so they only impact the process being benchmarked.
Fixes #86410
Author:AndyAyersMS
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@AndyAyersMS
AndyAyersMS
commented
Jun 8, 2023

Copy link


Copy Markdown

MemberAuthor
@kunalspathak PTAL

cc @dotnet/jit-contrib
Internal pipeline run with this new script: green save unrelated OSX failure.
https://dev.azure.com/dnceng/internal/_build/results?buildId=2196191&view=results
kunalspathak
kunalspathak
suggested changes
Jun 8, 2023
View reviewed changes
Comment threadsrc/coreclr/scripts/superpmi_benchmarks.py
 "--iterationCount 1 --warmupCount 0 --invocationCount 1 --unrollFactor 1 --strategy ColdStart --logBuildOutput " \
 f"--envVars DOTNET_JitName:{shim_name} DOTNET_ZapDisable:1 DOTNET_ReadyToRun:0"

 if coreclr_args.tiered_pgo:
@kunalspathakkunalspathakJun 8, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind also pulling the --iterationCount 1 --warmupCount 0 --invocationCount 1 --unrollFactor 1 --strategy ColdStart in common case?
Also, shouldn't you be passing iterationCount, etc. if for tiered/pgo runs? And a note about DOTNET_ZapDisable:1 DOTNET_ReadyToRun:0 too. Do we still want them for tiered/pgo runs?
@AndyAyersMSAndyAyersMSJun 8, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no common case right now, are you saying I should factor the common aspects out (or at least the common trailing elements)?
I wasn't planning on changing how we collect at this point. I would have to study the impact of altering BDN strategy to see if it adds value.
@kunalspathakkunalspathakJun 8, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no common case right now, are you saying I should factor the common aspects out (or at least the common trailing elements)?
Yes, that's what I meant.
I wasn't planning on changing how we collect at this point. I would have to study the impact of altering BDN strategy to see if it adds value.
Sure, we can limit this PR for just the changes you have currently and rethink about longer term strategy of how we should collect them in a later PR.
@ghostghost
added

needs-author-action
An issue or pull request that requires more info or actions from the author.
and removed

needs-author-action
An issue or pull request that requires more info or actions from the author.
labels
Jun 8, 2023
@kunalspathak
kunalspathak
commented
Jun 8, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Internal pipeline run with this new script: green save unrelated OSX failure.
Typically to test out things, I comment out all the unrelated collections in yml file and that way we just do the collection for type we are testing for. E.g. https://dev.azure.com/dnceng/internal/_build/results?buildId=2193577&view=results that just ran real-world collection.
@AndyAyersMS
AndyAyersMS
commented
Jun 9, 2023

Copy link


Copy Markdown

MemberAuthor
https://dev.azure.com/dnceng/internal/_build/results?buildId=2196878&view=results is the revised run -- benchmark runs were all happy, though a test build failed (will restart it once I am able).
@AndyAyersMSAndyAyersMS
mentioned this pull request
Jun 9, 2023

Closed

@AndyAyersMS
AndyAyersMS
merged commit 9b7db0f
into
dotnet:mainJun 9, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Jul 9, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes

+1 more reviewer

@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@AndyAyersMSAndyAyersMS

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

revise how we pass config settings to benchmarkdotnet for SPMI collections


3 participants

@AndyAyersMS@kunalspathak@EgorBo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Revise how we set tiering and pgo options for spmi benchmark collections by AndyAyersMS · Pull Request #87292 · dotnet/runtime · GitHub
Skip to content
Revise how we set tiering and pgo options for spmi benchmark collections - #87292
Merged
AndyAyersMS merged 2 commits into
dotnet:mainfrom 
AndyAyersMS:ReviseSPMIBenchmarkPgo2
Jun 9, 2023
Merged
Revise how we set tiering and pgo options for spmi benchmark collections#87292
AndyAyersMS merged 2 commits into
dotnet:mainfrom 
AndyAyersMS:ReviseSPMIBenchmarkPgo2
Conversation
@AndyAyersMS
@AndyAyersMSAndyAyersMS
commented
Jun 8, 2023

Copy link


Copy Markdown

Member
Don't set these in the BDN environment; set them via the BDN command line so they only impact the process being benchmarked.
Fixes#86410
@AndyAyersMS
Revise how we set tiering and pgo options for spmi benchmark collections
7f94aa5
Don't set these in the BDN environment; set them via the BDN command line
so they only impact the process being benchmarked.
Fixesdotnet#86410
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 8, 2023
@ghostghost
assigned AndyAyersMSJun 8, 2023
@ghost
ghost
commented
Jun 8, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
Don't set these in the BDN environment; set them via the BDN command line so they only impact the process being benchmarked.
Fixes #86410
Author:AndyAyersMS
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@AndyAyersMS
AndyAyersMS
commented
Jun 8, 2023

Copy link


Copy Markdown

MemberAuthor
@kunalspathak PTAL

cc @dotnet/jit-contrib
Internal pipeline run with this new script: green save unrelated OSX failure.
https://dev.azure.com/dnceng/internal/_build/results?buildId=2196191&view=results
kunalspathak
kunalspathak
suggested changes
Jun 8, 2023
View reviewed changes
Comment threadsrc/coreclr/scripts/superpmi_benchmarks.py
 "--iterationCount 1 --warmupCount 0 --invocationCount 1 --unrollFactor 1 --strategy ColdStart --logBuildOutput " \
 f"--envVars DOTNET_JitName:{shim_name} DOTNET_ZapDisable:1 DOTNET_ReadyToRun:0"

 if coreclr_args.tiered_pgo:
@kunalspathakkunalspathakJun 8, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind also pulling the --iterationCount 1 --warmupCount 0 --invocationCount 1 --unrollFactor 1 --strategy ColdStart in common case?
Also, shouldn't you be passing iterationCount, etc. if for tiered/pgo runs? And a note about DOTNET_ZapDisable:1 DOTNET_ReadyToRun:0 too. Do we still want them for tiered/pgo runs?
@AndyAyersMSAndyAyersMSJun 8, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no common case right now, are you saying I should factor the common aspects out (or at least the common trailing elements)?
I wasn't planning on changing how we collect at this point. I would have to study the impact of altering BDN strategy to see if it adds value.
@kunalspathakkunalspathakJun 8, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no common case right now, are you saying I should factor the common aspects out (or at least the common trailing elements)?
Yes, that's what I meant.
I wasn't planning on changing how we collect at this point. I would have to study the impact of altering BDN strategy to see if it adds value.
Sure, we can limit this PR for just the changes you have currently and rethink about longer term strategy of how we should collect them in a later PR.
@ghostghost
added

needs-author-action
An issue or pull request that requires more info or actions from the author.
and removed

needs-author-action
An issue or pull request that requires more info or actions from the author.
labels
Jun 8, 2023
@kunalspathak
kunalspathak
commented
Jun 8, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Internal pipeline run with this new script: green save unrelated OSX failure.
Typically to test out things, I comment out all the unrelated collections in yml file and that way we just do the collection for type we are testing for. E.g. https://dev.azure.com/dnceng/internal/_build/results?buildId=2193577&view=results that just ran real-world collection.
@AndyAyersMS
AndyAyersMS
commented
Jun 9, 2023

Copy link


Copy Markdown

MemberAuthor
https://dev.azure.com/dnceng/internal/_build/results?buildId=2196878&view=results is the revised run -- benchmark runs were all happy, though a test build failed (will restart it once I am able).
@AndyAyersMSAndyAyersMS
mentioned this pull request
Jun 9, 2023

Closed

@AndyAyersMS
AndyAyersMS
merged commit 9b7db0f
into
dotnet:mainJun 9, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Jul 9, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes

+1 more reviewer

@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@AndyAyersMSAndyAyersMS

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

revise how we pass config settings to benchmarkdotnet for SPMI collections


3 participants

@AndyAyersMS@kunalspathak@EgorBo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Revise how we set tiering and pgo options for spmi benchmark collections by AndyAyersMS · Pull Request #87292 · dotnet/runtime · GitHub
Skip to content
Revise how we set tiering and pgo options for spmi benchmark collections - #87292
Merged
AndyAyersMS merged 2 commits into
dotnet:mainfrom 
AndyAyersMS:ReviseSPMIBenchmarkPgo2
Jun 9, 2023
Merged
Revise how we set tiering and pgo options for spmi benchmark collections#87292
AndyAyersMS merged 2 commits into
dotnet:mainfrom 
AndyAyersMS:ReviseSPMIBenchmarkPgo2
Conversation
@AndyAyersMS
@AndyAyersMSAndyAyersMS
commented
Jun 8, 2023

Copy link


Copy Markdown

Member
Don't set these in the BDN environment; set them via the BDN command line so they only impact the process being benchmarked.
Fixes#86410
@AndyAyersMS
Revise how we set tiering and pgo options for spmi benchmark collections
7f94aa5
Don't set these in the BDN environment; set them via the BDN command line
so they only impact the process being benchmarked.
Fixesdotnet#86410
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 8, 2023
@ghostghost
assigned AndyAyersMSJun 8, 2023
@ghost
ghost
commented
Jun 8, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
Don't set these in the BDN environment; set them via the BDN command line so they only impact the process being benchmarked.
Fixes #86410
Author:AndyAyersMS
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@AndyAyersMS
AndyAyersMS
commented
Jun 8, 2023

Copy link


Copy Markdown

MemberAuthor
@kunalspathak PTAL

cc @dotnet/jit-contrib
Internal pipeline run with this new script: green save unrelated OSX failure.
https://dev.azure.com/dnceng/internal/_build/results?buildId=2196191&view=results
kunalspathak
kunalspathak
suggested changes
Jun 8, 2023
View reviewed changes
Comment threadsrc/coreclr/scripts/superpmi_benchmarks.py
 "--iterationCount 1 --warmupCount 0 --invocationCount 1 --unrollFactor 1 --strategy ColdStart --logBuildOutput " \
 f"--envVars DOTNET_JitName:{shim_name} DOTNET_ZapDisable:1 DOTNET_ReadyToRun:0"

 if coreclr_args.tiered_pgo:
@kunalspathakkunalspathakJun 8, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind also pulling the --iterationCount 1 --warmupCount 0 --invocationCount 1 --unrollFactor 1 --strategy ColdStart in common case?
Also, shouldn't you be passing iterationCount, etc. if for tiered/pgo runs? And a note about DOTNET_ZapDisable:1 DOTNET_ReadyToRun:0 too. Do we still want them for tiered/pgo runs?
@AndyAyersMSAndyAyersMSJun 8, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no common case right now, are you saying I should factor the common aspects out (or at least the common trailing elements)?
I wasn't planning on changing how we collect at this point. I would have to study the impact of altering BDN strategy to see if it adds value.
@kunalspathakkunalspathakJun 8, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no common case right now, are you saying I should factor the common aspects out (or at least the common trailing elements)?
Yes, that's what I meant.
I wasn't planning on changing how we collect at this point. I would have to study the impact of altering BDN strategy to see if it adds value.
Sure, we can limit this PR for just the changes you have currently and rethink about longer term strategy of how we should collect them in a later PR.
@ghostghost
added

needs-author-action
An issue or pull request that requires more info or actions from the author.
and removed

needs-author-action
An issue or pull request that requires more info or actions from the author.
labels
Jun 8, 2023
@kunalspathak
kunalspathak
commented
Jun 8, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Internal pipeline run with this new script: green save unrelated OSX failure.
Typically to test out things, I comment out all the unrelated collections in yml file and that way we just do the collection for type we are testing for. E.g. https://dev.azure.com/dnceng/internal/_build/results?buildId=2193577&view=results that just ran real-world collection.
@AndyAyersMS
AndyAyersMS
commented
Jun 9, 2023

Copy link


Copy Markdown

MemberAuthor
https://dev.azure.com/dnceng/internal/_build/results?buildId=2196878&view=results is the revised run -- benchmark runs were all happy, though a test build failed (will restart it once I am able).
@AndyAyersMSAndyAyersMS
mentioned this pull request
Jun 9, 2023

Closed

@AndyAyersMS
AndyAyersMS
merged commit 9b7db0f
into
dotnet:mainJun 9, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Jul 9, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes

+1 more reviewer

@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@AndyAyersMSAndyAyersMS

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

revise how we pass config settings to benchmarkdotnet for SPMI collections


3 participants

@AndyAyersMS@kunalspathak@EgorBo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Revise how we set tiering and pgo options for spmi benchmark collections by AndyAyersMS · Pull Request #87292 · dotnet/runtime · GitHub
Skip to content
Revise how we set tiering and pgo options for spmi benchmark collections - #87292
Merged
AndyAyersMS merged 2 commits into
dotnet:mainfrom 
AndyAyersMS:ReviseSPMIBenchmarkPgo2
Jun 9, 2023
Merged
Revise how we set tiering and pgo options for spmi benchmark collections#87292
AndyAyersMS merged 2 commits into
dotnet:mainfrom 
AndyAyersMS:ReviseSPMIBenchmarkPgo2
Conversation
@AndyAyersMS
@AndyAyersMSAndyAyersMS
commented
Jun 8, 2023

Copy link


Copy Markdown

Member
Don't set these in the BDN environment; set them via the BDN command line so they only impact the process being benchmarked.
Fixes#86410
@AndyAyersMS
Revise how we set tiering and pgo options for spmi benchmark collections
7f94aa5
Don't set these in the BDN environment; set them via the BDN command line
so they only impact the process being benchmarked.
Fixesdotnet#86410
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 8, 2023
@ghostghost
assigned AndyAyersMSJun 8, 2023
@ghost
ghost
commented
Jun 8, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
Don't set these in the BDN environment; set them via the BDN command line so they only impact the process being benchmarked.
Fixes #86410
Author:AndyAyersMS
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@AndyAyersMS
AndyAyersMS
commented
Jun 8, 2023

Copy link


Copy Markdown

MemberAuthor
@kunalspathak PTAL

cc @dotnet/jit-contrib
Internal pipeline run with this new script: green save unrelated OSX failure.
https://dev.azure.com/dnceng/internal/_build/results?buildId=2196191&view=results
kunalspathak
kunalspathak
suggested changes
Jun 8, 2023
View reviewed changes
Comment threadsrc/coreclr/scripts/superpmi_benchmarks.py
 "--iterationCount 1 --warmupCount 0 --invocationCount 1 --unrollFactor 1 --strategy ColdStart --logBuildOutput " \
 f"--envVars DOTNET_JitName:{shim_name} DOTNET_ZapDisable:1 DOTNET_ReadyToRun:0"

 if coreclr_args.tiered_pgo:
@kunalspathakkunalspathakJun 8, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind also pulling the --iterationCount 1 --warmupCount 0 --invocationCount 1 --unrollFactor 1 --strategy ColdStart in common case?
Also, shouldn't you be passing iterationCount, etc. if for tiered/pgo runs? And a note about DOTNET_ZapDisable:1 DOTNET_ReadyToRun:0 too. Do we still want them for tiered/pgo runs?
@AndyAyersMSAndyAyersMSJun 8, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no common case right now, are you saying I should factor the common aspects out (or at least the common trailing elements)?
I wasn't planning on changing how we collect at this point. I would have to study the impact of altering BDN strategy to see if it adds value.
@kunalspathakkunalspathakJun 8, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no common case right now, are you saying I should factor the common aspects out (or at least the common trailing elements)?
Yes, that's what I meant.
I wasn't planning on changing how we collect at this point. I would have to study the impact of altering BDN strategy to see if it adds value.
Sure, we can limit this PR for just the changes you have currently and rethink about longer term strategy of how we should collect them in a later PR.
@ghostghost
added

needs-author-action
An issue or pull request that requires more info or actions from the author.
and removed

needs-author-action
An issue or pull request that requires more info or actions from the author.
labels
Jun 8, 2023
@kunalspathak
kunalspathak
commented
Jun 8, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Internal pipeline run with this new script: green save unrelated OSX failure.
Typically to test out things, I comment out all the unrelated collections in yml file and that way we just do the collection for type we are testing for. E.g. https://dev.azure.com/dnceng/internal/_build/results?buildId=2193577&view=results that just ran real-world collection.
@AndyAyersMS
AndyAyersMS
commented
Jun 9, 2023

Copy link


Copy Markdown

MemberAuthor
https://dev.azure.com/dnceng/internal/_build/results?buildId=2196878&view=results is the revised run -- benchmark runs were all happy, though a test build failed (will restart it once I am able).
@AndyAyersMSAndyAyersMS
mentioned this pull request
Jun 9, 2023

Closed

@AndyAyersMS
AndyAyersMS
merged commit 9b7db0f
into
dotnet:mainJun 9, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Jul 9, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes

+1 more reviewer

@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@AndyAyersMSAndyAyersMS

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

revise how we pass config settings to benchmarkdotnet for SPMI collections


3 participants

@AndyAyersMS@kunalspathak@EgorBo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Revise how we set tiering and pgo options for spmi benchmark collections by AndyAyersMS · Pull Request #87292 · dotnet/runtime · GitHub
Skip to content
Revise how we set tiering and pgo options for spmi benchmark collections - #87292
Merged
AndyAyersMS merged 2 commits into
dotnet:mainfrom 
AndyAyersMS:ReviseSPMIBenchmarkPgo2
Jun 9, 2023
Merged
Revise how we set tiering and pgo options for spmi benchmark collections#87292
AndyAyersMS merged 2 commits into
dotnet:mainfrom 
AndyAyersMS:ReviseSPMIBenchmarkPgo2
Conversation
@AndyAyersMS
@AndyAyersMSAndyAyersMS
commented
Jun 8, 2023

Copy link


Copy Markdown

Member
Don't set these in the BDN environment; set them via the BDN command line so they only impact the process being benchmarked.
Fixes#86410
@AndyAyersMS
Revise how we set tiering and pgo options for spmi benchmark collections
7f94aa5
Don't set these in the BDN environment; set them via the BDN command line
so they only impact the process being benchmarked.
Fixesdotnet#86410
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 8, 2023
@ghostghost
assigned AndyAyersMSJun 8, 2023
@ghost
ghost
commented
Jun 8, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
Don't set these in the BDN environment; set them via the BDN command line so they only impact the process being benchmarked.
Fixes #86410
Author:AndyAyersMS
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@AndyAyersMS
AndyAyersMS
commented
Jun 8, 2023

Copy link


Copy Markdown

MemberAuthor
@kunalspathak PTAL

cc @dotnet/jit-contrib
Internal pipeline run with this new script: green save unrelated OSX failure.
https://dev.azure.com/dnceng/internal/_build/results?buildId=2196191&view=results
kunalspathak
kunalspathak
suggested changes
Jun 8, 2023
View reviewed changes
Comment threadsrc/coreclr/scripts/superpmi_benchmarks.py
 "--iterationCount 1 --warmupCount 0 --invocationCount 1 --unrollFactor 1 --strategy ColdStart --logBuildOutput " \
 f"--envVars DOTNET_JitName:{shim_name} DOTNET_ZapDisable:1 DOTNET_ReadyToRun:0"

 if coreclr_args.tiered_pgo:
@kunalspathakkunalspathakJun 8, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind also pulling the --iterationCount 1 --warmupCount 0 --invocationCount 1 --unrollFactor 1 --strategy ColdStart in common case?
Also, shouldn't you be passing iterationCount, etc. if for tiered/pgo runs? And a note about DOTNET_ZapDisable:1 DOTNET_ReadyToRun:0 too. Do we still want them for tiered/pgo runs?
@AndyAyersMSAndyAyersMSJun 8, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no common case right now, are you saying I should factor the common aspects out (or at least the common trailing elements)?
I wasn't planning on changing how we collect at this point. I would have to study the impact of altering BDN strategy to see if it adds value.
@kunalspathakkunalspathakJun 8, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no common case right now, are you saying I should factor the common aspects out (or at least the common trailing elements)?
Yes, that's what I meant.
I wasn't planning on changing how we collect at this point. I would have to study the impact of altering BDN strategy to see if it adds value.
Sure, we can limit this PR for just the changes you have currently and rethink about longer term strategy of how we should collect them in a later PR.
@ghostghost
added

needs-author-action
An issue or pull request that requires more info or actions from the author.
and removed

needs-author-action
An issue or pull request that requires more info or actions from the author.
labels
Jun 8, 2023
@kunalspathak
kunalspathak
commented
Jun 8, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Internal pipeline run with this new script: green save unrelated OSX failure.
Typically to test out things, I comment out all the unrelated collections in yml file and that way we just do the collection for type we are testing for. E.g. https://dev.azure.com/dnceng/internal/_build/results?buildId=2193577&view=results that just ran real-world collection.
@AndyAyersMS
AndyAyersMS
commented
Jun 9, 2023

Copy link


Copy Markdown

MemberAuthor
https://dev.azure.com/dnceng/internal/_build/results?buildId=2196878&view=results is the revised run -- benchmark runs were all happy, though a test build failed (will restart it once I am able).
@AndyAyersMSAndyAyersMS
mentioned this pull request
Jun 9, 2023

Closed

@AndyAyersMS
AndyAyersMS
merged commit 9b7db0f
into
dotnet:mainJun 9, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Jul 9, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes

+1 more reviewer

@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@AndyAyersMSAndyAyersMS

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

revise how we pass config settings to benchmarkdotnet for SPMI collections


3 participants

@AndyAyersMS@kunalspathak@EgorBo