Skip to content

Clean up JIT flags - #87588

Merged
jkotas merged 16 commits into
dotnet:mainfrom
BruceForstall:CleanUpJitFlags
Jun 16, 2023
Merged

Clean up JIT flags#87588
jkotas merged 16 commits into
dotnet:mainfrom
BruceForstall:CleanUpJitFlags

Conversation

@BruceForstall

@BruceForstallBruceForstall commented Jun 15, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor
  1. Remove never set CORJIT_MCJIT_BACKGROUND.
  2. Remove never checked CORJIT_PINVOKE_RESTORE_ESP (x86 only). Remove related
    COMPUTED_IS_PRE_V4_ASSEMBLY, IS_PRE_V4_ASSEMBLY, IsPreV4Assembly().
  3. Remove unused CORJIT_FEATURE_SIMD.
  4. Remove all the "UNUSED" flags, which only cause clutter.
  5. Renumber/pack all the remaining flags. Ensure that all flags have unique
    numbers, even for different platforms.
  6. Add missing flags in a few cases: the JIT/CORJIT equality asserts, mcs "-jitflags"
    dumpers, CorJitFlagToString(), CorJitFlag type.

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 15, 2023
@ghost

ghost commented Jun 15, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:BruceForstall
Assignees:BruceForstall
Labels:

area-CodeGen-coreclr

Milestone:-

@BruceForstall
Clean up JIT flags
47bf469
1. Remove never set CORJIT_MCJIT_BACKGROUND.
2. Remove never checked CORJIT_PINVOKE_RESTORE_ESP (x86 only). Remove related
`COMPUTED_IS_PRE_V4_ASSEMBLY`, `IS_PRE_V4_ASSEMBLY`, `IsPreV4Assembly()`.
3. Remove unused CORJIT_FEATURE_SIMD.
4. Remove all the "UNUSED" flags, which only cause clutter.
5. Renumber/pack all the remaining flags. Ensure that all flags have unique
numbers, even for different platforms.
6. Add missing flags in a few cases: the JIT/CORJIT equality asserts, mcs "-jitflags"
dumpers, `CorJitFlagToString()`, `CorJitFlag` type.
@BruceForstallBruceForstall changed the title Clean up jit flagsClean up JIT flagsJun 15, 2023
@BruceForstall
BruceForstall marked this pull request as ready for review June 15, 2023 15:26
BruceForstall
BruceForstall commented Jun 15, 2023
View reviewed changes
Comment threadsrc/coreclr/vm/jitinterface.cpp
@BruceForstall

BruceForstall commented Jun 15, 2023

Copy link
Copy Markdown
ContributorAuthor

@AndyAyersMS PTAL
cc @dotnet/jit-contrib

@AaronRobinsonMSFT PTAL at the CORJIT_PINVOKE_RESTORE_ESP related change

jkotas
jkotas reviewed Jun 15, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/jitee.h
jkotas
jkotas reviewed Jun 15, 2023
View reviewed changes
Comment threadsrc/coreclr/inc/jiteeversionguid.h
AaronRobinsonMSFT
AaronRobinsonMSFT approved these changes Jun 15, 2023
View reviewed changes

@AaronRobinsonMSFTAaronRobinsonMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great clean-up! Thanks @BruceForstall.

@BruceForstall

BruceForstall commented Jun 16, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

azure-pipelinesBot commented Jun 16, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@build-analysisbuild-analysisBot mentioned this pull request Jun 16, 2023
Closed
@BruceForstallBruceForstall mentioned this pull request Jun 16, 2023
Closed
@BruceForstall

BruceForstall commented Jun 16, 2023

Copy link
Copy Markdown
ContributorAuthor

I updated this to remove all the unused JIT-EE interface methods/types listed in #86672. There is one commit for each item removed. (Maybe this change should be merged without squashing, to preserve that?)

@jkotas@AaronRobinsonMSFT PTAL

@BruceForstall

BruceForstall commented Jun 16, 2023

Copy link
Copy Markdown
ContributorAuthor

Test failures all look known or infra.

jkotas
jkotas approved these changes Jun 16, 2023
View reviewed changes

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jkotas

jkotas commented Jun 16, 2023

Copy link
Copy Markdown
Member

Maybe this change should be merged without squashing, to preserve that?

Sounds good to me. I am going to merge as rebase.

@jkotas
jkotas merged commit b84612b into dotnet:mainJun 16, 2023
@BruceForstall
BruceForstall deleted the CleanUpJitFlags branch June 16, 2023 22:58
@BruceForstallBruceForstall mentioned this pull request Jun 16, 2023
Closed
13 tasks
@AaronRobinsonMSFT

AaronRobinsonMSFT commented Jun 17, 2023

Copy link
Copy Markdown
Member

I updated this to remove all the unused JIT-EE interface methods/types listed in #86672.

❤️

@ghostghost locked as resolved and limited conversation to collaborators Jul 17, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas approved these changes
@AndyAyersMSAndyAyersMSAndyAyersMS approved these changes
@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

Assignees

@BruceForstallBruceForstall

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BruceForstall@jkotas@AaronRobinsonMSFT@AndyAyersMS