Skip to content

Re-enable disabled BigInteger tests. - #87640

Merged
eiriktsarpalis merged 1 commit into
dotnet:mainfrom
eiriktsarpalis:enable-biginteger-tests
Jun 15, 2023
Merged

Re-enable disabled BigInteger tests.#87640
eiriktsarpalis merged 1 commit into
dotnet:mainfrom
eiriktsarpalis:enable-biginteger-tests

Conversation

@eiriktsarpalis

Copy link
Copy Markdown
Member

Fix#63802.

The BigInteger failures were fixed by #87383 and the record unit tests are caused by the fact that netfx doesn't have the IsExternalInit class defined.

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #63802.

The BigInteger failures were fixed by #87383 and the record unit tests are caused by the fact that netfx doesn't have the IsExternalInit class defined.

Author:eiriktsarpalis
Assignees:-
Labels:

area-System.Text.Json

Milestone:-

@eiriktsarpaliseiriktsarpalis added this to the 8.0.0 milestone Jun 15, 2023
@eiriktsarpalis
eiriktsarpalis merged commit 64cab8f into dotnet:mainJun 15, 2023
@eiriktsarpalis
eiriktsarpalis deleted the enable-biginteger-tests branch June 15, 2023 22:45
@ghostghost locked as resolved and limited conversation to collaborators Jul 16, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System.Text.Json.SourceGeneration.Tests have issues with BigInteger and records on netfx

2 participants

@eiriktsarpalis@tarekgh