Uh oh!
There was an error while loading. Please reload this page.
[mono][interp] Add vectorization for Vector4 - #87822
Merged
Merged
Conversation
ghost
commented
Jun 20, 2023
Tagging subscribers to this area: @BrzVlad, @kotlarmilos Issue DetailsAnd other vector of float improvements.
|
vargaz
approved these changes
Jun 20, 2023
This was referenced Jun 20, 2023
BrzVladforce-pushed
the
feature-interp-vector4
branch
from
June 22, 2023 14:19
5d1b462 to
0de18b8CompareBrzVladforce-pushed
the
feature-interp-vector4
branch
from
June 26, 2023 10:49
0de18b8 to
0325364Compare
This was referenced Jun 26, 2023
BrzVladforce-pushed
the
feature-interp-vector4
branch
2 times, most recently
from
July 5, 2023 06:28
ce989eb to
ca4a6c5CompareWhich is pretty much Vector<float>
The constructors receive each element as an argument. This is the same as `Vector128.Create` so we reuse that code. This ends up generating a MINT_SIMD_V128_I*_CREATE opcode which receives each element value as an argument.
Since it is common to instantiate Vector4 with constant values, add also support for tracking R4 values during optimizations. If all elements are constant, we generate instead a single MINT_SIMD_V128_LDC, which has the entire vector value embedded in the instruction stream.
It is not marked as simd type if the generic param is not valid (ex not primitive type). Future checks are not expecting this scenario and can potentially crash.
BrzVladforce-pushed
the
feature-interp-vector4
branch
from
July 5, 2023 06:51
ca4a6c5 to
941827dCompare
This was referenced Jul 10, 2023
This was referenced Jul 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And other vector of float improvements.