Uh oh!
There was an error while loading. Please reload this page.
Fix runtime-extra-platforms failures related to HybridGlobalization - #87913
Conversation
ghost
commented
Jun 22, 2023
Tagging subscribers to 'os-tvos': @steveisok, @akoeplinger Issue DetailsFix failures on runtime-extra-platforms after merging #86895
|
mkhamoyan
commented
Jun 22, 2023
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| { | ||
| assert(cwTargetLength >= 0); | ||
| Range result = {-2, 0}; | ||
| Range result = {-1, 0}; |
There was a problem hiding this comment.
What do these magic numbers of -1, -2, -3, etc. mean?
There was a problem hiding this comment.
Added ErrorCodes enum to make it clear.
mkhamoyan
commented
Jun 22, 2023
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| { | ||
| assert(cwTargetLength >= 0); | ||
| Range result = {-2, 0}; | ||
| Range result = {ERROR_INDEX_NOT_FOUND, 0}; |
There was a problem hiding this comment.
Shouldn't this be ERROR_COMPARISON_OPTIONS_NOT_FOUND as previously the value was -2?
There was a problem hiding this comment.
Never mind, that was actually the fix in the first place.
ivanpovazan
left a comment
There was a problem hiding this comment.
LGTM! Thank you!
Just please make sure that all related System.Globalization failures in runtime-extra-platforms are resolved before merging.
mkhamoyan
commented
Jun 22, 2023
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mkhamoyan
commented
Jun 22, 2023
Failures are not related. |
Fix failures on runtime-extra-platforms after merging #86895
Return ERROR_COMPARISON_OPTIONS_NOT_FOUND only when options are not found and ERROR_INDEX_NOT_FOUND when substring is not found.