') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [OSX] HybridGlobalization Implement casing functions by mkhamoyan · Pull Request #87919 · dotnet/runtime · GitHub
Skip to content

[OSX] HybridGlobalization Implement casing functions - #87919

Merged
mkhamoyan merged 46 commits into
mainfrom
hybrid_casing_functions
Jun 29, 2023
Merged

[OSX] HybridGlobalization Implement casing functions#87919
mkhamoyan merged 46 commits into
mainfrom
hybrid_casing_functions

Conversation

@mkhamoyan

@mkhamoyanmkhamoyan commented Jun 22, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Implements a chunk of apple native-api based globalization.

Old, icu-based private API:

GlobalizationNative_ChangeCase
GlobalizationNative_ChangeCaseInvariant

New, non-icu private API:

GlobalizationNative_ChangeCaseNative
GlobalizationNative_ChangeCaseInvariantNative

Contributes to #80689

cc @SamMonoRT

mkhamoyan added 30 commits May 30, 2023 15:07
@mkhamoyan
Implemented IndexOf and LastIndexOf functions
164bb0a
@mkhamoyan
Updated test cases
1e4e9a5
@mkhamoyan
Remove not needed parts
292b915
@mkhamoyan
Implemented IsPrefix, IsSuffix functions
9d23f7b
@mkhamoyan
Remove logs
1f8b5d5
@mkhamoyan
Fix CI build failures
7b91b6c
@mkhamoyan
Refactored
c4a2d3c
@mkhamoyan
Fixed some test cases for OSX
001c366
@mkhamoyan
Minor changes in test cases
0ec8d79
@mkhamoyan
test case minor refactoring
fa7322c
@mkhamoyan
Merge branch 'main' into hybrid_collation_functions
fc2837b
@mkhamoyan
Merge branch 'main' into hybrid_collation_functions
a7ab572
@mkhamoyan
Merge branch 'main' into hybrid_collation_functions
36de1a9
@mkhamoyan
Changed IndexOf functions implementation
139a6ba
@mkhamoyan
Fix build failue
f3da1e5
@mkhamoyan
Minor fixes
5c3f172
@mkhamoyan
Minor fix
ab317f7
@mkhamoyan
Refactor as per review comments
24094fe
@mkhamoyan
Refactored Indexing functions calls
c425d38
@mkhamoyan
Updated doc and added comments
a3f44b4
@mkhamoyan
Applied changes suggested by@jkotas
cbaaf80
@mkhamoyan
Refactored some files
caebcbe
@mkhamoyan
Make the doc more readable
71b026e
@mkhamoyan
Refactored IndexOf function
9dda83a
@mkhamoyan
Add more comments in IndexOF function
88c6861
@mkhamoyan
remove localizedStandardRangeOfString
460aba0
@mkhamoyan
Initial changes for casing functions
db0a8f8
@mkhamoyan
Added exception in case mixed compositions
3d5a195
@mkhamoyan
Merge branch 'hybrid_collation_functions' into hybrid_casing_functions
006bdb7
@mkhamoyan
Merge branch 'main' into hybrid_casing_functions
24136fc
@azure-pipelines

azure-pipelinesBot commented Jun 26, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyanmkhamoyan mentioned this pull request Jun 26, 2023
Closed
23 tasks
This was referenced Jun 26, 2023
Closed
Closed
@mkhamoyan

mkhamoyan commented Jun 27, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-ioslike

@azure-pipelines

azure-pipelinesBot commented Jun 27, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan

mkhamoyan commented Jun 27, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-ioslike

@azure-pipelines

azure-pipelinesBot commented Jun 27, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan

mkhamoyan commented Jun 27, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-ioslike

@azure-pipelines

azure-pipelinesBot commented Jun 27, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

mdh1418
mdh1418 reviewed Jun 27, 2023
View reviewed changes
Comment threadsrc/native/libs/System.Globalization.Native/pal_casing.m Outdated

typedef enum
{
ERROR_SUCCESS = 0,

@mdh1418mdh1418Jun 27, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: ERROR_NONE or SUCCESS or NO_ERROR

@mkhamoyanmkhamoyanJun 27, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that we use quite often ERROR_SUCCESS , like https://github.com/dotnet/runtime/blob/main/src/native/libs/System.Native/pal_networking.c#L709
https://github.com/dotnet/runtime/blob/main/src/coreclr/pal/src/init/pal.cpp#L787 and many other places.

@mdh1418mdh1418Jun 27, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah in that case keep as is!

@jkotasjkotasJun 27, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERROR_SUCCESS is a name from Windows SDK: https://learn.microsoft.com/en-us/windows/win32/debug/system-error-codes--0-499- . It is not a great name. We use it when we are on Windows or when we are trying to emulate Windows. It is not the case here.

@mkhamoyanmkhamoyanJun 27, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, will update it, thanks!

@jkotasjkotasJun 27, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have globalization error codes defined in

runtime/src/native/libs/System.Globalization.Native/pal_errors.h

Line 13 in 19d2e90

UnknownError=1,
. You may consider reusing and amending this definition.

mdh1418
mdh1418 reviewed Jun 27, 2023
View reviewed changes
Comment threadsrc/native/libs/System.Globalization.Native/pal_casing.m Outdated
mdh1418
mdh1418 approved these changes Jun 27, 2023
View reviewed changes

@mdh1418mdh1418 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the rest of the comments are resolved, it looks good to me! Thanks

ilonatommy
ilonatommy requested changes Jun 28, 2023
View reviewed changes
Comment threaddocs/design/features/globalization-hybrid-mode.md
@ghostghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jun 28, 2023
@mkhamoyan

mkhamoyan commented Jun 28, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-ioslike

@azure-pipelines

azure-pipelinesBot commented Jun 28, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ghostghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Jun 28, 2023
@build-analysisbuild-analysisBot mentioned this pull request Jun 29, 2023
Closed
ilonatommy
ilonatommy approved these changes Jun 29, 2023
View reviewed changes

@ilonatommyilonatommy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if the exception throwing will be solved in #88180.

@mkhamoyan
mkhamoyan merged commit 67b1ede into mainJun 29, 2023
@mkhamoyan
mkhamoyan deleted the hybrid_casing_functions branch June 29, 2023 10:02
@ghostghost locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas left review comments
@mdh1418mdh1418mdh1418 approved these changes
@ilonatommyilonatommyilonatommy approved these changes
@steveisoksteveisokAwaiting requested review from steveisoksteveisok is a code owner
@akoeplingerakoeplingerAwaiting requested review from akoeplinger
@vargazvargazAwaiting requested review from vargaz
@lambdageeklambdageekAwaiting requested review from lambdageek
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
+1 more reviewer
@am11am11am11 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@mkhamoyanmkhamoyan

Labels

area-System.Globalizationos-iosApple iOS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mkhamoyan@am11@jkotas@mdh1418@ilonatommy