[mono][tests] Enable ILStrip after AOT compilation for library tests by kotlarmilos · Pull Request #88167 · dotnet/runtime

kotlarmilos · 2023-06-28T21:57:06Z

Description

This PR enables IL stripping after AOT compilation for library tests on iOS-like platforms.

Contributes to #87740

ghost · 2023-06-28T21:57:20Z

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR aims to enable IL stripping during AOT compilation of library tests on iOS-like platforms.

Fixes #87740

Author:	kotlarmilos
Assignees:	kotlarmilos
Labels:	`area-Infrastructure-mono`, `os-ios`
Milestone:	8.0.0

kotlarmilos · 2023-06-28T21:57:31Z

/azp run runtime-ioslike,runtime-ioslikesimulator

azure-pipelines · 2023-06-28T21:57:41Z

Azure Pipelines successfully started running 2 pipeline(s).

kotlarmilos · 2023-06-29T20:35:47Z

The failures in the library tests appear to be unrelated (TCP connection failure), but since all tests fail during the startup, I would like to check it locally. @akoeplinger Please take a look when you get a chance.

akoeplinger · 2023-07-05T18:08:22Z

With the fix from https://github.com/dotnet/runtime/pull/87923/files#r1253418906 this passes System.Runtime.Tests on my iOS device, except for three tests which try to assert that a method body contains a specific IL instruction, or inlining attribute etc. I'll fix those and push to this PR.

lambdageek · 2023-07-05T18:25:10Z

@akoeplinger We'll need to backport the ILStrip fix to net7.0, too

akoeplinger · 2023-07-05T19:51:30Z

Yep, the 7.0 backport is in #88437

kotlarmilos · 2023-07-11T12:36:58Z

/azp run runtime-ioslike,runtime-ioslikesimulator

azure-pipelines · 2023-07-11T12:37:14Z

Azure Pipelines successfully started running 2 pipeline(s).

kotlarmilos · 2023-07-19T12:30:40Z

/azp run runtime-ioslike,runtime-ioslikesimulator

azure-pipelines · 2023-07-19T12:30:55Z

Azure Pipelines successfully started running 2 pipeline(s).

kotlarmilos · 2023-12-19T14:48:26Z

/azp run runtime-ioslike

kotlarmilos · 2023-12-21T10:32:35Z

/azp run runtime-ioslike

akoeplinger

Did you run runtime-extra-platforms or runtime-ioslike pipelines on this to make sure we don't have additional tests failing?

I wonder a bit if we should only turn this on for a subset of assemblies. Or maybe only for the System.* assemblies.

kotlarmilos · 2024-01-16T13:14:25Z

/azp run runtime-ioslike

kotlarmilos · 2024-01-16T13:20:10Z

I wonder a bit if we should only turn this on for a subset of assemblies. Or maybe only for the System.* assemblies.

Let's check if there are other failures. Are there any performance-related implications we need to consider?

akoeplinger · 2024-01-16T14:37:32Z

Are there any performance-related implications we need to consider?

Not that I know of. One thing to keep in mind is that we're now also turning this on for library mode i.e. external customers.

kotlarmilos · 2024-01-17T17:57:50Z

/azp run runtime-ioslike

kotlarmilos · 2024-01-17T20:14:49Z

/azp run runtime-ioslike

kotlarmilos · 2024-01-23T14:30:14Z

/azp run runtime-ioslike

kotlarmilos · 2024-01-23T14:30:44Z

/azp run runtime-ioslike

kotlarmilos · 2024-01-24T14:46:24Z

/azp run runtime-ioslike

kotlarmilos · 2024-01-26T15:18:27Z

Failures shouldn't be related. Additionally, I've disabled it for library mode.

Enable ILStrip during AOT compilation of library tests
6106722

kotlarmilos added area-Infrastructure-mono os-ios Apple iOS labels Jun 28, 2023

kotlarmilos added this to the 8.0.0 milestone Jun 28, 2023

kotlarmilos requested a review from akoeplinger June 28, 2023 21:57

kotlarmilos requested a review from marek-safar as a code owner June 28, 2023 21:57

kotlarmilos self-assigned this Jun 28, 2023

kotlarmilos mentioned this pull request Jun 29, 2023
[mono][ios] EventPipe processinfo3 test is failing on iOS-like platforms #88186
Closed

akoeplinger mentioned this pull request Jul 5, 2023
[mono] ILStrip sorts custom attribute table #87923
Merged

Merge branch 'dotnet:main' into improvement/enable-ios-ilstrip
8523dd5

This comment was marked as outdated.
Sign in to view

This was referenced Jul 11, 2023
simpleruntimeeventvalidation test failing in CI #88499
Closed
[mono][tests] Microsoft.Gen.OptionsValidation is failing on iOS platforms #88720
Closed

Merge branch 'dotnet:main' into improvement/enable-ios-ilstrip
69896e4

build-analysisBot mentioned this pull request Jul 19, 2023
Roslyn source generator crash on mono/linux/arm64 #81123
Closed

kotlarmilos changed the title ~~[mono][tests] Enable ILStrip during AOT compilation of library tests~~[WIP][mono][tests] Enable ILStrip during AOT compilation of library testsDec 19, 2023

kotlarmilos added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Dec 19, 2023

[tests] Fix failing tests
95a9268

kotlarmilos changed the title ~~[WIP][mono][tests] Enable ILStrip during AOT compilation of library tests~~[mono][tests] Enable ILStrip during AOT compilation of library testsDec 21, 2023

kotlarmilos changed the title ~~[mono][tests] Enable ILStrip during AOT compilation of library tests~~[mono][tests] Enable ILStrip after AOT compilation for library testsDec 21, 2023

kotlarmilos removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Dec 21, 2023

kotlarmilos marked this pull request as ready for review December 21, 2023 14:21

kotlarmilos commented Dec 21, 2023
View reviewed changes

Comment thread...s/System.Runtime/tests/System.Diagnostics.Debug.Tests/DebugTestsNoListeners.Interpolation.cs Outdated

kotlarmilos requested a review from SamMonoRT December 21, 2023 14:26

Merge branch 'dotnet:main' into improvement/enable-ios-ilstrip
88f74e7

akoeplinger reviewed Jan 16, 2024
View reviewed changes

Comment thread...s/System.Runtime/tests/System.Diagnostics.Debug.Tests/DebugTestsNoListeners.Interpolation.cs Outdated

[infra] Disable ILStrip for System.Diagnostics.Debug.Tests
711c1f5

kotlarmilos added 2 commits January 17, 2024 18:54

[infra] Don't run ILStrip for library mode
2b47415

Merge branch 'main' into improvement/enable-ios-ilstrip
e17a728

Fix typo
5fbc682

Merge branch 'dotnet:main' into improvement/enable-ios-ilstrip
c606845

Add ShouldILStrip to _ApplePropertyNames
9cdca01

akoeplinger approved these changes Jan 30, 2024
View reviewed changes

kotlarmilos merged commit 10ea547 into dotnet:mainJan 30, 2024

Uh oh!

Conversation

kotlarmilos commented Jun 28, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

ghost commented Jun 28, 2023

Uh oh!

kotlarmilos commented Jun 28, 2023

Uh oh!

azure-pipelinesBot commented Jun 28, 2023

Uh oh!

kotlarmilos commented Jun 29, 2023

Uh oh!

akoeplinger commented Jul 5, 2023

Uh oh!

lambdageek commented Jul 5, 2023

Uh oh!

akoeplinger commented Jul 5, 2023

Uh oh!

kotlarmilos commented Jul 11, 2023

Uh oh!

azure-pipelinesBot commented Jul 11, 2023

Uh oh!

This comment was marked as outdated.

kotlarmilos commented Jul 19, 2023

Uh oh!

azure-pipelinesBot commented Jul 19, 2023

Uh oh!

kotlarmilos commented Dec 19, 2023

Uh oh!

kotlarmilos commented Dec 21, 2023

Uh oh!

Uh oh!

akoeplinger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kotlarmilos commented Jan 16, 2024

Uh oh!

kotlarmilos commented Jan 16, 2024

Uh oh!

akoeplinger commented Jan 16, 2024

Uh oh!

kotlarmilos commented Jan 17, 2024

Uh oh!

kotlarmilos commented Jan 17, 2024

Uh oh!

kotlarmilos commented Jan 23, 2024

Uh oh!

kotlarmilos commented Jan 23, 2024

Uh oh!

kotlarmilos commented Jan 24, 2024

Uh oh!

kotlarmilos commented Jan 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kotlarmilos commented Jun 28, 2023•
edited
Loading