Do not say the wrong default behavior for blittable arrays in ComInterfaceGenerator warning by jtschuster · Pull Request #88212 · dotnet/runtime

jtschuster · 2023-06-29T20:21:52Z

Fixes#88205. The warning used to say the default is [In] for blittable arrays, when the default is [In, Out].

Reworks how Unnecessary / Not supported / supported [In, Out] diagnostic reporting is implemented. Each marshaller will decide which details are provided with the diagnostic and which attributes are unnecessary.

Shares a single Strings.resx with all projects. "Com" or "LibraryImport" suffixes were added to string names that conflicted.

…ngFix

ghost · 2023-06-29T20:22:03Z

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #88205. The warning used to say the default is [In] for blittable arrays, when the default is [In, Out].

Author:	jtschuster
Assignees:	-
Labels:	`area-System.Runtime.InteropServices`
Milestone:	-

diags

…ngFix

…erop.SourceGeneration/Marshalling/ByValueContentsMarshalKindValidator.cs Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>

…kip generation of the wrappers if we have any diagnostics.

…use of "unnecessary" diagostics).

…ningFix

…erop.SourceGeneration/Marshalling/ByValueMarshalKindSupportDescriptor.cs Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>

…erop.SourceGeneration/Marshalling/CustomTypeMarshallingGenerator.cs Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>

…erop.SourceGeneration/Marshalling/DelegateMarshaller.cs Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>

…enerator/Marshallers/ComInterfaceDispatchMarshallerFactory.cs Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>

…erop.SourceGeneration/Marshalling/ByValueMarshalKindSupportDescriptor.cs Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>

…erop.SourceGeneration/Marshalling/ByValueContentsMarshalKindValidator.cs Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>

jkoritzinsky

My only remaining concern is the commented-out test cases in CompileFails.cs. Let's either enable them or open an issue and add that issue link before them (as we can't use [ActiveIssue] for specific test cases).

jtschuster · 2023-07-13T16:15:35Z

Failures are known

jtschusterand others added 6 commits June 15, 2023 16:34

Fully qualify return type on UnreachableException methods
dc6356f

Merge branch 'main' ofhttps://github.com/dotnet/runtime
0cc937e

Merge branch 'main' ofhttps://github.com/dotnet/runtime
a16a7d6

Merge branch 'main' ofhttps://github.com/dotnet/runtime
cca57d3

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto InWarni…
d56e81c
…ngFix

Say correct default for blittable arrays in warning
3ac3f6f

jtschuster requested a review from jkoritzinsky June 29, 2023 20:21

ghost added the area-System.Runtime.InteropServices label Jun 29, 2023

ghost assigned jtschuster Jun 29, 2023

jkoritzinsky reviewed Jun 29, 2023
View reviewed changes

Comment thread...es/gen/Microsoft.Interop.SourceGeneration/Marshalling/ByValueContentsMarshalKindValidator.cs Outdated

build-analysisBot mentioned this pull request Jun 29, 2023
windows-x86 release MSBuild_CMake is failing #88172
Closed

jtschuster added 2 commits July 6, 2023 11:12

wip - SupportsByValueKind returns diag now
e901baa

Use one resources file for all generators and tests, change byvalue attr
2fd1d44
diags

jtschuster requested review from lewing and pavelsavara as code owners July 6, 2023 22:38

jtschuster added 2 commits July 6, 2023 15:45

Fix changes to SR names
e95fd73

[In] is allowed but not necessary
b7f4d21

build-analysisBot mentioned this pull request Jul 7, 2023
LibraryImportGenerator.Unit.Tests crashed in CI #87951
Closed

jtschuster added 6 commits July 7, 2023 12:10

wip
2f135c2

wip about to merge main
5839779

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto InWarni…
5b194d9
…ngFix

Test cases done, filed / prepped issues for problems I hit
7d2ac74

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto InWarni…
797617a
…ngFix

undo unnecessary changes
a698ae2

jkoritzinsky reviewed Jul 11, 2023
View reviewed changes

jtschusterand others added 4 commits July 11, 2023 09:41

Update src/libraries/System.Runtime.InteropServices/gen/Microsoft.Int…
0a84827
…erop.SourceGeneration/Marshalling/ByValueContentsMarshalKindValidator.cs Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>

Don't generate invalid UnmanagedCallersOnly wrappers. Instead, just s…
c48213e
…kip generation of the wrappers if we have any diagnostics.

Only filter on the unmanaged to managed stub diagnostics.
d324406

Only skip on error diagnostics (we don't want to skip generation beca…
d3f00a8
…use of "unnecessary" diagostics).

jtschuster added 3 commits July 11, 2023 12:37

PR Feedback
b4659f1

Merge remote-tracking branch 'jkoritzinsky/no-invalid-uco' into InWar…
53f5249
…ningFix

PR Feedback
91c5b0d

jkoritzinsky reviewed Jul 11, 2023
View reviewed changes

jtschusterand others added 8 commits July 11, 2023 15:13

Update src/libraries/System.Runtime.InteropServices/gen/Microsoft.Int…
8262e7d
…erop.SourceGeneration/Marshalling/ByValueMarshalKindSupportDescriptor.cs Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>

Update src/libraries/System.Runtime.InteropServices/gen/Microsoft.Int…
64725ae
…erop.SourceGeneration/Marshalling/CustomTypeMarshallingGenerator.cs Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>

Update src/libraries/System.Runtime.InteropServices/gen/Microsoft.Int…
789a023
…erop.SourceGeneration/Marshalling/DelegateMarshaller.cs Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>

Update src/libraries/System.Runtime.InteropServices/gen/ComInterfaceG…
acd847e
…enerator/Marshallers/ComInterfaceDispatchMarshallerFactory.cs Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>

Update src/libraries/System.Runtime.InteropServices/gen/Microsoft.Int…
2877315
…erop.SourceGeneration/Marshalling/ByValueMarshalKindSupportDescriptor.cs Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>

Update src/libraries/System.Runtime.InteropServices/gen/Microsoft.Int…
6536dcb
…erop.SourceGeneration/Marshalling/ByValueMarshalKindSupportDescriptor.cs Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>

Update src/libraries/System.Runtime.InteropServices/gen/Microsoft.Int…
7dfed5e
…erop.SourceGeneration/Marshalling/ByValueContentsMarshalKindValidator.cs Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>

Merge ref and value type default by value
41c11ea

jkoritzinsky reviewed Jul 11, 2023
View reviewed changes

Add issue for commented test cases
3ca63bc

jkoritzinsky approved these changes Jul 11, 2023
View reviewed changes

build-analysisBot mentioned this pull request Jul 12, 2023
Intermittent build failure in AfterSourceBuild: "Could not write state file" #76488
Closed

Fix JS generator build
f1f510c

jtschuster merged commit d361507 into dotnet:mainJul 13, 2023

ghost locked as resolved and limited conversation to collaborators Aug 13, 2023

Navigation Menu

Uh oh!

Do not say the wrong default behavior for blittable arrays in ComInterfaceGenerator warning - #88212

Do not say the wrong default behavior for blittable arrays in ComInterfaceGenerator warning#88212
jtschuster merged 33 commits into
dotnet:mainfrom
jtschuster:InWarningFix

jtschuster commented Jun 29, 2023•
edited
Loading

Uh oh!

ghost commented Jun 29, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkoritzinsky left a comment

Uh oh!

jtschuster commented Jul 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jtschuster commented Jun 29, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jun 29, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkoritzinsky left a comment

Choose a reason for hiding this comment

Uh oh!

jtschuster commented Jul 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jtschuster commented Jun 29, 2023•
edited
Loading