[browser] mono_exit improvements by pavelsavara · Pull Request #88387 · dotnet/runtime

pavelsavara · 2023-07-04T16:04:48Z

call mono_wasm_exit from mono_exit
- this will tell mono that shutting_down_inited and then join all mono threads
- after that emscripten will also immediately terminate all WebWorkers
add assert_runtime_running to many entry points
handle onExit
added withAssertAfterExit and assertAfterExit which is default true for shell/node
- we set this in test-main.js
- but it should not assert in Uno
changed mono_assert to abort the program and introduced mono_check alternative which just throws exception.
took over browser-shutdown sample from @kg's PR
replace abort_startup with mono_exit

Alternative to #87043

ghost · 2023-07-04T16:05:02Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

assert_runtime_running
handle onExit
call mono_wasm_exit from mono_exit

Author:	pavelsavara
Assignees:	pavelsavara
Labels:	`arch-wasm`, `os-browser`
Milestone:	8.0.0

pavelsavara · 2023-07-04T20:29:00Z

/azp run runtime-wasm

azure-pipelines · 2023-07-04T20:29:09Z

Azure Pipelines successfully started running 1 pipeline(s).

kg

Looks fine other than comments

pavelsavara · 2023-07-04T20:55:27Z

/azp run runtime-wasm

azure-pipelines · 2023-07-04T20:55:35Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2023-07-10T12:06:44Z

/azp run runtime-wasm

azure-pipelines · 2023-07-13T18:25:16Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2023-07-14T11:14:22Z

/azp run runtime-wasm

azure-pipelines · 2023-07-14T11:14:31Z

Azure Pipelines successfully started running 1 pipeline(s).

# Conflicts: # src/mono/wasm/runtime/http.ts # src/mono/wasm/runtime/web-socket.ts

pavelsavara · 2023-07-14T17:03:22Z

/azp run runtime-wasm

azure-pipelines · 2023-07-14T17:03:31Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2023-07-14T17:58:36Z

/azp run runtime-wasm

azure-pipelines · 2023-07-14T17:58:41Z

No commit pushedDate could be found for PR 88387 in repo dotnet/runtime

pavelsavara · 2023-07-14T17:58:50Z

/azp run runtime-wasm

azure-pipelines · 2023-07-14T17:59:00Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2023-07-14T21:32:27Z

/azp run runtime-wasm

azure-pipelines · 2023-07-14T21:32:33Z

No commit pushedDate could be found for PR 88387 in repo dotnet/runtime

pavelsavara · 2023-07-14T21:32:52Z

/azp run runtime-wasm

azure-pipelines · 2023-07-14T21:33:01Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara added arch-wasm WebAssembly architecture os-browser Browser variant of arch-wasm labels Jul 4, 2023

pavelsavara added this to the 8.0.0 milestone Jul 4, 2023

pavelsavara requested review from lambdageek and maraf July 4, 2023 16:04

pavelsavara self-assigned this Jul 4, 2023

ghost added the area-System.Runtime.InteropServices.JavaScript label Jul 4, 2023

pavelsavara mentioned this pull request Jul 4, 2023
[browser][mt] Release all proxies of C# and JS objects on WebWorker #88052
Merged

pavelsavara marked this pull request as ready for review July 4, 2023 20:28

pavelsavara requested review from kg and lewing as code owners July 4, 2023 20:28

kg reviewed Jul 4, 2023
View reviewed changes

Comment threadsrc/mono/wasm/runtime/invoke-cs.ts Outdated

kg reviewed Jul 4, 2023
View reviewed changes

Comment threadsrc/mono/wasm/runtime/invoke-cs.ts Outdated

kg reviewed Jul 4, 2023
View reviewed changes

Comment threadsrc/mono/wasm/runtime/loader/exit.ts Outdated

kg reviewed Jul 4, 2023
View reviewed changes

Comment threadsrc/mono/wasm/runtime/loader/exit.ts Outdated

kg reviewed Jul 4, 2023
View reviewed changes

Comment threadsrc/mono/wasm/runtime/managed-exports.ts Outdated

kg reviewed Jul 4, 2023
View reviewed changes

Comment threadsrc/mono/wasm/runtime/marshal.ts Outdated

kg approved these changes Jul 4, 2023
View reviewed changes

pavelsavara force-pushed the browser_exit branch from e4ba4ba to 6aa209bCompare July 7, 2023 14:36

This was referenced Jul 7, 2023
Tracking issue for CI build timeouts #76454
Closed
[wasm] Assertion failure in DebuggerTests.HotReloadTests on main - src/mono/mono/component/debugger-engine.c:176#88528
Closed

wip
021af3f

pavelsavara force-pushed the browser_exit branch from 6aa209b to 021af3fCompare July 10, 2023 11:58

wip
362de7d

pavelsavara added 2 commits July 14, 2023 12:22

fix abort
f93a43d

Merge branch 'main' into browser_exit
1818f02

pavelsavara requested a review from radical as a code owner July 14, 2023 10:22

build-analysisBot mentioned this pull request Jul 14, 2023
[browser][nodejs] RequestDuration_CustomTags_Recorded - ENOENT: no such file or directory, open 'http://127.0.0.1:45051/' #88900
Closed

pavelsavara added 3 commits July 14, 2023 16:54

Merge branch 'main' into browser_exit
c5e0c48
# Conflicts: # src/mono/wasm/runtime/http.ts # src/mono/wasm/runtime/web-socket.ts

fixx merge
66bfa87

fix abort + sample
5c0faf0

fix
fbbdfc7

runfoappBot mentioned this pull request Jul 14, 2023
Methodical_others test JIT/Methodical/Coverage/copy_prop_byref_to_native_int crashing #69832
Open

@maraf's feedback about just one exit method
8b43077

build-analysisBot mentioned this pull request Jul 15, 2023
[Test Failure] System.Net.Http.Functional.Tests.HttpClientHandlerTest_Http3.ServerSendsTrailingHeaders_Success #87552
Closed

pavelsavara merged commit 7980421 into dotnet:mainJul 15, 2023

ghost locked as resolved and limited conversation to collaborators Aug 14, 2023

pavelsavara deleted the browser_exit branch September 2, 2024 15:33

Uh oh!

Conversation

pavelsavara commented Jul 4, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jul 4, 2023

Uh oh!

pavelsavara commented Jul 4, 2023

Uh oh!

azure-pipelinesBot commented Jul 4, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kg left a comment

Choose a reason for hiding this comment

Uh oh!

pavelsavara commented Jul 4, 2023

Uh oh!

azure-pipelinesBot commented Jul 4, 2023

Uh oh!

pavelsavara commented Jul 10, 2023

Uh oh!

azure-pipelinesBot commented Jul 13, 2023

Uh oh!

pavelsavara commented Jul 14, 2023

Uh oh!

azure-pipelinesBot commented Jul 14, 2023

Uh oh!

pavelsavara commented Jul 14, 2023

Uh oh!

azure-pipelinesBot commented Jul 14, 2023

Uh oh!

pavelsavara commented Jul 14, 2023

Uh oh!

azure-pipelinesBot commented Jul 14, 2023

Uh oh!

pavelsavara commented Jul 14, 2023

Uh oh!

azure-pipelinesBot commented Jul 14, 2023

Uh oh!

pavelsavara commented Jul 14, 2023

Uh oh!

azure-pipelinesBot commented Jul 14, 2023

Uh oh!

pavelsavara commented Jul 14, 2023

Uh oh!

azure-pipelinesBot commented Jul 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pavelsavara commented Jul 4, 2023•
edited
Loading