Skip to content

Print variable types when dumping the output - #88420

Merged
EgorBo merged 4 commits into
dotnet:mainfrom
MichalPetryka:patch-10
Jul 7, 2023
Merged

Print variable types when dumping the output#88420
EgorBo merged 4 commits into
dotnet:mainfrom
MichalPetryka:patch-10

Conversation

@MichalPetryka

@MichalPetrykaMichalPetryka commented Jul 5, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

This makes reasoning about local types easier.

Would help with checking the diffs for #88163, #88277 and #88006.

@MichalPetryka
Print variable types when dumping the output
6295db1
This makes reasoning about local types easier.
@ghostghost added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member labels Jul 5, 2023
@ghost

ghost commented Jul 5, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This makes reasoning about local types easier.

Author:MichalPetryka
Assignees:-
Labels:

area-CodeGen-coreclr, community-contribution

Milestone:-

@MichalPetryka
MichalPetryka marked this pull request as ready for review July 5, 2023 17:48
@MichalPetryka

MichalPetryka commented Jul 5, 2023

Copy link
Copy Markdown
ContributorAuthor

@MihuBot

@MihuBotMihuBot mentioned this pull request Jul 5, 2023
Open
@MichalPetryka

MichalPetryka commented Jul 5, 2023

Copy link
Copy Markdown
ContributorAuthor

@MihuBot

@MihuBotMihuBot mentioned this pull request Jul 5, 2023
Open
@MichalPetryka

MichalPetryka commented Jul 6, 2023

Copy link
Copy Markdown
ContributorAuthor

@MihuBot

@MihuBotMihuBot mentioned this pull request Jul 6, 2023
Open
@MichalPetryka

MichalPetryka commented Jul 6, 2023

Copy link
Copy Markdown
ContributorAuthor

@EgorBo@jakobbotsch CoreLib jit-diff grew from 210MB to 218MB, some example diffs:

-; V00 this [V00,T00] ( 3, 3 ) ref -> rdi this class-hnd single-def-; V01 arg1 [V01,T01] ( 3, 3 ) ref -> rsi class-hnd single-def+; V00 this [V00,T00] ( 3, 3 ) ref -> rdi this class-hnd single-def <System.Collections.Generic.NonRandomizedStringEqualityComparer+OrdinalComparer>+; V01 arg1 [V01,T01] ( 3, 3 ) ref -> rsi class-hnd single-def <System.Collections.Generic.IEqualityComparer`1[System.String]>
-; V06 tmp1 [V06,T10] ( 3, 0 ) ref -> rbx class-hnd exact single-def "NewObj constructor temp"-;* V07 tmp2 [V07 ] ( 0, 0 ) struct (16) zero-ref "ReadOnlySpan<T> for CreateSpan<T>"+; V06 tmp1 [V06,T10] ( 3, 0 ) ref -> rbx class-hnd exact single-def "NewObj constructor temp" <System.ArgumentException>+;* V07 tmp2 [V07 ] ( 0, 0 ) struct (16) zero-ref "ReadOnlySpan<T> for CreateSpan<T>" <System.ReadOnlySpan`1[int]>
-; V05 tmp1 [V05,T08] ( 3, 6 ) ref -> r13 class-hnd exact single-def "NewObj constructor temp"-; V06 tmp2 [V06,T00] ( 3, 24 ) ref -> [rbp-38H] class-hnd spill-single-def "Inlining Arg"-; V07 tmp3 [V07,T02] ( 2, 16 ) ref -> [rbp-40H] class-hnd exact spill-single-def "Inlining Arg"-; V08 tmp4 [V08,T03] ( 2, 16 ) ref -> rdx class-hnd exact "Inlining Arg"+; V05 tmp1 [V05,T08] ( 3, 6 ) ref -> r13 class-hnd exact single-def "NewObj constructor temp" <System.Collections.Generic.Dictionary`2[System.String,System.Object]>+; V06 tmp2 [V06,T00] ( 3, 24 ) ref -> [rbp-38H] class-hnd spill-single-def "Inlining Arg" <System.Collections.Generic.Dictionary`2[System.String,System.Object]>+; V07 tmp3 [V07,T02] ( 2, 16 ) ref -> [rbp-40H] class-hnd exact spill-single-def "Inlining Arg" <System.String>+; V08 tmp4 [V08,T03] ( 2, 16 ) ref -> rdx class-hnd exact "Inlining Arg" <System.String>
-;* V09 loc8 [V09 ] ( 0, 0 ) simd32 -> zero-ref +;* V09 loc8 [V09 ] ( 0, 0 ) simd32 -> zero-ref <System.Runtime.Intrinsics.Vector256`1[ushort]>
;* V10 loc9 [V10 ] ( 0, 0 ) int -> zero-ref -;* V11 loc10 [V11 ] ( 0, 0 ) simd16 -> zero-ref +;* V11 loc10 [V11 ] ( 0, 0 ) simd16 -> zero-ref <System.Runtime.Intrinsics.Vector128`1[ushort]>
-;* V13 tmp7 [V13 ] ( 0, 0 ) struct (16) zero-ref multireg-arg "spilled call-like call argument"-;* V14 tmp8 [V14 ] ( 0, 0 ) struct (16) zero-ref "Inline return value spill temp"-;* V15 tmp9 [V15 ] ( 0, 0 ) struct (16) zero-ref ld-addr-op "NewObj constructor temp"-;* V16 tmp10 [V16 ] ( 0, 0 ) struct (16) zero-ref ld-addr-op "Inline ldloca(s) first use temp"+;* V13 tmp7 [V13 ] ( 0, 0 ) struct (16) zero-ref multireg-arg "spilled call-like call argument" <System.ReadOnlySpan`1[ushort]>+;* V14 tmp8 [V14 ] ( 0, 0 ) struct (16) zero-ref "Inline return value spill temp" <System.ReadOnlySpan`1[ushort]>+;* V15 tmp9 [V15 ] ( 0, 0 ) struct (16) zero-ref ld-addr-op "NewObj constructor temp" <System.ReadOnlySpan`1[ushort]>+;* V16 tmp10 [V16 ] ( 0, 0 ) struct (16) zero-ref ld-addr-op "Inline ldloca(s) first use temp" <System.ReadOnlySpan`1[ushort]>
-; V04 loc2 [V04,T12] ( 3, 3 ) ref -> r14 class-hnd single-def+; V04 loc2 [V04,T12] ( 3, 3 ) ref -> r14 class-hnd single-def <System.Collections.Generic.IEqualityComparer`1[System.__Canon]>
-; V01 tmp1 [V01 ] ( 1, 1 ) ref -> [rbp-08H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V02 tmp2 [V02 ] ( 1, 1 ) ref -> [rbp-10H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V03 tmp3 [V03 ] ( 1, 1 ) ref -> [rbp-18H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V04 tmp4 [V04 ] ( 1, 1 ) ref -> [rbp-20H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V05 tmp5 [V05 ] ( 1, 1 ) ref -> [rbp-28H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V06 tmp6 [V06 ] ( 1, 1 ) ref -> [rbp-30H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"+; V01 tmp1 [V01 ] ( 1, 1 ) ref -> [rbp-08H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Func`1[System.String]>+; V02 tmp2 [V02 ] ( 1, 1 ) ref -> [rbp-10H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Lazy`1[System.String]>+; V03 tmp3 [V03 ] ( 1, 1 ) ref -> [rbp-18H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Func`1[System.String]>+; V04 tmp4 [V04 ] ( 1, 1 ) ref -> [rbp-20H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Lazy`1[System.String]>+; V05 tmp5 [V05 ] ( 1, 1 ) ref -> [rbp-28H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Collections.Generic.List`1[ushort]>+; V06 tmp6 [V06 ] ( 1, 1 ) ref -> [rbp-30H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Collections.Generic.Dictionary`2[ushort,System.String]>
-;* V02 tmp1 [V02 ] ( 0, 0 ) struct (16) zero-ref do-not-enreg[SF] ld-addr-op "NewObj constructor temp"-; V03 tmp2 [V03,T00] ( 13, 26 ) struct (16) [rbp-20H] do-not-enreg[SFA] multireg-arg "Inlining Arg"-; V04 tmp3 [V04,T02] ( 3, 6 ) ref -> r15 class-hnd exact single-def "NewObj constructor temp"+;* V02 tmp1 [V02 ] ( 0, 0 ) struct (16) zero-ref do-not-enreg[SF] ld-addr-op "NewObj constructor temp" <System.Guid>+; V03 tmp2 [V03,T00] ( 13, 26 ) struct (16) [rbp-20H] do-not-enreg[SFA] multireg-arg "Inlining Arg" <System.Guid>+; V04 tmp3 [V04,T02] ( 3, 6 ) ref -> r15 class-hnd exact single-def "NewObj constructor temp" <System.Diagnostics.Tracing.TraceLoggingEventHandleTable>

@EgorBo
EgorBo merged commit 57608c3 into dotnet:mainJul 7, 2023
@ghostghost locked as resolved and limited conversation to collaborators Aug 7, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@EgorBoEgorBoEgorBo approved these changes

Assignees

No one assigned

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MichalPetryka@EgorBo
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Print variable types when dumping the output by MichalPetryka · Pull Request #88420 · dotnet/runtime · GitHub
Skip to content
Print variable types when dumping the output - #88420
Merged
EgorBo merged 4 commits into
dotnet:mainfrom 
MichalPetryka:patch-10
Jul 7, 2023
Merged
Print variable types when dumping the output#88420
EgorBo merged 4 commits into
dotnet:mainfrom 
MichalPetryka:patch-10
Conversation
@MichalPetryka
@MichalPetrykaMichalPetryka
commented
Jul 5, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This makes reasoning about local types easier.
Would help with checking the diffs for #88163, #88277 and #88006.
@MichalPetryka
Print variable types when dumping the output
6295db1
This makes reasoning about local types easier.
@ghostghost
added

area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
community-contribution
Indicates that the PR has been added by a community member
labels
Jul 5, 2023
@ghost
ghost
commented
Jul 5, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
This makes reasoning about local types easier.
Author:MichalPetryka
Assignees:-
Labels:
area-CodeGen-coreclr, community-contribution
Milestone:-
@MichalPetryka
MichalPetryka
marked this pull request as ready for review
July 5, 2023 17:48
@MichalPetryka
MichalPetryka
commented
Jul 5, 2023

Copy link


Copy Markdown

ContributorAuthor
@MihuBot
@MihuBotMihuBot
mentioned this pull request
Jul 5, 2023

Open

@MichalPetryka
MichalPetryka
commented
Jul 5, 2023

Copy link


Copy Markdown

ContributorAuthor
@MihuBot
@MihuBotMihuBot
mentioned this pull request
Jul 5, 2023

Open

@MichalPetryka
MichalPetryka
commented
Jul 6, 2023

Copy link


Copy Markdown

ContributorAuthor
@MihuBot
@MihuBotMihuBot
mentioned this pull request
Jul 6, 2023

Open

@MichalPetryka
MichalPetryka
commented
Jul 6, 2023

Copy link


Copy Markdown

ContributorAuthor
@EgorBo@jakobbotsch CoreLib jit-diff grew from 210MB to 218MB, some example diffs:
-; V00 this [V00,T00] ( 3, 3 ) ref -> rdi this class-hnd single-def-; V01 arg1 [V01,T01] ( 3, 3 ) ref -> rsi class-hnd single-def+; V00 this [V00,T00] ( 3, 3 ) ref -> rdi this class-hnd single-def <System.Collections.Generic.NonRandomizedStringEqualityComparer+OrdinalComparer>+; V01 arg1 [V01,T01] ( 3, 3 ) ref -> rsi class-hnd single-def <System.Collections.Generic.IEqualityComparer`1[System.String]>
-; V06 tmp1 [V06,T10] ( 3, 0 ) ref -> rbx class-hnd exact single-def "NewObj constructor temp"-;* V07 tmp2 [V07 ] ( 0, 0 ) struct (16) zero-ref "ReadOnlySpan<T> for CreateSpan<T>"+; V06 tmp1 [V06,T10] ( 3, 0 ) ref -> rbx class-hnd exact single-def "NewObj constructor temp" <System.ArgumentException>+;* V07 tmp2 [V07 ] ( 0, 0 ) struct (16) zero-ref "ReadOnlySpan<T> for CreateSpan<T>" <System.ReadOnlySpan`1[int]>
-; V05 tmp1 [V05,T08] ( 3, 6 ) ref -> r13 class-hnd exact single-def "NewObj constructor temp"-; V06 tmp2 [V06,T00] ( 3, 24 ) ref -> [rbp-38H] class-hnd spill-single-def "Inlining Arg"-; V07 tmp3 [V07,T02] ( 2, 16 ) ref -> [rbp-40H] class-hnd exact spill-single-def "Inlining Arg"-; V08 tmp4 [V08,T03] ( 2, 16 ) ref -> rdx class-hnd exact "Inlining Arg"+; V05 tmp1 [V05,T08] ( 3, 6 ) ref -> r13 class-hnd exact single-def "NewObj constructor temp" <System.Collections.Generic.Dictionary`2[System.String,System.Object]>+; V06 tmp2 [V06,T00] ( 3, 24 ) ref -> [rbp-38H] class-hnd spill-single-def "Inlining Arg" <System.Collections.Generic.Dictionary`2[System.String,System.Object]>+; V07 tmp3 [V07,T02] ( 2, 16 ) ref -> [rbp-40H] class-hnd exact spill-single-def "Inlining Arg" <System.String>+; V08 tmp4 [V08,T03] ( 2, 16 ) ref -> rdx class-hnd exact "Inlining Arg" <System.String>
-;* V09 loc8 [V09 ] ( 0, 0 ) simd32 -> zero-ref +;* V09 loc8 [V09 ] ( 0, 0 ) simd32 -> zero-ref <System.Runtime.Intrinsics.Vector256`1[ushort]>
;* V10 loc9 [V10 ] ( 0, 0 ) int -> zero-ref -;* V11 loc10 [V11 ] ( 0, 0 ) simd16 -> zero-ref +;* V11 loc10 [V11 ] ( 0, 0 ) simd16 -> zero-ref <System.Runtime.Intrinsics.Vector128`1[ushort]>
-;* V13 tmp7 [V13 ] ( 0, 0 ) struct (16) zero-ref multireg-arg "spilled call-like call argument"-;* V14 tmp8 [V14 ] ( 0, 0 ) struct (16) zero-ref "Inline return value spill temp"-;* V15 tmp9 [V15 ] ( 0, 0 ) struct (16) zero-ref ld-addr-op "NewObj constructor temp"-;* V16 tmp10 [V16 ] ( 0, 0 ) struct (16) zero-ref ld-addr-op "Inline ldloca(s) first use temp"+;* V13 tmp7 [V13 ] ( 0, 0 ) struct (16) zero-ref multireg-arg "spilled call-like call argument" <System.ReadOnlySpan`1[ushort]>+;* V14 tmp8 [V14 ] ( 0, 0 ) struct (16) zero-ref "Inline return value spill temp" <System.ReadOnlySpan`1[ushort]>+;* V15 tmp9 [V15 ] ( 0, 0 ) struct (16) zero-ref ld-addr-op "NewObj constructor temp" <System.ReadOnlySpan`1[ushort]>+;* V16 tmp10 [V16 ] ( 0, 0 ) struct (16) zero-ref ld-addr-op "Inline ldloca(s) first use temp" <System.ReadOnlySpan`1[ushort]>
-; V04 loc2 [V04,T12] ( 3, 3 ) ref -> r14 class-hnd single-def+; V04 loc2 [V04,T12] ( 3, 3 ) ref -> r14 class-hnd single-def <System.Collections.Generic.IEqualityComparer`1[System.__Canon]>
-; V01 tmp1 [V01 ] ( 1, 1 ) ref -> [rbp-08H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V02 tmp2 [V02 ] ( 1, 1 ) ref -> [rbp-10H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V03 tmp3 [V03 ] ( 1, 1 ) ref -> [rbp-18H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V04 tmp4 [V04 ] ( 1, 1 ) ref -> [rbp-20H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V05 tmp5 [V05 ] ( 1, 1 ) ref -> [rbp-28H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V06 tmp6 [V06 ] ( 1, 1 ) ref -> [rbp-30H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"+; V01 tmp1 [V01 ] ( 1, 1 ) ref -> [rbp-08H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Func`1[System.String]>+; V02 tmp2 [V02 ] ( 1, 1 ) ref -> [rbp-10H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Lazy`1[System.String]>+; V03 tmp3 [V03 ] ( 1, 1 ) ref -> [rbp-18H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Func`1[System.String]>+; V04 tmp4 [V04 ] ( 1, 1 ) ref -> [rbp-20H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Lazy`1[System.String]>+; V05 tmp5 [V05 ] ( 1, 1 ) ref -> [rbp-28H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Collections.Generic.List`1[ushort]>+; V06 tmp6 [V06 ] ( 1, 1 ) ref -> [rbp-30H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Collections.Generic.Dictionary`2[ushort,System.String]>
-;* V02 tmp1 [V02 ] ( 0, 0 ) struct (16) zero-ref do-not-enreg[SF] ld-addr-op "NewObj constructor temp"-; V03 tmp2 [V03,T00] ( 13, 26 ) struct (16) [rbp-20H] do-not-enreg[SFA] multireg-arg "Inlining Arg"-; V04 tmp3 [V04,T02] ( 3, 6 ) ref -> r15 class-hnd exact single-def "NewObj constructor temp"+;* V02 tmp1 [V02 ] ( 0, 0 ) struct (16) zero-ref do-not-enreg[SF] ld-addr-op "NewObj constructor temp" <System.Guid>+; V03 tmp2 [V03,T00] ( 13, 26 ) struct (16) [rbp-20H] do-not-enreg[SFA] multireg-arg "Inlining Arg" <System.Guid>+; V04 tmp3 [V04,T02] ( 3, 6 ) ref -> r15 class-hnd exact single-def "NewObj constructor temp" <System.Diagnostics.Tracing.TraceLoggingEventHandleTable>
@EgorBo
EgorBo
merged commit 57608c3
into
dotnet:mainJul 7, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Aug 7, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@MichalPetryka@EgorBo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Print variable types when dumping the output by MichalPetryka · Pull Request #88420 · dotnet/runtime · GitHub
Skip to content
Print variable types when dumping the output - #88420
Merged
EgorBo merged 4 commits into
dotnet:mainfrom 
MichalPetryka:patch-10
Jul 7, 2023
Merged
Print variable types when dumping the output#88420
EgorBo merged 4 commits into
dotnet:mainfrom 
MichalPetryka:patch-10
Conversation
@MichalPetryka
@MichalPetrykaMichalPetryka
commented
Jul 5, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This makes reasoning about local types easier.
Would help with checking the diffs for #88163, #88277 and #88006.
@MichalPetryka
Print variable types when dumping the output
6295db1
This makes reasoning about local types easier.
@ghostghost
added

area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
community-contribution
Indicates that the PR has been added by a community member
labels
Jul 5, 2023
@ghost
ghost
commented
Jul 5, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
This makes reasoning about local types easier.
Author:MichalPetryka
Assignees:-
Labels:
area-CodeGen-coreclr, community-contribution
Milestone:-
@MichalPetryka
MichalPetryka
marked this pull request as ready for review
July 5, 2023 17:48
@MichalPetryka
MichalPetryka
commented
Jul 5, 2023

Copy link


Copy Markdown

ContributorAuthor
@MihuBot
@MihuBotMihuBot
mentioned this pull request
Jul 5, 2023

Open

@MichalPetryka
MichalPetryka
commented
Jul 5, 2023

Copy link


Copy Markdown

ContributorAuthor
@MihuBot
@MihuBotMihuBot
mentioned this pull request
Jul 5, 2023

Open

@MichalPetryka
MichalPetryka
commented
Jul 6, 2023

Copy link


Copy Markdown

ContributorAuthor
@MihuBot
@MihuBotMihuBot
mentioned this pull request
Jul 6, 2023

Open

@MichalPetryka
MichalPetryka
commented
Jul 6, 2023

Copy link


Copy Markdown

ContributorAuthor
@EgorBo@jakobbotsch CoreLib jit-diff grew from 210MB to 218MB, some example diffs:
-; V00 this [V00,T00] ( 3, 3 ) ref -> rdi this class-hnd single-def-; V01 arg1 [V01,T01] ( 3, 3 ) ref -> rsi class-hnd single-def+; V00 this [V00,T00] ( 3, 3 ) ref -> rdi this class-hnd single-def <System.Collections.Generic.NonRandomizedStringEqualityComparer+OrdinalComparer>+; V01 arg1 [V01,T01] ( 3, 3 ) ref -> rsi class-hnd single-def <System.Collections.Generic.IEqualityComparer`1[System.String]>
-; V06 tmp1 [V06,T10] ( 3, 0 ) ref -> rbx class-hnd exact single-def "NewObj constructor temp"-;* V07 tmp2 [V07 ] ( 0, 0 ) struct (16) zero-ref "ReadOnlySpan<T> for CreateSpan<T>"+; V06 tmp1 [V06,T10] ( 3, 0 ) ref -> rbx class-hnd exact single-def "NewObj constructor temp" <System.ArgumentException>+;* V07 tmp2 [V07 ] ( 0, 0 ) struct (16) zero-ref "ReadOnlySpan<T> for CreateSpan<T>" <System.ReadOnlySpan`1[int]>
-; V05 tmp1 [V05,T08] ( 3, 6 ) ref -> r13 class-hnd exact single-def "NewObj constructor temp"-; V06 tmp2 [V06,T00] ( 3, 24 ) ref -> [rbp-38H] class-hnd spill-single-def "Inlining Arg"-; V07 tmp3 [V07,T02] ( 2, 16 ) ref -> [rbp-40H] class-hnd exact spill-single-def "Inlining Arg"-; V08 tmp4 [V08,T03] ( 2, 16 ) ref -> rdx class-hnd exact "Inlining Arg"+; V05 tmp1 [V05,T08] ( 3, 6 ) ref -> r13 class-hnd exact single-def "NewObj constructor temp" <System.Collections.Generic.Dictionary`2[System.String,System.Object]>+; V06 tmp2 [V06,T00] ( 3, 24 ) ref -> [rbp-38H] class-hnd spill-single-def "Inlining Arg" <System.Collections.Generic.Dictionary`2[System.String,System.Object]>+; V07 tmp3 [V07,T02] ( 2, 16 ) ref -> [rbp-40H] class-hnd exact spill-single-def "Inlining Arg" <System.String>+; V08 tmp4 [V08,T03] ( 2, 16 ) ref -> rdx class-hnd exact "Inlining Arg" <System.String>
-;* V09 loc8 [V09 ] ( 0, 0 ) simd32 -> zero-ref +;* V09 loc8 [V09 ] ( 0, 0 ) simd32 -> zero-ref <System.Runtime.Intrinsics.Vector256`1[ushort]>
;* V10 loc9 [V10 ] ( 0, 0 ) int -> zero-ref -;* V11 loc10 [V11 ] ( 0, 0 ) simd16 -> zero-ref +;* V11 loc10 [V11 ] ( 0, 0 ) simd16 -> zero-ref <System.Runtime.Intrinsics.Vector128`1[ushort]>
-;* V13 tmp7 [V13 ] ( 0, 0 ) struct (16) zero-ref multireg-arg "spilled call-like call argument"-;* V14 tmp8 [V14 ] ( 0, 0 ) struct (16) zero-ref "Inline return value spill temp"-;* V15 tmp9 [V15 ] ( 0, 0 ) struct (16) zero-ref ld-addr-op "NewObj constructor temp"-;* V16 tmp10 [V16 ] ( 0, 0 ) struct (16) zero-ref ld-addr-op "Inline ldloca(s) first use temp"+;* V13 tmp7 [V13 ] ( 0, 0 ) struct (16) zero-ref multireg-arg "spilled call-like call argument" <System.ReadOnlySpan`1[ushort]>+;* V14 tmp8 [V14 ] ( 0, 0 ) struct (16) zero-ref "Inline return value spill temp" <System.ReadOnlySpan`1[ushort]>+;* V15 tmp9 [V15 ] ( 0, 0 ) struct (16) zero-ref ld-addr-op "NewObj constructor temp" <System.ReadOnlySpan`1[ushort]>+;* V16 tmp10 [V16 ] ( 0, 0 ) struct (16) zero-ref ld-addr-op "Inline ldloca(s) first use temp" <System.ReadOnlySpan`1[ushort]>
-; V04 loc2 [V04,T12] ( 3, 3 ) ref -> r14 class-hnd single-def+; V04 loc2 [V04,T12] ( 3, 3 ) ref -> r14 class-hnd single-def <System.Collections.Generic.IEqualityComparer`1[System.__Canon]>
-; V01 tmp1 [V01 ] ( 1, 1 ) ref -> [rbp-08H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V02 tmp2 [V02 ] ( 1, 1 ) ref -> [rbp-10H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V03 tmp3 [V03 ] ( 1, 1 ) ref -> [rbp-18H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V04 tmp4 [V04 ] ( 1, 1 ) ref -> [rbp-20H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V05 tmp5 [V05 ] ( 1, 1 ) ref -> [rbp-28H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V06 tmp6 [V06 ] ( 1, 1 ) ref -> [rbp-30H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"+; V01 tmp1 [V01 ] ( 1, 1 ) ref -> [rbp-08H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Func`1[System.String]>+; V02 tmp2 [V02 ] ( 1, 1 ) ref -> [rbp-10H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Lazy`1[System.String]>+; V03 tmp3 [V03 ] ( 1, 1 ) ref -> [rbp-18H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Func`1[System.String]>+; V04 tmp4 [V04 ] ( 1, 1 ) ref -> [rbp-20H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Lazy`1[System.String]>+; V05 tmp5 [V05 ] ( 1, 1 ) ref -> [rbp-28H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Collections.Generic.List`1[ushort]>+; V06 tmp6 [V06 ] ( 1, 1 ) ref -> [rbp-30H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Collections.Generic.Dictionary`2[ushort,System.String]>
-;* V02 tmp1 [V02 ] ( 0, 0 ) struct (16) zero-ref do-not-enreg[SF] ld-addr-op "NewObj constructor temp"-; V03 tmp2 [V03,T00] ( 13, 26 ) struct (16) [rbp-20H] do-not-enreg[SFA] multireg-arg "Inlining Arg"-; V04 tmp3 [V04,T02] ( 3, 6 ) ref -> r15 class-hnd exact single-def "NewObj constructor temp"+;* V02 tmp1 [V02 ] ( 0, 0 ) struct (16) zero-ref do-not-enreg[SF] ld-addr-op "NewObj constructor temp" <System.Guid>+; V03 tmp2 [V03,T00] ( 13, 26 ) struct (16) [rbp-20H] do-not-enreg[SFA] multireg-arg "Inlining Arg" <System.Guid>+; V04 tmp3 [V04,T02] ( 3, 6 ) ref -> r15 class-hnd exact single-def "NewObj constructor temp" <System.Diagnostics.Tracing.TraceLoggingEventHandleTable>
@EgorBo
EgorBo
merged commit 57608c3
into
dotnet:mainJul 7, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Aug 7, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@MichalPetryka@EgorBo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Print variable types when dumping the output by MichalPetryka · Pull Request #88420 · dotnet/runtime · GitHub
Skip to content
Print variable types when dumping the output - #88420
Merged
EgorBo merged 4 commits into
dotnet:mainfrom 
MichalPetryka:patch-10
Jul 7, 2023
Merged
Print variable types when dumping the output#88420
EgorBo merged 4 commits into
dotnet:mainfrom 
MichalPetryka:patch-10
Conversation
@MichalPetryka
@MichalPetrykaMichalPetryka
commented
Jul 5, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This makes reasoning about local types easier.
Would help with checking the diffs for #88163, #88277 and #88006.
@MichalPetryka
Print variable types when dumping the output
6295db1
This makes reasoning about local types easier.
@ghostghost
added

area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
community-contribution
Indicates that the PR has been added by a community member
labels
Jul 5, 2023
@ghost
ghost
commented
Jul 5, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
This makes reasoning about local types easier.
Author:MichalPetryka
Assignees:-
Labels:
area-CodeGen-coreclr, community-contribution
Milestone:-
@MichalPetryka
MichalPetryka
marked this pull request as ready for review
July 5, 2023 17:48
@MichalPetryka
MichalPetryka
commented
Jul 5, 2023

Copy link


Copy Markdown

ContributorAuthor
@MihuBot
@MihuBotMihuBot
mentioned this pull request
Jul 5, 2023

Open

@MichalPetryka
MichalPetryka
commented
Jul 5, 2023

Copy link


Copy Markdown

ContributorAuthor
@MihuBot
@MihuBotMihuBot
mentioned this pull request
Jul 5, 2023

Open

@MichalPetryka
MichalPetryka
commented
Jul 6, 2023

Copy link


Copy Markdown

ContributorAuthor
@MihuBot
@MihuBotMihuBot
mentioned this pull request
Jul 6, 2023

Open

@MichalPetryka
MichalPetryka
commented
Jul 6, 2023

Copy link


Copy Markdown

ContributorAuthor
@EgorBo@jakobbotsch CoreLib jit-diff grew from 210MB to 218MB, some example diffs:
-; V00 this [V00,T00] ( 3, 3 ) ref -> rdi this class-hnd single-def-; V01 arg1 [V01,T01] ( 3, 3 ) ref -> rsi class-hnd single-def+; V00 this [V00,T00] ( 3, 3 ) ref -> rdi this class-hnd single-def <System.Collections.Generic.NonRandomizedStringEqualityComparer+OrdinalComparer>+; V01 arg1 [V01,T01] ( 3, 3 ) ref -> rsi class-hnd single-def <System.Collections.Generic.IEqualityComparer`1[System.String]>
-; V06 tmp1 [V06,T10] ( 3, 0 ) ref -> rbx class-hnd exact single-def "NewObj constructor temp"-;* V07 tmp2 [V07 ] ( 0, 0 ) struct (16) zero-ref "ReadOnlySpan<T> for CreateSpan<T>"+; V06 tmp1 [V06,T10] ( 3, 0 ) ref -> rbx class-hnd exact single-def "NewObj constructor temp" <System.ArgumentException>+;* V07 tmp2 [V07 ] ( 0, 0 ) struct (16) zero-ref "ReadOnlySpan<T> for CreateSpan<T>" <System.ReadOnlySpan`1[int]>
-; V05 tmp1 [V05,T08] ( 3, 6 ) ref -> r13 class-hnd exact single-def "NewObj constructor temp"-; V06 tmp2 [V06,T00] ( 3, 24 ) ref -> [rbp-38H] class-hnd spill-single-def "Inlining Arg"-; V07 tmp3 [V07,T02] ( 2, 16 ) ref -> [rbp-40H] class-hnd exact spill-single-def "Inlining Arg"-; V08 tmp4 [V08,T03] ( 2, 16 ) ref -> rdx class-hnd exact "Inlining Arg"+; V05 tmp1 [V05,T08] ( 3, 6 ) ref -> r13 class-hnd exact single-def "NewObj constructor temp" <System.Collections.Generic.Dictionary`2[System.String,System.Object]>+; V06 tmp2 [V06,T00] ( 3, 24 ) ref -> [rbp-38H] class-hnd spill-single-def "Inlining Arg" <System.Collections.Generic.Dictionary`2[System.String,System.Object]>+; V07 tmp3 [V07,T02] ( 2, 16 ) ref -> [rbp-40H] class-hnd exact spill-single-def "Inlining Arg" <System.String>+; V08 tmp4 [V08,T03] ( 2, 16 ) ref -> rdx class-hnd exact "Inlining Arg" <System.String>
-;* V09 loc8 [V09 ] ( 0, 0 ) simd32 -> zero-ref +;* V09 loc8 [V09 ] ( 0, 0 ) simd32 -> zero-ref <System.Runtime.Intrinsics.Vector256`1[ushort]>
;* V10 loc9 [V10 ] ( 0, 0 ) int -> zero-ref -;* V11 loc10 [V11 ] ( 0, 0 ) simd16 -> zero-ref +;* V11 loc10 [V11 ] ( 0, 0 ) simd16 -> zero-ref <System.Runtime.Intrinsics.Vector128`1[ushort]>
-;* V13 tmp7 [V13 ] ( 0, 0 ) struct (16) zero-ref multireg-arg "spilled call-like call argument"-;* V14 tmp8 [V14 ] ( 0, 0 ) struct (16) zero-ref "Inline return value spill temp"-;* V15 tmp9 [V15 ] ( 0, 0 ) struct (16) zero-ref ld-addr-op "NewObj constructor temp"-;* V16 tmp10 [V16 ] ( 0, 0 ) struct (16) zero-ref ld-addr-op "Inline ldloca(s) first use temp"+;* V13 tmp7 [V13 ] ( 0, 0 ) struct (16) zero-ref multireg-arg "spilled call-like call argument" <System.ReadOnlySpan`1[ushort]>+;* V14 tmp8 [V14 ] ( 0, 0 ) struct (16) zero-ref "Inline return value spill temp" <System.ReadOnlySpan`1[ushort]>+;* V15 tmp9 [V15 ] ( 0, 0 ) struct (16) zero-ref ld-addr-op "NewObj constructor temp" <System.ReadOnlySpan`1[ushort]>+;* V16 tmp10 [V16 ] ( 0, 0 ) struct (16) zero-ref ld-addr-op "Inline ldloca(s) first use temp" <System.ReadOnlySpan`1[ushort]>
-; V04 loc2 [V04,T12] ( 3, 3 ) ref -> r14 class-hnd single-def+; V04 loc2 [V04,T12] ( 3, 3 ) ref -> r14 class-hnd single-def <System.Collections.Generic.IEqualityComparer`1[System.__Canon]>
-; V01 tmp1 [V01 ] ( 1, 1 ) ref -> [rbp-08H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V02 tmp2 [V02 ] ( 1, 1 ) ref -> [rbp-10H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V03 tmp3 [V03 ] ( 1, 1 ) ref -> [rbp-18H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V04 tmp4 [V04 ] ( 1, 1 ) ref -> [rbp-20H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V05 tmp5 [V05 ] ( 1, 1 ) ref -> [rbp-28H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V06 tmp6 [V06 ] ( 1, 1 ) ref -> [rbp-30H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"+; V01 tmp1 [V01 ] ( 1, 1 ) ref -> [rbp-08H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Func`1[System.String]>+; V02 tmp2 [V02 ] ( 1, 1 ) ref -> [rbp-10H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Lazy`1[System.String]>+; V03 tmp3 [V03 ] ( 1, 1 ) ref -> [rbp-18H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Func`1[System.String]>+; V04 tmp4 [V04 ] ( 1, 1 ) ref -> [rbp-20H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Lazy`1[System.String]>+; V05 tmp5 [V05 ] ( 1, 1 ) ref -> [rbp-28H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Collections.Generic.List`1[ushort]>+; V06 tmp6 [V06 ] ( 1, 1 ) ref -> [rbp-30H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Collections.Generic.Dictionary`2[ushort,System.String]>
-;* V02 tmp1 [V02 ] ( 0, 0 ) struct (16) zero-ref do-not-enreg[SF] ld-addr-op "NewObj constructor temp"-; V03 tmp2 [V03,T00] ( 13, 26 ) struct (16) [rbp-20H] do-not-enreg[SFA] multireg-arg "Inlining Arg"-; V04 tmp3 [V04,T02] ( 3, 6 ) ref -> r15 class-hnd exact single-def "NewObj constructor temp"+;* V02 tmp1 [V02 ] ( 0, 0 ) struct (16) zero-ref do-not-enreg[SF] ld-addr-op "NewObj constructor temp" <System.Guid>+; V03 tmp2 [V03,T00] ( 13, 26 ) struct (16) [rbp-20H] do-not-enreg[SFA] multireg-arg "Inlining Arg" <System.Guid>+; V04 tmp3 [V04,T02] ( 3, 6 ) ref -> r15 class-hnd exact single-def "NewObj constructor temp" <System.Diagnostics.Tracing.TraceLoggingEventHandleTable>
@EgorBo
EgorBo
merged commit 57608c3
into
dotnet:mainJul 7, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Aug 7, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@MichalPetryka@EgorBo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Print variable types when dumping the output by MichalPetryka · Pull Request #88420 · dotnet/runtime · GitHub
Skip to content
Print variable types when dumping the output - #88420
Merged
EgorBo merged 4 commits into
dotnet:mainfrom 
MichalPetryka:patch-10
Jul 7, 2023
Merged
Print variable types when dumping the output#88420
EgorBo merged 4 commits into
dotnet:mainfrom 
MichalPetryka:patch-10
Conversation
@MichalPetryka
@MichalPetrykaMichalPetryka
commented
Jul 5, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This makes reasoning about local types easier.
Would help with checking the diffs for #88163, #88277 and #88006.
@MichalPetryka
Print variable types when dumping the output
6295db1
This makes reasoning about local types easier.
@ghostghost
added

area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
community-contribution
Indicates that the PR has been added by a community member
labels
Jul 5, 2023
@ghost
ghost
commented
Jul 5, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
This makes reasoning about local types easier.
Author:MichalPetryka
Assignees:-
Labels:
area-CodeGen-coreclr, community-contribution
Milestone:-
@MichalPetryka
MichalPetryka
marked this pull request as ready for review
July 5, 2023 17:48
@MichalPetryka
MichalPetryka
commented
Jul 5, 2023

Copy link


Copy Markdown

ContributorAuthor
@MihuBot
@MihuBotMihuBot
mentioned this pull request
Jul 5, 2023

Open

@MichalPetryka
MichalPetryka
commented
Jul 5, 2023

Copy link


Copy Markdown

ContributorAuthor
@MihuBot
@MihuBotMihuBot
mentioned this pull request
Jul 5, 2023

Open

@MichalPetryka
MichalPetryka
commented
Jul 6, 2023

Copy link


Copy Markdown

ContributorAuthor
@MihuBot
@MihuBotMihuBot
mentioned this pull request
Jul 6, 2023

Open

@MichalPetryka
MichalPetryka
commented
Jul 6, 2023

Copy link


Copy Markdown

ContributorAuthor
@EgorBo@jakobbotsch CoreLib jit-diff grew from 210MB to 218MB, some example diffs:
-; V00 this [V00,T00] ( 3, 3 ) ref -> rdi this class-hnd single-def-; V01 arg1 [V01,T01] ( 3, 3 ) ref -> rsi class-hnd single-def+; V00 this [V00,T00] ( 3, 3 ) ref -> rdi this class-hnd single-def <System.Collections.Generic.NonRandomizedStringEqualityComparer+OrdinalComparer>+; V01 arg1 [V01,T01] ( 3, 3 ) ref -> rsi class-hnd single-def <System.Collections.Generic.IEqualityComparer`1[System.String]>
-; V06 tmp1 [V06,T10] ( 3, 0 ) ref -> rbx class-hnd exact single-def "NewObj constructor temp"-;* V07 tmp2 [V07 ] ( 0, 0 ) struct (16) zero-ref "ReadOnlySpan<T> for CreateSpan<T>"+; V06 tmp1 [V06,T10] ( 3, 0 ) ref -> rbx class-hnd exact single-def "NewObj constructor temp" <System.ArgumentException>+;* V07 tmp2 [V07 ] ( 0, 0 ) struct (16) zero-ref "ReadOnlySpan<T> for CreateSpan<T>" <System.ReadOnlySpan`1[int]>
-; V05 tmp1 [V05,T08] ( 3, 6 ) ref -> r13 class-hnd exact single-def "NewObj constructor temp"-; V06 tmp2 [V06,T00] ( 3, 24 ) ref -> [rbp-38H] class-hnd spill-single-def "Inlining Arg"-; V07 tmp3 [V07,T02] ( 2, 16 ) ref -> [rbp-40H] class-hnd exact spill-single-def "Inlining Arg"-; V08 tmp4 [V08,T03] ( 2, 16 ) ref -> rdx class-hnd exact "Inlining Arg"+; V05 tmp1 [V05,T08] ( 3, 6 ) ref -> r13 class-hnd exact single-def "NewObj constructor temp" <System.Collections.Generic.Dictionary`2[System.String,System.Object]>+; V06 tmp2 [V06,T00] ( 3, 24 ) ref -> [rbp-38H] class-hnd spill-single-def "Inlining Arg" <System.Collections.Generic.Dictionary`2[System.String,System.Object]>+; V07 tmp3 [V07,T02] ( 2, 16 ) ref -> [rbp-40H] class-hnd exact spill-single-def "Inlining Arg" <System.String>+; V08 tmp4 [V08,T03] ( 2, 16 ) ref -> rdx class-hnd exact "Inlining Arg" <System.String>
-;* V09 loc8 [V09 ] ( 0, 0 ) simd32 -> zero-ref +;* V09 loc8 [V09 ] ( 0, 0 ) simd32 -> zero-ref <System.Runtime.Intrinsics.Vector256`1[ushort]>
;* V10 loc9 [V10 ] ( 0, 0 ) int -> zero-ref -;* V11 loc10 [V11 ] ( 0, 0 ) simd16 -> zero-ref +;* V11 loc10 [V11 ] ( 0, 0 ) simd16 -> zero-ref <System.Runtime.Intrinsics.Vector128`1[ushort]>
-;* V13 tmp7 [V13 ] ( 0, 0 ) struct (16) zero-ref multireg-arg "spilled call-like call argument"-;* V14 tmp8 [V14 ] ( 0, 0 ) struct (16) zero-ref "Inline return value spill temp"-;* V15 tmp9 [V15 ] ( 0, 0 ) struct (16) zero-ref ld-addr-op "NewObj constructor temp"-;* V16 tmp10 [V16 ] ( 0, 0 ) struct (16) zero-ref ld-addr-op "Inline ldloca(s) first use temp"+;* V13 tmp7 [V13 ] ( 0, 0 ) struct (16) zero-ref multireg-arg "spilled call-like call argument" <System.ReadOnlySpan`1[ushort]>+;* V14 tmp8 [V14 ] ( 0, 0 ) struct (16) zero-ref "Inline return value spill temp" <System.ReadOnlySpan`1[ushort]>+;* V15 tmp9 [V15 ] ( 0, 0 ) struct (16) zero-ref ld-addr-op "NewObj constructor temp" <System.ReadOnlySpan`1[ushort]>+;* V16 tmp10 [V16 ] ( 0, 0 ) struct (16) zero-ref ld-addr-op "Inline ldloca(s) first use temp" <System.ReadOnlySpan`1[ushort]>
-; V04 loc2 [V04,T12] ( 3, 3 ) ref -> r14 class-hnd single-def+; V04 loc2 [V04,T12] ( 3, 3 ) ref -> r14 class-hnd single-def <System.Collections.Generic.IEqualityComparer`1[System.__Canon]>
-; V01 tmp1 [V01 ] ( 1, 1 ) ref -> [rbp-08H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V02 tmp2 [V02 ] ( 1, 1 ) ref -> [rbp-10H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V03 tmp3 [V03 ] ( 1, 1 ) ref -> [rbp-18H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V04 tmp4 [V04 ] ( 1, 1 ) ref -> [rbp-20H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V05 tmp5 [V05 ] ( 1, 1 ) ref -> [rbp-28H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V06 tmp6 [V06 ] ( 1, 1 ) ref -> [rbp-30H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"+; V01 tmp1 [V01 ] ( 1, 1 ) ref -> [rbp-08H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Func`1[System.String]>+; V02 tmp2 [V02 ] ( 1, 1 ) ref -> [rbp-10H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Lazy`1[System.String]>+; V03 tmp3 [V03 ] ( 1, 1 ) ref -> [rbp-18H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Func`1[System.String]>+; V04 tmp4 [V04 ] ( 1, 1 ) ref -> [rbp-20H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Lazy`1[System.String]>+; V05 tmp5 [V05 ] ( 1, 1 ) ref -> [rbp-28H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Collections.Generic.List`1[ushort]>+; V06 tmp6 [V06 ] ( 1, 1 ) ref -> [rbp-30H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Collections.Generic.Dictionary`2[ushort,System.String]>
-;* V02 tmp1 [V02 ] ( 0, 0 ) struct (16) zero-ref do-not-enreg[SF] ld-addr-op "NewObj constructor temp"-; V03 tmp2 [V03,T00] ( 13, 26 ) struct (16) [rbp-20H] do-not-enreg[SFA] multireg-arg "Inlining Arg"-; V04 tmp3 [V04,T02] ( 3, 6 ) ref -> r15 class-hnd exact single-def "NewObj constructor temp"+;* V02 tmp1 [V02 ] ( 0, 0 ) struct (16) zero-ref do-not-enreg[SF] ld-addr-op "NewObj constructor temp" <System.Guid>+; V03 tmp2 [V03,T00] ( 13, 26 ) struct (16) [rbp-20H] do-not-enreg[SFA] multireg-arg "Inlining Arg" <System.Guid>+; V04 tmp3 [V04,T02] ( 3, 6 ) ref -> r15 class-hnd exact single-def "NewObj constructor temp" <System.Diagnostics.Tracing.TraceLoggingEventHandleTable>
@EgorBo
EgorBo
merged commit 57608c3
into
dotnet:mainJul 7, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Aug 7, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@MichalPetryka@EgorBo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Print variable types when dumping the output by MichalPetryka · Pull Request #88420 · dotnet/runtime · GitHub
Skip to content
Print variable types when dumping the output - #88420
Merged
EgorBo merged 4 commits into
dotnet:mainfrom 
MichalPetryka:patch-10
Jul 7, 2023
Merged
Print variable types when dumping the output#88420
EgorBo merged 4 commits into
dotnet:mainfrom 
MichalPetryka:patch-10
Conversation
@MichalPetryka
@MichalPetrykaMichalPetryka
commented
Jul 5, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This makes reasoning about local types easier.
Would help with checking the diffs for #88163, #88277 and #88006.
@MichalPetryka
Print variable types when dumping the output
6295db1
This makes reasoning about local types easier.
@ghostghost
added

area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
community-contribution
Indicates that the PR has been added by a community member
labels
Jul 5, 2023
@ghost
ghost
commented
Jul 5, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
This makes reasoning about local types easier.
Author:MichalPetryka
Assignees:-
Labels:
area-CodeGen-coreclr, community-contribution
Milestone:-
@MichalPetryka
MichalPetryka
marked this pull request as ready for review
July 5, 2023 17:48
@MichalPetryka
MichalPetryka
commented
Jul 5, 2023

Copy link


Copy Markdown

ContributorAuthor
@MihuBot
@MihuBotMihuBot
mentioned this pull request
Jul 5, 2023

Open

@MichalPetryka
MichalPetryka
commented
Jul 5, 2023

Copy link


Copy Markdown

ContributorAuthor
@MihuBot
@MihuBotMihuBot
mentioned this pull request
Jul 5, 2023

Open

@MichalPetryka
MichalPetryka
commented
Jul 6, 2023

Copy link


Copy Markdown

ContributorAuthor
@MihuBot
@MihuBotMihuBot
mentioned this pull request
Jul 6, 2023

Open

@MichalPetryka
MichalPetryka
commented
Jul 6, 2023

Copy link


Copy Markdown

ContributorAuthor
@EgorBo@jakobbotsch CoreLib jit-diff grew from 210MB to 218MB, some example diffs:
-; V00 this [V00,T00] ( 3, 3 ) ref -> rdi this class-hnd single-def-; V01 arg1 [V01,T01] ( 3, 3 ) ref -> rsi class-hnd single-def+; V00 this [V00,T00] ( 3, 3 ) ref -> rdi this class-hnd single-def <System.Collections.Generic.NonRandomizedStringEqualityComparer+OrdinalComparer>+; V01 arg1 [V01,T01] ( 3, 3 ) ref -> rsi class-hnd single-def <System.Collections.Generic.IEqualityComparer`1[System.String]>
-; V06 tmp1 [V06,T10] ( 3, 0 ) ref -> rbx class-hnd exact single-def "NewObj constructor temp"-;* V07 tmp2 [V07 ] ( 0, 0 ) struct (16) zero-ref "ReadOnlySpan<T> for CreateSpan<T>"+; V06 tmp1 [V06,T10] ( 3, 0 ) ref -> rbx class-hnd exact single-def "NewObj constructor temp" <System.ArgumentException>+;* V07 tmp2 [V07 ] ( 0, 0 ) struct (16) zero-ref "ReadOnlySpan<T> for CreateSpan<T>" <System.ReadOnlySpan`1[int]>
-; V05 tmp1 [V05,T08] ( 3, 6 ) ref -> r13 class-hnd exact single-def "NewObj constructor temp"-; V06 tmp2 [V06,T00] ( 3, 24 ) ref -> [rbp-38H] class-hnd spill-single-def "Inlining Arg"-; V07 tmp3 [V07,T02] ( 2, 16 ) ref -> [rbp-40H] class-hnd exact spill-single-def "Inlining Arg"-; V08 tmp4 [V08,T03] ( 2, 16 ) ref -> rdx class-hnd exact "Inlining Arg"+; V05 tmp1 [V05,T08] ( 3, 6 ) ref -> r13 class-hnd exact single-def "NewObj constructor temp" <System.Collections.Generic.Dictionary`2[System.String,System.Object]>+; V06 tmp2 [V06,T00] ( 3, 24 ) ref -> [rbp-38H] class-hnd spill-single-def "Inlining Arg" <System.Collections.Generic.Dictionary`2[System.String,System.Object]>+; V07 tmp3 [V07,T02] ( 2, 16 ) ref -> [rbp-40H] class-hnd exact spill-single-def "Inlining Arg" <System.String>+; V08 tmp4 [V08,T03] ( 2, 16 ) ref -> rdx class-hnd exact "Inlining Arg" <System.String>
-;* V09 loc8 [V09 ] ( 0, 0 ) simd32 -> zero-ref +;* V09 loc8 [V09 ] ( 0, 0 ) simd32 -> zero-ref <System.Runtime.Intrinsics.Vector256`1[ushort]>
;* V10 loc9 [V10 ] ( 0, 0 ) int -> zero-ref -;* V11 loc10 [V11 ] ( 0, 0 ) simd16 -> zero-ref +;* V11 loc10 [V11 ] ( 0, 0 ) simd16 -> zero-ref <System.Runtime.Intrinsics.Vector128`1[ushort]>
-;* V13 tmp7 [V13 ] ( 0, 0 ) struct (16) zero-ref multireg-arg "spilled call-like call argument"-;* V14 tmp8 [V14 ] ( 0, 0 ) struct (16) zero-ref "Inline return value spill temp"-;* V15 tmp9 [V15 ] ( 0, 0 ) struct (16) zero-ref ld-addr-op "NewObj constructor temp"-;* V16 tmp10 [V16 ] ( 0, 0 ) struct (16) zero-ref ld-addr-op "Inline ldloca(s) first use temp"+;* V13 tmp7 [V13 ] ( 0, 0 ) struct (16) zero-ref multireg-arg "spilled call-like call argument" <System.ReadOnlySpan`1[ushort]>+;* V14 tmp8 [V14 ] ( 0, 0 ) struct (16) zero-ref "Inline return value spill temp" <System.ReadOnlySpan`1[ushort]>+;* V15 tmp9 [V15 ] ( 0, 0 ) struct (16) zero-ref ld-addr-op "NewObj constructor temp" <System.ReadOnlySpan`1[ushort]>+;* V16 tmp10 [V16 ] ( 0, 0 ) struct (16) zero-ref ld-addr-op "Inline ldloca(s) first use temp" <System.ReadOnlySpan`1[ushort]>
-; V04 loc2 [V04,T12] ( 3, 3 ) ref -> r14 class-hnd single-def+; V04 loc2 [V04,T12] ( 3, 3 ) ref -> r14 class-hnd single-def <System.Collections.Generic.IEqualityComparer`1[System.__Canon]>
-; V01 tmp1 [V01 ] ( 1, 1 ) ref -> [rbp-08H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V02 tmp2 [V02 ] ( 1, 1 ) ref -> [rbp-10H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V03 tmp3 [V03 ] ( 1, 1 ) ref -> [rbp-18H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V04 tmp4 [V04 ] ( 1, 1 ) ref -> [rbp-20H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V05 tmp5 [V05 ] ( 1, 1 ) ref -> [rbp-28H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V06 tmp6 [V06 ] ( 1, 1 ) ref -> [rbp-30H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"+; V01 tmp1 [V01 ] ( 1, 1 ) ref -> [rbp-08H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Func`1[System.String]>+; V02 tmp2 [V02 ] ( 1, 1 ) ref -> [rbp-10H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Lazy`1[System.String]>+; V03 tmp3 [V03 ] ( 1, 1 ) ref -> [rbp-18H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Func`1[System.String]>+; V04 tmp4 [V04 ] ( 1, 1 ) ref -> [rbp-20H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Lazy`1[System.String]>+; V05 tmp5 [V05 ] ( 1, 1 ) ref -> [rbp-28H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Collections.Generic.List`1[ushort]>+; V06 tmp6 [V06 ] ( 1, 1 ) ref -> [rbp-30H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Collections.Generic.Dictionary`2[ushort,System.String]>
-;* V02 tmp1 [V02 ] ( 0, 0 ) struct (16) zero-ref do-not-enreg[SF] ld-addr-op "NewObj constructor temp"-; V03 tmp2 [V03,T00] ( 13, 26 ) struct (16) [rbp-20H] do-not-enreg[SFA] multireg-arg "Inlining Arg"-; V04 tmp3 [V04,T02] ( 3, 6 ) ref -> r15 class-hnd exact single-def "NewObj constructor temp"+;* V02 tmp1 [V02 ] ( 0, 0 ) struct (16) zero-ref do-not-enreg[SF] ld-addr-op "NewObj constructor temp" <System.Guid>+; V03 tmp2 [V03,T00] ( 13, 26 ) struct (16) [rbp-20H] do-not-enreg[SFA] multireg-arg "Inlining Arg" <System.Guid>+; V04 tmp3 [V04,T02] ( 3, 6 ) ref -> r15 class-hnd exact single-def "NewObj constructor temp" <System.Diagnostics.Tracing.TraceLoggingEventHandleTable>
@EgorBo
EgorBo
merged commit 57608c3
into
dotnet:mainJul 7, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Aug 7, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@MichalPetryka@EgorBo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Print variable types when dumping the output by MichalPetryka · Pull Request #88420 · dotnet/runtime · GitHub
Skip to content
Print variable types when dumping the output - #88420
Merged
EgorBo merged 4 commits into
dotnet:mainfrom 
MichalPetryka:patch-10
Jul 7, 2023
Merged
Print variable types when dumping the output#88420
EgorBo merged 4 commits into
dotnet:mainfrom 
MichalPetryka:patch-10
Conversation
@MichalPetryka
@MichalPetrykaMichalPetryka
commented
Jul 5, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This makes reasoning about local types easier.
Would help with checking the diffs for #88163, #88277 and #88006.
@MichalPetryka
Print variable types when dumping the output
6295db1
This makes reasoning about local types easier.
@ghostghost
added

area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
community-contribution
Indicates that the PR has been added by a community member
labels
Jul 5, 2023
@ghost
ghost
commented
Jul 5, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
This makes reasoning about local types easier.
Author:MichalPetryka
Assignees:-
Labels:
area-CodeGen-coreclr, community-contribution
Milestone:-
@MichalPetryka
MichalPetryka
marked this pull request as ready for review
July 5, 2023 17:48
@MichalPetryka
MichalPetryka
commented
Jul 5, 2023

Copy link


Copy Markdown

ContributorAuthor
@MihuBot
@MihuBotMihuBot
mentioned this pull request
Jul 5, 2023

Open

@MichalPetryka
MichalPetryka
commented
Jul 5, 2023

Copy link


Copy Markdown

ContributorAuthor
@MihuBot
@MihuBotMihuBot
mentioned this pull request
Jul 5, 2023

Open

@MichalPetryka
MichalPetryka
commented
Jul 6, 2023

Copy link


Copy Markdown

ContributorAuthor
@MihuBot
@MihuBotMihuBot
mentioned this pull request
Jul 6, 2023

Open

@MichalPetryka
MichalPetryka
commented
Jul 6, 2023

Copy link


Copy Markdown

ContributorAuthor
@EgorBo@jakobbotsch CoreLib jit-diff grew from 210MB to 218MB, some example diffs:
-; V00 this [V00,T00] ( 3, 3 ) ref -> rdi this class-hnd single-def-; V01 arg1 [V01,T01] ( 3, 3 ) ref -> rsi class-hnd single-def+; V00 this [V00,T00] ( 3, 3 ) ref -> rdi this class-hnd single-def <System.Collections.Generic.NonRandomizedStringEqualityComparer+OrdinalComparer>+; V01 arg1 [V01,T01] ( 3, 3 ) ref -> rsi class-hnd single-def <System.Collections.Generic.IEqualityComparer`1[System.String]>
-; V06 tmp1 [V06,T10] ( 3, 0 ) ref -> rbx class-hnd exact single-def "NewObj constructor temp"-;* V07 tmp2 [V07 ] ( 0, 0 ) struct (16) zero-ref "ReadOnlySpan<T> for CreateSpan<T>"+; V06 tmp1 [V06,T10] ( 3, 0 ) ref -> rbx class-hnd exact single-def "NewObj constructor temp" <System.ArgumentException>+;* V07 tmp2 [V07 ] ( 0, 0 ) struct (16) zero-ref "ReadOnlySpan<T> for CreateSpan<T>" <System.ReadOnlySpan`1[int]>
-; V05 tmp1 [V05,T08] ( 3, 6 ) ref -> r13 class-hnd exact single-def "NewObj constructor temp"-; V06 tmp2 [V06,T00] ( 3, 24 ) ref -> [rbp-38H] class-hnd spill-single-def "Inlining Arg"-; V07 tmp3 [V07,T02] ( 2, 16 ) ref -> [rbp-40H] class-hnd exact spill-single-def "Inlining Arg"-; V08 tmp4 [V08,T03] ( 2, 16 ) ref -> rdx class-hnd exact "Inlining Arg"+; V05 tmp1 [V05,T08] ( 3, 6 ) ref -> r13 class-hnd exact single-def "NewObj constructor temp" <System.Collections.Generic.Dictionary`2[System.String,System.Object]>+; V06 tmp2 [V06,T00] ( 3, 24 ) ref -> [rbp-38H] class-hnd spill-single-def "Inlining Arg" <System.Collections.Generic.Dictionary`2[System.String,System.Object]>+; V07 tmp3 [V07,T02] ( 2, 16 ) ref -> [rbp-40H] class-hnd exact spill-single-def "Inlining Arg" <System.String>+; V08 tmp4 [V08,T03] ( 2, 16 ) ref -> rdx class-hnd exact "Inlining Arg" <System.String>
-;* V09 loc8 [V09 ] ( 0, 0 ) simd32 -> zero-ref +;* V09 loc8 [V09 ] ( 0, 0 ) simd32 -> zero-ref <System.Runtime.Intrinsics.Vector256`1[ushort]>
;* V10 loc9 [V10 ] ( 0, 0 ) int -> zero-ref -;* V11 loc10 [V11 ] ( 0, 0 ) simd16 -> zero-ref +;* V11 loc10 [V11 ] ( 0, 0 ) simd16 -> zero-ref <System.Runtime.Intrinsics.Vector128`1[ushort]>
-;* V13 tmp7 [V13 ] ( 0, 0 ) struct (16) zero-ref multireg-arg "spilled call-like call argument"-;* V14 tmp8 [V14 ] ( 0, 0 ) struct (16) zero-ref "Inline return value spill temp"-;* V15 tmp9 [V15 ] ( 0, 0 ) struct (16) zero-ref ld-addr-op "NewObj constructor temp"-;* V16 tmp10 [V16 ] ( 0, 0 ) struct (16) zero-ref ld-addr-op "Inline ldloca(s) first use temp"+;* V13 tmp7 [V13 ] ( 0, 0 ) struct (16) zero-ref multireg-arg "spilled call-like call argument" <System.ReadOnlySpan`1[ushort]>+;* V14 tmp8 [V14 ] ( 0, 0 ) struct (16) zero-ref "Inline return value spill temp" <System.ReadOnlySpan`1[ushort]>+;* V15 tmp9 [V15 ] ( 0, 0 ) struct (16) zero-ref ld-addr-op "NewObj constructor temp" <System.ReadOnlySpan`1[ushort]>+;* V16 tmp10 [V16 ] ( 0, 0 ) struct (16) zero-ref ld-addr-op "Inline ldloca(s) first use temp" <System.ReadOnlySpan`1[ushort]>
-; V04 loc2 [V04,T12] ( 3, 3 ) ref -> r14 class-hnd single-def+; V04 loc2 [V04,T12] ( 3, 3 ) ref -> r14 class-hnd single-def <System.Collections.Generic.IEqualityComparer`1[System.__Canon]>
-; V01 tmp1 [V01 ] ( 1, 1 ) ref -> [rbp-08H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V02 tmp2 [V02 ] ( 1, 1 ) ref -> [rbp-10H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V03 tmp3 [V03 ] ( 1, 1 ) ref -> [rbp-18H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V04 tmp4 [V04 ] ( 1, 1 ) ref -> [rbp-20H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V05 tmp5 [V05 ] ( 1, 1 ) ref -> [rbp-28H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"-; V06 tmp6 [V06 ] ( 1, 1 ) ref -> [rbp-30H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"+; V01 tmp1 [V01 ] ( 1, 1 ) ref -> [rbp-08H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Func`1[System.String]>+; V02 tmp2 [V02 ] ( 1, 1 ) ref -> [rbp-10H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Lazy`1[System.String]>+; V03 tmp3 [V03 ] ( 1, 1 ) ref -> [rbp-18H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Func`1[System.String]>+; V04 tmp4 [V04 ] ( 1, 1 ) ref -> [rbp-20H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Lazy`1[System.String]>+; V05 tmp5 [V05 ] ( 1, 1 ) ref -> [rbp-28H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Collections.Generic.List`1[ushort]>+; V06 tmp6 [V06 ] ( 1, 1 ) ref -> [rbp-30H] do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Collections.Generic.Dictionary`2[ushort,System.String]>
-;* V02 tmp1 [V02 ] ( 0, 0 ) struct (16) zero-ref do-not-enreg[SF] ld-addr-op "NewObj constructor temp"-; V03 tmp2 [V03,T00] ( 13, 26 ) struct (16) [rbp-20H] do-not-enreg[SFA] multireg-arg "Inlining Arg"-; V04 tmp3 [V04,T02] ( 3, 6 ) ref -> r15 class-hnd exact single-def "NewObj constructor temp"+;* V02 tmp1 [V02 ] ( 0, 0 ) struct (16) zero-ref do-not-enreg[SF] ld-addr-op "NewObj constructor temp" <System.Guid>+; V03 tmp2 [V03,T00] ( 13, 26 ) struct (16) [rbp-20H] do-not-enreg[SFA] multireg-arg "Inlining Arg" <System.Guid>+; V04 tmp3 [V04,T02] ( 3, 6 ) ref -> r15 class-hnd exact single-def "NewObj constructor temp" <System.Diagnostics.Tracing.TraceLoggingEventHandleTable>
@EgorBo
EgorBo
merged commit 57608c3
into
dotnet:mainJul 7, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Aug 7, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@MichalPetryka@EgorBo