Skip to content

Added QuicException.TransportErrorCode - #88550

Merged
ManickaP merged 6 commits into
dotnet:mainfrom
AlexRadch:QuicException.TransportErrorCode
Jul 17, 2023
Merged

Added QuicException.TransportErrorCode#88550
ManickaP merged 6 commits into
dotnet:mainfrom
AlexRadch:QuicException.TransportErrorCode

Conversation

@AlexRadch

@AlexRadchAlexRadch commented Jul 9, 2023•
edited by karelz
Loading

Copy link
Copy Markdown
Contributor

Resolves#87262#72666

@ghostghost added area-System.Net.Quic new-api-needs-documentation community-contribution Indicates that the PR has been added by a community member labels Jul 9, 2023
@ghost

ghost commented Jul 9, 2023

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost

ghost commented Jul 9, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

For issue #87262

Author:AlexRadch
Assignees:-
Labels:

new-api-needs-documentation, area-System.Net.Quic

Milestone:-

wfurt
wfurt reviewed Jul 9, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/ref/System.Net.Quic.cs Outdated
wfurt
wfurt reviewed Jul 9, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ThrowHelper.cs Outdated
wfurt
wfurt reviewed Jul 9, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/QuicConnection.cs Outdated
wfurt
wfurt reviewed Jul 9, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/QuicConnection.cs Outdated
wfurt
wfurt reviewed Jul 9, 2023
View reviewed changes

@wfurtwfurt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also look at #87679 (comment) and try to address it.

@AlexRadch

AlexRadch commented Jul 9, 2023

Copy link
Copy Markdown
ContributorAuthor

please also look at #87679 (comment) and try to address it.

Thank you, I added the transport error code propagation.

@wfurtwfurt mentioned this pull request Jul 9, 2023
Closed
ManickaP
ManickaP reviewed Jul 10, 2023
View reviewed changes

@ManickaPManickaP left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good modulo comments, thanks!

Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/QuicException.cs
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/QuicStream.cs Outdated
rzikm
rzikm reviewed Jul 10, 2023
View reviewed changes

@rzikmrzikm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comments.

Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ThrowHelper.cs Outdated
ManickaP
ManickaP reviewed Jul 14, 2023
View reviewed changes

@ManickaPManickaP left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment, otherwise looks good and we can merge this, thanks!

Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ThrowHelper.cs Outdated
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ThrowHelper.cs Outdated
@karelzkarelz added this to the 8.0.0 milestone Jul 16, 2023
@karelz

karelz commented Jul 16, 2023

Copy link
Copy Markdown
Member

@AlexRadch will you be able to finish the changes? It is highly desirable to merge it by tomorrow 7/17 to catch our Platform complete deadline (= finish all features) for 8.0. Thanks!

@ManickaP

ManickaP commented Jul 17, 2023

Copy link
Copy Markdown
Member

I'm taking over, @wfurt has a pending PR on this, we need to get this in today.

This was referenced Jul 17, 2023
Closed
Closed
Closed
Closed
@ManickaP
ManickaP merged commit c0971e5 into dotnet:mainJul 17, 2023
stephentoub
stephentoub reviewed Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicHelpers.cs
throw ThrowHelper.GetExceptionForMsQuicStatus(status, $"GetParam({handle}, {parameter}) failed");
}

ThrowHelper.ThrowIfMsQuicError(status, $"GetParam({handle}, {parameter}) failed");

@stephentoubstephentoubJul 17, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now going to allocate a string for the error message even in the success case.

@ManickaPManickaPJul 17, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to address this in some of my future PRs. Or @wfurt do you think you could revert these two in #88614?

@wfurtwfurtJul 17, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is ok in interim as it is only perf optimization. I feel it is more important to get the API out.

stephentoub
stephentoub reviewed Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicHelpers.cs
{
throw ThrowHelper.GetExceptionForMsQuicStatus(status, $"SetParam({handle}, {parameter}) failed");
}
ThrowHelper.ThrowIfMsQuicError(status, $"SetParam({handle}, {parameter}) failed");

@stephentoubstephentoubJul 17, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now going to allocate a string for the error message even in the success case.

@stephentoubstephentoub mentioned this pull request Jul 17, 2023
Merged
@wfurtwfurt mentioned this pull request Jul 18, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Aug 16, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoubstephentoubstephentoub left review comments
@ManickaPManickaPManickaP approved these changes
@wfurtwfurtwfurt left review comments
@rzikmrzikmrzikm left review comments

Assignees

@ManickaPManickaP

Labels

area-System.Net.Quiccommunity-contributionIndicates that the PR has been added by a community membernew-api-needs-documentation

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[API Proposal]: Add transport error code to QuicException

6 participants

@AlexRadch@karelz@ManickaP@stephentoub@wfurt@rzikm
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Added QuicException.TransportErrorCode by AlexRadch · Pull Request #88550 · dotnet/runtime · GitHub
Skip to content
Added QuicException.TransportErrorCode - #88550
Merged
ManickaP merged 6 commits into
dotnet:mainfrom 
AlexRadch:QuicException.TransportErrorCode
Jul 17, 2023
Merged
Added QuicException.TransportErrorCode#88550
ManickaP merged 6 commits into
dotnet:mainfrom 
AlexRadch:QuicException.TransportErrorCode
Conversation
@AlexRadch
@AlexRadchAlexRadch
commented
Jul 9, 2023•

edited by karelz

Loading

Copy link


Copy Markdown

Contributor
Resolves#87262#72666
@ghostghost
added

area-System.Net.Quic

new-api-needs-documentation

community-contribution
Indicates that the PR has been added by a community member
labels
Jul 9, 2023
@ghost
ghost
commented
Jul 9, 2023

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.
@ghost
ghost
commented
Jul 9, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
For issue #87262
Author:AlexRadch
Assignees:-
Labels:
new-api-needs-documentation, area-System.Net.Quic
Milestone:-
wfurt
wfurt
reviewed
Jul 9, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/ref/System.Net.Quic.cs
Outdated

wfurt
wfurt
reviewed
Jul 9, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ThrowHelper.cs
Outdated

wfurt
wfurt
reviewed
Jul 9, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/QuicConnection.cs
Outdated

wfurt
wfurt
reviewed
Jul 9, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/QuicConnection.cs
Outdated

wfurt
wfurt
reviewed
Jul 9, 2023
View reviewed changes
@wfurtwfurt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also look at #87679 (comment) and try to address it.
@AlexRadch
AlexRadch
commented
Jul 9, 2023

Copy link


Copy Markdown

ContributorAuthor
please also look at #87679 (comment) and try to address it.
Thank you, I added the transport error code propagation.
@wfurtwfurt
mentioned this pull request
Jul 9, 2023
 Closed

ManickaP
ManickaP
reviewed
Jul 10, 2023
View reviewed changes
@ManickaPManickaP
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good modulo comments, thanks!
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/QuicException.cs
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/QuicStream.cs
Outdated

rzikm
rzikm
reviewed
Jul 10, 2023
View reviewed changes
@rzikmrzikm
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comments.
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ThrowHelper.cs
Outdated

ManickaP
ManickaP
reviewed
Jul 14, 2023
View reviewed changes
@ManickaPManickaP
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment, otherwise looks good and we can merge this, thanks!
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ThrowHelper.cs
Outdated

Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ThrowHelper.cs
Outdated

@karelzkarelz
added this to the 8.0.0 milestone
Jul 16, 2023
@karelz
karelz
commented
Jul 16, 2023

Copy link


Copy Markdown

Member
@AlexRadch will you be able to finish the changes? It is highly desirable to merge it by tomorrow 7/17 to catch our Platform complete deadline (= finish all features) for 8.0. Thanks!
@ManickaP
ManickaP
commented
Jul 17, 2023

Copy link


Copy Markdown

Member
I'm taking over, @wfurt has a pending PR on this, we need to get this in today.

This was referenced Jul 17, 2023

Closed


Closed


Closed


Closed

@ManickaP
ManickaP
merged commit c0971e5
into
dotnet:mainJul 17, 2023
stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicHelpers.cs
 throw ThrowHelper.GetExceptionForMsQuicStatus(status, $"GetParam({handle}, {parameter}) failed");
 }

 ThrowHelper.ThrowIfMsQuicError(status, $"GetParam({handle}, {parameter}) failed");
@stephentoubstephentoubJul 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now going to allocate a string for the error message even in the success case.
@ManickaPManickaPJul 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to address this in some of my future PRs. Or @wfurt do you think you could revert these two in #88614?
@wfurtwfurtJul 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is ok in interim as it is only perf optimization. I feel it is more important to get the API out.
stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicHelpers.cs
 {
 throw ThrowHelper.GetExceptionForMsQuicStatus(status, $"SetParam({handle}, {parameter}) failed");
 }
 ThrowHelper.ThrowIfMsQuicError(status, $"SetParam({handle}, {parameter}) failed");
@stephentoubstephentoubJul 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now going to allocate a string for the error message even in the success case.
@stephentoubstephentoub
mentioned this pull request
Jul 17, 2023
 Merged

@wfurtwfurt
mentioned this pull request
Jul 18, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Aug 16, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub left review comments
@ManickaPManickaPManickaP approved these changes
@wfurtwfurtwfurt left review comments
@rzikmrzikmrzikm left review comments

Assignees

@ManickaPManickaP

Labels

area-System.Net.Quiccommunity-contributionIndicates that the PR has been added by a community membernew-api-needs-documentation

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[API Proposal]: Add transport error code to QuicException


6 participants

@AlexRadch@karelz@ManickaP@stephentoub@wfurt@rzikm

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Added QuicException.TransportErrorCode by AlexRadch · Pull Request #88550 · dotnet/runtime · GitHub
Skip to content
Added QuicException.TransportErrorCode - #88550
Merged
ManickaP merged 6 commits into
dotnet:mainfrom 
AlexRadch:QuicException.TransportErrorCode
Jul 17, 2023
Merged
Added QuicException.TransportErrorCode#88550
ManickaP merged 6 commits into
dotnet:mainfrom 
AlexRadch:QuicException.TransportErrorCode
Conversation
@AlexRadch
@AlexRadchAlexRadch
commented
Jul 9, 2023•

edited by karelz

Loading

Copy link


Copy Markdown

Contributor
Resolves#87262#72666
@ghostghost
added

area-System.Net.Quic

new-api-needs-documentation

community-contribution
Indicates that the PR has been added by a community member
labels
Jul 9, 2023
@ghost
ghost
commented
Jul 9, 2023

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.
@ghost
ghost
commented
Jul 9, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
For issue #87262
Author:AlexRadch
Assignees:-
Labels:
new-api-needs-documentation, area-System.Net.Quic
Milestone:-
wfurt
wfurt
reviewed
Jul 9, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/ref/System.Net.Quic.cs
Outdated

wfurt
wfurt
reviewed
Jul 9, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ThrowHelper.cs
Outdated

wfurt
wfurt
reviewed
Jul 9, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/QuicConnection.cs
Outdated

wfurt
wfurt
reviewed
Jul 9, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/QuicConnection.cs
Outdated

wfurt
wfurt
reviewed
Jul 9, 2023
View reviewed changes
@wfurtwfurt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also look at #87679 (comment) and try to address it.
@AlexRadch
AlexRadch
commented
Jul 9, 2023

Copy link


Copy Markdown

ContributorAuthor
please also look at #87679 (comment) and try to address it.
Thank you, I added the transport error code propagation.
@wfurtwfurt
mentioned this pull request
Jul 9, 2023
 Closed

ManickaP
ManickaP
reviewed
Jul 10, 2023
View reviewed changes
@ManickaPManickaP
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good modulo comments, thanks!
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/QuicException.cs
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/QuicStream.cs
Outdated

rzikm
rzikm
reviewed
Jul 10, 2023
View reviewed changes
@rzikmrzikm
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comments.
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ThrowHelper.cs
Outdated

ManickaP
ManickaP
reviewed
Jul 14, 2023
View reviewed changes
@ManickaPManickaP
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment, otherwise looks good and we can merge this, thanks!
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ThrowHelper.cs
Outdated

Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ThrowHelper.cs
Outdated

@karelzkarelz
added this to the 8.0.0 milestone
Jul 16, 2023
@karelz
karelz
commented
Jul 16, 2023

Copy link


Copy Markdown

Member
@AlexRadch will you be able to finish the changes? It is highly desirable to merge it by tomorrow 7/17 to catch our Platform complete deadline (= finish all features) for 8.0. Thanks!
@ManickaP
ManickaP
commented
Jul 17, 2023

Copy link


Copy Markdown

Member
I'm taking over, @wfurt has a pending PR on this, we need to get this in today.

This was referenced Jul 17, 2023

Closed


Closed


Closed


Closed

@ManickaP
ManickaP
merged commit c0971e5
into
dotnet:mainJul 17, 2023
stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicHelpers.cs
 throw ThrowHelper.GetExceptionForMsQuicStatus(status, $"GetParam({handle}, {parameter}) failed");
 }

 ThrowHelper.ThrowIfMsQuicError(status, $"GetParam({handle}, {parameter}) failed");
@stephentoubstephentoubJul 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now going to allocate a string for the error message even in the success case.
@ManickaPManickaPJul 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to address this in some of my future PRs. Or @wfurt do you think you could revert these two in #88614?
@wfurtwfurtJul 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is ok in interim as it is only perf optimization. I feel it is more important to get the API out.
stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicHelpers.cs
 {
 throw ThrowHelper.GetExceptionForMsQuicStatus(status, $"SetParam({handle}, {parameter}) failed");
 }
 ThrowHelper.ThrowIfMsQuicError(status, $"SetParam({handle}, {parameter}) failed");
@stephentoubstephentoubJul 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now going to allocate a string for the error message even in the success case.
@stephentoubstephentoub
mentioned this pull request
Jul 17, 2023
 Merged

@wfurtwfurt
mentioned this pull request
Jul 18, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Aug 16, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub left review comments
@ManickaPManickaPManickaP approved these changes
@wfurtwfurtwfurt left review comments
@rzikmrzikmrzikm left review comments

Assignees

@ManickaPManickaP

Labels

area-System.Net.Quiccommunity-contributionIndicates that the PR has been added by a community membernew-api-needs-documentation

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[API Proposal]: Add transport error code to QuicException


6 participants

@AlexRadch@karelz@ManickaP@stephentoub@wfurt@rzikm

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Added QuicException.TransportErrorCode by AlexRadch · Pull Request #88550 · dotnet/runtime · GitHub
Skip to content
Added QuicException.TransportErrorCode - #88550
Merged
ManickaP merged 6 commits into
dotnet:mainfrom 
AlexRadch:QuicException.TransportErrorCode
Jul 17, 2023
Merged
Added QuicException.TransportErrorCode#88550
ManickaP merged 6 commits into
dotnet:mainfrom 
AlexRadch:QuicException.TransportErrorCode
Conversation
@AlexRadch
@AlexRadchAlexRadch
commented
Jul 9, 2023•

edited by karelz

Loading

Copy link


Copy Markdown

Contributor
Resolves#87262#72666
@ghostghost
added

area-System.Net.Quic

new-api-needs-documentation

community-contribution
Indicates that the PR has been added by a community member
labels
Jul 9, 2023
@ghost
ghost
commented
Jul 9, 2023

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.
@ghost
ghost
commented
Jul 9, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
For issue #87262
Author:AlexRadch
Assignees:-
Labels:
new-api-needs-documentation, area-System.Net.Quic
Milestone:-
wfurt
wfurt
reviewed
Jul 9, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/ref/System.Net.Quic.cs
Outdated

wfurt
wfurt
reviewed
Jul 9, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ThrowHelper.cs
Outdated

wfurt
wfurt
reviewed
Jul 9, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/QuicConnection.cs
Outdated

wfurt
wfurt
reviewed
Jul 9, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/QuicConnection.cs
Outdated

wfurt
wfurt
reviewed
Jul 9, 2023
View reviewed changes
@wfurtwfurt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also look at #87679 (comment) and try to address it.
@AlexRadch
AlexRadch
commented
Jul 9, 2023

Copy link


Copy Markdown

ContributorAuthor
please also look at #87679 (comment) and try to address it.
Thank you, I added the transport error code propagation.
@wfurtwfurt
mentioned this pull request
Jul 9, 2023
 Closed

ManickaP
ManickaP
reviewed
Jul 10, 2023
View reviewed changes
@ManickaPManickaP
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good modulo comments, thanks!
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/QuicException.cs
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/QuicStream.cs
Outdated

rzikm
rzikm
reviewed
Jul 10, 2023
View reviewed changes
@rzikmrzikm
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comments.
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ThrowHelper.cs
Outdated

ManickaP
ManickaP
reviewed
Jul 14, 2023
View reviewed changes
@ManickaPManickaP
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment, otherwise looks good and we can merge this, thanks!
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ThrowHelper.cs
Outdated

Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ThrowHelper.cs
Outdated

@karelzkarelz
added this to the 8.0.0 milestone
Jul 16, 2023
@karelz
karelz
commented
Jul 16, 2023

Copy link


Copy Markdown

Member
@AlexRadch will you be able to finish the changes? It is highly desirable to merge it by tomorrow 7/17 to catch our Platform complete deadline (= finish all features) for 8.0. Thanks!
@ManickaP
ManickaP
commented
Jul 17, 2023

Copy link


Copy Markdown

Member
I'm taking over, @wfurt has a pending PR on this, we need to get this in today.

This was referenced Jul 17, 2023

Closed


Closed


Closed


Closed

@ManickaP
ManickaP
merged commit c0971e5
into
dotnet:mainJul 17, 2023
stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicHelpers.cs
 throw ThrowHelper.GetExceptionForMsQuicStatus(status, $"GetParam({handle}, {parameter}) failed");
 }

 ThrowHelper.ThrowIfMsQuicError(status, $"GetParam({handle}, {parameter}) failed");
@stephentoubstephentoubJul 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now going to allocate a string for the error message even in the success case.
@ManickaPManickaPJul 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to address this in some of my future PRs. Or @wfurt do you think you could revert these two in #88614?
@wfurtwfurtJul 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is ok in interim as it is only perf optimization. I feel it is more important to get the API out.
stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicHelpers.cs
 {
 throw ThrowHelper.GetExceptionForMsQuicStatus(status, $"SetParam({handle}, {parameter}) failed");
 }
 ThrowHelper.ThrowIfMsQuicError(status, $"SetParam({handle}, {parameter}) failed");
@stephentoubstephentoubJul 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now going to allocate a string for the error message even in the success case.
@stephentoubstephentoub
mentioned this pull request
Jul 17, 2023
 Merged

@wfurtwfurt
mentioned this pull request
Jul 18, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Aug 16, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub left review comments
@ManickaPManickaPManickaP approved these changes
@wfurtwfurtwfurt left review comments
@rzikmrzikmrzikm left review comments

Assignees

@ManickaPManickaP

Labels

area-System.Net.Quiccommunity-contributionIndicates that the PR has been added by a community membernew-api-needs-documentation

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[API Proposal]: Add transport error code to QuicException


6 participants

@AlexRadch@karelz@ManickaP@stephentoub@wfurt@rzikm

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Added QuicException.TransportErrorCode by AlexRadch · Pull Request #88550 · dotnet/runtime · GitHub
Skip to content
Added QuicException.TransportErrorCode - #88550
Merged
ManickaP merged 6 commits into
dotnet:mainfrom 
AlexRadch:QuicException.TransportErrorCode
Jul 17, 2023
Merged
Added QuicException.TransportErrorCode#88550
ManickaP merged 6 commits into
dotnet:mainfrom 
AlexRadch:QuicException.TransportErrorCode
Conversation
@AlexRadch
@AlexRadchAlexRadch
commented
Jul 9, 2023•

edited by karelz

Loading

Copy link


Copy Markdown

Contributor
Resolves#87262#72666
@ghostghost
added

area-System.Net.Quic

new-api-needs-documentation

community-contribution
Indicates that the PR has been added by a community member
labels
Jul 9, 2023
@ghost
ghost
commented
Jul 9, 2023

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.
@ghost
ghost
commented
Jul 9, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
For issue #87262
Author:AlexRadch
Assignees:-
Labels:
new-api-needs-documentation, area-System.Net.Quic
Milestone:-
wfurt
wfurt
reviewed
Jul 9, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/ref/System.Net.Quic.cs
Outdated

wfurt
wfurt
reviewed
Jul 9, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ThrowHelper.cs
Outdated

wfurt
wfurt
reviewed
Jul 9, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/QuicConnection.cs
Outdated

wfurt
wfurt
reviewed
Jul 9, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/QuicConnection.cs
Outdated

wfurt
wfurt
reviewed
Jul 9, 2023
View reviewed changes
@wfurtwfurt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also look at #87679 (comment) and try to address it.
@AlexRadch
AlexRadch
commented
Jul 9, 2023

Copy link


Copy Markdown

ContributorAuthor
please also look at #87679 (comment) and try to address it.
Thank you, I added the transport error code propagation.
@wfurtwfurt
mentioned this pull request
Jul 9, 2023
 Closed

ManickaP
ManickaP
reviewed
Jul 10, 2023
View reviewed changes
@ManickaPManickaP
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good modulo comments, thanks!
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/QuicException.cs
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/QuicStream.cs
Outdated

rzikm
rzikm
reviewed
Jul 10, 2023
View reviewed changes
@rzikmrzikm
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comments.
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ThrowHelper.cs
Outdated

ManickaP
ManickaP
reviewed
Jul 14, 2023
View reviewed changes
@ManickaPManickaP
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment, otherwise looks good and we can merge this, thanks!
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ThrowHelper.cs
Outdated

Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ThrowHelper.cs
Outdated

@karelzkarelz
added this to the 8.0.0 milestone
Jul 16, 2023
@karelz
karelz
commented
Jul 16, 2023

Copy link


Copy Markdown

Member
@AlexRadch will you be able to finish the changes? It is highly desirable to merge it by tomorrow 7/17 to catch our Platform complete deadline (= finish all features) for 8.0. Thanks!
@ManickaP
ManickaP
commented
Jul 17, 2023

Copy link


Copy Markdown

Member
I'm taking over, @wfurt has a pending PR on this, we need to get this in today.

This was referenced Jul 17, 2023

Closed


Closed


Closed


Closed

@ManickaP
ManickaP
merged commit c0971e5
into
dotnet:mainJul 17, 2023
stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicHelpers.cs
 throw ThrowHelper.GetExceptionForMsQuicStatus(status, $"GetParam({handle}, {parameter}) failed");
 }

 ThrowHelper.ThrowIfMsQuicError(status, $"GetParam({handle}, {parameter}) failed");
@stephentoubstephentoubJul 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now going to allocate a string for the error message even in the success case.
@ManickaPManickaPJul 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to address this in some of my future PRs. Or @wfurt do you think you could revert these two in #88614?
@wfurtwfurtJul 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is ok in interim as it is only perf optimization. I feel it is more important to get the API out.
stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicHelpers.cs
 {
 throw ThrowHelper.GetExceptionForMsQuicStatus(status, $"SetParam({handle}, {parameter}) failed");
 }
 ThrowHelper.ThrowIfMsQuicError(status, $"SetParam({handle}, {parameter}) failed");
@stephentoubstephentoubJul 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now going to allocate a string for the error message even in the success case.
@stephentoubstephentoub
mentioned this pull request
Jul 17, 2023
 Merged

@wfurtwfurt
mentioned this pull request
Jul 18, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Aug 16, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub left review comments
@ManickaPManickaPManickaP approved these changes
@wfurtwfurtwfurt left review comments
@rzikmrzikmrzikm left review comments

Assignees

@ManickaPManickaP

Labels

area-System.Net.Quiccommunity-contributionIndicates that the PR has been added by a community membernew-api-needs-documentation

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[API Proposal]: Add transport error code to QuicException


6 participants

@AlexRadch@karelz@ManickaP@stephentoub@wfurt@rzikm

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Added QuicException.TransportErrorCode by AlexRadch · Pull Request #88550 · dotnet/runtime · GitHub
Skip to content
Added QuicException.TransportErrorCode - #88550
Merged
ManickaP merged 6 commits into
dotnet:mainfrom 
AlexRadch:QuicException.TransportErrorCode
Jul 17, 2023
Merged
Added QuicException.TransportErrorCode#88550
ManickaP merged 6 commits into
dotnet:mainfrom 
AlexRadch:QuicException.TransportErrorCode
Conversation
@AlexRadch
@AlexRadchAlexRadch
commented
Jul 9, 2023•

edited by karelz

Loading

Copy link


Copy Markdown

Contributor
Resolves#87262#72666
@ghostghost
added

area-System.Net.Quic

new-api-needs-documentation

community-contribution
Indicates that the PR has been added by a community member
labels
Jul 9, 2023
@ghost
ghost
commented
Jul 9, 2023

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.
@ghost
ghost
commented
Jul 9, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
For issue #87262
Author:AlexRadch
Assignees:-
Labels:
new-api-needs-documentation, area-System.Net.Quic
Milestone:-
wfurt
wfurt
reviewed
Jul 9, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/ref/System.Net.Quic.cs
Outdated

wfurt
wfurt
reviewed
Jul 9, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ThrowHelper.cs
Outdated

wfurt
wfurt
reviewed
Jul 9, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/QuicConnection.cs
Outdated

wfurt
wfurt
reviewed
Jul 9, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/QuicConnection.cs
Outdated

wfurt
wfurt
reviewed
Jul 9, 2023
View reviewed changes
@wfurtwfurt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also look at #87679 (comment) and try to address it.
@AlexRadch
AlexRadch
commented
Jul 9, 2023

Copy link


Copy Markdown

ContributorAuthor
please also look at #87679 (comment) and try to address it.
Thank you, I added the transport error code propagation.
@wfurtwfurt
mentioned this pull request
Jul 9, 2023
 Closed

ManickaP
ManickaP
reviewed
Jul 10, 2023
View reviewed changes
@ManickaPManickaP
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good modulo comments, thanks!
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/QuicException.cs
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/QuicStream.cs
Outdated

rzikm
rzikm
reviewed
Jul 10, 2023
View reviewed changes
@rzikmrzikm
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comments.
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ThrowHelper.cs
Outdated

ManickaP
ManickaP
reviewed
Jul 14, 2023
View reviewed changes
@ManickaPManickaP
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment, otherwise looks good and we can merge this, thanks!
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ThrowHelper.cs
Outdated

Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ThrowHelper.cs
Outdated

@karelzkarelz
added this to the 8.0.0 milestone
Jul 16, 2023
@karelz
karelz
commented
Jul 16, 2023

Copy link


Copy Markdown

Member
@AlexRadch will you be able to finish the changes? It is highly desirable to merge it by tomorrow 7/17 to catch our Platform complete deadline (= finish all features) for 8.0. Thanks!
@ManickaP
ManickaP
commented
Jul 17, 2023

Copy link


Copy Markdown

Member
I'm taking over, @wfurt has a pending PR on this, we need to get this in today.

This was referenced Jul 17, 2023

Closed


Closed


Closed


Closed

@ManickaP
ManickaP
merged commit c0971e5
into
dotnet:mainJul 17, 2023
stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicHelpers.cs
 throw ThrowHelper.GetExceptionForMsQuicStatus(status, $"GetParam({handle}, {parameter}) failed");
 }

 ThrowHelper.ThrowIfMsQuicError(status, $"GetParam({handle}, {parameter}) failed");
@stephentoubstephentoubJul 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now going to allocate a string for the error message even in the success case.
@ManickaPManickaPJul 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to address this in some of my future PRs. Or @wfurt do you think you could revert these two in #88614?
@wfurtwfurtJul 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is ok in interim as it is only perf optimization. I feel it is more important to get the API out.
stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicHelpers.cs
 {
 throw ThrowHelper.GetExceptionForMsQuicStatus(status, $"SetParam({handle}, {parameter}) failed");
 }
 ThrowHelper.ThrowIfMsQuicError(status, $"SetParam({handle}, {parameter}) failed");
@stephentoubstephentoubJul 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now going to allocate a string for the error message even in the success case.
@stephentoubstephentoub
mentioned this pull request
Jul 17, 2023
 Merged

@wfurtwfurt
mentioned this pull request
Jul 18, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Aug 16, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub left review comments
@ManickaPManickaPManickaP approved these changes
@wfurtwfurtwfurt left review comments
@rzikmrzikmrzikm left review comments

Assignees

@ManickaPManickaP

Labels

area-System.Net.Quiccommunity-contributionIndicates that the PR has been added by a community membernew-api-needs-documentation

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[API Proposal]: Add transport error code to QuicException


6 participants

@AlexRadch@karelz@ManickaP@stephentoub@wfurt@rzikm

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Added QuicException.TransportErrorCode by AlexRadch · Pull Request #88550 · dotnet/runtime · GitHub
Skip to content
Added QuicException.TransportErrorCode - #88550
Merged
ManickaP merged 6 commits into
dotnet:mainfrom 
AlexRadch:QuicException.TransportErrorCode
Jul 17, 2023
Merged
Added QuicException.TransportErrorCode#88550
ManickaP merged 6 commits into
dotnet:mainfrom 
AlexRadch:QuicException.TransportErrorCode
Conversation
@AlexRadch
@AlexRadchAlexRadch
commented
Jul 9, 2023•

edited by karelz

Loading

Copy link


Copy Markdown

Contributor
Resolves#87262#72666
@ghostghost
added

area-System.Net.Quic

new-api-needs-documentation

community-contribution
Indicates that the PR has been added by a community member
labels
Jul 9, 2023
@ghost
ghost
commented
Jul 9, 2023

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.
@ghost
ghost
commented
Jul 9, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
For issue #87262
Author:AlexRadch
Assignees:-
Labels:
new-api-needs-documentation, area-System.Net.Quic
Milestone:-
wfurt
wfurt
reviewed
Jul 9, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/ref/System.Net.Quic.cs
Outdated

wfurt
wfurt
reviewed
Jul 9, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ThrowHelper.cs
Outdated

wfurt
wfurt
reviewed
Jul 9, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/QuicConnection.cs
Outdated

wfurt
wfurt
reviewed
Jul 9, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/QuicConnection.cs
Outdated

wfurt
wfurt
reviewed
Jul 9, 2023
View reviewed changes
@wfurtwfurt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also look at #87679 (comment) and try to address it.
@AlexRadch
AlexRadch
commented
Jul 9, 2023

Copy link


Copy Markdown

ContributorAuthor
please also look at #87679 (comment) and try to address it.
Thank you, I added the transport error code propagation.
@wfurtwfurt
mentioned this pull request
Jul 9, 2023
 Closed

ManickaP
ManickaP
reviewed
Jul 10, 2023
View reviewed changes
@ManickaPManickaP
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good modulo comments, thanks!
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/QuicException.cs
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/QuicStream.cs
Outdated

rzikm
rzikm
reviewed
Jul 10, 2023
View reviewed changes
@rzikmrzikm
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comments.
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ThrowHelper.cs
Outdated

ManickaP
ManickaP
reviewed
Jul 14, 2023
View reviewed changes
@ManickaPManickaP
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment, otherwise looks good and we can merge this, thanks!
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ThrowHelper.cs
Outdated

Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ThrowHelper.cs
Outdated

@karelzkarelz
added this to the 8.0.0 milestone
Jul 16, 2023
@karelz
karelz
commented
Jul 16, 2023

Copy link


Copy Markdown

Member
@AlexRadch will you be able to finish the changes? It is highly desirable to merge it by tomorrow 7/17 to catch our Platform complete deadline (= finish all features) for 8.0. Thanks!
@ManickaP
ManickaP
commented
Jul 17, 2023

Copy link


Copy Markdown

Member
I'm taking over, @wfurt has a pending PR on this, we need to get this in today.

This was referenced Jul 17, 2023

Closed


Closed


Closed


Closed

@ManickaP
ManickaP
merged commit c0971e5
into
dotnet:mainJul 17, 2023
stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicHelpers.cs
 throw ThrowHelper.GetExceptionForMsQuicStatus(status, $"GetParam({handle}, {parameter}) failed");
 }

 ThrowHelper.ThrowIfMsQuicError(status, $"GetParam({handle}, {parameter}) failed");
@stephentoubstephentoubJul 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now going to allocate a string for the error message even in the success case.
@ManickaPManickaPJul 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to address this in some of my future PRs. Or @wfurt do you think you could revert these two in #88614?
@wfurtwfurtJul 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is ok in interim as it is only perf optimization. I feel it is more important to get the API out.
stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicHelpers.cs
 {
 throw ThrowHelper.GetExceptionForMsQuicStatus(status, $"SetParam({handle}, {parameter}) failed");
 }
 ThrowHelper.ThrowIfMsQuicError(status, $"SetParam({handle}, {parameter}) failed");
@stephentoubstephentoubJul 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now going to allocate a string for the error message even in the success case.
@stephentoubstephentoub
mentioned this pull request
Jul 17, 2023
 Merged

@wfurtwfurt
mentioned this pull request
Jul 18, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Aug 16, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub left review comments
@ManickaPManickaPManickaP approved these changes
@wfurtwfurtwfurt left review comments
@rzikmrzikmrzikm left review comments

Assignees

@ManickaPManickaP

Labels

area-System.Net.Quiccommunity-contributionIndicates that the PR has been added by a community membernew-api-needs-documentation

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[API Proposal]: Add transport error code to QuicException


6 participants

@AlexRadch@karelz@ManickaP@stephentoub@wfurt@rzikm