Skip to content

Ensure that the CpuId tests set preferredVectorByteLength to a non-zero value - #88623

Merged
tannergooding merged 3 commits into
dotnet:mainfrom
tannergooding:vector512-ci
Jul 11, 2023
Merged

Ensure that the CpuId tests set preferredVectorByteLength to a non-zero value#88623
tannergooding merged 3 commits into
dotnet:mainfrom
tannergooding:vector512-ci

Conversation

@tannergooding

@tannergoodingtannergooding commented Jul 10, 2023

Copy link
Copy Markdown
Member

This resolves#88581 and resolves#88582 and resolves#88580

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 10, 2023
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This resolves #88581

Author:tannergooding
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@tannergooding

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr jitstress-isas-x86, runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 4 pipeline(s).

@tannergooding

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr jitstress-isas-x86, runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 4 pipeline(s).

@tannergooding

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr jitstress-isas-x86, runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

@azure-pipelines

Copy link
Copy Markdown

No commit pushedDate could be found for PR 88623 in repo dotnet/runtime

@tannergooding

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr jitstress-isas-x86, runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 4 pipeline(s).

@tannergooding

Copy link
Copy Markdown
MemberAuthor

CC. @dotnet/jit-contrib. This resolves #88581 and resolves #88582 and resolves #88580

The two main issues were that PreferredVectorByteWidth was being tied to the jit-stress mode, which made it non-deterministic and differ per-method. This broke cases like Vector512.IsHardwareAccelerated.

Additionally, the check around IsHardwareAccelerated itself wasn't properly conditioned and could differ in some scenarios, leading to other issues and inconsistencies.

This fixes both of those issues and ensures the tests are taking the preferred width into account so they pass as expected.

@AndyAyersMSAndyAyersMS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the stress mode might be salvageable somehow, but let's sort that out later.

@tannergooding

Copy link
Copy Markdown
MemberAuthor

Seems like the stress mode might be salvageable somehow, but let's sort that out later.

It's worth noting that we are explicitly testing PreferredVectorBitWidth=512 in stress already, so it wasn't buying us much.

@tannergooding

Copy link
Copy Markdown
MemberAuthor

@dotnet-policy-service rerun

@tannergooding

Copy link
Copy Markdown
MemberAuthor

There are still some stress failures, but unrelated to this PR in particular.

@tannergooding
tannergooding merged commit 83bf4b6 into dotnet:mainJul 11, 2023
@tannergooding
tannergooding deleted the vector512-ci branch July 11, 2023 22:26
@ghostghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

2 participants

@tannergooding@AndyAyersMS