Skip to content

[Mono] UnsafeAccessorAttribute non-generic support for field - #88626

Merged
AaronRobinsonMSFT merged 35 commits into
dotnet:mainfrom
fanyang-mono:unsafeAccessor
Jul 14, 2023
Merged

[Mono] UnsafeAccessorAttribute non-generic support for field#88626
AaronRobinsonMSFT merged 35 commits into
dotnet:mainfrom
fanyang-mono:unsafeAccessor

Conversation

@fanyang-mono

@fanyang-monofanyang-mono commented Jul 10, 2023

Copy link
Copy Markdown
Member

Contributes to #86040

fanyang-monoand others added 14 commits July 5, 2023 16:02
@fanyang-mono
Detect an UnsafeAccessorAttribute for method with interpreter
bc9d6ed
@fanyang-mono
Change field to property
1643710
@fanyang-mono
Get Kind from typed_args
b0def6c
@lambdageek@fanyang-mono
define MonoUnsafeAccessorKind enum
0c51e8a
@fanyang-mono
Add the frontend for JIT
94ce7d2
@lambdageek@fanyang-mono
Add mono_marshal_get_unsafe_accessor_wrapper and WRAPPER_SUBTYPE_UNSA…
a49a8e0
…FE_ACCESSOR
And the associated AOT compiler/runtime and marshaling caching boilerplate.
@lambdageek@fanyang-mono
[interp] get the unsafe accessor wrapper
4701689
@lambdageek@fanyang-mono
fix: skip visibility in unsafe accessor wrappers
495ce38
that is the whole point of them
@lambdageek@fanyang-mono
fix: decode the length and copy the name from UnsafeAccessorAttribute
35c4d45
The name has a length as a prefix and doesn not have a null terminator
@lambdageek@fanyang-mono
[mini] compile wrapper
0c8f4da
@lambdageek@fanyang-mono
[aot] Emit unsafe accessor wrappers to the AOT image
8d039e6
@fanyang-mono
Add the method to emit wrapper for field
080559a
@fanyang-mono
Fix typo
2ec266b
@fanyang-mono
Remove assertion for interpreter
8571969
@ghostghost added the area-VM-meta-mono label Jul 10, 2023
lambdageek
lambdageek reviewed Jul 10, 2023
View reviewed changes
Comment threadsrc/mono/mono/metadata/marshal-lightweight.c Outdated
vargaz
vargaz reviewed Jul 10, 2023
View reviewed changes
Comment threadsrc/mono/mono/metadata/custom-attrs.c
vargaz
vargaz reviewed Jul 10, 2023
View reviewed changes
Comment threadsrc/mono/mono/metadata/custom-attrs.c
vargaz
vargaz reviewed Jul 10, 2023
View reviewed changes
Comment threadsrc/mono/mono/metadata/custom-attrs.c
vargaz
vargaz reviewed Jul 10, 2023
View reviewed changes
Comment threadsrc/mono/mono/metadata/unsafe-accessor.c
vargaz
vargaz reviewed Jul 10, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/aot-compiler.c
vargaz
vargaz reviewed Jul 10, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/mini-runtime.c Outdated
lambdageek
lambdageek reviewed Jul 12, 2023
View reviewed changes
Comment threadsrc/mono/mono/metadata/marshal-lightweight.c Outdated
@build-analysisbuild-analysisBot mentioned this pull request Jul 13, 2023
Closed
lambdageek
lambdageek reviewed Jul 13, 2023
View reviewed changes

@lambdageeklambdageek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of nits for the new test and static modifier check

Comment threadsrc/tests/baseservices/compilerservices/UnsafeAccessors/UnsafeAccessorsTests.cs Outdated
Comment threadsrc/mono/mono/metadata/marshal-lightweight.c Outdated
lambdageek
lambdageek approved these changes Jul 13, 2023
View reviewed changes

@lambdageeklambdageek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we're mostly focusing on nits now

@fanyang-monofanyang-mono mentioned this pull request Jul 13, 2023
Closed
@fanyang-mono

fanyang-mono commented Jul 13, 2023

Copy link
Copy Markdown
MemberAuthor

The newly added tests for checking static modifier failed on CoreCLR. Disabled the test and created an issue(#88858) to track that.

AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Jul 13, 2023
View reviewed changes
Comment threadsrc/tests/baseservices/compilerservices/UnsafeAccessors/UnsafeAccessorsTests.cs Outdated
AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Jul 13, 2023
View reviewed changes
Comment threadsrc/tests/baseservices/compilerservices/UnsafeAccessors/UnsafeAccessorsTests.cs Outdated
AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Jul 13, 2023
View reviewed changes
Comment threadsrc/tests/baseservices/compilerservices/UnsafeAccessors/UnsafeAccessorsTests.cs Outdated
AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Jul 13, 2023
View reviewed changes
Comment threadsrc/tests/baseservices/compilerservices/UnsafeAccessors/UnsafeAccessorsTests.cs Outdated
AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Jul 13, 2023
View reviewed changes
Comment threadsrc/tests/baseservices/compilerservices/UnsafeAccessors/UnsafeAccessorsTests.cs Outdated
AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Jul 13, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/aot-runtime.c Outdated
fanyang-monoand others added 6 commits July 13, 2023 15:30
@fanyang-mono@AaronRobinsonMSFT
Update src/tests/baseservices/compilerservices/UnsafeAccessors/Unsafe…
8afb00a
…AccessorsTests.cs
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
@fanyang-mono@AaronRobinsonMSFT
Update src/tests/baseservices/compilerservices/UnsafeAccessors/Unsafe…
a3f9e77
…AccessorsTests.cs
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
@fanyang-mono@AaronRobinsonMSFT
Update src/tests/baseservices/compilerservices/UnsafeAccessors/Unsafe…
9f6b532
…AccessorsTests.cs
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
@fanyang-mono@AaronRobinsonMSFT
Update src/tests/baseservices/compilerservices/UnsafeAccessors/Unsafe…
0c15ccd
…AccessorsTests.cs
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
@fanyang-mono@AaronRobinsonMSFT
Update src/tests/baseservices/compilerservices/UnsafeAccessors/Unsafe…
f21b78e
…AccessorsTests.cs
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
@fanyang-mono
Address more review feedback
781f512
@fanyang-mono

fanyang-mono commented Jul 13, 2023

Copy link
Copy Markdown
MemberAuthor

The newly added tests for checking static modifier failed on CoreCLR. Disabled the test and created an issue(#88858) to track that.

Aaron updated the test, it is passing now.

This was referenced Jul 14, 2023
Closed
Closed
@AaronRobinsonMSFT

AaronRobinsonMSFT commented Jul 14, 2023

Copy link
Copy Markdown
Member

The failures all appear to be known - #88867 and #82637.

@AaronRobinsonMSFT
AaronRobinsonMSFT merged commit 45db21d into dotnet:mainJul 14, 2023
@lambdageeklambdageek mentioned this pull request Jul 14, 2023
Closed
7 tasks
@ghostghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageeklambdageeklambdageek approved these changes
@kotlarmiloskotlarmiloskotlarmilos left review comments
@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@thaystgthaystgAwaiting requested review from thaystgthaystg is a code owner
@jandupejjandupejAwaiting requested review from jandupej
+1 more reviewer
@vargazvargazvargaz left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@fanyang-monofanyang-mono

Labels

area-VM-meta-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fanyang-mono@AaronRobinsonMSFT@vargaz@lambdageek@kotlarmilos