Skip to content

[RISC-V] Missing defines in GC - #88661

Merged
mangod9 merged 1 commit into
dotnet:mainfrom
alpencolt:risc-v-missing-defines-gc
Jul 12, 2023
Merged

[RISC-V] Missing defines in GC#88661
mangod9 merged 1 commit into
dotnet:mainfrom
alpencolt:risc-v-missing-defines-gc

Conversation

@alpencolt

@alpencoltalpencolt commented Jul 11, 2023

Copy link
Copy Markdown

Some defines were not ported to RISC-V in GC. This PR fix it.

Part of #84834

cc @jakobbotsch@wscho77@HJLeee@JongHeonChoi@t-mustafin@clamp03@gbalykov

@ghostghost added community-contribution Indicates that the PR has been added by a community member area-GC-coreclr labels Jul 11, 2023
@ghost

ghost commented Jul 11, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

Some defines were not ported to RISC-V in GC. This PR fix it.

Part of #84834

cc @jakobbotsch@wscho77@HJLeee@JongHeonChoi@t-mustafin@clamp03@gbalykov

Author:alpencolt
Assignees:-
Labels:

area-GC-coreclr, community-contribution

Milestone:-

This was referenced Jul 11, 2023
Closed
Closed
@clamp03clamp03 added the arch-riscv Related to the RISC-V architecture label Jul 11, 2023
gbalykov
gbalykov reviewed Jul 12, 2023
View reviewed changes
Comment threadsrc/coreclr/gc/gc.cpp Outdated
@alpencolt
alpencoltforce-pushed the risc-v-missing-defines-gc branch from 69d50d8 to eae024dCompareJuly 12, 2023 16:47
This was referenced Jul 12, 2023
Closed
Closed
Closed
Closed
@mangod9

mangod9 commented Jul 12, 2023

Copy link
Copy Markdown
Member

CI failures appear to be known issues.

@mangod9mangod9 closed this Jul 12, 2023
@mangod9mangod9 reopened this Jul 12, 2023
@mangod9
mangod9 merged commit a23c7a1 into dotnet:mainJul 12, 2023
@build-analysisbuild-analysisBot mentioned this pull request Jul 13, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mangod9mangod9mangod9 approved these changes
+2 more reviewers
@gbalykovgbalykovgbalykov approved these changes
@t-mustafint-mustafint-mustafin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@alpencoltalpencolt

Labels

arch-riscvRelated to the RISC-V architecturearea-GC-coreclrcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alpencolt@mangod9@gbalykov@t-mustafin@clamp03