Skip to content

JIT: Always consider empty remainders to be dying in physical promotion - #88665

Merged
jakobbotsch merged 2 commits into
dotnet:mainfrom
jakobbotsch:physical-promotion-no-remainder-dying
Jul 13, 2023
Merged

JIT: Always consider empty remainders to be dying in physical promotion#88665
jakobbotsch merged 2 commits into
dotnet:mainfrom
jakobbotsch:physical-promotion-no-remainder-dying

Conversation

@jakobbotsch

Copy link
Copy Markdown
Member

Liveness takes a few shortcuts that means it doesn't always handle the case where there is no remainder as the remainder dying, so add a special case in StructDeaths::IsRemainderDying to take care of this case.

Some minor improvements from more last-use copy omission are expected.

Without this the bug in #88616 is hard to expose because it requires there to be a remainder that is fully defined between the two calls.

Liveness takes a few shortcuts that means it doesn't always handle the
case where there is no remainder as the remainder dying, so add a
special case in StructDeaths::IsRemainderDying to take care of this
case.
Some minor improvements from more last-use copy omission are expected.
@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 11, 2023
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Liveness takes a few shortcuts that means it doesn't always handle the case where there is no remainder as the remainder dying, so add a special case in StructDeaths::IsRemainderDying to take care of this case.

Some minor improvements from more last-use copy omission are expected.

Without this the bug in #88616 is hard to expose because it requires there to be a remainder that is fully defined between the two calls.

Author:jakobbotsch
Assignees:jakobbotsch
Labels:

area-CodeGen-coreclr

Milestone:-

@jakobbotsch

jakobbotsch commented Jul 11, 2023

Copy link
Copy Markdown
MemberAuthor

cc @dotnet/jit-contrib PTAL @AndyAyersMS

Diffs. Some minor improvements due to more last-use copy omission.

The failure is #88582.

@jakobbotsch

Copy link
Copy Markdown
MemberAuthor

license/cla seems to be stuck... will rerun by pushing a new commit.

@jakobbotsch

Copy link
Copy Markdown
MemberAuthor

/azp run runtime

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jakobbotsch
jakobbotsch merged commit d9f6b98 into dotnet:mainJul 13, 2023
@jakobbotsch
jakobbotsch deleted the physical-promotion-no-remainder-dying branch July 13, 2023 03:06
@ghostghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jakobbotsch@AndyAyersMS