Clean up usings in test cases assembly

[mrvoorhe]

The main goal here is to get rid of the unused System.Linq usings. These cause problems for our UnityLinker tests that run against mono class libraries as it requires an additional reference. We could work around it by referencing everything in the mono class libraries, which is what illink does during it's tests. That said, some of the files had a lot of unnecessary usings and I don't think it's a bad thing to clean them up anyways.

Rather than hunt down the 10-20 files that were problematic I ran Rider's namespace clean up functionality on Mono.Linker.Tests.Cases

[ghost]

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar
See info in area-owners.md if you want to be subscribed.

Issue Details

---

The main goal here is to get rid of the unused System.Linq usings. These cause problems for our UnityLinker tests that run against mono class libraries as it requires an additional reference. We could work around it by referencing everything in the mono class libraries, which is what illink does during it's tests. That said, some of the files had a lot of unnecessary usings and I don't think it's a bad thing to clean them up anyways.

Rather than hunt down the 10-20 files that were problematic I ran Rider's namespace clean up functionality on Mono.Linker.Tests.Cases

Author:	mrvoorhe
Assignees:	-
Labels:	linkable-framework
Milestone:	-

[vitek-karas]

There's something weird about the test assembly. VS refuses to cleanup any usings (it behaves as if all of them are necessary even though if I remove one which is unused everything works). And apparently Rider goes to the other extreme and removes even those which are needed (as seen by the failing tests). Oh well :-(

[mrvoorhe]

Tests with #if threw Rider's logic off. Reverted changes in failing tests. And I did a manual review of other tests with #if to see if there were any incorrect changes. I reverted some of these. Worst case, the risk is I break a test when ran with the mono class libraries. Which will be my problem to fix down the road when we pull in these changes to UnityLinker

[vitek-karas]

Thanks a lot for the cleanup!

[mrvoorhe]

@vitek-karas I don't understand what the Build Analysis failure is about. Is there something wrong?

[vitek-karas]

It's a check which looks through all of the failures and matches them against known bugs. It needs to wait for all the runs to finish - unfortunately the wasi leg seems to be stuck. I'll give it a bit more time and if that doesn't help we can merge regardless as nothing else seems to be failing.

[vitek-karas]

Test failures are unrelated. Most of the failures have since been fixed by #88751.