Skip to content

Enable new analyzers CA1862, CA1864 in runtime and fix findings. - #88700

Merged
buyaa-n merged 2 commits into
dotnet:mainfrom
buyaa-n:enable-ca1864
Jul 14, 2023
Merged

Enable new analyzers CA1862, CA1864 in runtime and fix findings.#88700
buyaa-n merged 2 commits into
dotnet:mainfrom
buyaa-n:enable-ca1864

Conversation

@buyaa-n

@buyaa-nbuyaa-n commented Jul 11, 2023

Copy link
Copy Markdown
Contributor

Enable new analyzers CA1862, CA1864 in runtime and fix findings.

  • Nothing flagged for CA1862: Prefer using 'StringComparer'/'StringComparison' to perform case-insensitive string comparisons
  • All updates related to CA1864: Prefer the 'IDictionary.TryAdd(TKey, TValue)' method, thanks to @CollinAlpert

@ghostghost added the area-Meta label Jul 11, 2023
@ghostghost assigned buyaa-nJul 11, 2023
@ghost

ghost commented Jul 11, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

Enable new analyzers CA1862, CA1864 in runtime and fix findings.

  • Nothing flagged for CA1862: Prefer using 'StringComparer'/'StringComparison' to perform case-insensitive string comparisons
  • All updates related to CA1864: Prefer the 'IDictionary.TryAdd(TKey, TValue)' method, thanks to @CollinAlpert
Author:buyaa-n
Assignees:-
Labels:

area-Meta

Milestone:-

buyaa-n
buyaa-n commented Jul 11, 2023
View reviewed changes
Comment threadsrc/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/ComputeWasmPublishAssets.cs Outdated

@buyaa-nbuyaa-nJul 11, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to if-def .Net framework build and apply the fix

carlossanlop
carlossanlop approved these changes Jul 11, 2023
View reviewed changes

@carlossanlopcarlossanlop left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for enabling it. I am not expecting any hits from CA1862 in the runtime repo.

@build-analysisbuild-analysisBot mentioned this pull request Jul 12, 2023
Closed
This was referenced Jul 13, 2023
Closed
Closed
Closed
Closed
@buyaa-n

buyaa-n commented Jul 14, 2023

Copy link
Copy Markdown
ContributorAuthor

All failures are unrelated and known

@buyaa-n
buyaa-n merged commit 9409e2d into dotnet:mainJul 14, 2023
@buyaa-n
buyaa-n deleted the enable-ca1864 branch July 14, 2023 02:57
@ghostghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jeffhandleyjeffhandleyAwaiting requested review from jeffhandley
@stephentoubstephentoubAwaiting requested review from stephentoub
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar
2 more reviewers
@kkeirsteadkkeirsteadkkeirstead left review comments
@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@buyaa-nbuyaa-n

Labels

area-Meta

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@buyaa-n@carlossanlop@kkeirstead