Skip to content

Feature to be able to selectively deoptimize methods - #88797

Merged
hoyosjs merged 11 commits into
dotnet:mainfrom
davmason:method_deoptimization
Jul 14, 2023
Merged

Feature to be able to selectively deoptimize methods#88797
hoyosjs merged 11 commits into
dotnet:mainfrom
davmason:method_deoptimization

Conversation

@davmason

@davmasondavmason commented Jul 12, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@davmasondavmason added this to the 8.0.0 milestone Jul 12, 2023
@davmason
davmason requested a review from a teamJuly 12, 2023 23:00
@davmasondavmason self-assigned this Jul 12, 2023
@ghost

ghost commented Jul 12, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:davmason
Assignees:davmason
Labels:

area-Diagnostics-coreclr

Milestone:8.0.0

hoyosjs
hoyosjs reviewed Jul 13, 2023
View reviewed changes
Comment threadsrc/coreclr/debug/di/rsfunction.cpp Outdated

@hoyosjshoyosjsJul 13, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the process is stopped to be able to do this inspection - is there any reason to not ask this question though the DAC?

@davmasondavmasonJul 13, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is already tested and ready to go my plan is to check it in as is and do a follow up PR to address this and the GetFunctionAddress question

This was referenced Jul 13, 2023
Closed
Closed
mikelle-rogersand others added 9 commits July 13, 2023 14:31
@mikelle-rogers@davmason
rebase
46f833d
removing some code
working on the tiered portion
commit the changes
initial commit for ICorDebugFunction5 DisableOpimizations
removing some code
working on the tiered portion
only enter API once
@davmason
Updates
bd90e25
Update rsfunction.cpp
inliners, but there's a problem
Backing up
WIP
WIP
Fix lock ordering and allow debugger thread to access locks
Add method
Update functioninfo.cpp
@davmason
Update generated files after rebase
825cd9f
@davmason
Update task.cpp
ce731b3
@davmason
Refactor
ede3436
@davmason
Feedback
994fff5
@davmason
Feedback
45411c5
@davmason
Feedback
1d57cee
@davmason
Update cordebug.h
16f7265
@davmason
davmasonforce-pushed the method_deoptimization branch from 6d3364c to 16f7265CompareJuly 13, 2023 21:41
This was referenced Jul 14, 2023
Closed
Closed
@hoyosjs
hoyosjs merged commit b4118a6 into dotnet:mainJul 14, 2023
@hoyosjs

hoyosjs commented Jul 14, 2023

Copy link
Copy Markdown
Member

All failures are known.

@ghostghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hoyosjshoyosjshoyosjs approved these changes

Assignees

@davmasondavmason

Labels

area-Diagnostics-coreclr

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@davmason@hoyosjs@mikelle-rogers