Skip to content

Remove createdump's DAC dependency for the PAL for NativeAOT - #88802

Merged
mikem8361 merged 9 commits into
dotnet:mainfrom
mikem8361:createdumpaot
Jul 18, 2023
Merged

Remove createdump's DAC dependency for the PAL for NativeAOT#88802
mikem8361 merged 9 commits into
dotnet:mainfrom
mikem8361:createdumpaot

Conversation

@mikem8361

@mikem8361mikem8361 commented Jul 12, 2023

Copy link
Copy Markdown
Contributor

Added a createdump mini pal that implements directly a some of the PAL functions needed that are used on both .NET Core and Native AOT and on .NET Core dynamically loads/links to the DAC next createdump for the following functions:

PAL_VirtualUnwindOutOfProc
PAL_GetUnwindInfoSize
WideCharToMultiByte

@mikem8361
mikem8361 requested a review from hoyosjsJuly 12, 2023 23:38
@mikem8361mikem8361 self-assigned this Jul 12, 2023
@ghost

ghost commented Jul 12, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Added a createdump mini pal that implements directly a some of the PAL functions needed that are used on both .NET Core and Native AOT and on .NET Core dynamically loads/links to the DAC next createdump for the following functions:

PAL_VirtualUnwindOutOfProc
PAL_GetUnwindInfoSize
WideCharToMultiByte

Author:mikem8361
Assignees:mikem8361
Labels:

area-Diagnostics-coreclr

Milestone:-

jkoritzinsky
jkoritzinsky reviewed Jul 13, 2023
View reviewed changes
Comment threadsrc/coreclr/debug/createdump/createdumppal.cpp Outdated
This was referenced Jul 13, 2023
Closed
Closed
Closed
Closed
Closed
@mikem8361mikem8361 mentioned this pull request Jul 14, 2023
Closed
3 tasks
@mikem8361

mikem8361 commented Jul 15, 2023

Copy link
Copy Markdown
ContributorAuthor

@hoyosjs can I get your feedback?

hoyosjs
hoyosjs reviewed Jul 17, 2023
View reviewed changes
Comment threadsrc/coreclr/debug/createdump/configure.cmake
hoyosjs
hoyosjs approved these changes Jul 17, 2023
View reviewed changes
Comment threadsrc/coreclr/debug/createdump/crashinfo.cpp
Comment threadsrc/coreclr/debug/createdump/crashinfo.cpp
Comment threadsrc/coreclr/debug/createdump/crashinfounix.cpp Outdated
Comment threadsrc/coreclr/debug/createdump/createdumpmain.cpp
Comment threadsrc/coreclr/debug/createdump/createdumpmain.cpp
Comment threadsrc/coreclr/debug/createdump/createdumppal.cpp
Comment threadsrc/coreclr/debug/createdump/createdumppal.cpp
@mikem8361
mikem8361 merged commit fb613a5 into dotnet:mainJul 18, 2023
@mikem8361
mikem8361 deleted the createdumpaot branch July 18, 2023 02:05
@ghostghost locked as resolved and limited conversation to collaborators Aug 17, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinskyjkoritzinskyjkoritzinsky left review comments
@jkotasjkotasjkotas left review comments
@hoyosjshoyosjshoyosjs approved these changes
+1 more reviewer
@am11am11am11 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@mikem8361mikem8361

Labels

area-Diagnostics-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mikem8361@jkoritzinsky@am11@jkotas@hoyosjs