Skip to content

[7.0] Backport "Fix MSBuild integration for the host build with CMake 3.26" - #88809

Merged
carlossanlop merged 2 commits into
dotnet:release/7.0-stagingfrom
carlossanlop:FixCmake
Jul 14, 2023
Merged

[7.0] Backport "Fix MSBuild integration for the host build with CMake 3.26"#88809
carlossanlop merged 2 commits into
dotnet:release/7.0-stagingfrom
carlossanlop:FixCmake

Conversation

@carlossanlop

@carlossanlopcarlossanlop commented Jul 13, 2023

Copy link
Copy Markdown
Contributor

Backporting commit 2f20812 from this PR: #88208

From a conversation with @hoyosjs, this should fix#88806

There was other commit in the PR, but it just added a comment. Do we need it?

@carlossanlopcarlossanlop added the area-Infrastructure-coreclr Only use for closed issues label Jul 13, 2023
@carlossanlopcarlossanlop self-assigned this Jul 13, 2023
@ghost

ghost commented Jul 13, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Backporting commit 2f20812 from this PR: #88208

From a conversation with @hoyosjs, this should fix #88806

There was other commit in the PR, but it just added a comment. Do we need it?

Author:carlossanlop
Assignees:carlossanlop
Labels:

area-Infrastructure-coreclr

Milestone:-

carlossanlop
carlossanlop commented Jul 13, 2023
View reviewed changes
Comment threadsrc/tests/Interop/IJW/CopyConstructorMarshaler/CMakeLists.txt
@carlossanlopcarlossanlop added the Servicing-approved Approved for servicing release label Jul 13, 2023
This was referenced Jul 13, 2023
Closed
Closed
Closed
@carlossanlop

carlossanlop commented Jul 13, 2023

Copy link
Copy Markdown
ContributorAuthor

@hoyosjs@jkoritzinsky unfortunately, it didn't work. Failure is still happening: https://github.com/dotnet/runtime/pull/88809/checks?check_run_id=15001712296

carlossanlop
carlossanlop commented Jul 13, 2023
View reviewed changes
Comment threadeng/native/ijw/IJW.cmake Outdated
This was referenced Jul 14, 2023
Closed
Closed
@carlossanlop
carlossanlop merged commit 3aae244 into dotnet:release/7.0-stagingJul 14, 2023
@carlossanlop
carlossanlop deleted the FixCmake branch July 14, 2023 16:13
@radicalradical mentioned this pull request Aug 3, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinskyjkoritzinskyjkoritzinsky approved these changes
@hoyosjshoyosjshoyosjs approved these changes

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure-coreclrOnly use for closed issuesServicing-approvedApproved for servicing release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carlossanlop@jkoritzinsky@hoyosjs