') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [mono][tests] Enable dynamic linking for maccatalyst in sandbox environment by kotlarmilos · Pull Request #88847 · dotnet/runtime · GitHub
Skip to content

[mono][tests] Enable dynamic linking for maccatalyst in sandbox environment - #88847

Merged
kotlarmilos merged 1 commit into
dotnet:mainfrom
kotlarmilos:bugfix/maccatalyst-sandbox-jobs
Jul 14, 2023
Merged

[mono][tests] Enable dynamic linking for maccatalyst in sandbox environment#88847
kotlarmilos merged 1 commit into
dotnet:mainfrom
kotlarmilos:bugfix/maccatalyst-sandbox-jobs

Conversation

@kotlarmilos

@kotlarmiloskotlarmilos commented Jul 13, 2023

Copy link
Copy Markdown
Member

This PR should fix the failing maccatalyst jobs in the sandbox environment by enabling dynamic linking. Additionally, it explicitly sets MonoForceInterpreter to false in the sample app when running in the full AOT mode on iossimulator and maccatalyst.

@kotlarmiloskotlarmilos added this to the 8.0.0 milestone Jul 13, 2023
@kotlarmiloskotlarmilos self-assigned this Jul 13, 2023
@ghost

ghost commented Jul 13, 2023

Copy link
Copy Markdown

Tagging subscribers to 'os-maccatalyst': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR should fix the failing maccatalyst jobs in the sandbox environment by enabling dynamic linking. Additionally, it explicitly sets MonoForceInterpreter to false in the sample app when running in the full AOT mode on iossimulator and maccatalyst.

Author:kotlarmilos
Assignees:kotlarmilos
Labels:

area-Codegen-AOT-mono, os-ios, os-maccatalyst

Milestone:8.0.0

@kotlarmilos

kotlarmilos commented Jul 13, 2023

Copy link
Copy Markdown
MemberAuthor

/cc: @jandupej This PR should unblock you.

@kotlarmilos

kotlarmilos commented Jul 13, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-maccatalyst

@azure-pipelines

azure-pipelinesBot commented Jul 13, 2023

Copy link
Copy Markdown

No commit pushedDate could be found for PR 88847 in repo dotnet/runtime

@kotlarmilos

kotlarmilos commented Jul 13, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-maccatalyst

@azure-pipelines

azure-pipelinesBot commented Jul 13, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@steveisok

steveisok commented Jul 13, 2023

Copy link
Copy Markdown
Member

/azp run runtime-maccatalyst

@azure-pipelines

azure-pipelinesBot commented Jul 13, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 13, 2023
Closed
Closed
Closed
@kotlarmilos
kotlarmilos merged commit ae068fe into dotnet:mainJul 14, 2023
@ghostghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@steveisoksteveisoksteveisok approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar

Assignees

@kotlarmiloskotlarmilos

Labels

area-Codegen-AOT-monoos-iosApple iOSos-maccatalystMacCatalyst OS

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@kotlarmilos@steveisok