Skip to content

[release/7.0-staging] Skip RC2 encrypted PKCS12 files on Android for iteration counting - #88854

Merged
akoeplinger merged 1 commit into
dotnet:release/7.0-stagingfrom
vcsjones:backport-dedaf46154a8938848fc9a7e0bd6e5ccebe7809c
Jul 17, 2023
Merged

[release/7.0-staging] Skip RC2 encrypted PKCS12 files on Android for iteration counting#88854
akoeplinger merged 1 commit into
dotnet:release/7.0-stagingfrom
vcsjones:backport-dedaf46154a8938848fc9a7e0bd6e5ccebe7809c

Conversation

@vcsjones

@vcsjonesvcsjones commented Jul 13, 2023

Copy link
Copy Markdown
Member

Manual backport of #88787

This is a test-only change to address failures on Android.

@ghostghost assigned vcsjonesJul 13, 2023
@ghost

ghost commented Jul 13, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Manual backport of #88787

This is a test-only change to address failures on Android.

Author:vcsjones
Assignees:vcsjones
Labels:

area-System.Security

Milestone:-

@vcsjonesvcsjones added the test-bug Problem in test source code (most likely) label Jul 13, 2023
@vcsjones

vcsjones commented Jul 13, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-android, runtime-androidemulator

@azure-pipelines

azure-pipelinesBot commented Jul 13, 2023

Copy link
Copy Markdown
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

This was referenced Jul 13, 2023
Closed
Closed
Closed
@vcsjones

vcsjones commented Jul 13, 2023

Copy link
Copy Markdown
MemberAuthor

Test failures look unrelated. Is there a way to get this to run through Android in release/7.0-staging?

@carlossanlop

carlossanlop commented Jul 13, 2023

Copy link
Copy Markdown
Contributor

/azp list

@azure-pipelines

This comment was marked as resolved.

Sign in to view
@carlossanlop

carlossanlop commented Jul 13, 2023

Copy link
Copy Markdown
Contributor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Jul 13, 2023

Copy link
Copy Markdown

No commit pushedDate could be found for PR 88854 in repo dotnet/runtime

@carlossanlopcarlossanlop added the Servicing-approved Approved for servicing release label Jul 13, 2023
@carlossanlop

carlossanlop commented Jul 13, 2023

Copy link
Copy Markdown
Contributor

Contacted Azure DevOps to ask for help with this error. Does not seem to be coming from our end.

@vcsjones

vcsjones commented Jul 14, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Jul 14, 2023

Copy link
Copy Markdown

No commit pushedDate could be found for PR 88854 in repo dotnet/runtime

@vcsjones

vcsjones commented Jul 14, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Jul 14, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@vcsjones

vcsjones commented Jul 14, 2023

Copy link
Copy Markdown
MemberAuthor

Haha okay. Glad it worked. 🤷

This was referenced Jul 14, 2023
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jul 14, 2023
Closed
Closed
Closed
Closed
Closed
@carlossanlop

carlossanlop commented Jul 14, 2023

Copy link
Copy Markdown
Contributor

Haha okay. Glad it worked. 🤷

I was just told that if you try multiple times, one of them ends up working.

@carlossanlop

carlossanlop commented Jul 16, 2023

Copy link
Copy Markdown
Contributor

@vcsjones let me know if you don't see anything concerning in the CI, and I can merge this for you.

@vcsjones

vcsjones commented Jul 16, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Jul 16, 2023

Copy link
Copy Markdown

No commit pushedDate could be found for PR 88854 in repo dotnet/runtime

@vcsjones

vcsjones commented Jul 16, 2023

Copy link
Copy Markdown
MemberAuthor

The tests timed out, so going to give it another shot on the weekend.

@vcsjones

vcsjones commented Jul 16, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Jul 16, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 17, 2023
Open
Closed
@akoeplinger

akoeplinger commented Jul 17, 2023

Copy link
Copy Markdown
Member

The Ubuntu.1804.Amd64.Android.29.Open servicing helix queue seems to be broken and doesn't provision VMs, I've pinged the infra folks.

@akoeplinger

akoeplinger commented Jul 17, 2023

Copy link
Copy Markdown
Member

The queue is back up, retried the builds.

@akoeplinger

akoeplinger commented Jul 17, 2023

Copy link
Copy Markdown
Member

Failures are unrelated, I checked the Android testResults.xml and the tests are correctly skipped there.

@akoeplinger
akoeplinger merged commit 216f6ee into dotnet:release/7.0-stagingJul 17, 2023
@vcsjones
vcsjones deleted the backport-dedaf46154a8938848fc9a7e0bd6e5ccebe7809c branch July 17, 2023 15:18
@vcsjones

vcsjones commented Jul 17, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

This should be back ported to release/6.0-staging since it will likely fail there as well. The odds of the diff applying cleanly are low, but I'll try backport bot, and if doesn't work, I'll open a manual port.

@vcsjones

vcsjones commented Jul 17, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to release/6.0-staging

@github-actions

github-actionsBot commented Jul 17, 2023

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0-staging: https://github.com/dotnet/runtime/actions/runs/5577496919

@github-actionsgithub-actionsBot mentioned this pull request Jul 17, 2023
Merged
@vcsjones

vcsjones commented Jul 17, 2023

Copy link
Copy Markdown
MemberAuthor

Wow. Backport command I will never doubt you again.

@radicalradical mentioned this pull request Aug 3, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Aug 16, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
+1 more reviewer
@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@vcsjonesvcsjones

Labels

area-System.SecurityServicing-approvedApproved for servicing releasetest-bugProblem in test source code (most likely)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vcsjones@carlossanlop@akoeplinger