Skip to content

Light up Ascii.IsValidCore with Vector512 code path#88872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
khushal1996 wants to merge 4 commits into from
Closed

Light up Ascii.IsValidCore with Vector512 code path #88872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3126811
initial implementation for accelerating isValidCore
khushal1996 Jul 13, 2023
30e6708
adding proper size for processing Vector 512
khushal1996 Jul 13, 2023
2fddeb6
Adding Vector512 support for IsValidCore
khushal1996 Jul 13, 2023
b939585
addressing review comments
khushal1996 Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/libraries/System.Private.CoreLib/src/System/Text/Ascii.Utility.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1499,6 +1499,22 @@ private static bool AllCharsInVectorAreAscii<T>(Vector256<T> vector)
}
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
private static bool AllCharsInVectorAreAscii<T>(Vector512<T> vector)
where T : unmanaged
{
Debug.Assert(typeof(T) == typeof(byte) || typeof(T) == typeof(ushort));

if (typeof(T) == typeof(byte))
{
return vector.AsByte().ExtractMostSignificantBits() == 0;
}
else
{
return (vector.AsUInt16() & Vector512.Create((ushort)0xFF80)) == Vector512<ushort>.Zero;
}
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
private static Vector128<byte> ExtractAsciiVector(Vector128<ushort> vectorFirst, Vector128<ushort> vectorSecond)
{
Expand Down
63 changes: 62 additions & 1 deletion src/libraries/System.Private.CoreLib/src/System/Text/Ascii.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -113,7 +113,68 @@ private static unsafe bool IsValidCore<T>(ref T searchSpace, int length) where T
Vector128.LoadUnsafe(ref Unsafe.Subtract(ref searchSpaceEnd, Vector128<T>.Count)));
}

if (Avx.IsSupported)
if (Vector512.IsHardwareAccelerated && length >= Vector512<T>.Count)
{
// Process inputs with lengths [65, 128] bytes.
if (length <= 2 * Vector512<T>.Count)
{
return AllCharsInVectorAreAscii(
Vector512.LoadUnsafe(ref searchSpace) |
Vector512.LoadUnsafe(ref Unsafe.Subtract(ref searchSpaceEnd, Vector512<T>.Count)));
}

// Process long inputs 256 bytes at a time.
if (length > 4 * Vector512<T>.Count)
{
// Process the first 256 bytes.
if (!AllCharsInVectorAreAscii(
Vector512.LoadUnsafe(ref searchSpace) |
Vector512.LoadUnsafe(ref searchSpace, (nuint)Vector512<T>.Count) |
Vector512.LoadUnsafe(ref searchSpace, 2 * (nuint)Vector512<T>.Count) |
Vector512.LoadUnsafe(ref searchSpace, 3 * (nuint)Vector512<T>.Count)))
{
return false;
}

nuint i = 4 * (nuint)Vector512<T>.Count;

// Try to opportunistically align the reads below. The input isn't pinned, so the GC
// is free to move the references. We're therefore assuming that reads may still be unaligned.
// They may also be unaligned if the input chars aren't 2-byte aligned.
nuint misalignedElements = ((nuint)Unsafe.AsPointer(ref searchSpace) & (nuint)(Vector512<byte>.Count - 1)) / (nuint)sizeof(T);
i -= misalignedElements;
Debug.Assert((int)i > 3 * Vector512<T>.Count);

nuint finalStart = (nuint)length - 4 * (nuint)Vector512<T>.Count;

for (; i < finalStart; i += 4 * (nuint)Vector512<T>.Count)
{
ref T current = ref Unsafe.Add(ref searchSpace, i);

if (!AllCharsInVectorAreAscii(
Vector512.LoadUnsafe(ref current) |
Vector512.LoadUnsafe(ref current, (nuint)Vector512<T>.Count) |
Vector512.LoadUnsafe(ref current, 2 * (nuint)Vector512<T>.Count) |
Vector512.LoadUnsafe(ref current, 3 * (nuint)Vector512<T>.Count)))
{
return false;
}
}

searchSpace = ref Unsafe.Add(ref searchSpace, finalStart);
}

// Process the last [1, 256] bytes.
// The search space has at least 2 * Vector512 bytes available to read.
// We process the first 2 and last 2 vectors, which may overlap.
return AllCharsInVectorAreAscii(
Vector512.LoadUnsafe(ref searchSpace) |
Vector512.LoadUnsafe(ref searchSpace, (nuint)Vector512<T>.Count) |
Vector512.LoadUnsafe(ref Unsafe.Subtract(ref searchSpaceEnd, 2 * Vector512<T>.Count)) |
Vector512.LoadUnsafe(ref Unsafe.Subtract(ref searchSpaceEnd, Vector512<T>.Count)));
}

else if (Avx.IsSupported)
{
// Process inputs with lengths [33, 64] bytes.
if (length <= 2 * Vector256<T>.Count)
Expand Down
7 changes: 6 additions & 1 deletion src/libraries/System.Text.Encoding/tests/Ascii/IsValidByteTests.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,12 @@ public static void EmptyInput_ReturnsTrue()
Vector128<byte>.Count + 1,
Vector256<byte>.Count - 1,
Vector256<byte>.Count,
Vector256<byte>.Count + 1 };
Vector256<byte>.Count + 1,
Vector512<byte>.Count - 1,
Vector512<byte>.Count,
Vector512<byte>.Count + 1,
4*Vector512<byte>.Count,
4*Vector512<byte>.Count + 1 };

public static IEnumerable<object[]> AsciiOnlyBuffers
{
Expand Down
7 changes: 6 additions & 1 deletion src/libraries/System.Text.Encoding/tests/Ascii/IsValidCharTests.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,12 @@ public static void EmptyInput_ReturnsTrue()
Vector128<short>.Count + 1,
Vector256<short>.Count - 1,
Vector256<short>.Count,
Vector256<short>.Count + 1 };
Vector256<short>.Count + 1,
Vector512<short>.Count - 1,
Vector512<short>.Count,
Vector512<short>.Count + 1,
4*Vector512<short>.Count,
4*Vector512<short>.Count + 1 };

public static IEnumerable<object[]> AsciiOnlyBuffers
{
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Light up Ascii.IsValidCore with Vector512 code path by khushal1996 · Pull Request #88872 · dotnet/runtime · GitHub
Skip to content
Light up Ascii.IsValidCore with Vector512 code path#88872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

khushal1996
wants to merge
4
commits into

from

 Closed


Light up Ascii.IsValidCore with Vector512 code path
#88872
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
3126811

initial implementation for accelerating isValidCore


khushal1996 Jul 13, 2023
30e6708

adding proper size for processing Vector 512


khushal1996 Jul 13, 2023
2fddeb6

Adding Vector512 support for IsValidCore


khushal1996 Jul 13, 2023
b939585

addressing review comments


khushal1996 Jul 14, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


16 changes: 16 additions & 0 deletions
src/libraries/System.Private.CoreLib/src/System/Text/Ascii.Utility.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1499,6 +1499,22 @@ private static bool AllCharsInVectorAreAscii<T>(Vector256<T> vector)
 }
 }

 [MethodImpl(MethodImplOptions.AggressiveInlining)]
 private static bool AllCharsInVectorAreAscii<T>(Vector512<T> vector)
 where T : unmanaged
 {
 Debug.Assert(typeof(T) == typeof(byte) || typeof(T) == typeof(ushort));

 if (typeof(T) == typeof(byte))
 {
 return vector.AsByte().ExtractMostSignificantBits() == 0;
 }
 else
 {
 return (vector.AsUInt16() & Vector512.Create((ushort)0xFF80)) == Vector512<ushort>.Zero;
 }
 }

 [MethodImpl(MethodImplOptions.AggressiveInlining)]
 private static Vector128<byte> ExtractAsciiVector(Vector128<ushort> vectorFirst, Vector128<ushort> vectorSecond)
 {
Expand Down

63 changes: 62 additions & 1 deletion
src/libraries/System.Private.CoreLib/src/System/Text/Ascii.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -113,7 +113,68 @@ private static unsafe bool IsValidCore<T>(ref T searchSpace, int length) where T
 Vector128.LoadUnsafe(ref Unsafe.Subtract(ref searchSpaceEnd, Vector128<T>.Count)));
 }

 if (Avx.IsSupported)
 if (Vector512.IsHardwareAccelerated && length >= Vector512<T>.Count)
 {
 // Process inputs with lengths [65, 128] bytes.
 if (length <= 2 * Vector512<T>.Count)
 {
 return AllCharsInVectorAreAscii(
 Vector512.LoadUnsafe(ref searchSpace) |
 Vector512.LoadUnsafe(ref Unsafe.Subtract(ref searchSpaceEnd, Vector512<T>.Count)));
 }

 // Process long inputs 256 bytes at a time.
 if (length > 4 * Vector512<T>.Count)
 {
 // Process the first 256 bytes.
 if (!AllCharsInVectorAreAscii(
 Vector512.LoadUnsafe(ref searchSpace) |
 Vector512.LoadUnsafe(ref searchSpace, (nuint)Vector512<T>.Count) |
 Vector512.LoadUnsafe(ref searchSpace, 2 * (nuint)Vector512<T>.Count) |
 Vector512.LoadUnsafe(ref searchSpace, 3 * (nuint)Vector512<T>.Count)))
 {
 return false;
 }

 nuint i = 4 * (nuint)Vector512<T>.Count;

 // Try to opportunistically align the reads below. The input isn't pinned, so the GC
 // is free to move the references. We're therefore assuming that reads may still be unaligned.
 // They may also be unaligned if the input chars aren't 2-byte aligned.
 nuint misalignedElements = ((nuint)Unsafe.AsPointer(ref searchSpace) & (nuint)(Vector512<byte>.Count - 1)) / (nuint)sizeof(T);
 i -= misalignedElements;
 Debug.Assert((int)i > 3 * Vector512<T>.Count);

 nuint finalStart = (nuint)length - 4 * (nuint)Vector512<T>.Count;

 for (; i < finalStart; i += 4 * (nuint)Vector512<T>.Count)
 {
 ref T current = ref Unsafe.Add(ref searchSpace, i);

 if (!AllCharsInVectorAreAscii(
 Vector512.LoadUnsafe(ref current) |
 Vector512.LoadUnsafe(ref current, (nuint)Vector512<T>.Count) |
 Vector512.LoadUnsafe(ref current, 2 * (nuint)Vector512<T>.Count) |
 Vector512.LoadUnsafe(ref current, 3 * (nuint)Vector512<T>.Count)))
 {
 return false;
 }
 }

 searchSpace = ref Unsafe.Add(ref searchSpace, finalStart);
 }

 // Process the last [1, 256] bytes.
 // The search space has at least 2 * Vector512 bytes available to read.
 // We process the first 2 and last 2 vectors, which may overlap.
 return AllCharsInVectorAreAscii(
 Vector512.LoadUnsafe(ref searchSpace) |
 Vector512.LoadUnsafe(ref searchSpace, (nuint)Vector512<T>.Count) |
 Vector512.LoadUnsafe(ref Unsafe.Subtract(ref searchSpaceEnd, 2 * Vector512<T>.Count)) |
 Vector512.LoadUnsafe(ref Unsafe.Subtract(ref searchSpaceEnd, Vector512<T>.Count)));
 }

 else if (Avx.IsSupported)
 {
 // Process inputs with lengths [33, 64] bytes.
 if (length <= 2 * Vector256<T>.Count)
Expand Down

7 changes: 6 additions & 1 deletion
src/libraries/System.Text.Encoding/tests/Ascii/IsValidByteTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,12 @@ public static void EmptyInput_ReturnsTrue()
 Vector128<byte>.Count + 1,
 Vector256<byte>.Count - 1,
 Vector256<byte>.Count,
 Vector256<byte>.Count + 1 };
 Vector256<byte>.Count + 1,
 Vector512<byte>.Count - 1,
 Vector512<byte>.Count,
 Vector512<byte>.Count + 1,
 4*Vector512<byte>.Count,
 4*Vector512<byte>.Count + 1 };

 public static IEnumerable<object[]> AsciiOnlyBuffers
 {
Expand Down

7 changes: 6 additions & 1 deletion
src/libraries/System.Text.Encoding/tests/Ascii/IsValidCharTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,12 @@ public static void EmptyInput_ReturnsTrue()
 Vector128<short>.Count + 1,
 Vector256<short>.Count - 1,
 Vector256<short>.Count,
 Vector256<short>.Count + 1 };
 Vector256<short>.Count + 1,
 Vector512<short>.Count - 1,
 Vector512<short>.Count,
 Vector512<short>.Count + 1,
 4*Vector512<short>.Count,
 4*Vector512<short>.Count + 1 };

 public static IEnumerable<object[]> AsciiOnlyBuffers
 {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Light up Ascii.IsValidCore with Vector512 code path by khushal1996 · Pull Request #88872 · dotnet/runtime · GitHub
Skip to content
Light up Ascii.IsValidCore with Vector512 code path#88872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

khushal1996
wants to merge
4
commits into

from

 Closed


Light up Ascii.IsValidCore with Vector512 code path
#88872
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
3126811

initial implementation for accelerating isValidCore


khushal1996 Jul 13, 2023
30e6708

adding proper size for processing Vector 512


khushal1996 Jul 13, 2023
2fddeb6

Adding Vector512 support for IsValidCore


khushal1996 Jul 13, 2023
b939585

addressing review comments


khushal1996 Jul 14, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


16 changes: 16 additions & 0 deletions
src/libraries/System.Private.CoreLib/src/System/Text/Ascii.Utility.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1499,6 +1499,22 @@ private static bool AllCharsInVectorAreAscii<T>(Vector256<T> vector)
 }
 }

 [MethodImpl(MethodImplOptions.AggressiveInlining)]
 private static bool AllCharsInVectorAreAscii<T>(Vector512<T> vector)
 where T : unmanaged
 {
 Debug.Assert(typeof(T) == typeof(byte) || typeof(T) == typeof(ushort));

 if (typeof(T) == typeof(byte))
 {
 return vector.AsByte().ExtractMostSignificantBits() == 0;
 }
 else
 {
 return (vector.AsUInt16() & Vector512.Create((ushort)0xFF80)) == Vector512<ushort>.Zero;
 }
 }

 [MethodImpl(MethodImplOptions.AggressiveInlining)]
 private static Vector128<byte> ExtractAsciiVector(Vector128<ushort> vectorFirst, Vector128<ushort> vectorSecond)
 {
Expand Down

63 changes: 62 additions & 1 deletion
src/libraries/System.Private.CoreLib/src/System/Text/Ascii.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -113,7 +113,68 @@ private static unsafe bool IsValidCore<T>(ref T searchSpace, int length) where T
 Vector128.LoadUnsafe(ref Unsafe.Subtract(ref searchSpaceEnd, Vector128<T>.Count)));
 }

 if (Avx.IsSupported)
 if (Vector512.IsHardwareAccelerated && length >= Vector512<T>.Count)
 {
 // Process inputs with lengths [65, 128] bytes.
 if (length <= 2 * Vector512<T>.Count)
 {
 return AllCharsInVectorAreAscii(
 Vector512.LoadUnsafe(ref searchSpace) |
 Vector512.LoadUnsafe(ref Unsafe.Subtract(ref searchSpaceEnd, Vector512<T>.Count)));
 }

 // Process long inputs 256 bytes at a time.
 if (length > 4 * Vector512<T>.Count)
 {
 // Process the first 256 bytes.
 if (!AllCharsInVectorAreAscii(
 Vector512.LoadUnsafe(ref searchSpace) |
 Vector512.LoadUnsafe(ref searchSpace, (nuint)Vector512<T>.Count) |
 Vector512.LoadUnsafe(ref searchSpace, 2 * (nuint)Vector512<T>.Count) |
 Vector512.LoadUnsafe(ref searchSpace, 3 * (nuint)Vector512<T>.Count)))
 {
 return false;
 }

 nuint i = 4 * (nuint)Vector512<T>.Count;

 // Try to opportunistically align the reads below. The input isn't pinned, so the GC
 // is free to move the references. We're therefore assuming that reads may still be unaligned.
 // They may also be unaligned if the input chars aren't 2-byte aligned.
 nuint misalignedElements = ((nuint)Unsafe.AsPointer(ref searchSpace) & (nuint)(Vector512<byte>.Count - 1)) / (nuint)sizeof(T);
 i -= misalignedElements;
 Debug.Assert((int)i > 3 * Vector512<T>.Count);

 nuint finalStart = (nuint)length - 4 * (nuint)Vector512<T>.Count;

 for (; i < finalStart; i += 4 * (nuint)Vector512<T>.Count)
 {
 ref T current = ref Unsafe.Add(ref searchSpace, i);

 if (!AllCharsInVectorAreAscii(
 Vector512.LoadUnsafe(ref current) |
 Vector512.LoadUnsafe(ref current, (nuint)Vector512<T>.Count) |
 Vector512.LoadUnsafe(ref current, 2 * (nuint)Vector512<T>.Count) |
 Vector512.LoadUnsafe(ref current, 3 * (nuint)Vector512<T>.Count)))
 {
 return false;
 }
 }

 searchSpace = ref Unsafe.Add(ref searchSpace, finalStart);
 }

 // Process the last [1, 256] bytes.
 // The search space has at least 2 * Vector512 bytes available to read.
 // We process the first 2 and last 2 vectors, which may overlap.
 return AllCharsInVectorAreAscii(
 Vector512.LoadUnsafe(ref searchSpace) |
 Vector512.LoadUnsafe(ref searchSpace, (nuint)Vector512<T>.Count) |
 Vector512.LoadUnsafe(ref Unsafe.Subtract(ref searchSpaceEnd, 2 * Vector512<T>.Count)) |
 Vector512.LoadUnsafe(ref Unsafe.Subtract(ref searchSpaceEnd, Vector512<T>.Count)));
 }

 else if (Avx.IsSupported)
 {
 // Process inputs with lengths [33, 64] bytes.
 if (length <= 2 * Vector256<T>.Count)
Expand Down

7 changes: 6 additions & 1 deletion
src/libraries/System.Text.Encoding/tests/Ascii/IsValidByteTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,12 @@ public static void EmptyInput_ReturnsTrue()
 Vector128<byte>.Count + 1,
 Vector256<byte>.Count - 1,
 Vector256<byte>.Count,
 Vector256<byte>.Count + 1 };
 Vector256<byte>.Count + 1,
 Vector512<byte>.Count - 1,
 Vector512<byte>.Count,
 Vector512<byte>.Count + 1,
 4*Vector512<byte>.Count,
 4*Vector512<byte>.Count + 1 };

 public static IEnumerable<object[]> AsciiOnlyBuffers
 {
Expand Down

7 changes: 6 additions & 1 deletion
src/libraries/System.Text.Encoding/tests/Ascii/IsValidCharTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,12 @@ public static void EmptyInput_ReturnsTrue()
 Vector128<short>.Count + 1,
 Vector256<short>.Count - 1,
 Vector256<short>.Count,
 Vector256<short>.Count + 1 };
 Vector256<short>.Count + 1,
 Vector512<short>.Count - 1,
 Vector512<short>.Count,
 Vector512<short>.Count + 1,
 4*Vector512<short>.Count,
 4*Vector512<short>.Count + 1 };

 public static IEnumerable<object[]> AsciiOnlyBuffers
 {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Light up Ascii.IsValidCore with Vector512 code path by khushal1996 · Pull Request #88872 · dotnet/runtime · GitHub
Skip to content
Light up Ascii.IsValidCore with Vector512 code path#88872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

khushal1996
wants to merge
4
commits into

from

 Closed


Light up Ascii.IsValidCore with Vector512 code path
#88872
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
3126811

initial implementation for accelerating isValidCore


khushal1996 Jul 13, 2023
30e6708

adding proper size for processing Vector 512


khushal1996 Jul 13, 2023
2fddeb6

Adding Vector512 support for IsValidCore


khushal1996 Jul 13, 2023
b939585

addressing review comments


khushal1996 Jul 14, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


16 changes: 16 additions & 0 deletions
src/libraries/System.Private.CoreLib/src/System/Text/Ascii.Utility.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1499,6 +1499,22 @@ private static bool AllCharsInVectorAreAscii<T>(Vector256<T> vector)
 }
 }

 [MethodImpl(MethodImplOptions.AggressiveInlining)]
 private static bool AllCharsInVectorAreAscii<T>(Vector512<T> vector)
 where T : unmanaged
 {
 Debug.Assert(typeof(T) == typeof(byte) || typeof(T) == typeof(ushort));

 if (typeof(T) == typeof(byte))
 {
 return vector.AsByte().ExtractMostSignificantBits() == 0;
 }
 else
 {
 return (vector.AsUInt16() & Vector512.Create((ushort)0xFF80)) == Vector512<ushort>.Zero;
 }
 }

 [MethodImpl(MethodImplOptions.AggressiveInlining)]
 private static Vector128<byte> ExtractAsciiVector(Vector128<ushort> vectorFirst, Vector128<ushort> vectorSecond)
 {
Expand Down

63 changes: 62 additions & 1 deletion
src/libraries/System.Private.CoreLib/src/System/Text/Ascii.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -113,7 +113,68 @@ private static unsafe bool IsValidCore<T>(ref T searchSpace, int length) where T
 Vector128.LoadUnsafe(ref Unsafe.Subtract(ref searchSpaceEnd, Vector128<T>.Count)));
 }

 if (Avx.IsSupported)
 if (Vector512.IsHardwareAccelerated && length >= Vector512<T>.Count)
 {
 // Process inputs with lengths [65, 128] bytes.
 if (length <= 2 * Vector512<T>.Count)
 {
 return AllCharsInVectorAreAscii(
 Vector512.LoadUnsafe(ref searchSpace) |
 Vector512.LoadUnsafe(ref Unsafe.Subtract(ref searchSpaceEnd, Vector512<T>.Count)));
 }

 // Process long inputs 256 bytes at a time.
 if (length > 4 * Vector512<T>.Count)
 {
 // Process the first 256 bytes.
 if (!AllCharsInVectorAreAscii(
 Vector512.LoadUnsafe(ref searchSpace) |
 Vector512.LoadUnsafe(ref searchSpace, (nuint)Vector512<T>.Count) |
 Vector512.LoadUnsafe(ref searchSpace, 2 * (nuint)Vector512<T>.Count) |
 Vector512.LoadUnsafe(ref searchSpace, 3 * (nuint)Vector512<T>.Count)))
 {
 return false;
 }

 nuint i = 4 * (nuint)Vector512<T>.Count;

 // Try to opportunistically align the reads below. The input isn't pinned, so the GC
 // is free to move the references. We're therefore assuming that reads may still be unaligned.
 // They may also be unaligned if the input chars aren't 2-byte aligned.
 nuint misalignedElements = ((nuint)Unsafe.AsPointer(ref searchSpace) & (nuint)(Vector512<byte>.Count - 1)) / (nuint)sizeof(T);
 i -= misalignedElements;
 Debug.Assert((int)i > 3 * Vector512<T>.Count);

 nuint finalStart = (nuint)length - 4 * (nuint)Vector512<T>.Count;

 for (; i < finalStart; i += 4 * (nuint)Vector512<T>.Count)
 {
 ref T current = ref Unsafe.Add(ref searchSpace, i);

 if (!AllCharsInVectorAreAscii(
 Vector512.LoadUnsafe(ref current) |
 Vector512.LoadUnsafe(ref current, (nuint)Vector512<T>.Count) |
 Vector512.LoadUnsafe(ref current, 2 * (nuint)Vector512<T>.Count) |
 Vector512.LoadUnsafe(ref current, 3 * (nuint)Vector512<T>.Count)))
 {
 return false;
 }
 }

 searchSpace = ref Unsafe.Add(ref searchSpace, finalStart);
 }

 // Process the last [1, 256] bytes.
 // The search space has at least 2 * Vector512 bytes available to read.
 // We process the first 2 and last 2 vectors, which may overlap.
 return AllCharsInVectorAreAscii(
 Vector512.LoadUnsafe(ref searchSpace) |
 Vector512.LoadUnsafe(ref searchSpace, (nuint)Vector512<T>.Count) |
 Vector512.LoadUnsafe(ref Unsafe.Subtract(ref searchSpaceEnd, 2 * Vector512<T>.Count)) |
 Vector512.LoadUnsafe(ref Unsafe.Subtract(ref searchSpaceEnd, Vector512<T>.Count)));
 }

 else if (Avx.IsSupported)
 {
 // Process inputs with lengths [33, 64] bytes.
 if (length <= 2 * Vector256<T>.Count)
Expand Down

7 changes: 6 additions & 1 deletion
src/libraries/System.Text.Encoding/tests/Ascii/IsValidByteTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,12 @@ public static void EmptyInput_ReturnsTrue()
 Vector128<byte>.Count + 1,
 Vector256<byte>.Count - 1,
 Vector256<byte>.Count,
 Vector256<byte>.Count + 1 };
 Vector256<byte>.Count + 1,
 Vector512<byte>.Count - 1,
 Vector512<byte>.Count,
 Vector512<byte>.Count + 1,
 4*Vector512<byte>.Count,
 4*Vector512<byte>.Count + 1 };

 public static IEnumerable<object[]> AsciiOnlyBuffers
 {
Expand Down

7 changes: 6 additions & 1 deletion
src/libraries/System.Text.Encoding/tests/Ascii/IsValidCharTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,12 @@ public static void EmptyInput_ReturnsTrue()
 Vector128<short>.Count + 1,
 Vector256<short>.Count - 1,
 Vector256<short>.Count,
 Vector256<short>.Count + 1 };
 Vector256<short>.Count + 1,
 Vector512<short>.Count - 1,
 Vector512<short>.Count,
 Vector512<short>.Count + 1,
 4*Vector512<short>.Count,
 4*Vector512<short>.Count + 1 };

 public static IEnumerable<object[]> AsciiOnlyBuffers
 {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Light up Ascii.IsValidCore with Vector512 code path by khushal1996 · Pull Request #88872 · dotnet/runtime · GitHub
Skip to content
Light up Ascii.IsValidCore with Vector512 code path#88872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

khushal1996
wants to merge
4
commits into

from

 Closed


Light up Ascii.IsValidCore with Vector512 code path
#88872
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
3126811

initial implementation for accelerating isValidCore


khushal1996 Jul 13, 2023
30e6708

adding proper size for processing Vector 512


khushal1996 Jul 13, 2023
2fddeb6

Adding Vector512 support for IsValidCore


khushal1996 Jul 13, 2023
b939585

addressing review comments


khushal1996 Jul 14, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


16 changes: 16 additions & 0 deletions
src/libraries/System.Private.CoreLib/src/System/Text/Ascii.Utility.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1499,6 +1499,22 @@ private static bool AllCharsInVectorAreAscii<T>(Vector256<T> vector)
 }
 }

 [MethodImpl(MethodImplOptions.AggressiveInlining)]
 private static bool AllCharsInVectorAreAscii<T>(Vector512<T> vector)
 where T : unmanaged
 {
 Debug.Assert(typeof(T) == typeof(byte) || typeof(T) == typeof(ushort));

 if (typeof(T) == typeof(byte))
 {
 return vector.AsByte().ExtractMostSignificantBits() == 0;
 }
 else
 {
 return (vector.AsUInt16() & Vector512.Create((ushort)0xFF80)) == Vector512<ushort>.Zero;
 }
 }

 [MethodImpl(MethodImplOptions.AggressiveInlining)]
 private static Vector128<byte> ExtractAsciiVector(Vector128<ushort> vectorFirst, Vector128<ushort> vectorSecond)
 {
Expand Down

63 changes: 62 additions & 1 deletion
src/libraries/System.Private.CoreLib/src/System/Text/Ascii.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -113,7 +113,68 @@ private static unsafe bool IsValidCore<T>(ref T searchSpace, int length) where T
 Vector128.LoadUnsafe(ref Unsafe.Subtract(ref searchSpaceEnd, Vector128<T>.Count)));
 }

 if (Avx.IsSupported)
 if (Vector512.IsHardwareAccelerated && length >= Vector512<T>.Count)
 {
 // Process inputs with lengths [65, 128] bytes.
 if (length <= 2 * Vector512<T>.Count)
 {
 return AllCharsInVectorAreAscii(
 Vector512.LoadUnsafe(ref searchSpace) |
 Vector512.LoadUnsafe(ref Unsafe.Subtract(ref searchSpaceEnd, Vector512<T>.Count)));
 }

 // Process long inputs 256 bytes at a time.
 if (length > 4 * Vector512<T>.Count)
 {
 // Process the first 256 bytes.
 if (!AllCharsInVectorAreAscii(
 Vector512.LoadUnsafe(ref searchSpace) |
 Vector512.LoadUnsafe(ref searchSpace, (nuint)Vector512<T>.Count) |
 Vector512.LoadUnsafe(ref searchSpace, 2 * (nuint)Vector512<T>.Count) |
 Vector512.LoadUnsafe(ref searchSpace, 3 * (nuint)Vector512<T>.Count)))
 {
 return false;
 }

 nuint i = 4 * (nuint)Vector512<T>.Count;

 // Try to opportunistically align the reads below. The input isn't pinned, so the GC
 // is free to move the references. We're therefore assuming that reads may still be unaligned.
 // They may also be unaligned if the input chars aren't 2-byte aligned.
 nuint misalignedElements = ((nuint)Unsafe.AsPointer(ref searchSpace) & (nuint)(Vector512<byte>.Count - 1)) / (nuint)sizeof(T);
 i -= misalignedElements;
 Debug.Assert((int)i > 3 * Vector512<T>.Count);

 nuint finalStart = (nuint)length - 4 * (nuint)Vector512<T>.Count;

 for (; i < finalStart; i += 4 * (nuint)Vector512<T>.Count)
 {
 ref T current = ref Unsafe.Add(ref searchSpace, i);

 if (!AllCharsInVectorAreAscii(
 Vector512.LoadUnsafe(ref current) |
 Vector512.LoadUnsafe(ref current, (nuint)Vector512<T>.Count) |
 Vector512.LoadUnsafe(ref current, 2 * (nuint)Vector512<T>.Count) |
 Vector512.LoadUnsafe(ref current, 3 * (nuint)Vector512<T>.Count)))
 {
 return false;
 }
 }

 searchSpace = ref Unsafe.Add(ref searchSpace, finalStart);
 }

 // Process the last [1, 256] bytes.
 // The search space has at least 2 * Vector512 bytes available to read.
 // We process the first 2 and last 2 vectors, which may overlap.
 return AllCharsInVectorAreAscii(
 Vector512.LoadUnsafe(ref searchSpace) |
 Vector512.LoadUnsafe(ref searchSpace, (nuint)Vector512<T>.Count) |
 Vector512.LoadUnsafe(ref Unsafe.Subtract(ref searchSpaceEnd, 2 * Vector512<T>.Count)) |
 Vector512.LoadUnsafe(ref Unsafe.Subtract(ref searchSpaceEnd, Vector512<T>.Count)));
 }

 else if (Avx.IsSupported)
 {
 // Process inputs with lengths [33, 64] bytes.
 if (length <= 2 * Vector256<T>.Count)
Expand Down

7 changes: 6 additions & 1 deletion
src/libraries/System.Text.Encoding/tests/Ascii/IsValidByteTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,12 @@ public static void EmptyInput_ReturnsTrue()
 Vector128<byte>.Count + 1,
 Vector256<byte>.Count - 1,
 Vector256<byte>.Count,
 Vector256<byte>.Count + 1 };
 Vector256<byte>.Count + 1,
 Vector512<byte>.Count - 1,
 Vector512<byte>.Count,
 Vector512<byte>.Count + 1,
 4*Vector512<byte>.Count,
 4*Vector512<byte>.Count + 1 };

 public static IEnumerable<object[]> AsciiOnlyBuffers
 {
Expand Down

7 changes: 6 additions & 1 deletion
src/libraries/System.Text.Encoding/tests/Ascii/IsValidCharTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,12 @@ public static void EmptyInput_ReturnsTrue()
 Vector128<short>.Count + 1,
 Vector256<short>.Count - 1,
 Vector256<short>.Count,
 Vector256<short>.Count + 1 };
 Vector256<short>.Count + 1,
 Vector512<short>.Count - 1,
 Vector512<short>.Count,
 Vector512<short>.Count + 1,
 4*Vector512<short>.Count,
 4*Vector512<short>.Count + 1 };

 public static IEnumerable<object[]> AsciiOnlyBuffers
 {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Light up Ascii.IsValidCore with Vector512 code path by khushal1996 · Pull Request #88872 · dotnet/runtime · GitHub
Skip to content
Light up Ascii.IsValidCore with Vector512 code path#88872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

khushal1996
wants to merge
4
commits into

from

 Closed


Light up Ascii.IsValidCore with Vector512 code path
#88872
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
3126811

initial implementation for accelerating isValidCore


khushal1996 Jul 13, 2023
30e6708

adding proper size for processing Vector 512


khushal1996 Jul 13, 2023
2fddeb6

Adding Vector512 support for IsValidCore


khushal1996 Jul 13, 2023
b939585

addressing review comments


khushal1996 Jul 14, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


16 changes: 16 additions & 0 deletions
src/libraries/System.Private.CoreLib/src/System/Text/Ascii.Utility.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1499,6 +1499,22 @@ private static bool AllCharsInVectorAreAscii<T>(Vector256<T> vector)
 }
 }

 [MethodImpl(MethodImplOptions.AggressiveInlining)]
 private static bool AllCharsInVectorAreAscii<T>(Vector512<T> vector)
 where T : unmanaged
 {
 Debug.Assert(typeof(T) == typeof(byte) || typeof(T) == typeof(ushort));

 if (typeof(T) == typeof(byte))
 {
 return vector.AsByte().ExtractMostSignificantBits() == 0;
 }
 else
 {
 return (vector.AsUInt16() & Vector512.Create((ushort)0xFF80)) == Vector512<ushort>.Zero;
 }
 }

 [MethodImpl(MethodImplOptions.AggressiveInlining)]
 private static Vector128<byte> ExtractAsciiVector(Vector128<ushort> vectorFirst, Vector128<ushort> vectorSecond)
 {
Expand Down

63 changes: 62 additions & 1 deletion
src/libraries/System.Private.CoreLib/src/System/Text/Ascii.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -113,7 +113,68 @@ private static unsafe bool IsValidCore<T>(ref T searchSpace, int length) where T
 Vector128.LoadUnsafe(ref Unsafe.Subtract(ref searchSpaceEnd, Vector128<T>.Count)));
 }

 if (Avx.IsSupported)
 if (Vector512.IsHardwareAccelerated && length >= Vector512<T>.Count)
 {
 // Process inputs with lengths [65, 128] bytes.
 if (length <= 2 * Vector512<T>.Count)
 {
 return AllCharsInVectorAreAscii(
 Vector512.LoadUnsafe(ref searchSpace) |
 Vector512.LoadUnsafe(ref Unsafe.Subtract(ref searchSpaceEnd, Vector512<T>.Count)));
 }

 // Process long inputs 256 bytes at a time.
 if (length > 4 * Vector512<T>.Count)
 {
 // Process the first 256 bytes.
 if (!AllCharsInVectorAreAscii(
 Vector512.LoadUnsafe(ref searchSpace) |
 Vector512.LoadUnsafe(ref searchSpace, (nuint)Vector512<T>.Count) |
 Vector512.LoadUnsafe(ref searchSpace, 2 * (nuint)Vector512<T>.Count) |
 Vector512.LoadUnsafe(ref searchSpace, 3 * (nuint)Vector512<T>.Count)))
 {
 return false;
 }

 nuint i = 4 * (nuint)Vector512<T>.Count;

 // Try to opportunistically align the reads below. The input isn't pinned, so the GC
 // is free to move the references. We're therefore assuming that reads may still be unaligned.
 // They may also be unaligned if the input chars aren't 2-byte aligned.
 nuint misalignedElements = ((nuint)Unsafe.AsPointer(ref searchSpace) & (nuint)(Vector512<byte>.Count - 1)) / (nuint)sizeof(T);
 i -= misalignedElements;
 Debug.Assert((int)i > 3 * Vector512<T>.Count);

 nuint finalStart = (nuint)length - 4 * (nuint)Vector512<T>.Count;

 for (; i < finalStart; i += 4 * (nuint)Vector512<T>.Count)
 {
 ref T current = ref Unsafe.Add(ref searchSpace, i);

 if (!AllCharsInVectorAreAscii(
 Vector512.LoadUnsafe(ref current) |
 Vector512.LoadUnsafe(ref current, (nuint)Vector512<T>.Count) |
 Vector512.LoadUnsafe(ref current, 2 * (nuint)Vector512<T>.Count) |
 Vector512.LoadUnsafe(ref current, 3 * (nuint)Vector512<T>.Count)))
 {
 return false;
 }
 }

 searchSpace = ref Unsafe.Add(ref searchSpace, finalStart);
 }

 // Process the last [1, 256] bytes.
 // The search space has at least 2 * Vector512 bytes available to read.
 // We process the first 2 and last 2 vectors, which may overlap.
 return AllCharsInVectorAreAscii(
 Vector512.LoadUnsafe(ref searchSpace) |
 Vector512.LoadUnsafe(ref searchSpace, (nuint)Vector512<T>.Count) |
 Vector512.LoadUnsafe(ref Unsafe.Subtract(ref searchSpaceEnd, 2 * Vector512<T>.Count)) |
 Vector512.LoadUnsafe(ref Unsafe.Subtract(ref searchSpaceEnd, Vector512<T>.Count)));
 }

 else if (Avx.IsSupported)
 {
 // Process inputs with lengths [33, 64] bytes.
 if (length <= 2 * Vector256<T>.Count)
Expand Down

7 changes: 6 additions & 1 deletion
src/libraries/System.Text.Encoding/tests/Ascii/IsValidByteTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,12 @@ public static void EmptyInput_ReturnsTrue()
 Vector128<byte>.Count + 1,
 Vector256<byte>.Count - 1,
 Vector256<byte>.Count,
 Vector256<byte>.Count + 1 };
 Vector256<byte>.Count + 1,
 Vector512<byte>.Count - 1,
 Vector512<byte>.Count,
 Vector512<byte>.Count + 1,
 4*Vector512<byte>.Count,
 4*Vector512<byte>.Count + 1 };

 public static IEnumerable<object[]> AsciiOnlyBuffers
 {
Expand Down

7 changes: 6 additions & 1 deletion
src/libraries/System.Text.Encoding/tests/Ascii/IsValidCharTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,12 @@ public static void EmptyInput_ReturnsTrue()
 Vector128<short>.Count + 1,
 Vector256<short>.Count - 1,
 Vector256<short>.Count,
 Vector256<short>.Count + 1 };
 Vector256<short>.Count + 1,
 Vector512<short>.Count - 1,
 Vector512<short>.Count,
 Vector512<short>.Count + 1,
 4*Vector512<short>.Count,
 4*Vector512<short>.Count + 1 };

 public static IEnumerable<object[]> AsciiOnlyBuffers
 {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Light up Ascii.IsValidCore with Vector512 code path by khushal1996 · Pull Request #88872 · dotnet/runtime · GitHub
Skip to content
Light up Ascii.IsValidCore with Vector512 code path#88872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

khushal1996
wants to merge
4
commits into

from

 Closed


Light up Ascii.IsValidCore with Vector512 code path
#88872
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
3126811

initial implementation for accelerating isValidCore


khushal1996 Jul 13, 2023
30e6708

adding proper size for processing Vector 512


khushal1996 Jul 13, 2023
2fddeb6

Adding Vector512 support for IsValidCore


khushal1996 Jul 13, 2023
b939585

addressing review comments


khushal1996 Jul 14, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


16 changes: 16 additions & 0 deletions
src/libraries/System.Private.CoreLib/src/System/Text/Ascii.Utility.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1499,6 +1499,22 @@ private static bool AllCharsInVectorAreAscii<T>(Vector256<T> vector)
 }
 }

 [MethodImpl(MethodImplOptions.AggressiveInlining)]
 private static bool AllCharsInVectorAreAscii<T>(Vector512<T> vector)
 where T : unmanaged
 {
 Debug.Assert(typeof(T) == typeof(byte) || typeof(T) == typeof(ushort));

 if (typeof(T) == typeof(byte))
 {
 return vector.AsByte().ExtractMostSignificantBits() == 0;
 }
 else
 {
 return (vector.AsUInt16() & Vector512.Create((ushort)0xFF80)) == Vector512<ushort>.Zero;
 }
 }

 [MethodImpl(MethodImplOptions.AggressiveInlining)]
 private static Vector128<byte> ExtractAsciiVector(Vector128<ushort> vectorFirst, Vector128<ushort> vectorSecond)
 {
Expand Down

63 changes: 62 additions & 1 deletion
src/libraries/System.Private.CoreLib/src/System/Text/Ascii.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -113,7 +113,68 @@ private static unsafe bool IsValidCore<T>(ref T searchSpace, int length) where T
 Vector128.LoadUnsafe(ref Unsafe.Subtract(ref searchSpaceEnd, Vector128<T>.Count)));
 }

 if (Avx.IsSupported)
 if (Vector512.IsHardwareAccelerated && length >= Vector512<T>.Count)
 {
 // Process inputs with lengths [65, 128] bytes.
 if (length <= 2 * Vector512<T>.Count)
 {
 return AllCharsInVectorAreAscii(
 Vector512.LoadUnsafe(ref searchSpace) |
 Vector512.LoadUnsafe(ref Unsafe.Subtract(ref searchSpaceEnd, Vector512<T>.Count)));
 }

 // Process long inputs 256 bytes at a time.
 if (length > 4 * Vector512<T>.Count)
 {
 // Process the first 256 bytes.
 if (!AllCharsInVectorAreAscii(
 Vector512.LoadUnsafe(ref searchSpace) |
 Vector512.LoadUnsafe(ref searchSpace, (nuint)Vector512<T>.Count) |
 Vector512.LoadUnsafe(ref searchSpace, 2 * (nuint)Vector512<T>.Count) |
 Vector512.LoadUnsafe(ref searchSpace, 3 * (nuint)Vector512<T>.Count)))
 {
 return false;
 }

 nuint i = 4 * (nuint)Vector512<T>.Count;

 // Try to opportunistically align the reads below. The input isn't pinned, so the GC
 // is free to move the references. We're therefore assuming that reads may still be unaligned.
 // They may also be unaligned if the input chars aren't 2-byte aligned.
 nuint misalignedElements = ((nuint)Unsafe.AsPointer(ref searchSpace) & (nuint)(Vector512<byte>.Count - 1)) / (nuint)sizeof(T);
 i -= misalignedElements;
 Debug.Assert((int)i > 3 * Vector512<T>.Count);

 nuint finalStart = (nuint)length - 4 * (nuint)Vector512<T>.Count;

 for (; i < finalStart; i += 4 * (nuint)Vector512<T>.Count)
 {
 ref T current = ref Unsafe.Add(ref searchSpace, i);

 if (!AllCharsInVectorAreAscii(
 Vector512.LoadUnsafe(ref current) |
 Vector512.LoadUnsafe(ref current, (nuint)Vector512<T>.Count) |
 Vector512.LoadUnsafe(ref current, 2 * (nuint)Vector512<T>.Count) |
 Vector512.LoadUnsafe(ref current, 3 * (nuint)Vector512<T>.Count)))
 {
 return false;
 }
 }

 searchSpace = ref Unsafe.Add(ref searchSpace, finalStart);
 }

 // Process the last [1, 256] bytes.
 // The search space has at least 2 * Vector512 bytes available to read.
 // We process the first 2 and last 2 vectors, which may overlap.
 return AllCharsInVectorAreAscii(
 Vector512.LoadUnsafe(ref searchSpace) |
 Vector512.LoadUnsafe(ref searchSpace, (nuint)Vector512<T>.Count) |
 Vector512.LoadUnsafe(ref Unsafe.Subtract(ref searchSpaceEnd, 2 * Vector512<T>.Count)) |
 Vector512.LoadUnsafe(ref Unsafe.Subtract(ref searchSpaceEnd, Vector512<T>.Count)));
 }

 else if (Avx.IsSupported)
 {
 // Process inputs with lengths [33, 64] bytes.
 if (length <= 2 * Vector256<T>.Count)
Expand Down

7 changes: 6 additions & 1 deletion
src/libraries/System.Text.Encoding/tests/Ascii/IsValidByteTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,12 @@ public static void EmptyInput_ReturnsTrue()
 Vector128<byte>.Count + 1,
 Vector256<byte>.Count - 1,
 Vector256<byte>.Count,
 Vector256<byte>.Count + 1 };
 Vector256<byte>.Count + 1,
 Vector512<byte>.Count - 1,
 Vector512<byte>.Count,
 Vector512<byte>.Count + 1,
 4*Vector512<byte>.Count,
 4*Vector512<byte>.Count + 1 };

 public static IEnumerable<object[]> AsciiOnlyBuffers
 {
Expand Down

7 changes: 6 additions & 1 deletion
src/libraries/System.Text.Encoding/tests/Ascii/IsValidCharTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,12 @@ public static void EmptyInput_ReturnsTrue()
 Vector128<short>.Count + 1,
 Vector256<short>.Count - 1,
 Vector256<short>.Count,
 Vector256<short>.Count + 1 };
 Vector256<short>.Count + 1,
 Vector512<short>.Count - 1,
 Vector512<short>.Count,
 Vector512<short>.Count + 1,
 4*Vector512<short>.Count,
 4*Vector512<short>.Count + 1 };

 public static IEnumerable<object[]> AsciiOnlyBuffers
 {
Expand Down