') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Remove incorrect flag setting by MichalStrehovsky · Pull Request #88878 · dotnet/runtime · GitHub
Skip to content

Remove incorrect flag setting - #88878

Merged
MichalStrehovsky merged 1 commit into
mainfrom
MichalStrehovsky-patch-2
Jul 22, 2023
Merged

Remove incorrect flag setting#88878
MichalStrehovsky merged 1 commit into
mainfrom
MichalStrehovsky-patch-2

Conversation

@MichalStrehovsky

@MichalStrehovskyMichalStrehovsky commented Jul 14, 2023•
edited
Loading

Copy link
Copy Markdown
Member

This was added in #85743 (comment). Setting this flag is not the right thing to do. It sweeps issues under the carpet. Also, we're only doing it for signature type variables, not method variable. And since no tests seem to be failing, it might not even be necessary.

@ghostghost added the area-ReadyToRun label Jul 14, 2023
@MichalStrehovsky

MichalStrehovsky commented Jul 14, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr crossgen2
/azp run runtime-coreclr crossgen2 outerloop

@azure-pipelines

azure-pipelinesBot commented Jul 14, 2023

Copy link
Copy Markdown
No pipelines are associated with this pull request.

@MichalStrehovsky

MichalStrehovsky commented Jul 14, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr crossgen2
/azp run runtime-coreclr crossgen2 outerloop

@azure-pipelines

azure-pipelinesBot commented Jul 14, 2023

Copy link
Copy Markdown
No pipelines are associated with this pull request.

@MichalStrehovsky

MichalStrehovsky commented Jul 14, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr crossgen2
/azp run runtime-coreclr crossgen2 outerloop

@azure-pipelines

azure-pipelinesBot commented Jul 14, 2023

Copy link
Copy Markdown

No commit pushedDate could be found for PR 88878 in repo dotnet/runtime

This was referenced Jul 14, 2023
Closed
Closed
@MichalStrehovsky

MichalStrehovsky commented Jul 14, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr crossgen2
/azp run runtime-coreclr crossgen2 outerloop

@azure-pipelines

azure-pipelinesBot commented Jul 14, 2023

Copy link
Copy Markdown
No pipelines are associated with this pull request.

@MichalStrehovsky

MichalStrehovsky commented Jul 17, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr crossgen2
/azp run runtime-coreclr crossgen2 outerloop

@azure-pipelines

azure-pipelinesBot commented Jul 17, 2023

Copy link
Copy Markdown
No pipelines are associated with this pull request.

@MichalStrehovsky

MichalStrehovsky commented Jul 19, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr crossgen2
/azp run runtime-coreclr crossgen2 outerloop

@azure-pipelines

azure-pipelinesBot commented Jul 19, 2023

Copy link
Copy Markdown

No commit pushedDate could be found for PR 88878 in repo dotnet/runtime

@build-analysisbuild-analysisBot mentioned this pull request Jul 19, 2023
Closed
@MichalStrehovsky
MichalStrehovskyforce-pushed the MichalStrehovsky-patch-2 branch from 9009978 to 47d69aeCompareJuly 20, 2023 03:57
@MichalStrehovsky

MichalStrehovsky commented Jul 20, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr crossgen2
/azp run runtime-coreclr crossgen2 outerloop

@azure-pipelines

azure-pipelinesBot commented Jul 20, 2023

Copy link
Copy Markdown
No pipelines are associated with this pull request.

davidwrighton
davidwrighton approved these changes Jul 21, 2023
View reviewed changes

@davidwrightondavidwrighton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@MichalStrehovsky
MichalStrehovsky merged commit 3c7027a into mainJul 22, 2023
@MichalStrehovsky
MichalStrehovsky deleted the MichalStrehovsky-patch-2 branch July 22, 2023 06:19
@ghostghost locked as resolved and limited conversation to collaborators Aug 21, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@davidwrightondavidwrightondavidwrighton approved these changes

Assignees

@MichalStrehovskyMichalStrehovsky

Labels

area-ReadyToRun

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MichalStrehovsky@davidwrighton