Skip to content

Add SocketsHttpHandler connection metrics - #88893

Merged
MihaZupan merged 4 commits into
dotnet:mainfrom
MihaZupan:http-meter-3
Jul 14, 2023
Merged

Add SocketsHttpHandler connection metrics#88893
MihaZupan merged 4 commits into
dotnet:mainfrom
MihaZupan:http-meter-3

Conversation

@MihaZupan

@MihaZupanMihaZupan commented Jul 14, 2023

Copy link
Copy Markdown
Member

Closes#84978

Implements the following counters (final names TBD):

  • http-client-current-connections
  • http-client-current-idle-connections
  • http-client-connection-duration

Unlike the description from #84978, I dropped the reason tag from http-client-connection-duration as it feels out of place on the duration counter, and it's not clear what values we'd want to report.

Merge conflicts with #88853 are expected.

@MihaZupanMihaZupan added this to the 8.0.0 milestone Jul 14, 2023
@MihaZupanMihaZupan self-assigned this Jul 14, 2023
@ghost

ghost commented Jul 14, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes #84978

Implements the following counters (final names TBD):

  • http-client-current-connections
  • http-client-current-idle-connections
  • http-client-connection-duration

Unlike the description from #84978, I dropped the reason tag from http-client-connection-duration as it feels out of place on the duration counter, and it's not clear what values we'd want to report.

Merge conflicts with #88853 are expected.

Author:MihaZupan
Assignees:MihaZupan
Labels:

area-System.Net.Http

Milestone:8.0.0

@MihaZupan

MihaZupan commented Jul 14, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines

azure-pipelinesBot commented Jul 14, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 14, 2023
Closed
Closed
Closed
Closed
Closed
antonfirsov
antonfirsov approved these changes Jul 14, 2023
View reviewed changes

@antonfirsovantonfirsov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few questions and suggestions.

Comment thread...ries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Metrics/ConnectionMetricsInfo.cs Outdated
Comment thread...ries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Metrics/ConnectionMetricsInfo.cs
Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPool.cs Outdated
Comment thread...ries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Metrics/ConnectionMetricsInfo.cs Outdated
Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3Connection.cs
@MihaZupan
MihaZupan merged commit bf74880 into dotnet:mainJul 14, 2023
@MihaZupanMihaZupan mentioned this pull request Jul 17, 2023
Merged
@simonrozsivalsimonrozsival mentioned this pull request Jul 20, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Aug 14, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@antonfirsovantonfirsovantonfirsov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@MihaZupanMihaZupan

Labels

area-System.Net.Http

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[API Proposal]: HttpClient/HttpMessageInvoker metrics

2 participants

@MihaZupan@antonfirsov