[WASM] Add ILStrip task to wasm app build process by fanyang-mono · Pull Request #88926 · dotnet/runtime

fanyang-mono · 2023-07-14T18:26:32Z

With this PR, the customer is able to create an WASM app and enabling IL trimming for AOT compiled methods. By default, this is disabled. To enable it, build the app with WasmStripILAfterAOT =true. This change help producing a smaller WASM app.

Impact of this change is displayed as follows. I measured the size of _framework after compression using brotli for wasm apps with AOT enabled:

Wasm app under src/mono/sample/wasm/browser
- 6.0M -> 5.8M (-p:WasmEnableWebcil=false) (3.3% smaller)
- 5.9M -> 5.8M (-p:WasmEnableWebcil=true) (1.7% smaller)
Wasm app under src/mono/sample/wasm/browser-bench
- 7.1M -> 6.8M (-p:WasmEnableWebcil=false) (4.2% smaller)
- 7.1M -> 6.8M (-p:WasmEnableWebcil=true) (4.2% smaller)

lewing · 2023-07-14T19:27:17Z

Are we confident that this handles all the cases where wasm might transition to the interpreter appropriately?

radical · 2023-07-14T20:15:00Z

Also, test needed in src/mono/wasm/Wasm.Build.Tests.

radical · 2023-07-14T20:16:06Z

And could you please add some detail about what the PR is doing, like what the default is for the property, and what it will do, and/or affect?

ghost · 2023-07-14T20:37:59Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #88696

Author:	fanyang-mono
Assignees:	fanyang-mono
Labels:	`arch-wasm`, `area-Build-mono`
Milestone:	-

…o for tiny methods

* Methods which have 'deopt' set can enter the interpreter during EH. * Methods which have 'interp_entry_only' set are AOTed, but the AOT code is only used to enter the interpreter.

lewing · 2023-07-26T19:25:41Z

cc @kg

…ion of it

fanyang-mono · 2023-07-27T23:20:54Z

Are we confident that this handles all the cases where wasm might transition to the interpreter appropriately?

I am trying to test it with as many apps as I could get a hold on before merging it. TBH, I can't guarantee that this feature is going to work 100% for all wasm apps, that's why it is off by default.

vargaz · 2023-08-09T14:34:42Z

The mono changes look ok to me.

lambdageek

LGTM. Consider changing WASMStripIL to WasmStripIL.

Is it worth calling out that this only makes sense with AOT right in the property name? Maybe WasmStripILAfterAOT ?

fanyang-mono · 2023-08-09T19:25:34Z

Will enable WASM AOT tests with WasmStripILAfterAOT =true in a follow-up PR.

Add ILStrip task to wasm app build process
3f632d1

fanyang-mono requested a review from SamMonoRT July 14, 2023 18:26

fanyang-mono requested a review from radical as a code owner July 14, 2023 18:26

ghost added the area-Build-mono label Jul 14, 2023

ghost assigned fanyang-mono Jul 14, 2023

lewing requested a review from vargaz July 14, 2023 19:25

vargaz reviewed Jul 14, 2023
View reviewed changes

Comment threadsrc/mono/wasm/build/WasmApp.Native.targets Outdated

radical reviewed Jul 14, 2023
View reviewed changes

Comment threadsrc/mono/wasm/build/WasmApp.InTree.targets

radical added the arch-wasm WebAssembly architecture label Jul 14, 2023

radical added this to the 8.0.0 milestone Jul 14, 2023

Make it work for wasm app building workflow
2f1765b

This was referenced Jul 16, 2023
Tracking issue for CI build timeouts #76454
Closed
LibraryImportGenerator.Unit.Tests crashed in CI #87951
Closed

fanyang-mono changed the title ~~[WASM] Add ILStrip task to wasm app build process~~[WASM][WIP] Add ILStrip task to wasm app build processJul 16, 2023

Interp: stop inlining stripped methods. ILStrip: set code size to zer…
cfd4c60
…o for tiny methods

fanyang-mono requested review from BrzVlad and kotlarmilos as code owners July 17, 2023 14:11

[mono][aot] Avoid adding some methods to the compiled method file.
074abf0
* Methods which have 'deopt' set can enter the interpreter during EH. * Methods which have 'interp_entry_only' set are AOTed, but the AOT code is only used to enter the interpreter.

vargaz requested a review from lambdageek as a code owner July 17, 2023 16:05

build-analysisBot mentioned this pull request Jul 17, 2023
Tests.System.TimeProviderTests.TestProviderTimer test failure #87477
Closed

fanyang-mono marked this pull request as draft July 26, 2023 20:20

fanyang-mono added 2 commits July 27, 2023 18:53

Only trim the methods that interpreter is able to call the aot'ed ver…
ae0c62a
…ion of it

Add default value and documentation for WASMStripIL
52a2a8c

fanyang-mono mentioned this pull request Jul 27, 2023
[Mono] Give ILStrip a namespace #89608
Open

Skip TestUtilities Reference
feead71

BrzVlad reviewed Aug 7, 2023
View reviewed changes

Comment threadsrc/mono/mono/mini/aot-compiler.c Outdated

Address review feedback
74fbf16

lambdageek reviewed Aug 7, 2023
View reviewed changes

Comment threadsrc/mono/mono/mini/interp/transform.c

build-analysisBot mentioned this pull request Aug 7, 2023
Insufficient memory of docker containers on CI dotnet/dnceng#450
Closed
3 tasks

fanyang-mono added 2 commits August 7, 2023 16:53

Merge branch 'main' into enable_il_trim_wasm
c2eb9e2

Change it to true
64bbd78

Change name to trimming eligible
859f10a

fanyang-mono requested a review from marek-safar as a code owner August 9, 2023 14:11

Merge branch 'main' into enable_il_trim_wasm
4d5203b

build-analysisBot mentioned this pull request Aug 9, 2023
[Test Failure] System.Net.Http.Functional.Tests.HttpClientHandlerTest_Http3.ServerSendsTrailingHeaders_Success #87552
Closed

lambdageek approved these changes Aug 9, 2023
View reviewed changes

Comment threadsrc/mono/wasm/build/WasmApp.targets Outdated

fanyang-mono added 2 commits August 9, 2023 15:17

Remove testing
eaf4f55

Address review feedback
0ac748c

kg reviewed Aug 9, 2023
View reviewed changes

Comment threadsrc/mono/mono/mini/aot-compiler.c Outdated

kg reviewed Aug 9, 2023
View reviewed changes

Comment threadsrc/mono/mono/mini/aot-compiler.c

kg reviewed Aug 9, 2023
View reviewed changes

Comment threadsrc/mono/mono/mini/aot-compiler.c Outdated

kg reviewed Aug 9, 2023
View reviewed changes

Comment threadsrc/mono/mono/mini/interp/interp.c Outdated

kg approved these changes Aug 9, 2023
View reviewed changes

fanyang-mono added 2 commits August 9, 2023 17:16

Address review feedback from Kate
5476bb1

Add a var for llvm_only
99b91be

fanyang-mono merged commit 867e185 into dotnet:mainAug 10, 2023

This was referenced Aug 11, 2023
[Xamarin.Android.Build.Tasks] implement $(AndroidStripILAfterAOT) dotnet/android#8172
Merged
What's new in .NET 8 RC 1 [WIP] dotnet/core#8439
Closed

ghost locked as resolved and limited conversation to collaborators Sep 10, 2023

Uh oh!

Conversation

fanyang-mono commented Jul 14, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lewing commented Jul 14, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

radical commented Jul 14, 2023

Uh oh!

radical commented Jul 14, 2023

Uh oh!

ghost commented Jul 14, 2023

Uh oh!

lewing commented Jul 26, 2023

Uh oh!

fanyang-mono commented Jul 27, 2023

Uh oh!

Uh oh!

Uh oh!

vargaz commented Aug 9, 2023

Uh oh!

lambdageek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fanyang-mono commented Aug 9, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

fanyang-mono commented Jul 14, 2023•
edited
Loading

lewing commented Jul 14, 2023•
edited
Loading