Skip to content

Fix use-out-of-scope in signature comparison - #88928

Merged
jkoritzinsky merged 5 commits into
dotnet:mainfrom
jkoritzinsky:asan-fixes
Jul 15, 2023
Merged

Fix use-out-of-scope in signature comparison#88928
jkoritzinsky merged 5 commits into
dotnet:mainfrom
jkoritzinsky:asan-fixes

Conversation

@jkoritzinsky

@jkoritzinskyjkoritzinsky commented Jul 14, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Propagate token list to callers by copying instead of passing an out-of-scope address.

Fixes a violation found by ASAN.

Fixes the underlying issue in #87807

This PR is blocking #74623 (the ASAN enabling PR) from being green.

@ghostghost added the area-Infrastructure-coreclr Only use for closed issues label Jul 14, 2023
@ghost

ghost commented Jul 14, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Propagate token list to callers by copying instead of passing an out-of-scope address.

Fixes a violation found by ASAN.

Fixes the underlying issue in #87807

Author:jkoritzinsky
Assignees:jkoritzinsky
Labels:

area-Infrastructure-coreclr

Milestone:-

@jkoritzinskyjkoritzinsky added area-VM-coreclr and removed area-Infrastructure-coreclr Only use for closed issues labels Jul 14, 2023
@jkoritzinskyjkoritzinsky added this to the 8.0.0 milestone Jul 14, 2023
@jkoritzinsky
jkoritzinsky marked this pull request as ready for review July 14, 2023 18:59
@jkoritzinskyjkoritzinsky added the blocking Marks issues that we want to fast track in order to unblock other important work label Jul 14, 2023
@jkoritzinskyjkoritzinsky mentioned this pull request Jul 14, 2023
Merged
AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Jul 14, 2023
View reviewed changes
Comment threadsrc/coreclr/vm/siginfo.cpp
AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Jul 14, 2023
View reviewed changes
Comment threadsrc/coreclr/vm/siginfo.hpp Outdated
AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Jul 14, 2023
View reviewed changes
Comment threadsrc/coreclr/vm/siginfo.cpp Outdated
AaronRobinsonMSFT
AaronRobinsonMSFT approved these changes Jul 14, 2023
View reviewed changes

@AaronRobinsonMSFTAaronRobinsonMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkoritzinsky

jkoritzinsky commented Jul 15, 2023

Copy link
Copy Markdown
MemberAuthor

Only failure is a timeout:

@jkoritzinsky
jkoritzinsky merged commit 2d1d727 into dotnet:mainJul 15, 2023
@jkoritzinsky
jkoritzinsky deleted the asan-fixes branch July 15, 2023 02:05
@ghostghost locked as resolved and limited conversation to collaborators Aug 14, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes
@jkotasjkotasAwaiting requested review from jkotas

Assignees

@jkoritzinskyjkoritzinsky

Labels

area-VM-coreclrblockingMarks issues that we want to fast track in order to unblock other important work

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jkoritzinsky@AaronRobinsonMSFT