add SendTo/ReceiveFrom with SocketAddress - #88970

Merged
wfurt merged 18 commits into
dotnet:mainfrom
wfurt:udp2
Aug 1, 2023
Merged

add SendTo/ReceiveFrom with SocketAddress#88970
wfurt merged 18 commits into
dotnet:mainfrom
wfurt:udp2

Conversation

@wfurt

@wfurtwfurt commented Jul 16, 2023•
edited
Loading

Copy link
Copy Markdown
Member

And uses new SocketAddress API. That spanifies some of the PAL code as prep for removal of Internal.SocketAddress.

fixes#86872
contributes to #87397
contributes to #30797

@ghostghost assigned wfurtJul 16, 2023
@ghost

ghost commented Jul 16, 2023

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost

ghost commented Jul 16, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

And uses new SocketAddress API. That spanifies some of the PAL code as prep for removal of Internal.SocketAddress.

Author:wfurt
Assignees:wfurt
Labels:

area-System.Net.Sockets, new-api-needs-documentation

Milestone:-

This was referenced Jul 17, 2023
Closed
Closed
This was referenced Jul 17, 2023
Closed
Closed
Closed
stephentoub
stephentoub reviewed Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddress.cs Outdated
stephentoub
stephentoub reviewed Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddress.cs Outdated
stephentoub
stephentoub reviewed Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/ref/System.Net.Sockets.cs
stephentoub
stephentoub reviewed Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs Outdated
stephentoub
stephentoub reviewed Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs Outdated
@build-analysisbuild-analysisBot mentioned this pull request Jul 18, 2023
Closed
@build-analysisbuild-analysisBot mentioned this pull request Jul 19, 2023
Closed
@wfurtwfurt changed the title Poc: add SendTo/ReceiveFrom with SocketAddressadd SendTo/ReceiveFrom with SocketAddressJul 19, 2023
@wfurt
wfurt requested a review from a teamJuly 19, 2023 16:52
@build-analysisbuild-analysisBot mentioned this pull request Jul 20, 2023
Open
5 tasks
stephentoub
stephentoub reviewed Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEventArgs.Windows.cs
out int bytesTransferred,
_socketFlags,
_socketAddress!.Buffer.AsSpan(),
_socketAddress!.InternalBuffer.AsSpan(),

@stephentoubstephentoubJul 27, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as earlier for these... we don't need to splice it down to Size?

stephentoub
stephentoub reviewed Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
// We can fail to get peer address on TCP
socketAddressLen = socketAddress.Length;
SocketAddressPal.Clear(socketAddress);
}

@stephentoubstephentoubJul 27, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a bug fix?

@wfurtwfurtJul 27, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure but possibly yes. On Windows we seems to get the address but it fails on Linux. Perhaps we can also check if this is TCP and get the value from RemoteEndPoint? I can write issue for improvement and investigation.
I had trouble because setting Size zero would throw. Alternatively we can allow it to indicate that the buffer does not have any valid address.

stephentoub
stephentoub reviewed Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs Outdated
stephentoub
stephentoub reviewed Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs Outdated
stephentoub
stephentoub reviewed Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs Outdated
stephentoub
stephentoub reviewed Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/ReceiveFrom.cs
stephentoub
stephentoub reviewed Jul 27, 2023
View reviewed changes

@stephentoubstephentoub left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my comments/questions, LGTM.

@stephentoub

stephentoub commented Jul 27, 2023

Copy link
Copy Markdown
Member

I assume SendToAsync / ReceiveFromAsync are coming in a follow-up PR?

@wfurt

wfurt commented Jul 27, 2023

Copy link
Copy Markdown
MemberAuthor

I assume SendToAsync / ReceiveFromAsync are coming in a follow-up PR?

yes. That needs more work to clean up Internal.SocketAddress in socket code.

@wfurt

wfurt commented Jul 28, 2023

Copy link
Copy Markdown
MemberAuthor

this should be ready for another review pass @stephentoub

stephentoub
stephentoub reviewed Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/Interop/Windows/WinSock/Interop.WSAConnect.cs Outdated
internal static partial SocketError WSAConnect(
SafeSocketHandle socketHandle,
byte[] socketAddress,
Span<byte> socketAddress,

@stephentoubstephentoubAug 1, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make the actual LibraryImport private, with an internal wrapper that doesn't take socketAddressSize? e.g.

[LibraryImport(Interop.Libraries.Ws2_32,SetLastError=true)]privatestaticpartialSocketErrorWSAConnect(SafeSocketHandlesocketHandle,Span<byte>socketAddress,intsocketAddressSize,IntPtrinBuffer,IntPtroutBuffer,IntPtrsQOS,IntPtrgQOS);internalstaticSocketErrorWSAConnect(SafeSocketHandlesocketHandle,Span<byte>socketAddress,IntPtrinBuffer,IntPtroutBuffer,IntPtrsQOS,IntPtrgQOS)=>WSAConnect(socketHandle,socketAddress,socketAddress.Length,inBuffer,outBuffer,sQOS,gQOS);

?

Though reading further that might make it a bit inconsistent with some of the other overloads. It's just a bit strange to see both the span and length passed in.

stephentoub
stephentoub reviewed Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/Interop/Windows/WinSock/Interop.WSAConnect.cs Outdated
stephentoub
stephentoub reviewed Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddress.cs
stephentoub
stephentoub reviewed Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddressPal.Unix.cs Outdated
@wfurt

wfurt commented Aug 1, 2023

Copy link
Copy Markdown
MemberAuthor

perf check

MethodJobToolchainMeanErrorStdDevMedianMinMaxRatioRatioSDAllocatedAlloc Ratio
ConnectAcceptAsyncJob-QAPYHK\PR \corerun.exe416.5 us4.92 us4.61 us415.9 us408.6 us426.5 us1.010.011370 B0.99
ConnectAcceptAsyncJob-ZQMRZG\main\corerun.exe411.2 us3.12 us2.77 us410.7 us407.7 us416.6 us1.000.001386 B1.00
SendAsyncThenReceiveAsync_TaskJob-QAPYHK\PR \corerun.exe271,064.3 us4,562.00 us4,267.30 us269,604.6 us265,718.7 us277,834.9 us1.010.02752 B1.00
SendAsyncThenReceiveAsync_TaskJob-ZQMRZG\main\corerun.exe267,751.9 us1,734.53 us1,622.48 us267,574.0 us265,252.0 us270,458.9 us1.000.00752 B1.00
ReceiveAsyncThenSendAsync_TaskJob-QAPYHK\PR \corerun.exe351,264.2 us1,238.80 us1,158.77 us351,484.9 us349,380.1 us353,069.9 us1.020.011280 B1.29
ReceiveAsyncThenSendAsync_TaskJob-ZQMRZG\main\corerun.exe345,229.4 us1,554.32 us1,453.92 us345,121.6 us343,334.1 us348,427.2 us1.000.00992 B1.00
SendAsyncThenReceiveAsync_SocketAsyncEventArgsJob-QAPYHK\PR \corerun.exe262,947.6 us2,276.07 us2,129.04 us261,991.3 us260,505.5 us266,591.9 us0.960.011920 B1.00
SendAsyncThenReceiveAsync_SocketAsyncEventArgsJob-ZQMRZG\main\corerun.exe274,286.3 us2,102.03 us1,966.24 us274,853.0 us270,239.3 us277,223.5 us1.000.001920 B1.00
ReceiveAsyncThenSendAsync_SocketAsyncEventArgsJob-QAPYHK\PR \corerun.exe331,678.8 us990.62 us926.63 us331,653.9 us329,933.3 us333,237.0 us1.000.013088 B1.33
ReceiveAsyncThenSendAsync_SocketAsyncEventArgsJob-ZQMRZG\main\corerun.exe332,023.6 us1,PR 1 us1,428.75 us332,203.7 us329,059.4 us334,365.6 us1.000.002320 B1.00

@wfurt
wfurt merged commit e2c6fcf into dotnet:mainAug 1, 2023
@karelzkarelz added this to the 8.0.0 milestone Aug 1, 2023
This was referenced Aug 2, 2023
Merged
Merged
Merged
@MihaZupanMihaZupan mentioned this pull request Aug 7, 2023
Closed
@wfurtwfurt mentioned this pull request Aug 10, 2023
Merged
@ghostghost locked as resolved and limited conversation to collaborators Aug 31, 2023
@wfurt
wfurt deleted the udp2 branch January 7, 2026 20:01
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoubstephentoubstephentoub approved these changes

Assignees

@wfurtwfurt

Labels

area-System.Net.Socketsnew-api-needs-documentation

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[API Proposal]: make SocketAddress more useful

3 participants

@wfurt@stephentoub@karelz
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
add SendTo/ReceiveFrom with SocketAddress - #88970
Merged
wfurt merged 18 commits into
dotnet:mainfrom 
wfurt:udp2
Aug 1, 2023
Merged
add SendTo/ReceiveFrom with SocketAddress#88970
wfurt merged 18 commits into
dotnet:mainfrom 
wfurt:udp2
Conversation
@wfurt
@wfurtwfurt
commented
Jul 16, 2023•

edited

Loading

Copy link


Copy Markdown

Member
And uses new SocketAddress API. That spanifies some of the PAL code as prep for removal of Internal.SocketAddress.
fixes#86872

contributes to #87397

contributes to #30797
@ghostghost
assigned wfurtJul 16, 2023
@ghost
ghost
commented
Jul 16, 2023

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.
@ghost
ghost
commented
Jul 16, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
And uses new SocketAddress API. That spanifies some of the PAL code as prep for removal of Internal.SocketAddress.
Author:wfurt
Assignees:wfurt
Labels:
area-System.Net.Sockets, new-api-needs-documentation
Milestone:-

This was referenced Jul 17, 2023

Closed


Closed


This was referenced Jul 17, 2023

Closed


Closed


Closed

stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddress.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddress.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/ref/System.Net.Sockets.cs
stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 18, 2023

Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 19, 2023

Closed

@wfurtwfurt
changed the title
Poc: add SendTo/ReceiveFrom with SocketAddressadd SendTo/ReceiveFrom with SocketAddressJul 19, 2023
@wfurt
wfurt
requested a review
from a teamJuly 19, 2023 16:52
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 20, 2023

Open

5 tasks
stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEventArgs.Windows.cs
 out int bytesTransferred,
 _socketFlags,
 _socketAddress!.Buffer.AsSpan(),
 _socketAddress!.InternalBuffer.AsSpan(),
@stephentoubstephentoubJul 27, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as earlier for these... we don't need to splice it down to Size?
stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
 // We can fail to get peer address on TCP
 socketAddressLen = socketAddress.Length;
 SocketAddressPal.Clear(socketAddress);
 }
@stephentoubstephentoubJul 27, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a bug fix?
@wfurtwfurtJul 27, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure but possibly yes. On Windows we seems to get the address but it fails on Linux. Perhaps we can also check if this is TCP and get the value from RemoteEndPoint? I can write issue for improvement and investigation.

I had trouble because setting Size zero would throw. Alternatively we can allow it to indicate that the buffer does not have any valid address.
stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/ReceiveFrom.cs
stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
@stephentoubstephentoub
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my comments/questions, LGTM.
@stephentoub
stephentoub
commented
Jul 27, 2023

Copy link


Copy Markdown

Member
I assume SendToAsync / ReceiveFromAsync are coming in a follow-up PR?
@wfurt
wfurt
commented
Jul 27, 2023

Copy link


Copy Markdown

MemberAuthor
I assume SendToAsync / ReceiveFromAsync are coming in a follow-up PR?
yes. That needs more work to clean up Internal.SocketAddress in socket code.
@wfurt
wfurt
commented
Jul 28, 2023

Copy link


Copy Markdown

MemberAuthor
this should be ready for another review pass @stephentoub
stephentoub
stephentoub
reviewed
Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/Interop/Windows/WinSock/Interop.WSAConnect.cs
Outdated

 internal static partial SocketError WSAConnect(
 SafeSocketHandle socketHandle,
 byte[] socketAddress,
Span<byte> socketAddress,
@stephentoubstephentoubAug 1, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make the actual LibraryImport private, with an internal wrapper that doesn't take socketAddressSize? e.g.
[LibraryImport(Interop.Libraries.Ws2_32,SetLastError=true)]privatestaticpartialSocketErrorWSAConnect(SafeSocketHandlesocketHandle,Span<byte>socketAddress,intsocketAddressSize,IntPtrinBuffer,IntPtroutBuffer,IntPtrsQOS,IntPtrgQOS);internalstaticSocketErrorWSAConnect(SafeSocketHandlesocketHandle,Span<byte>socketAddress,IntPtrinBuffer,IntPtroutBuffer,IntPtrsQOS,IntPtrgQOS)=>WSAConnect(socketHandle,socketAddress,socketAddress.Length,inBuffer,outBuffer,sQOS,gQOS);
?
Though reading further that might make it a bit inconsistent with some of the other overloads. It's just a bit strange to see both the span and length passed in.
stephentoub
stephentoub
reviewed
Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/Interop/Windows/WinSock/Interop.WSAConnect.cs
Outdated

stephentoub
stephentoub
reviewed
Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddress.cs
stephentoub
stephentoub
reviewed
Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddressPal.Unix.cs
Outdated

@wfurt
wfurt
commented
Aug 1, 2023

Copy link


Copy Markdown

MemberAuthor
perf check
MethodJobToolchainMeanErrorStdDevMedianMinMaxRatioRatioSDAllocatedAlloc Ratio
ConnectAcceptAsyncJob-QAPYHK\PR \corerun.exe416.5 us4.92 us4.61 us415.9 us408.6 us426.5 us1.010.011370 B0.99
ConnectAcceptAsyncJob-ZQMRZG\main\corerun.exe411.2 us3.12 us2.77 us410.7 us407.7 us416.6 us1.000.001386 B1.00
SendAsyncThenReceiveAsync_TaskJob-QAPYHK\PR \corerun.exe271,064.3 us4,562.00 us4,267.30 us269,604.6 us265,718.7 us277,834.9 us1.010.02752 B1.00
SendAsyncThenReceiveAsync_TaskJob-ZQMRZG\main\corerun.exe267,751.9 us1,734.53 us1,622.48 us267,574.0 us265,252.0 us270,458.9 us1.000.00752 B1.00
ReceiveAsyncThenSendAsync_TaskJob-QAPYHK\PR \corerun.exe351,264.2 us1,238.80 us1,158.77 us351,484.9 us349,380.1 us353,069.9 us1.020.011280 B1.29
ReceiveAsyncThenSendAsync_TaskJob-ZQMRZG\main\corerun.exe345,229.4 us1,554.32 us1,453.92 us345,121.6 us343,334.1 us348,427.2 us1.000.00992 B1.00
SendAsyncThenReceiveAsync_SocketAsyncEventArgsJob-QAPYHK\PR \corerun.exe262,947.6 us2,276.07 us2,129.04 us261,991.3 us260,505.5 us266,591.9 us0.960.011920 B1.00
SendAsyncThenReceiveAsync_SocketAsyncEventArgsJob-ZQMRZG\main\corerun.exe274,286.3 us2,102.03 us1,966.24 us274,853.0 us270,239.3 us277,223.5 us1.000.001920 B1.00
ReceiveAsyncThenSendAsync_SocketAsyncEventArgsJob-QAPYHK\PR \corerun.exe331,678.8 us990.62 us926.63 us331,653.9 us329,933.3 us333,237.0 us1.000.013088 B1.33
ReceiveAsyncThenSendAsync_SocketAsyncEventArgsJob-ZQMRZG\main\corerun.exe332,023.6 us1,PR 1 us1,428.75 us332,203.7 us329,059.4 us334,365.6 us1.000.002320 B1.00
@wfurt
wfurt
merged commit e2c6fcf
into
dotnet:mainAug 1, 2023
@karelzkarelz
added this to the 8.0.0 milestone
Aug 1, 2023

This was referenced Aug 2, 2023
 Merged

 Merged

 Merged

@MihaZupanMihaZupan
mentioned this pull request
Aug 7, 2023

Closed

@wfurtwfurt
mentioned this pull request
Aug 10, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Aug 31, 2023
@wfurt
wfurt
deleted the

udp2

branch
January 7, 2026 20:01
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub approved these changes

Assignees

@wfurtwfurt

Labels

area-System.Net.Socketsnew-api-needs-documentation

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[API Proposal]: make SocketAddress more useful 

3 participants

@wfurt@stephentoub@karelz

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
add SendTo/ReceiveFrom with SocketAddress - #88970
Merged
wfurt merged 18 commits into
dotnet:mainfrom 
wfurt:udp2
Aug 1, 2023
Merged
add SendTo/ReceiveFrom with SocketAddress#88970
wfurt merged 18 commits into
dotnet:mainfrom 
wfurt:udp2
Conversation
@wfurt
@wfurtwfurt
commented
Jul 16, 2023•

edited

Loading

Copy link


Copy Markdown

Member
And uses new SocketAddress API. That spanifies some of the PAL code as prep for removal of Internal.SocketAddress.
fixes#86872

contributes to #87397

contributes to #30797
@ghostghost
assigned wfurtJul 16, 2023
@ghost
ghost
commented
Jul 16, 2023

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.
@ghost
ghost
commented
Jul 16, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
And uses new SocketAddress API. That spanifies some of the PAL code as prep for removal of Internal.SocketAddress.
Author:wfurt
Assignees:wfurt
Labels:
area-System.Net.Sockets, new-api-needs-documentation
Milestone:-

This was referenced Jul 17, 2023

Closed


Closed


This was referenced Jul 17, 2023

Closed


Closed


Closed

stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddress.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddress.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/ref/System.Net.Sockets.cs
stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 18, 2023

Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 19, 2023

Closed

@wfurtwfurt
changed the title
Poc: add SendTo/ReceiveFrom with SocketAddressadd SendTo/ReceiveFrom with SocketAddressJul 19, 2023
@wfurt
wfurt
requested a review
from a teamJuly 19, 2023 16:52
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 20, 2023

Open

5 tasks
stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEventArgs.Windows.cs
 out int bytesTransferred,
 _socketFlags,
 _socketAddress!.Buffer.AsSpan(),
 _socketAddress!.InternalBuffer.AsSpan(),
@stephentoubstephentoubJul 27, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as earlier for these... we don't need to splice it down to Size?
stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
 // We can fail to get peer address on TCP
 socketAddressLen = socketAddress.Length;
 SocketAddressPal.Clear(socketAddress);
 }
@stephentoubstephentoubJul 27, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a bug fix?
@wfurtwfurtJul 27, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure but possibly yes. On Windows we seems to get the address but it fails on Linux. Perhaps we can also check if this is TCP and get the value from RemoteEndPoint? I can write issue for improvement and investigation.

I had trouble because setting Size zero would throw. Alternatively we can allow it to indicate that the buffer does not have any valid address.
stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/ReceiveFrom.cs
stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
@stephentoubstephentoub
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my comments/questions, LGTM.
@stephentoub
stephentoub
commented
Jul 27, 2023

Copy link


Copy Markdown

Member
I assume SendToAsync / ReceiveFromAsync are coming in a follow-up PR?
@wfurt
wfurt
commented
Jul 27, 2023

Copy link


Copy Markdown

MemberAuthor
I assume SendToAsync / ReceiveFromAsync are coming in a follow-up PR?
yes. That needs more work to clean up Internal.SocketAddress in socket code.
@wfurt
wfurt
commented
Jul 28, 2023

Copy link


Copy Markdown

MemberAuthor
this should be ready for another review pass @stephentoub
stephentoub
stephentoub
reviewed
Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/Interop/Windows/WinSock/Interop.WSAConnect.cs
Outdated

 internal static partial SocketError WSAConnect(
 SafeSocketHandle socketHandle,
 byte[] socketAddress,
Span<byte> socketAddress,
@stephentoubstephentoubAug 1, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make the actual LibraryImport private, with an internal wrapper that doesn't take socketAddressSize? e.g.
[LibraryImport(Interop.Libraries.Ws2_32,SetLastError=true)]privatestaticpartialSocketErrorWSAConnect(SafeSocketHandlesocketHandle,Span<byte>socketAddress,intsocketAddressSize,IntPtrinBuffer,IntPtroutBuffer,IntPtrsQOS,IntPtrgQOS);internalstaticSocketErrorWSAConnect(SafeSocketHandlesocketHandle,Span<byte>socketAddress,IntPtrinBuffer,IntPtroutBuffer,IntPtrsQOS,IntPtrgQOS)=>WSAConnect(socketHandle,socketAddress,socketAddress.Length,inBuffer,outBuffer,sQOS,gQOS);
?
Though reading further that might make it a bit inconsistent with some of the other overloads. It's just a bit strange to see both the span and length passed in.
stephentoub
stephentoub
reviewed
Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/Interop/Windows/WinSock/Interop.WSAConnect.cs
Outdated

stephentoub
stephentoub
reviewed
Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddress.cs
stephentoub
stephentoub
reviewed
Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddressPal.Unix.cs
Outdated

@wfurt
wfurt
commented
Aug 1, 2023

Copy link


Copy Markdown

MemberAuthor
perf check
MethodJobToolchainMeanErrorStdDevMedianMinMaxRatioRatioSDAllocatedAlloc Ratio
ConnectAcceptAsyncJob-QAPYHK\PR \corerun.exe416.5 us4.92 us4.61 us415.9 us408.6 us426.5 us1.010.011370 B0.99
ConnectAcceptAsyncJob-ZQMRZG\main\corerun.exe411.2 us3.12 us2.77 us410.7 us407.7 us416.6 us1.000.001386 B1.00
SendAsyncThenReceiveAsync_TaskJob-QAPYHK\PR \corerun.exe271,064.3 us4,562.00 us4,267.30 us269,604.6 us265,718.7 us277,834.9 us1.010.02752 B1.00
SendAsyncThenReceiveAsync_TaskJob-ZQMRZG\main\corerun.exe267,751.9 us1,734.53 us1,622.48 us267,574.0 us265,252.0 us270,458.9 us1.000.00752 B1.00
ReceiveAsyncThenSendAsync_TaskJob-QAPYHK\PR \corerun.exe351,264.2 us1,238.80 us1,158.77 us351,484.9 us349,380.1 us353,069.9 us1.020.011280 B1.29
ReceiveAsyncThenSendAsync_TaskJob-ZQMRZG\main\corerun.exe345,229.4 us1,554.32 us1,453.92 us345,121.6 us343,334.1 us348,427.2 us1.000.00992 B1.00
SendAsyncThenReceiveAsync_SocketAsyncEventArgsJob-QAPYHK\PR \corerun.exe262,947.6 us2,276.07 us2,129.04 us261,991.3 us260,505.5 us266,591.9 us0.960.011920 B1.00
SendAsyncThenReceiveAsync_SocketAsyncEventArgsJob-ZQMRZG\main\corerun.exe274,286.3 us2,102.03 us1,966.24 us274,853.0 us270,239.3 us277,223.5 us1.000.001920 B1.00
ReceiveAsyncThenSendAsync_SocketAsyncEventArgsJob-QAPYHK\PR \corerun.exe331,678.8 us990.62 us926.63 us331,653.9 us329,933.3 us333,237.0 us1.000.013088 B1.33
ReceiveAsyncThenSendAsync_SocketAsyncEventArgsJob-ZQMRZG\main\corerun.exe332,023.6 us1,PR 1 us1,428.75 us332,203.7 us329,059.4 us334,365.6 us1.000.002320 B1.00
@wfurt
wfurt
merged commit e2c6fcf
into
dotnet:mainAug 1, 2023
@karelzkarelz
added this to the 8.0.0 milestone
Aug 1, 2023

This was referenced Aug 2, 2023
 Merged

 Merged

 Merged

@MihaZupanMihaZupan
mentioned this pull request
Aug 7, 2023

Closed

@wfurtwfurt
mentioned this pull request
Aug 10, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Aug 31, 2023
@wfurt
wfurt
deleted the

udp2

branch
January 7, 2026 20:01
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub approved these changes

Assignees

@wfurtwfurt

Labels

area-System.Net.Socketsnew-api-needs-documentation

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[API Proposal]: make SocketAddress more useful 

3 participants

@wfurt@stephentoub@karelz

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
add SendTo/ReceiveFrom with SocketAddress - #88970
Merged
wfurt merged 18 commits into
dotnet:mainfrom 
wfurt:udp2
Aug 1, 2023
Merged
add SendTo/ReceiveFrom with SocketAddress#88970
wfurt merged 18 commits into
dotnet:mainfrom 
wfurt:udp2
Conversation
@wfurt
@wfurtwfurt
commented
Jul 16, 2023•

edited

Loading

Copy link


Copy Markdown

Member
And uses new SocketAddress API. That spanifies some of the PAL code as prep for removal of Internal.SocketAddress.
fixes#86872

contributes to #87397

contributes to #30797
@ghostghost
assigned wfurtJul 16, 2023
@ghost
ghost
commented
Jul 16, 2023

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.
@ghost
ghost
commented
Jul 16, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
And uses new SocketAddress API. That spanifies some of the PAL code as prep for removal of Internal.SocketAddress.
Author:wfurt
Assignees:wfurt
Labels:
area-System.Net.Sockets, new-api-needs-documentation
Milestone:-

This was referenced Jul 17, 2023

Closed


Closed


This was referenced Jul 17, 2023

Closed


Closed


Closed

stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddress.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddress.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/ref/System.Net.Sockets.cs
stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 18, 2023

Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 19, 2023

Closed

@wfurtwfurt
changed the title
Poc: add SendTo/ReceiveFrom with SocketAddressadd SendTo/ReceiveFrom with SocketAddressJul 19, 2023
@wfurt
wfurt
requested a review
from a teamJuly 19, 2023 16:52
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 20, 2023

Open

5 tasks
stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEventArgs.Windows.cs
 out int bytesTransferred,
 _socketFlags,
 _socketAddress!.Buffer.AsSpan(),
 _socketAddress!.InternalBuffer.AsSpan(),
@stephentoubstephentoubJul 27, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as earlier for these... we don't need to splice it down to Size?
stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
 // We can fail to get peer address on TCP
 socketAddressLen = socketAddress.Length;
 SocketAddressPal.Clear(socketAddress);
 }
@stephentoubstephentoubJul 27, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a bug fix?
@wfurtwfurtJul 27, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure but possibly yes. On Windows we seems to get the address but it fails on Linux. Perhaps we can also check if this is TCP and get the value from RemoteEndPoint? I can write issue for improvement and investigation.

I had trouble because setting Size zero would throw. Alternatively we can allow it to indicate that the buffer does not have any valid address.
stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/ReceiveFrom.cs
stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
@stephentoubstephentoub
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my comments/questions, LGTM.
@stephentoub
stephentoub
commented
Jul 27, 2023

Copy link


Copy Markdown

Member
I assume SendToAsync / ReceiveFromAsync are coming in a follow-up PR?
@wfurt
wfurt
commented
Jul 27, 2023

Copy link


Copy Markdown

MemberAuthor
I assume SendToAsync / ReceiveFromAsync are coming in a follow-up PR?
yes. That needs more work to clean up Internal.SocketAddress in socket code.
@wfurt
wfurt
commented
Jul 28, 2023

Copy link


Copy Markdown

MemberAuthor
this should be ready for another review pass @stephentoub
stephentoub
stephentoub
reviewed
Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/Interop/Windows/WinSock/Interop.WSAConnect.cs
Outdated

 internal static partial SocketError WSAConnect(
 SafeSocketHandle socketHandle,
 byte[] socketAddress,
Span<byte> socketAddress,
@stephentoubstephentoubAug 1, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make the actual LibraryImport private, with an internal wrapper that doesn't take socketAddressSize? e.g.
[LibraryImport(Interop.Libraries.Ws2_32,SetLastError=true)]privatestaticpartialSocketErrorWSAConnect(SafeSocketHandlesocketHandle,Span<byte>socketAddress,intsocketAddressSize,IntPtrinBuffer,IntPtroutBuffer,IntPtrsQOS,IntPtrgQOS);internalstaticSocketErrorWSAConnect(SafeSocketHandlesocketHandle,Span<byte>socketAddress,IntPtrinBuffer,IntPtroutBuffer,IntPtrsQOS,IntPtrgQOS)=>WSAConnect(socketHandle,socketAddress,socketAddress.Length,inBuffer,outBuffer,sQOS,gQOS);
?
Though reading further that might make it a bit inconsistent with some of the other overloads. It's just a bit strange to see both the span and length passed in.
stephentoub
stephentoub
reviewed
Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/Interop/Windows/WinSock/Interop.WSAConnect.cs
Outdated

stephentoub
stephentoub
reviewed
Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddress.cs
stephentoub
stephentoub
reviewed
Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddressPal.Unix.cs
Outdated

@wfurt
wfurt
commented
Aug 1, 2023

Copy link


Copy Markdown

MemberAuthor
perf check
MethodJobToolchainMeanErrorStdDevMedianMinMaxRatioRatioSDAllocatedAlloc Ratio
ConnectAcceptAsyncJob-QAPYHK\PR \corerun.exe416.5 us4.92 us4.61 us415.9 us408.6 us426.5 us1.010.011370 B0.99
ConnectAcceptAsyncJob-ZQMRZG\main\corerun.exe411.2 us3.12 us2.77 us410.7 us407.7 us416.6 us1.000.001386 B1.00
SendAsyncThenReceiveAsync_TaskJob-QAPYHK\PR \corerun.exe271,064.3 us4,562.00 us4,267.30 us269,604.6 us265,718.7 us277,834.9 us1.010.02752 B1.00
SendAsyncThenReceiveAsync_TaskJob-ZQMRZG\main\corerun.exe267,751.9 us1,734.53 us1,622.48 us267,574.0 us265,252.0 us270,458.9 us1.000.00752 B1.00
ReceiveAsyncThenSendAsync_TaskJob-QAPYHK\PR \corerun.exe351,264.2 us1,238.80 us1,158.77 us351,484.9 us349,380.1 us353,069.9 us1.020.011280 B1.29
ReceiveAsyncThenSendAsync_TaskJob-ZQMRZG\main\corerun.exe345,229.4 us1,554.32 us1,453.92 us345,121.6 us343,334.1 us348,427.2 us1.000.00992 B1.00
SendAsyncThenReceiveAsync_SocketAsyncEventArgsJob-QAPYHK\PR \corerun.exe262,947.6 us2,276.07 us2,129.04 us261,991.3 us260,505.5 us266,591.9 us0.960.011920 B1.00
SendAsyncThenReceiveAsync_SocketAsyncEventArgsJob-ZQMRZG\main\corerun.exe274,286.3 us2,102.03 us1,966.24 us274,853.0 us270,239.3 us277,223.5 us1.000.001920 B1.00
ReceiveAsyncThenSendAsync_SocketAsyncEventArgsJob-QAPYHK\PR \corerun.exe331,678.8 us990.62 us926.63 us331,653.9 us329,933.3 us333,237.0 us1.000.013088 B1.33
ReceiveAsyncThenSendAsync_SocketAsyncEventArgsJob-ZQMRZG\main\corerun.exe332,023.6 us1,PR 1 us1,428.75 us332,203.7 us329,059.4 us334,365.6 us1.000.002320 B1.00
@wfurt
wfurt
merged commit e2c6fcf
into
dotnet:mainAug 1, 2023
@karelzkarelz
added this to the 8.0.0 milestone
Aug 1, 2023

This was referenced Aug 2, 2023
 Merged

 Merged

 Merged

@MihaZupanMihaZupan
mentioned this pull request
Aug 7, 2023

Closed

@wfurtwfurt
mentioned this pull request
Aug 10, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Aug 31, 2023
@wfurt
wfurt
deleted the

udp2

branch
January 7, 2026 20:01
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub approved these changes

Assignees

@wfurtwfurt

Labels

area-System.Net.Socketsnew-api-needs-documentation

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[API Proposal]: make SocketAddress more useful 

3 participants

@wfurt@stephentoub@karelz

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
add SendTo/ReceiveFrom with SocketAddress - #88970
Merged
wfurt merged 18 commits into
dotnet:mainfrom 
wfurt:udp2
Aug 1, 2023
Merged
add SendTo/ReceiveFrom with SocketAddress#88970
wfurt merged 18 commits into
dotnet:mainfrom 
wfurt:udp2
Conversation
@wfurt
@wfurtwfurt
commented
Jul 16, 2023•

edited

Loading

Copy link


Copy Markdown

Member
And uses new SocketAddress API. That spanifies some of the PAL code as prep for removal of Internal.SocketAddress.
fixes#86872

contributes to #87397

contributes to #30797
@ghostghost
assigned wfurtJul 16, 2023
@ghost
ghost
commented
Jul 16, 2023

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.
@ghost
ghost
commented
Jul 16, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
And uses new SocketAddress API. That spanifies some of the PAL code as prep for removal of Internal.SocketAddress.
Author:wfurt
Assignees:wfurt
Labels:
area-System.Net.Sockets, new-api-needs-documentation
Milestone:-

This was referenced Jul 17, 2023

Closed


Closed


This was referenced Jul 17, 2023

Closed


Closed


Closed

stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddress.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddress.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/ref/System.Net.Sockets.cs
stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 18, 2023

Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 19, 2023

Closed

@wfurtwfurt
changed the title
Poc: add SendTo/ReceiveFrom with SocketAddressadd SendTo/ReceiveFrom with SocketAddressJul 19, 2023
@wfurt
wfurt
requested a review
from a teamJuly 19, 2023 16:52
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 20, 2023

Open

5 tasks
stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEventArgs.Windows.cs
 out int bytesTransferred,
 _socketFlags,
 _socketAddress!.Buffer.AsSpan(),
 _socketAddress!.InternalBuffer.AsSpan(),
@stephentoubstephentoubJul 27, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as earlier for these... we don't need to splice it down to Size?
stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
 // We can fail to get peer address on TCP
 socketAddressLen = socketAddress.Length;
 SocketAddressPal.Clear(socketAddress);
 }
@stephentoubstephentoubJul 27, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a bug fix?
@wfurtwfurtJul 27, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure but possibly yes. On Windows we seems to get the address but it fails on Linux. Perhaps we can also check if this is TCP and get the value from RemoteEndPoint? I can write issue for improvement and investigation.

I had trouble because setting Size zero would throw. Alternatively we can allow it to indicate that the buffer does not have any valid address.
stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/ReceiveFrom.cs
stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
@stephentoubstephentoub
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my comments/questions, LGTM.
@stephentoub
stephentoub
commented
Jul 27, 2023

Copy link


Copy Markdown

Member
I assume SendToAsync / ReceiveFromAsync are coming in a follow-up PR?
@wfurt
wfurt
commented
Jul 27, 2023

Copy link


Copy Markdown

MemberAuthor
I assume SendToAsync / ReceiveFromAsync are coming in a follow-up PR?
yes. That needs more work to clean up Internal.SocketAddress in socket code.
@wfurt
wfurt
commented
Jul 28, 2023

Copy link


Copy Markdown

MemberAuthor
this should be ready for another review pass @stephentoub
stephentoub
stephentoub
reviewed
Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/Interop/Windows/WinSock/Interop.WSAConnect.cs
Outdated

 internal static partial SocketError WSAConnect(
 SafeSocketHandle socketHandle,
 byte[] socketAddress,
Span<byte> socketAddress,
@stephentoubstephentoubAug 1, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make the actual LibraryImport private, with an internal wrapper that doesn't take socketAddressSize? e.g.
[LibraryImport(Interop.Libraries.Ws2_32,SetLastError=true)]privatestaticpartialSocketErrorWSAConnect(SafeSocketHandlesocketHandle,Span<byte>socketAddress,intsocketAddressSize,IntPtrinBuffer,IntPtroutBuffer,IntPtrsQOS,IntPtrgQOS);internalstaticSocketErrorWSAConnect(SafeSocketHandlesocketHandle,Span<byte>socketAddress,IntPtrinBuffer,IntPtroutBuffer,IntPtrsQOS,IntPtrgQOS)=>WSAConnect(socketHandle,socketAddress,socketAddress.Length,inBuffer,outBuffer,sQOS,gQOS);
?
Though reading further that might make it a bit inconsistent with some of the other overloads. It's just a bit strange to see both the span and length passed in.
stephentoub
stephentoub
reviewed
Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/Interop/Windows/WinSock/Interop.WSAConnect.cs
Outdated

stephentoub
stephentoub
reviewed
Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddress.cs
stephentoub
stephentoub
reviewed
Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddressPal.Unix.cs
Outdated

@wfurt
wfurt
commented
Aug 1, 2023

Copy link


Copy Markdown

MemberAuthor
perf check
MethodJobToolchainMeanErrorStdDevMedianMinMaxRatioRatioSDAllocatedAlloc Ratio
ConnectAcceptAsyncJob-QAPYHK\PR \corerun.exe416.5 us4.92 us4.61 us415.9 us408.6 us426.5 us1.010.011370 B0.99
ConnectAcceptAsyncJob-ZQMRZG\main\corerun.exe411.2 us3.12 us2.77 us410.7 us407.7 us416.6 us1.000.001386 B1.00
SendAsyncThenReceiveAsync_TaskJob-QAPYHK\PR \corerun.exe271,064.3 us4,562.00 us4,267.30 us269,604.6 us265,718.7 us277,834.9 us1.010.02752 B1.00
SendAsyncThenReceiveAsync_TaskJob-ZQMRZG\main\corerun.exe267,751.9 us1,734.53 us1,622.48 us267,574.0 us265,252.0 us270,458.9 us1.000.00752 B1.00
ReceiveAsyncThenSendAsync_TaskJob-QAPYHK\PR \corerun.exe351,264.2 us1,238.80 us1,158.77 us351,484.9 us349,380.1 us353,069.9 us1.020.011280 B1.29
ReceiveAsyncThenSendAsync_TaskJob-ZQMRZG\main\corerun.exe345,229.4 us1,554.32 us1,453.92 us345,121.6 us343,334.1 us348,427.2 us1.000.00992 B1.00
SendAsyncThenReceiveAsync_SocketAsyncEventArgsJob-QAPYHK\PR \corerun.exe262,947.6 us2,276.07 us2,129.04 us261,991.3 us260,505.5 us266,591.9 us0.960.011920 B1.00
SendAsyncThenReceiveAsync_SocketAsyncEventArgsJob-ZQMRZG\main\corerun.exe274,286.3 us2,102.03 us1,966.24 us274,853.0 us270,239.3 us277,223.5 us1.000.001920 B1.00
ReceiveAsyncThenSendAsync_SocketAsyncEventArgsJob-QAPYHK\PR \corerun.exe331,678.8 us990.62 us926.63 us331,653.9 us329,933.3 us333,237.0 us1.000.013088 B1.33
ReceiveAsyncThenSendAsync_SocketAsyncEventArgsJob-ZQMRZG\main\corerun.exe332,023.6 us1,PR 1 us1,428.75 us332,203.7 us329,059.4 us334,365.6 us1.000.002320 B1.00
@wfurt
wfurt
merged commit e2c6fcf
into
dotnet:mainAug 1, 2023
@karelzkarelz
added this to the 8.0.0 milestone
Aug 1, 2023

This was referenced Aug 2, 2023
 Merged

 Merged

 Merged

@MihaZupanMihaZupan
mentioned this pull request
Aug 7, 2023

Closed

@wfurtwfurt
mentioned this pull request
Aug 10, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Aug 31, 2023
@wfurt
wfurt
deleted the

udp2

branch
January 7, 2026 20:01
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub approved these changes

Assignees

@wfurtwfurt

Labels

area-System.Net.Socketsnew-api-needs-documentation

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[API Proposal]: make SocketAddress more useful 

3 participants

@wfurt@stephentoub@karelz

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
add SendTo/ReceiveFrom with SocketAddress - #88970
Merged
wfurt merged 18 commits into
dotnet:mainfrom 
wfurt:udp2
Aug 1, 2023
Merged
add SendTo/ReceiveFrom with SocketAddress#88970
wfurt merged 18 commits into
dotnet:mainfrom 
wfurt:udp2
Conversation
@wfurt
@wfurtwfurt
commented
Jul 16, 2023•

edited

Loading

Copy link


Copy Markdown

Member
And uses new SocketAddress API. That spanifies some of the PAL code as prep for removal of Internal.SocketAddress.
fixes#86872

contributes to #87397

contributes to #30797
@ghostghost
assigned wfurtJul 16, 2023
@ghost
ghost
commented
Jul 16, 2023

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.
@ghost
ghost
commented
Jul 16, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
And uses new SocketAddress API. That spanifies some of the PAL code as prep for removal of Internal.SocketAddress.
Author:wfurt
Assignees:wfurt
Labels:
area-System.Net.Sockets, new-api-needs-documentation
Milestone:-

This was referenced Jul 17, 2023

Closed


Closed


This was referenced Jul 17, 2023

Closed


Closed


Closed

stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddress.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddress.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/ref/System.Net.Sockets.cs
stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 18, 2023

Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 19, 2023

Closed

@wfurtwfurt
changed the title
Poc: add SendTo/ReceiveFrom with SocketAddressadd SendTo/ReceiveFrom with SocketAddressJul 19, 2023
@wfurt
wfurt
requested a review
from a teamJuly 19, 2023 16:52
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 20, 2023

Open

5 tasks
stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEventArgs.Windows.cs
 out int bytesTransferred,
 _socketFlags,
 _socketAddress!.Buffer.AsSpan(),
 _socketAddress!.InternalBuffer.AsSpan(),
@stephentoubstephentoubJul 27, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as earlier for these... we don't need to splice it down to Size?
stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
 // We can fail to get peer address on TCP
 socketAddressLen = socketAddress.Length;
 SocketAddressPal.Clear(socketAddress);
 }
@stephentoubstephentoubJul 27, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a bug fix?
@wfurtwfurtJul 27, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure but possibly yes. On Windows we seems to get the address but it fails on Linux. Perhaps we can also check if this is TCP and get the value from RemoteEndPoint? I can write issue for improvement and investigation.

I had trouble because setting Size zero would throw. Alternatively we can allow it to indicate that the buffer does not have any valid address.
stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/ReceiveFrom.cs
stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
@stephentoubstephentoub
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my comments/questions, LGTM.
@stephentoub
stephentoub
commented
Jul 27, 2023

Copy link


Copy Markdown

Member
I assume SendToAsync / ReceiveFromAsync are coming in a follow-up PR?
@wfurt
wfurt
commented
Jul 27, 2023

Copy link


Copy Markdown

MemberAuthor
I assume SendToAsync / ReceiveFromAsync are coming in a follow-up PR?
yes. That needs more work to clean up Internal.SocketAddress in socket code.
@wfurt
wfurt
commented
Jul 28, 2023

Copy link


Copy Markdown

MemberAuthor
this should be ready for another review pass @stephentoub
stephentoub
stephentoub
reviewed
Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/Interop/Windows/WinSock/Interop.WSAConnect.cs
Outdated

 internal static partial SocketError WSAConnect(
 SafeSocketHandle socketHandle,
 byte[] socketAddress,
Span<byte> socketAddress,
@stephentoubstephentoubAug 1, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make the actual LibraryImport private, with an internal wrapper that doesn't take socketAddressSize? e.g.
[LibraryImport(Interop.Libraries.Ws2_32,SetLastError=true)]privatestaticpartialSocketErrorWSAConnect(SafeSocketHandlesocketHandle,Span<byte>socketAddress,intsocketAddressSize,IntPtrinBuffer,IntPtroutBuffer,IntPtrsQOS,IntPtrgQOS);internalstaticSocketErrorWSAConnect(SafeSocketHandlesocketHandle,Span<byte>socketAddress,IntPtrinBuffer,IntPtroutBuffer,IntPtrsQOS,IntPtrgQOS)=>WSAConnect(socketHandle,socketAddress,socketAddress.Length,inBuffer,outBuffer,sQOS,gQOS);
?
Though reading further that might make it a bit inconsistent with some of the other overloads. It's just a bit strange to see both the span and length passed in.
stephentoub
stephentoub
reviewed
Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/Interop/Windows/WinSock/Interop.WSAConnect.cs
Outdated

stephentoub
stephentoub
reviewed
Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddress.cs
stephentoub
stephentoub
reviewed
Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddressPal.Unix.cs
Outdated

@wfurt
wfurt
commented
Aug 1, 2023

Copy link


Copy Markdown

MemberAuthor
perf check
MethodJobToolchainMeanErrorStdDevMedianMinMaxRatioRatioSDAllocatedAlloc Ratio
ConnectAcceptAsyncJob-QAPYHK\PR \corerun.exe416.5 us4.92 us4.61 us415.9 us408.6 us426.5 us1.010.011370 B0.99
ConnectAcceptAsyncJob-ZQMRZG\main\corerun.exe411.2 us3.12 us2.77 us410.7 us407.7 us416.6 us1.000.001386 B1.00
SendAsyncThenReceiveAsync_TaskJob-QAPYHK\PR \corerun.exe271,064.3 us4,562.00 us4,267.30 us269,604.6 us265,718.7 us277,834.9 us1.010.02752 B1.00
SendAsyncThenReceiveAsync_TaskJob-ZQMRZG\main\corerun.exe267,751.9 us1,734.53 us1,622.48 us267,574.0 us265,252.0 us270,458.9 us1.000.00752 B1.00
ReceiveAsyncThenSendAsync_TaskJob-QAPYHK\PR \corerun.exe351,264.2 us1,238.80 us1,158.77 us351,484.9 us349,380.1 us353,069.9 us1.020.011280 B1.29
ReceiveAsyncThenSendAsync_TaskJob-ZQMRZG\main\corerun.exe345,229.4 us1,554.32 us1,453.92 us345,121.6 us343,334.1 us348,427.2 us1.000.00992 B1.00
SendAsyncThenReceiveAsync_SocketAsyncEventArgsJob-QAPYHK\PR \corerun.exe262,947.6 us2,276.07 us2,129.04 us261,991.3 us260,505.5 us266,591.9 us0.960.011920 B1.00
SendAsyncThenReceiveAsync_SocketAsyncEventArgsJob-ZQMRZG\main\corerun.exe274,286.3 us2,102.03 us1,966.24 us274,853.0 us270,239.3 us277,223.5 us1.000.001920 B1.00
ReceiveAsyncThenSendAsync_SocketAsyncEventArgsJob-QAPYHK\PR \corerun.exe331,678.8 us990.62 us926.63 us331,653.9 us329,933.3 us333,237.0 us1.000.013088 B1.33
ReceiveAsyncThenSendAsync_SocketAsyncEventArgsJob-ZQMRZG\main\corerun.exe332,023.6 us1,PR 1 us1,428.75 us332,203.7 us329,059.4 us334,365.6 us1.000.002320 B1.00
@wfurt
wfurt
merged commit e2c6fcf
into
dotnet:mainAug 1, 2023
@karelzkarelz
added this to the 8.0.0 milestone
Aug 1, 2023

This was referenced Aug 2, 2023
 Merged

 Merged

 Merged

@MihaZupanMihaZupan
mentioned this pull request
Aug 7, 2023

Closed

@wfurtwfurt
mentioned this pull request
Aug 10, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Aug 31, 2023
@wfurt
wfurt
deleted the

udp2

branch
January 7, 2026 20:01
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub approved these changes

Assignees

@wfurtwfurt

Labels

area-System.Net.Socketsnew-api-needs-documentation

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[API Proposal]: make SocketAddress more useful 

3 participants

@wfurt@stephentoub@karelz

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
add SendTo/ReceiveFrom with SocketAddress - #88970
Merged
wfurt merged 18 commits into
dotnet:mainfrom 
wfurt:udp2
Aug 1, 2023
Merged
add SendTo/ReceiveFrom with SocketAddress#88970
wfurt merged 18 commits into
dotnet:mainfrom 
wfurt:udp2
Conversation
@wfurt
@wfurtwfurt
commented
Jul 16, 2023•

edited

Loading

Copy link


Copy Markdown

Member
And uses new SocketAddress API. That spanifies some of the PAL code as prep for removal of Internal.SocketAddress.
fixes#86872

contributes to #87397

contributes to #30797
@ghostghost
assigned wfurtJul 16, 2023
@ghost
ghost
commented
Jul 16, 2023

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.
@ghost
ghost
commented
Jul 16, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
And uses new SocketAddress API. That spanifies some of the PAL code as prep for removal of Internal.SocketAddress.
Author:wfurt
Assignees:wfurt
Labels:
area-System.Net.Sockets, new-api-needs-documentation
Milestone:-

This was referenced Jul 17, 2023

Closed


Closed


This was referenced Jul 17, 2023

Closed


Closed


Closed

stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddress.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddress.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/ref/System.Net.Sockets.cs
stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 18, 2023

Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 19, 2023

Closed

@wfurtwfurt
changed the title
Poc: add SendTo/ReceiveFrom with SocketAddressadd SendTo/ReceiveFrom with SocketAddressJul 19, 2023
@wfurt
wfurt
requested a review
from a teamJuly 19, 2023 16:52
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 20, 2023

Open

5 tasks
stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEventArgs.Windows.cs
 out int bytesTransferred,
 _socketFlags,
 _socketAddress!.Buffer.AsSpan(),
 _socketAddress!.InternalBuffer.AsSpan(),
@stephentoubstephentoubJul 27, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as earlier for these... we don't need to splice it down to Size?
stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
 // We can fail to get peer address on TCP
 socketAddressLen = socketAddress.Length;
 SocketAddressPal.Clear(socketAddress);
 }
@stephentoubstephentoubJul 27, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a bug fix?
@wfurtwfurtJul 27, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure but possibly yes. On Windows we seems to get the address but it fails on Linux. Perhaps we can also check if this is TCP and get the value from RemoteEndPoint? I can write issue for improvement and investigation.

I had trouble because setting Size zero would throw. Alternatively we can allow it to indicate that the buffer does not have any valid address.
stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/ReceiveFrom.cs
stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
@stephentoubstephentoub
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my comments/questions, LGTM.
@stephentoub
stephentoub
commented
Jul 27, 2023

Copy link


Copy Markdown

Member
I assume SendToAsync / ReceiveFromAsync are coming in a follow-up PR?
@wfurt
wfurt
commented
Jul 27, 2023

Copy link


Copy Markdown

MemberAuthor
I assume SendToAsync / ReceiveFromAsync are coming in a follow-up PR?
yes. That needs more work to clean up Internal.SocketAddress in socket code.
@wfurt
wfurt
commented
Jul 28, 2023

Copy link


Copy Markdown

MemberAuthor
this should be ready for another review pass @stephentoub
stephentoub
stephentoub
reviewed
Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/Interop/Windows/WinSock/Interop.WSAConnect.cs
Outdated

 internal static partial SocketError WSAConnect(
 SafeSocketHandle socketHandle,
 byte[] socketAddress,
Span<byte> socketAddress,
@stephentoubstephentoubAug 1, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make the actual LibraryImport private, with an internal wrapper that doesn't take socketAddressSize? e.g.
[LibraryImport(Interop.Libraries.Ws2_32,SetLastError=true)]privatestaticpartialSocketErrorWSAConnect(SafeSocketHandlesocketHandle,Span<byte>socketAddress,intsocketAddressSize,IntPtrinBuffer,IntPtroutBuffer,IntPtrsQOS,IntPtrgQOS);internalstaticSocketErrorWSAConnect(SafeSocketHandlesocketHandle,Span<byte>socketAddress,IntPtrinBuffer,IntPtroutBuffer,IntPtrsQOS,IntPtrgQOS)=>WSAConnect(socketHandle,socketAddress,socketAddress.Length,inBuffer,outBuffer,sQOS,gQOS);
?
Though reading further that might make it a bit inconsistent with some of the other overloads. It's just a bit strange to see both the span and length passed in.
stephentoub
stephentoub
reviewed
Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/Interop/Windows/WinSock/Interop.WSAConnect.cs
Outdated

stephentoub
stephentoub
reviewed
Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddress.cs
stephentoub
stephentoub
reviewed
Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddressPal.Unix.cs
Outdated

@wfurt
wfurt
commented
Aug 1, 2023

Copy link


Copy Markdown

MemberAuthor
perf check
MethodJobToolchainMeanErrorStdDevMedianMinMaxRatioRatioSDAllocatedAlloc Ratio
ConnectAcceptAsyncJob-QAPYHK\PR \corerun.exe416.5 us4.92 us4.61 us415.9 us408.6 us426.5 us1.010.011370 B0.99
ConnectAcceptAsyncJob-ZQMRZG\main\corerun.exe411.2 us3.12 us2.77 us410.7 us407.7 us416.6 us1.000.001386 B1.00
SendAsyncThenReceiveAsync_TaskJob-QAPYHK\PR \corerun.exe271,064.3 us4,562.00 us4,267.30 us269,604.6 us265,718.7 us277,834.9 us1.010.02752 B1.00
SendAsyncThenReceiveAsync_TaskJob-ZQMRZG\main\corerun.exe267,751.9 us1,734.53 us1,622.48 us267,574.0 us265,252.0 us270,458.9 us1.000.00752 B1.00
ReceiveAsyncThenSendAsync_TaskJob-QAPYHK\PR \corerun.exe351,264.2 us1,238.80 us1,158.77 us351,484.9 us349,380.1 us353,069.9 us1.020.011280 B1.29
ReceiveAsyncThenSendAsync_TaskJob-ZQMRZG\main\corerun.exe345,229.4 us1,554.32 us1,453.92 us345,121.6 us343,334.1 us348,427.2 us1.000.00992 B1.00
SendAsyncThenReceiveAsync_SocketAsyncEventArgsJob-QAPYHK\PR \corerun.exe262,947.6 us2,276.07 us2,129.04 us261,991.3 us260,505.5 us266,591.9 us0.960.011920 B1.00
SendAsyncThenReceiveAsync_SocketAsyncEventArgsJob-ZQMRZG\main\corerun.exe274,286.3 us2,102.03 us1,966.24 us274,853.0 us270,239.3 us277,223.5 us1.000.001920 B1.00
ReceiveAsyncThenSendAsync_SocketAsyncEventArgsJob-QAPYHK\PR \corerun.exe331,678.8 us990.62 us926.63 us331,653.9 us329,933.3 us333,237.0 us1.000.013088 B1.33
ReceiveAsyncThenSendAsync_SocketAsyncEventArgsJob-ZQMRZG\main\corerun.exe332,023.6 us1,PR 1 us1,428.75 us332,203.7 us329,059.4 us334,365.6 us1.000.002320 B1.00
@wfurt
wfurt
merged commit e2c6fcf
into
dotnet:mainAug 1, 2023
@karelzkarelz
added this to the 8.0.0 milestone
Aug 1, 2023

This was referenced Aug 2, 2023
 Merged

 Merged

 Merged

@MihaZupanMihaZupan
mentioned this pull request
Aug 7, 2023

Closed

@wfurtwfurt
mentioned this pull request
Aug 10, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Aug 31, 2023
@wfurt
wfurt
deleted the

udp2

branch
January 7, 2026 20:01
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub approved these changes

Assignees

@wfurtwfurt

Labels

area-System.Net.Socketsnew-api-needs-documentation

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[API Proposal]: make SocketAddress more useful 

3 participants

@wfurt@stephentoub@karelz

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
add SendTo/ReceiveFrom with SocketAddress - #88970
Merged
wfurt merged 18 commits into
dotnet:mainfrom 
wfurt:udp2
Aug 1, 2023
Merged
add SendTo/ReceiveFrom with SocketAddress#88970
wfurt merged 18 commits into
dotnet:mainfrom 
wfurt:udp2
Conversation
@wfurt
@wfurtwfurt
commented
Jul 16, 2023•

edited

Loading

Copy link


Copy Markdown

Member
And uses new SocketAddress API. That spanifies some of the PAL code as prep for removal of Internal.SocketAddress.
fixes#86872

contributes to #87397

contributes to #30797
@ghostghost
assigned wfurtJul 16, 2023
@ghost
ghost
commented
Jul 16, 2023

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.
@ghost
ghost
commented
Jul 16, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
And uses new SocketAddress API. That spanifies some of the PAL code as prep for removal of Internal.SocketAddress.
Author:wfurt
Assignees:wfurt
Labels:
area-System.Net.Sockets, new-api-needs-documentation
Milestone:-

This was referenced Jul 17, 2023

Closed


Closed


This was referenced Jul 17, 2023

Closed


Closed


Closed

stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddress.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddress.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/ref/System.Net.Sockets.cs
stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 17, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 18, 2023

Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 19, 2023

Closed

@wfurtwfurt
changed the title
Poc: add SendTo/ReceiveFrom with SocketAddressadd SendTo/ReceiveFrom with SocketAddressJul 19, 2023
@wfurt
wfurt
requested a review
from a teamJuly 19, 2023 16:52
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 20, 2023

Open

5 tasks
stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEventArgs.Windows.cs
 out int bytesTransferred,
 _socketFlags,
 _socketAddress!.Buffer.AsSpan(),
 _socketAddress!.InternalBuffer.AsSpan(),
@stephentoubstephentoubJul 27, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as earlier for these... we don't need to splice it down to Size?
stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
 // We can fail to get peer address on TCP
 socketAddressLen = socketAddress.Length;
 SocketAddressPal.Clear(socketAddress);
 }
@stephentoubstephentoubJul 27, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a bug fix?
@wfurtwfurtJul 27, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure but possibly yes. On Windows we seems to get the address but it fails on Linux. Perhaps we can also check if this is TCP and get the value from RemoteEndPoint? I can write issue for improvement and investigation.

I had trouble because setting Size zero would throw. Alternatively we can allow it to indicate that the buffer does not have any valid address.
stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
Outdated

stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/ReceiveFrom.cs
stephentoub
stephentoub
reviewed
Jul 27, 2023
View reviewed changes
@stephentoubstephentoub
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my comments/questions, LGTM.
@stephentoub
stephentoub
commented
Jul 27, 2023

Copy link


Copy Markdown

Member
I assume SendToAsync / ReceiveFromAsync are coming in a follow-up PR?
@wfurt
wfurt
commented
Jul 27, 2023

Copy link


Copy Markdown

MemberAuthor
I assume SendToAsync / ReceiveFromAsync are coming in a follow-up PR?
yes. That needs more work to clean up Internal.SocketAddress in socket code.
@wfurt
wfurt
commented
Jul 28, 2023

Copy link


Copy Markdown

MemberAuthor
this should be ready for another review pass @stephentoub
stephentoub
stephentoub
reviewed
Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/Interop/Windows/WinSock/Interop.WSAConnect.cs
Outdated

 internal static partial SocketError WSAConnect(
 SafeSocketHandle socketHandle,
 byte[] socketAddress,
Span<byte> socketAddress,
@stephentoubstephentoubAug 1, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make the actual LibraryImport private, with an internal wrapper that doesn't take socketAddressSize? e.g.
[LibraryImport(Interop.Libraries.Ws2_32,SetLastError=true)]privatestaticpartialSocketErrorWSAConnect(SafeSocketHandlesocketHandle,Span<byte>socketAddress,intsocketAddressSize,IntPtrinBuffer,IntPtroutBuffer,IntPtrsQOS,IntPtrgQOS);internalstaticSocketErrorWSAConnect(SafeSocketHandlesocketHandle,Span<byte>socketAddress,IntPtrinBuffer,IntPtroutBuffer,IntPtrsQOS,IntPtrgQOS)=>WSAConnect(socketHandle,socketAddress,socketAddress.Length,inBuffer,outBuffer,sQOS,gQOS);
?
Though reading further that might make it a bit inconsistent with some of the other overloads. It's just a bit strange to see both the span and length passed in.
stephentoub
stephentoub
reviewed
Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/Interop/Windows/WinSock/Interop.WSAConnect.cs
Outdated

stephentoub
stephentoub
reviewed
Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddress.cs
stephentoub
stephentoub
reviewed
Aug 1, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/SocketAddressPal.Unix.cs
Outdated

@wfurt
wfurt
commented
Aug 1, 2023

Copy link


Copy Markdown

MemberAuthor
perf check
MethodJobToolchainMeanErrorStdDevMedianMinMaxRatioRatioSDAllocatedAlloc Ratio
ConnectAcceptAsyncJob-QAPYHK\PR \corerun.exe416.5 us4.92 us4.61 us415.9 us408.6 us426.5 us1.010.011370 B0.99
ConnectAcceptAsyncJob-ZQMRZG\main\corerun.exe411.2 us3.12 us2.77 us410.7 us407.7 us416.6 us1.000.001386 B1.00
SendAsyncThenReceiveAsync_TaskJob-QAPYHK\PR \corerun.exe271,064.3 us4,562.00 us4,267.30 us269,604.6 us265,718.7 us277,834.9 us1.010.02752 B1.00
SendAsyncThenReceiveAsync_TaskJob-ZQMRZG\main\corerun.exe267,751.9 us1,734.53 us1,622.48 us267,574.0 us265,252.0 us270,458.9 us1.000.00752 B1.00
ReceiveAsyncThenSendAsync_TaskJob-QAPYHK\PR \corerun.exe351,264.2 us1,238.80 us1,158.77 us351,484.9 us349,380.1 us353,069.9 us1.020.011280 B1.29
ReceiveAsyncThenSendAsync_TaskJob-ZQMRZG\main\corerun.exe345,229.4 us1,554.32 us1,453.92 us345,121.6 us343,334.1 us348,427.2 us1.000.00992 B1.00
SendAsyncThenReceiveAsync_SocketAsyncEventArgsJob-QAPYHK\PR \corerun.exe262,947.6 us2,276.07 us2,129.04 us261,991.3 us260,505.5 us266,591.9 us0.960.011920 B1.00
SendAsyncThenReceiveAsync_SocketAsyncEventArgsJob-ZQMRZG\main\corerun.exe274,286.3 us2,102.03 us1,966.24 us274,853.0 us270,239.3 us277,223.5 us1.000.001920 B1.00
ReceiveAsyncThenSendAsync_SocketAsyncEventArgsJob-QAPYHK\PR \corerun.exe331,678.8 us990.62 us926.63 us331,653.9 us329,933.3 us333,237.0 us1.000.013088 B1.33
ReceiveAsyncThenSendAsync_SocketAsyncEventArgsJob-ZQMRZG\main\corerun.exe332,023.6 us1,PR 1 us1,428.75 us332,203.7 us329,059.4 us334,365.6 us1.000.002320 B1.00
@wfurt
wfurt
merged commit e2c6fcf
into
dotnet:mainAug 1, 2023
@karelzkarelz
added this to the 8.0.0 milestone
Aug 1, 2023

This was referenced Aug 2, 2023
 Merged

 Merged

 Merged

@MihaZupanMihaZupan
mentioned this pull request
Aug 7, 2023

Closed

@wfurtwfurt
mentioned this pull request
Aug 10, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Aug 31, 2023
@wfurt
wfurt
deleted the

udp2

branch
January 7, 2026 20:01
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub approved these changes

Assignees

@wfurtwfurt

Labels

area-System.Net.Socketsnew-api-needs-documentation

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[API Proposal]: make SocketAddress more useful 

3 participants

@wfurt@stephentoub@karelz