Uh oh!
There was an error while loading. Please reload this page.
[hot_reload] Check for added fields earlier in compute_class_bitmap - #89121
Merged
Conversation
lambdageek
marked this pull request as draft
July 18, 2023 19:23
lambdageek
marked this pull request as ready for review
July 18, 2023 19:40
lambdageekforce-pushed
the
fix-gh-86172
branch
2 times, most recently
from
July 18, 2023 19:42
1b727e3 to
c0510feCompareand in mono_class_create_runtime_vtable Added fields don't contribute to the class bitmap, and they also might not have their type resolved yet - move the "is from update" check before we need to access the field's type
vargaz
reviewed
Jul 18, 2023
Uh oh!
There was an error while loading. Please reload this page.
vargaz
approved these changes
Jul 18, 2023
fanyang-mono
approved these changes
Jul 18, 2023
This was referenced Jul 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added fields don't contribute to the class bitmap, and they also might not have their type resolved yet - move the "is from update" check before we need to access the field's type
Fixes#86172