') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); adding clrgc variant with regions enabled by mangod9 · Pull Request #89129 · dotnet/runtime · GitHub
Skip to content

adding clrgc variant with regions enabled - #89129

Merged
mangod9 merged 3 commits into
dotnet:mainfrom
mangod9:clrgc_regions
Jul 28, 2023
Merged

adding clrgc variant with regions enabled#89129
mangod9 merged 3 commits into
dotnet:mainfrom
mangod9:clrgc_regions

Conversation

@mangod9

@mangod9mangod9 commented Jul 18, 2023

Copy link
Copy Markdown
Member

we already ship standalone clrgc.dll with segments. This adds another clrgcr.dll with regions enabled.

@ghostghost assigned mangod9Jul 18, 2023
@ghost

ghost commented Jul 18, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

we already ship standalone clrgc.dll with segments. This adds another clrgcr.dll with regions enabled.

Author:mangod9
Assignees:-
Labels:

area-GC-coreclr

Milestone:-

@mangod9
mangod9 requested review from Maoni0, cshung and mrsharmJuly 18, 2023 23:37
mangod9
mangod9 commented Jul 18, 2023
View reviewed changes
Comment threadsrc/coreclr/gc/CMakeLists.txt
convert_to_absolute_path(GC_SOURCES ${GC_SOURCES})

# clrgcr is build with standalone+regions
if (CLR_CMAKE_TARGET_ARCH_ARM64 OR CLR_CMAKE_TARGET_ARCH_AMD64)

@mangod9mangod9Jul 18, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this builds clrgcr.dll (and libclrgcr.so) on 64 bit platforms. We could change naming if required.

@mrsharmmrsharmJul 27, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: for the sake of readability, would it be better to change the name to: clrgc_regions?

@mangod9mangod9Jul 27, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt want to name it as regions since longer term it might be for a different feature. Perhaps something like experimental or something. Maybe rename it clrgce for experimental ?

@Maoni0Maoni0Jul 27, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clrgcexp?

@mangod9mangod9Jul 27, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that works, will rename.

mangod9
mangod9 commented Jul 18, 2023
View reviewed changes
Comment threadsrc/coreclr/gc/CMakeLists.txt
@mangod9

mangod9 commented Jul 18, 2023

Copy link
Copy Markdown
MemberAuthor

CI failures look unrelated but will take a closer look.

This was referenced Jul 19, 2023
Closed
Closed
Closed
@mangod9

mangod9 commented Jul 19, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime

@azure-pipelines

azure-pipelinesBot commented Jul 19, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 19, 2023
Closed
Closed
Closed
@mangod9

mangod9 commented Jul 20, 2023

Copy link
Copy Markdown
MemberAuthor

Ci is now green. Please review, we can discuss naming, but anything we come up with would most likely require changing.

mrsharm
mrsharm approved these changes Jul 27, 2023
View reviewed changes

@mrsharmmrsharm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One small nit but it's not necessary.

@mangod9
mangod9 merged commit b869e8d into dotnet:mainJul 28, 2023
@mangod9
mangod9 deleted the clrgc_regions branch July 28, 2023 05:50
markples pushed a commit to markples/runtime that referenced this pull request Aug 23, 2023
@mangod9@markples
adding clrgc variant with regions enabled (dotnet#89129)
34e0b9e
* adding clrgc variant with regions enabled
* only build regions for 64 bit platforms
* rename to clrgcexp for experimental
@ghostghost locked as resolved and limited conversation to collaborators Aug 27, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Maoni0Maoni0Maoni0 approved these changes
@mrsharmmrsharmmrsharm approved these changes
@cshungcshungAwaiting requested review from cshung

Assignees

@mangod9mangod9

Labels

area-GC-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mangod9@Maoni0@mrsharm