Uh oh!
There was an error while loading. Please reload this page.
JIT: Expand inlined delegate calls in correct order - #89175
Conversation
The access of the target instance was incorrectly inserted right after the location of the delegate instance. Since this indirection can throw a NRE this is incorrect; to get the proper inlined behavior, the indirection must happen only after all arguments have been evaluated. Fixdotnet#75832
ghost
commented
Jul 19, 2023
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsThe access of the target instance was incorrectly inserted right after the location of the delegate instance. Since this indirection can throw a NRE this is incorrect; to get the proper inlined behavior, the indirection must happen only after all arguments have been evaluated. Fix #75832
|
jakobbotsch
commented
Jul 19, 2023
/azp run runtime |
No commit pushedDate could be found for PR 89175 in repo dotnet/runtime |
jakobbotsch
commented
Jul 19, 2023
/azp run runtime, runtime-coreclr jitstress, runtime-coreclr libraries-jitstress |
No commit pushedDate could be found for PR 89175 in repo dotnet/runtime |
jakobbotsch
commented
Jul 19, 2023
/azp run runtime, runtime-coreclr jitstress, runtime-coreclr libraries-jitstress |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jakobbotsch
commented
Jul 20, 2023
Failures are known. Diffs. As expected some minor size-wise diffs, with a large count of diffs due to the reordered IR. cc @dotnet/jit-contrib PTAL @BruceForstall |
The access of the target instance was incorrectly inserted right after the location of the delegate instance. Since this indirection can throw a NRE this is incorrect; to get the proper inlined behavior, the indirection must happen only after all arguments have been evaluated.
Fix#75832
Large number of diffs expected due to reordering, with relatively small overall size-wise diffs.