Skip to content

Remove Crossgen2's -O option in Test Builds Wherever Possible - #89223

Merged
ivdiazsa merged 8 commits into
dotnet:mainfrom
ivdiazsa:obsolete-optimization
Aug 1, 2023
Merged

Remove Crossgen2's -O option in Test Builds Wherever Possible#89223
ivdiazsa merged 8 commits into
dotnet:mainfrom
ivdiazsa:obsolete-optimization

Conversation

@ivdiazsa

@ivdiazsaivdiazsa commented Jul 19, 2023

Copy link
Copy Markdown
Contributor

This PR fixes issue #56148. The -O option for Crossgen2 was required in the past for several reasons. However, nowadays it's causing issues in some tests that depend on their assembly's debug bit, which the -O option causes to be ignored.

@ghostghost added the area-ReadyToRun label Jul 19, 2023
@ivdiazsaivdiazsa self-assigned this Jul 19, 2023
@ivdiazsaivdiazsa added this to the 8.0.0 milestone Jul 19, 2023
@ivdiazsaivdiazsa linked an issue Jul 19, 2023 that may be closed by this pull request
R2R jobs should not pass -O to crossgen2 #56148
Closed
@build-analysisbuild-analysisBot mentioned this pull request Jul 20, 2023
Closed
@ivdiazsa
ivdiazsa marked this pull request as ready for review July 25, 2023 18:24
@ivdiazsa
ivdiazsa requested a review from trylekJuly 25, 2023 18:24
@ivdiazsa

ivdiazsa commented Jul 25, 2023

Copy link
Copy Markdown
ContributorAuthor

@trylek Hi Tomas! I removed all the -O calls to Crossgen I could find, but I'm not sure if I missed others or whether some of these must remain. PTAL and let me know your thoughts.

@ivdiazsa

ivdiazsa commented Jul 25, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

azure-pipelinesBot commented Jul 25, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ivdiazsa

ivdiazsa commented Jul 25, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp help

@azure-pipelines

azure-pipelinesBot commented Jul 25, 2023

Copy link
Copy Markdown
Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@dotnetdotnet deleted a comment from azure-pipelinesBotJul 25, 2023
@ivdiazsa

ivdiazsa commented Jul 25, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp list

@azure-pipelines

azure-pipelinesBot commented Jul 25, 2023

Copy link
Copy Markdown
CI/CD Pipelines for this repository:

@ivdiazsa

ivdiazsa commented Jul 25, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Jul 25, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

trylek
trylek approved these changes Jul 25, 2023
View reviewed changes

@trylektrylek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thank you!

This was referenced Jul 26, 2023
Closed
Closed
Closed
Closed
Closed
Closed
@ivdiazsa

ivdiazsa commented Jul 26, 2023

Copy link
Copy Markdown
ContributorAuthor

Hmm seems like something broke in certain AOT configurations. Taking a look right now.

@ivdiazsa

ivdiazsa commented Jul 26, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Jul 26, 2023

Copy link
Copy Markdown

No commit pushedDate could be found for PR 89223 in repo dotnet/runtime

@ivdiazsa

ivdiazsa commented Jul 26, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Jul 26, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 27, 2023
Closed
Closed
Closed
@ivdiazsa

ivdiazsa commented Jul 27, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Jul 27, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 27, 2023
Open
Closed
@ivdiazsa

ivdiazsa commented Jul 28, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Jul 28, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@build-analysisbuild-analysisBot mentioned this pull request Jul 29, 2023
Closed
@ivdiazsa
Restored even the original change just to see whether there is
e51bc9e
actually a problem with the extra-platforms, or they're just trolling
at this point.
@ivdiazsa

ivdiazsa commented Jul 31, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Jul 31, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ivdiazsa

ivdiazsa commented Jul 31, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Jul 31, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ivdiazsa

ivdiazsa commented Jul 31, 2023

Copy link
Copy Markdown
ContributorAuthor

Extra Platforms seems to be utterly broken for Mono, completely unrelated to my changes. Will try to run only the default innerloop and outerloop with all the changes and if those pass, then this PR is ready to merge.

@ivdiazsa
Removed the -O's from Crossgen2 again after discovering the
abd20ef
extra-platforms pipelines are super broken right now.
@ivdiazsa

ivdiazsa commented Jul 31, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

azure-pipelinesBot commented Jul 31, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ivdiazsa

ivdiazsa commented Aug 1, 2023

Copy link
Copy Markdown
ContributorAuthor

R2R-CG2 failures are unrelated so merging this now.

@ivdiazsa
ivdiazsa merged commit ac464d2 into dotnet:mainAug 1, 2023
@jakobbotschjakobbotsch mentioned this pull request Aug 9, 2023
Merged
@AaronRobinsonMSFTAaronRobinsonMSFT mentioned this pull request Aug 9, 2023
Closed
@ivdiazsaivdiazsa mentioned this pull request Aug 9, 2023
Merged
@ghostghost locked as resolved and limited conversation to collaborators Sep 1, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@trylektrylektrylek approved these changes

Assignees

@ivdiazsaivdiazsa

Labels

area-ReadyToRun

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

R2R jobs should not pass -O to crossgen2

2 participants

@ivdiazsa@trylek
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Remove Crossgen2's -O option in Test Builds Wherever Possible by ivdiazsa · Pull Request #89223 · dotnet/runtime · GitHub
Skip to content
Remove Crossgen2's -O option in Test Builds Wherever Possible - #89223
Merged
ivdiazsa merged 8 commits into
dotnet:mainfrom 
ivdiazsa:obsolete-optimization
Aug 1, 2023
Merged
Remove Crossgen2's -O option in Test Builds Wherever Possible#89223
ivdiazsa merged 8 commits into
dotnet:mainfrom 
ivdiazsa:obsolete-optimization
Conversation
@ivdiazsa
@ivdiazsaivdiazsa
commented
Jul 19, 2023

Copy link


Copy Markdown

Contributor
This PR fixes issue #56148. The -O option for Crossgen2 was required in the past for several reasons. However, nowadays it's causing issues in some tests that depend on their assembly's debug bit, which the -O option causes to be ignored.
@ghostghost
added
the 
area-ReadyToRun

label
Jul 19, 2023
@ivdiazsaivdiazsa
self-assigned this
Jul 19, 2023
@ivdiazsaivdiazsa
added this to the 8.0.0 milestone
Jul 19, 2023
@ivdiazsaivdiazsa
linked an issue
Jul 19, 2023
that may be
closed
by this pull request


R2R jobs should not pass -O to crossgen2
#56148

Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 20, 2023

Closed

@ivdiazsa
ivdiazsa
marked this pull request as ready for review
July 25, 2023 18:24
@ivdiazsa
ivdiazsa
requested a review
from trylekJuly 25, 2023 18:24
@ivdiazsa
ivdiazsa
commented
Jul 25, 2023

Copy link


Copy Markdown

ContributorAuthor
@trylek Hi Tomas! I removed all the -O calls to Crossgen I could find, but I'm not sure if I missed others or whether some of these must remain. PTAL and let me know your thoughts.
@ivdiazsa
ivdiazsa
commented
Jul 25, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Jul 25, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@ivdiazsa
ivdiazsa
commented
Jul 25, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp help
@azure-pipelines
azure-pipelinesBot
commented
Jul 25, 2023

Copy link


Copy Markdown

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"


See additional documentation.
@dotnetdotnet
deleted a comment from azure-pipelinesBotJul 25, 2023
@ivdiazsa
ivdiazsa
commented
Jul 25, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp list
@azure-pipelines
azure-pipelinesBot
commented
Jul 25, 2023

Copy link


Copy Markdown


CI/CD Pipelines for this repository:
@ivdiazsa
ivdiazsa
commented
Jul 25, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 25, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
trylek
trylek
approved these changes
Jul 25, 2023
View reviewed changes
@trylektrylek
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thank you!

This was referenced Jul 26, 2023

Closed


Closed


Closed


Closed


Closed


Closed

@ivdiazsa
ivdiazsa
commented
Jul 26, 2023

Copy link


Copy Markdown

ContributorAuthor
Hmm seems like something broke in certain AOT configurations. Taking a look right now.
@ivdiazsa
ivdiazsa
commented
Jul 26, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 26, 2023

Copy link


Copy Markdown

No commit pushedDate could be found for PR 89223 in repo dotnet/runtime
@ivdiazsa
ivdiazsa
commented
Jul 26, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 26, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 27, 2023

Closed


Closed


Closed

@ivdiazsa
ivdiazsa
commented
Jul 27, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 27, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 27, 2023

Open


Closed

@ivdiazsa
ivdiazsa
commented
Jul 28, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 28, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 29, 2023

Closed

@ivdiazsa
Restored even the original change just to see whether there is
e51bc9e
actually a problem with the extra-platforms, or they're just trolling
at this point.
@ivdiazsa
ivdiazsa
commented
Jul 31, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 31, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@ivdiazsa
ivdiazsa
commented
Jul 31, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 31, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@ivdiazsa
ivdiazsa
commented
Jul 31, 2023

Copy link


Copy Markdown

ContributorAuthor
Extra Platforms seems to be utterly broken for Mono, completely unrelated to my changes. Will try to run only the default innerloop and outerloop with all the changes and if those pass, then this PR is ready to merge.
@ivdiazsa
Removed the -O's from Crossgen2 again after discovering the
abd20ef
extra-platforms pipelines are super broken right now.
@ivdiazsa
ivdiazsa
commented
Jul 31, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Jul 31, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@ivdiazsa
ivdiazsa
commented
Aug 1, 2023

Copy link


Copy Markdown

ContributorAuthor
R2R-CG2 failures are unrelated so merging this now.
@ivdiazsa
ivdiazsa
merged commit ac464d2
into
dotnet:mainAug 1, 2023
@jakobbotschjakobbotsch
mentioned this pull request
Aug 9, 2023
 Merged

@AaronRobinsonMSFTAaronRobinsonMSFT
mentioned this pull request
Aug 9, 2023

Closed

@ivdiazsaivdiazsa
mentioned this pull request
Aug 9, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 1, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@trylektrylektrylek approved these changes

Assignees

@ivdiazsaivdiazsa

Labels

area-ReadyToRun

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

R2R jobs should not pass -O to crossgen2


2 participants

@ivdiazsa@trylek

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove Crossgen2's -O option in Test Builds Wherever Possible by ivdiazsa · Pull Request #89223 · dotnet/runtime · GitHub
Skip to content
Remove Crossgen2's -O option in Test Builds Wherever Possible - #89223
Merged
ivdiazsa merged 8 commits into
dotnet:mainfrom 
ivdiazsa:obsolete-optimization
Aug 1, 2023
Merged
Remove Crossgen2's -O option in Test Builds Wherever Possible#89223
ivdiazsa merged 8 commits into
dotnet:mainfrom 
ivdiazsa:obsolete-optimization
Conversation
@ivdiazsa
@ivdiazsaivdiazsa
commented
Jul 19, 2023

Copy link


Copy Markdown

Contributor
This PR fixes issue #56148. The -O option for Crossgen2 was required in the past for several reasons. However, nowadays it's causing issues in some tests that depend on their assembly's debug bit, which the -O option causes to be ignored.
@ghostghost
added
the 
area-ReadyToRun

label
Jul 19, 2023
@ivdiazsaivdiazsa
self-assigned this
Jul 19, 2023
@ivdiazsaivdiazsa
added this to the 8.0.0 milestone
Jul 19, 2023
@ivdiazsaivdiazsa
linked an issue
Jul 19, 2023
that may be
closed
by this pull request


R2R jobs should not pass -O to crossgen2
#56148

Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 20, 2023

Closed

@ivdiazsa
ivdiazsa
marked this pull request as ready for review
July 25, 2023 18:24
@ivdiazsa
ivdiazsa
requested a review
from trylekJuly 25, 2023 18:24
@ivdiazsa
ivdiazsa
commented
Jul 25, 2023

Copy link


Copy Markdown

ContributorAuthor
@trylek Hi Tomas! I removed all the -O calls to Crossgen I could find, but I'm not sure if I missed others or whether some of these must remain. PTAL and let me know your thoughts.
@ivdiazsa
ivdiazsa
commented
Jul 25, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Jul 25, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@ivdiazsa
ivdiazsa
commented
Jul 25, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp help
@azure-pipelines
azure-pipelinesBot
commented
Jul 25, 2023

Copy link


Copy Markdown

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"


See additional documentation.
@dotnetdotnet
deleted a comment from azure-pipelinesBotJul 25, 2023
@ivdiazsa
ivdiazsa
commented
Jul 25, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp list
@azure-pipelines
azure-pipelinesBot
commented
Jul 25, 2023

Copy link


Copy Markdown


CI/CD Pipelines for this repository:
@ivdiazsa
ivdiazsa
commented
Jul 25, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 25, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
trylek
trylek
approved these changes
Jul 25, 2023
View reviewed changes
@trylektrylek
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thank you!

This was referenced Jul 26, 2023

Closed


Closed


Closed


Closed


Closed


Closed

@ivdiazsa
ivdiazsa
commented
Jul 26, 2023

Copy link


Copy Markdown

ContributorAuthor
Hmm seems like something broke in certain AOT configurations. Taking a look right now.
@ivdiazsa
ivdiazsa
commented
Jul 26, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 26, 2023

Copy link


Copy Markdown

No commit pushedDate could be found for PR 89223 in repo dotnet/runtime
@ivdiazsa
ivdiazsa
commented
Jul 26, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 26, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 27, 2023

Closed


Closed


Closed

@ivdiazsa
ivdiazsa
commented
Jul 27, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 27, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 27, 2023

Open


Closed

@ivdiazsa
ivdiazsa
commented
Jul 28, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 28, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 29, 2023

Closed

@ivdiazsa
Restored even the original change just to see whether there is
e51bc9e
actually a problem with the extra-platforms, or they're just trolling
at this point.
@ivdiazsa
ivdiazsa
commented
Jul 31, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 31, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@ivdiazsa
ivdiazsa
commented
Jul 31, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 31, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@ivdiazsa
ivdiazsa
commented
Jul 31, 2023

Copy link


Copy Markdown

ContributorAuthor
Extra Platforms seems to be utterly broken for Mono, completely unrelated to my changes. Will try to run only the default innerloop and outerloop with all the changes and if those pass, then this PR is ready to merge.
@ivdiazsa
Removed the -O's from Crossgen2 again after discovering the
abd20ef
extra-platforms pipelines are super broken right now.
@ivdiazsa
ivdiazsa
commented
Jul 31, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Jul 31, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@ivdiazsa
ivdiazsa
commented
Aug 1, 2023

Copy link


Copy Markdown

ContributorAuthor
R2R-CG2 failures are unrelated so merging this now.
@ivdiazsa
ivdiazsa
merged commit ac464d2
into
dotnet:mainAug 1, 2023
@jakobbotschjakobbotsch
mentioned this pull request
Aug 9, 2023
 Merged

@AaronRobinsonMSFTAaronRobinsonMSFT
mentioned this pull request
Aug 9, 2023

Closed

@ivdiazsaivdiazsa
mentioned this pull request
Aug 9, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 1, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@trylektrylektrylek approved these changes

Assignees

@ivdiazsaivdiazsa

Labels

area-ReadyToRun

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

R2R jobs should not pass -O to crossgen2


2 participants

@ivdiazsa@trylek

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove Crossgen2's -O option in Test Builds Wherever Possible by ivdiazsa · Pull Request #89223 · dotnet/runtime · GitHub
Skip to content
Remove Crossgen2's -O option in Test Builds Wherever Possible - #89223
Merged
ivdiazsa merged 8 commits into
dotnet:mainfrom 
ivdiazsa:obsolete-optimization
Aug 1, 2023
Merged
Remove Crossgen2's -O option in Test Builds Wherever Possible#89223
ivdiazsa merged 8 commits into
dotnet:mainfrom 
ivdiazsa:obsolete-optimization
Conversation
@ivdiazsa
@ivdiazsaivdiazsa
commented
Jul 19, 2023

Copy link


Copy Markdown

Contributor
This PR fixes issue #56148. The -O option for Crossgen2 was required in the past for several reasons. However, nowadays it's causing issues in some tests that depend on their assembly's debug bit, which the -O option causes to be ignored.
@ghostghost
added
the 
area-ReadyToRun

label
Jul 19, 2023
@ivdiazsaivdiazsa
self-assigned this
Jul 19, 2023
@ivdiazsaivdiazsa
added this to the 8.0.0 milestone
Jul 19, 2023
@ivdiazsaivdiazsa
linked an issue
Jul 19, 2023
that may be
closed
by this pull request


R2R jobs should not pass -O to crossgen2
#56148

Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 20, 2023

Closed

@ivdiazsa
ivdiazsa
marked this pull request as ready for review
July 25, 2023 18:24
@ivdiazsa
ivdiazsa
requested a review
from trylekJuly 25, 2023 18:24
@ivdiazsa
ivdiazsa
commented
Jul 25, 2023

Copy link


Copy Markdown

ContributorAuthor
@trylek Hi Tomas! I removed all the -O calls to Crossgen I could find, but I'm not sure if I missed others or whether some of these must remain. PTAL and let me know your thoughts.
@ivdiazsa
ivdiazsa
commented
Jul 25, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Jul 25, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@ivdiazsa
ivdiazsa
commented
Jul 25, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp help
@azure-pipelines
azure-pipelinesBot
commented
Jul 25, 2023

Copy link


Copy Markdown

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"


See additional documentation.
@dotnetdotnet
deleted a comment from azure-pipelinesBotJul 25, 2023
@ivdiazsa
ivdiazsa
commented
Jul 25, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp list
@azure-pipelines
azure-pipelinesBot
commented
Jul 25, 2023

Copy link


Copy Markdown


CI/CD Pipelines for this repository:
@ivdiazsa
ivdiazsa
commented
Jul 25, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 25, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
trylek
trylek
approved these changes
Jul 25, 2023
View reviewed changes
@trylektrylek
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thank you!

This was referenced Jul 26, 2023

Closed


Closed


Closed


Closed


Closed


Closed

@ivdiazsa
ivdiazsa
commented
Jul 26, 2023

Copy link


Copy Markdown

ContributorAuthor
Hmm seems like something broke in certain AOT configurations. Taking a look right now.
@ivdiazsa
ivdiazsa
commented
Jul 26, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 26, 2023

Copy link


Copy Markdown

No commit pushedDate could be found for PR 89223 in repo dotnet/runtime
@ivdiazsa
ivdiazsa
commented
Jul 26, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 26, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 27, 2023

Closed


Closed


Closed

@ivdiazsa
ivdiazsa
commented
Jul 27, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 27, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 27, 2023

Open


Closed

@ivdiazsa
ivdiazsa
commented
Jul 28, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 28, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 29, 2023

Closed

@ivdiazsa
Restored even the original change just to see whether there is
e51bc9e
actually a problem with the extra-platforms, or they're just trolling
at this point.
@ivdiazsa
ivdiazsa
commented
Jul 31, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 31, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@ivdiazsa
ivdiazsa
commented
Jul 31, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 31, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@ivdiazsa
ivdiazsa
commented
Jul 31, 2023

Copy link


Copy Markdown

ContributorAuthor
Extra Platforms seems to be utterly broken for Mono, completely unrelated to my changes. Will try to run only the default innerloop and outerloop with all the changes and if those pass, then this PR is ready to merge.
@ivdiazsa
Removed the -O's from Crossgen2 again after discovering the
abd20ef
extra-platforms pipelines are super broken right now.
@ivdiazsa
ivdiazsa
commented
Jul 31, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Jul 31, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@ivdiazsa
ivdiazsa
commented
Aug 1, 2023

Copy link


Copy Markdown

ContributorAuthor
R2R-CG2 failures are unrelated so merging this now.
@ivdiazsa
ivdiazsa
merged commit ac464d2
into
dotnet:mainAug 1, 2023
@jakobbotschjakobbotsch
mentioned this pull request
Aug 9, 2023
 Merged

@AaronRobinsonMSFTAaronRobinsonMSFT
mentioned this pull request
Aug 9, 2023

Closed

@ivdiazsaivdiazsa
mentioned this pull request
Aug 9, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 1, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@trylektrylektrylek approved these changes

Assignees

@ivdiazsaivdiazsa

Labels

area-ReadyToRun

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

R2R jobs should not pass -O to crossgen2


2 participants

@ivdiazsa@trylek

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Remove Crossgen2's -O option in Test Builds Wherever Possible by ivdiazsa · Pull Request #89223 · dotnet/runtime · GitHub
Skip to content
Remove Crossgen2's -O option in Test Builds Wherever Possible - #89223
Merged
ivdiazsa merged 8 commits into
dotnet:mainfrom 
ivdiazsa:obsolete-optimization
Aug 1, 2023
Merged
Remove Crossgen2's -O option in Test Builds Wherever Possible#89223
ivdiazsa merged 8 commits into
dotnet:mainfrom 
ivdiazsa:obsolete-optimization
Conversation
@ivdiazsa
@ivdiazsaivdiazsa
commented
Jul 19, 2023

Copy link


Copy Markdown

Contributor
This PR fixes issue #56148. The -O option for Crossgen2 was required in the past for several reasons. However, nowadays it's causing issues in some tests that depend on their assembly's debug bit, which the -O option causes to be ignored.
@ghostghost
added
the 
area-ReadyToRun

label
Jul 19, 2023
@ivdiazsaivdiazsa
self-assigned this
Jul 19, 2023
@ivdiazsaivdiazsa
added this to the 8.0.0 milestone
Jul 19, 2023
@ivdiazsaivdiazsa
linked an issue
Jul 19, 2023
that may be
closed
by this pull request


R2R jobs should not pass -O to crossgen2
#56148

Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 20, 2023

Closed

@ivdiazsa
ivdiazsa
marked this pull request as ready for review
July 25, 2023 18:24
@ivdiazsa
ivdiazsa
requested a review
from trylekJuly 25, 2023 18:24
@ivdiazsa
ivdiazsa
commented
Jul 25, 2023

Copy link


Copy Markdown

ContributorAuthor
@trylek Hi Tomas! I removed all the -O calls to Crossgen I could find, but I'm not sure if I missed others or whether some of these must remain. PTAL and let me know your thoughts.
@ivdiazsa
ivdiazsa
commented
Jul 25, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Jul 25, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@ivdiazsa
ivdiazsa
commented
Jul 25, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp help
@azure-pipelines
azure-pipelinesBot
commented
Jul 25, 2023

Copy link


Copy Markdown

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"


See additional documentation.
@dotnetdotnet
deleted a comment from azure-pipelinesBotJul 25, 2023
@ivdiazsa
ivdiazsa
commented
Jul 25, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp list
@azure-pipelines
azure-pipelinesBot
commented
Jul 25, 2023

Copy link


Copy Markdown


CI/CD Pipelines for this repository:
@ivdiazsa
ivdiazsa
commented
Jul 25, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 25, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
trylek
trylek
approved these changes
Jul 25, 2023
View reviewed changes
@trylektrylek
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thank you!

This was referenced Jul 26, 2023

Closed


Closed


Closed


Closed


Closed


Closed

@ivdiazsa
ivdiazsa
commented
Jul 26, 2023

Copy link


Copy Markdown

ContributorAuthor
Hmm seems like something broke in certain AOT configurations. Taking a look right now.
@ivdiazsa
ivdiazsa
commented
Jul 26, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 26, 2023

Copy link


Copy Markdown

No commit pushedDate could be found for PR 89223 in repo dotnet/runtime
@ivdiazsa
ivdiazsa
commented
Jul 26, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 26, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 27, 2023

Closed


Closed


Closed

@ivdiazsa
ivdiazsa
commented
Jul 27, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 27, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 27, 2023

Open


Closed

@ivdiazsa
ivdiazsa
commented
Jul 28, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 28, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 29, 2023

Closed

@ivdiazsa
Restored even the original change just to see whether there is
e51bc9e
actually a problem with the extra-platforms, or they're just trolling
at this point.
@ivdiazsa
ivdiazsa
commented
Jul 31, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 31, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@ivdiazsa
ivdiazsa
commented
Jul 31, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 31, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@ivdiazsa
ivdiazsa
commented
Jul 31, 2023

Copy link


Copy Markdown

ContributorAuthor
Extra Platforms seems to be utterly broken for Mono, completely unrelated to my changes. Will try to run only the default innerloop and outerloop with all the changes and if those pass, then this PR is ready to merge.
@ivdiazsa
Removed the -O's from Crossgen2 again after discovering the
abd20ef
extra-platforms pipelines are super broken right now.
@ivdiazsa
ivdiazsa
commented
Jul 31, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Jul 31, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@ivdiazsa
ivdiazsa
commented
Aug 1, 2023

Copy link


Copy Markdown

ContributorAuthor
R2R-CG2 failures are unrelated so merging this now.
@ivdiazsa
ivdiazsa
merged commit ac464d2
into
dotnet:mainAug 1, 2023
@jakobbotschjakobbotsch
mentioned this pull request
Aug 9, 2023
 Merged

@AaronRobinsonMSFTAaronRobinsonMSFT
mentioned this pull request
Aug 9, 2023

Closed

@ivdiazsaivdiazsa
mentioned this pull request
Aug 9, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 1, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@trylektrylektrylek approved these changes

Assignees

@ivdiazsaivdiazsa

Labels

area-ReadyToRun

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

R2R jobs should not pass -O to crossgen2


2 participants

@ivdiazsa@trylek

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove Crossgen2's -O option in Test Builds Wherever Possible by ivdiazsa · Pull Request #89223 · dotnet/runtime · GitHub
Skip to content
Remove Crossgen2's -O option in Test Builds Wherever Possible - #89223
Merged
ivdiazsa merged 8 commits into
dotnet:mainfrom 
ivdiazsa:obsolete-optimization
Aug 1, 2023
Merged
Remove Crossgen2's -O option in Test Builds Wherever Possible#89223
ivdiazsa merged 8 commits into
dotnet:mainfrom 
ivdiazsa:obsolete-optimization
Conversation
@ivdiazsa
@ivdiazsaivdiazsa
commented
Jul 19, 2023

Copy link


Copy Markdown

Contributor
This PR fixes issue #56148. The -O option for Crossgen2 was required in the past for several reasons. However, nowadays it's causing issues in some tests that depend on their assembly's debug bit, which the -O option causes to be ignored.
@ghostghost
added
the 
area-ReadyToRun

label
Jul 19, 2023
@ivdiazsaivdiazsa
self-assigned this
Jul 19, 2023
@ivdiazsaivdiazsa
added this to the 8.0.0 milestone
Jul 19, 2023
@ivdiazsaivdiazsa
linked an issue
Jul 19, 2023
that may be
closed
by this pull request


R2R jobs should not pass -O to crossgen2
#56148

Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 20, 2023

Closed

@ivdiazsa
ivdiazsa
marked this pull request as ready for review
July 25, 2023 18:24
@ivdiazsa
ivdiazsa
requested a review
from trylekJuly 25, 2023 18:24
@ivdiazsa
ivdiazsa
commented
Jul 25, 2023

Copy link


Copy Markdown

ContributorAuthor
@trylek Hi Tomas! I removed all the -O calls to Crossgen I could find, but I'm not sure if I missed others or whether some of these must remain. PTAL and let me know your thoughts.
@ivdiazsa
ivdiazsa
commented
Jul 25, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Jul 25, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@ivdiazsa
ivdiazsa
commented
Jul 25, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp help
@azure-pipelines
azure-pipelinesBot
commented
Jul 25, 2023

Copy link


Copy Markdown

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"


See additional documentation.
@dotnetdotnet
deleted a comment from azure-pipelinesBotJul 25, 2023
@ivdiazsa
ivdiazsa
commented
Jul 25, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp list
@azure-pipelines
azure-pipelinesBot
commented
Jul 25, 2023

Copy link


Copy Markdown


CI/CD Pipelines for this repository:
@ivdiazsa
ivdiazsa
commented
Jul 25, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 25, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
trylek
trylek
approved these changes
Jul 25, 2023
View reviewed changes
@trylektrylek
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thank you!

This was referenced Jul 26, 2023

Closed


Closed


Closed


Closed


Closed


Closed

@ivdiazsa
ivdiazsa
commented
Jul 26, 2023

Copy link


Copy Markdown

ContributorAuthor
Hmm seems like something broke in certain AOT configurations. Taking a look right now.
@ivdiazsa
ivdiazsa
commented
Jul 26, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 26, 2023

Copy link


Copy Markdown

No commit pushedDate could be found for PR 89223 in repo dotnet/runtime
@ivdiazsa
ivdiazsa
commented
Jul 26, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 26, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 27, 2023

Closed


Closed


Closed

@ivdiazsa
ivdiazsa
commented
Jul 27, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 27, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 27, 2023

Open


Closed

@ivdiazsa
ivdiazsa
commented
Jul 28, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 28, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 29, 2023

Closed

@ivdiazsa
Restored even the original change just to see whether there is
e51bc9e
actually a problem with the extra-platforms, or they're just trolling
at this point.
@ivdiazsa
ivdiazsa
commented
Jul 31, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 31, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@ivdiazsa
ivdiazsa
commented
Jul 31, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 31, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@ivdiazsa
ivdiazsa
commented
Jul 31, 2023

Copy link


Copy Markdown

ContributorAuthor
Extra Platforms seems to be utterly broken for Mono, completely unrelated to my changes. Will try to run only the default innerloop and outerloop with all the changes and if those pass, then this PR is ready to merge.
@ivdiazsa
Removed the -O's from Crossgen2 again after discovering the
abd20ef
extra-platforms pipelines are super broken right now.
@ivdiazsa
ivdiazsa
commented
Jul 31, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Jul 31, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@ivdiazsa
ivdiazsa
commented
Aug 1, 2023

Copy link


Copy Markdown

ContributorAuthor
R2R-CG2 failures are unrelated so merging this now.
@ivdiazsa
ivdiazsa
merged commit ac464d2
into
dotnet:mainAug 1, 2023
@jakobbotschjakobbotsch
mentioned this pull request
Aug 9, 2023
 Merged

@AaronRobinsonMSFTAaronRobinsonMSFT
mentioned this pull request
Aug 9, 2023

Closed

@ivdiazsaivdiazsa
mentioned this pull request
Aug 9, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 1, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@trylektrylektrylek approved these changes

Assignees

@ivdiazsaivdiazsa

Labels

area-ReadyToRun

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

R2R jobs should not pass -O to crossgen2


2 participants

@ivdiazsa@trylek

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Remove Crossgen2's -O option in Test Builds Wherever Possible by ivdiazsa · Pull Request #89223 · dotnet/runtime · GitHub
Skip to content
Remove Crossgen2's -O option in Test Builds Wherever Possible - #89223
Merged
ivdiazsa merged 8 commits into
dotnet:mainfrom 
ivdiazsa:obsolete-optimization
Aug 1, 2023
Merged
Remove Crossgen2's -O option in Test Builds Wherever Possible#89223
ivdiazsa merged 8 commits into
dotnet:mainfrom 
ivdiazsa:obsolete-optimization
Conversation
@ivdiazsa
@ivdiazsaivdiazsa
commented
Jul 19, 2023

Copy link


Copy Markdown

Contributor
This PR fixes issue #56148. The -O option for Crossgen2 was required in the past for several reasons. However, nowadays it's causing issues in some tests that depend on their assembly's debug bit, which the -O option causes to be ignored.
@ghostghost
added
the 
area-ReadyToRun

label
Jul 19, 2023
@ivdiazsaivdiazsa
self-assigned this
Jul 19, 2023
@ivdiazsaivdiazsa
added this to the 8.0.0 milestone
Jul 19, 2023
@ivdiazsaivdiazsa
linked an issue
Jul 19, 2023
that may be
closed
by this pull request


R2R jobs should not pass -O to crossgen2
#56148

Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 20, 2023

Closed

@ivdiazsa
ivdiazsa
marked this pull request as ready for review
July 25, 2023 18:24
@ivdiazsa
ivdiazsa
requested a review
from trylekJuly 25, 2023 18:24
@ivdiazsa
ivdiazsa
commented
Jul 25, 2023

Copy link


Copy Markdown

ContributorAuthor
@trylek Hi Tomas! I removed all the -O calls to Crossgen I could find, but I'm not sure if I missed others or whether some of these must remain. PTAL and let me know your thoughts.
@ivdiazsa
ivdiazsa
commented
Jul 25, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Jul 25, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@ivdiazsa
ivdiazsa
commented
Jul 25, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp help
@azure-pipelines
azure-pipelinesBot
commented
Jul 25, 2023

Copy link


Copy Markdown

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"


See additional documentation.
@dotnetdotnet
deleted a comment from azure-pipelinesBotJul 25, 2023
@ivdiazsa
ivdiazsa
commented
Jul 25, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp list
@azure-pipelines
azure-pipelinesBot
commented
Jul 25, 2023

Copy link


Copy Markdown


CI/CD Pipelines for this repository:
@ivdiazsa
ivdiazsa
commented
Jul 25, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 25, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
trylek
trylek
approved these changes
Jul 25, 2023
View reviewed changes
@trylektrylek
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thank you!

This was referenced Jul 26, 2023

Closed


Closed


Closed


Closed


Closed


Closed

@ivdiazsa
ivdiazsa
commented
Jul 26, 2023

Copy link


Copy Markdown

ContributorAuthor
Hmm seems like something broke in certain AOT configurations. Taking a look right now.
@ivdiazsa
ivdiazsa
commented
Jul 26, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 26, 2023

Copy link


Copy Markdown

No commit pushedDate could be found for PR 89223 in repo dotnet/runtime
@ivdiazsa
ivdiazsa
commented
Jul 26, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 26, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 27, 2023

Closed


Closed


Closed

@ivdiazsa
ivdiazsa
commented
Jul 27, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 27, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 27, 2023

Open


Closed

@ivdiazsa
ivdiazsa
commented
Jul 28, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 28, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 29, 2023

Closed

@ivdiazsa
Restored even the original change just to see whether there is
e51bc9e
actually a problem with the extra-platforms, or they're just trolling
at this point.
@ivdiazsa
ivdiazsa
commented
Jul 31, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 31, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@ivdiazsa
ivdiazsa
commented
Jul 31, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Jul 31, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@ivdiazsa
ivdiazsa
commented
Jul 31, 2023

Copy link


Copy Markdown

ContributorAuthor
Extra Platforms seems to be utterly broken for Mono, completely unrelated to my changes. Will try to run only the default innerloop and outerloop with all the changes and if those pass, then this PR is ready to merge.
@ivdiazsa
Removed the -O's from Crossgen2 again after discovering the
abd20ef
extra-platforms pipelines are super broken right now.
@ivdiazsa
ivdiazsa
commented
Jul 31, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Jul 31, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@ivdiazsa
ivdiazsa
commented
Aug 1, 2023

Copy link


Copy Markdown

ContributorAuthor
R2R-CG2 failures are unrelated so merging this now.
@ivdiazsa
ivdiazsa
merged commit ac464d2
into
dotnet:mainAug 1, 2023
@jakobbotschjakobbotsch
mentioned this pull request
Aug 9, 2023
 Merged

@AaronRobinsonMSFTAaronRobinsonMSFT
mentioned this pull request
Aug 9, 2023

Closed

@ivdiazsaivdiazsa
mentioned this pull request
Aug 9, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 1, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@trylektrylektrylek approved these changes

Assignees

@ivdiazsaivdiazsa

Labels

area-ReadyToRun

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

R2R jobs should not pass -O to crossgen2


2 participants

@ivdiazsa@trylek