[release/8.0-preview7] Filter list of candidate invocations for parsing in binding generator

[github-actions]

Backport of #89226 to release/8.0-preview7

/cc @layomia

Customer Impact

Improves IDE perf when the generator is used. Average time spent in the generator goes from ~2s to ~145ms, using the Roslyn repo as a test. Details in #89226 / https://gist.github.com/layomia/8f51ac107f76853f4f37a6a7c596f67e.

Testing

Existing tests still pass. Manual testing with tracing demonstrates significant performance improvement.

Risk

Invocation processing logic is the same, just filtering based on the names of the input method calls, and avoiding expensive checks (i.e skipping from the list) when there's no match. There might method name aliasing which could cause dropping some calls, but it's probably fair to expect an exact match e.g. .Bind, .Configure, etc. It would be good to get any feedback/issues filed here.

[ghost]

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Backport of #89226 to release/8.0-preview7

/cc @layomia

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

• The PR target branch is release/X.0-staging, not release/X.0.

• If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author:	github-actions[bot]
Assignees:	-
Labels:	area-Extensions-Configuration, needs-area-label
Milestone:	-

[ericstj]

This was approved over mail last week, but it might be too late to merge at this point. Let's check with @mmitche and @carlossanlop on that.

[ericstj]

Too late to merge for Preview 7

[carlossanlop]

Reopening. The CI passed in the previous run before closing, so we can merge it ASAP. We still have runway.

[github-actions]

Backport of #89226 to release/8.0-preview7

/cc @layomia

Customer Impact

Improves IDE perf when the generator is used. Average time spent in the generator goes from ~2s to ~145ms, using the Roslyn repo as a test. Details in #89226 / https://gist.github.com/layomia/8f51ac107f76853f4f37a6a7c596f67e.

Testing

Existing tests still pass. Manual testing with tracing demonstrates significant performance improvement.

Risk

Invocation processing logic is the same, just filtering based on the names of the input method calls, and avoiding expensive checks (i.e skipping from the list) when there's no match. There might method name aliasing which could cause dropping some calls, but it's probably fair to expect an exact match e.g. .Bind, .Configure, etc. It would be good to get any feedback/issues filed here.

[ghost]

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Backport of #89226 to release/8.0-preview7

/cc @layomia

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

• The PR target branch is release/X.0-staging, not release/X.0.

• If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author:	github-actions[bot]
Assignees:	-
Labels:	area-Extensions-Configuration, needs-area-label
Milestone:	-

[ericstj]

This was approved over mail last week, but it might be too late to merge at this point. Let's check with @mmitche and @carlossanlop on that.

[ericstj]

Too late to merge for Preview 7

[carlossanlop]

Reopening. The CI passed in the previous run before closing, so we can merge it ASAP. We still have runway.

[github-actions]

Backport of #89226 to release/8.0-preview7

/cc @layomia

Customer Impact

Improves IDE perf when the generator is used. Average time spent in the generator goes from ~2s to ~145ms, using the Roslyn repo as a test. Details in #89226 / https://gist.github.com/layomia/8f51ac107f76853f4f37a6a7c596f67e.

Testing

Existing tests still pass. Manual testing with tracing demonstrates significant performance improvement.

Risk

Invocation processing logic is the same, just filtering based on the names of the input method calls, and avoiding expensive checks (i.e skipping from the list) when there's no match. There might method name aliasing which could cause dropping some calls, but it's probably fair to expect an exact match e.g. .Bind, .Configure, etc. It would be good to get any feedback/issues filed here.

[ghost]

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Backport of #89226 to release/8.0-preview7

/cc @layomia

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

• The PR target branch is release/X.0-staging, not release/X.0.

• If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author:	github-actions[bot]
Assignees:	-
Labels:	area-Extensions-Configuration, needs-area-label
Milestone:	-

[ericstj]

This was approved over mail last week, but it might be too late to merge at this point. Let's check with @mmitche and @carlossanlop on that.

[ericstj]

Too late to merge for Preview 7

[carlossanlop]

Reopening. The CI passed in the previous run before closing, so we can merge it ASAP. We still have runway.

[github-actions]

Backport of #89226 to release/8.0-preview7

/cc @layomia

Customer Impact

Improves IDE perf when the generator is used. Average time spent in the generator goes from ~2s to ~145ms, using the Roslyn repo as a test. Details in #89226 / https://gist.github.com/layomia/8f51ac107f76853f4f37a6a7c596f67e.

Testing

Existing tests still pass. Manual testing with tracing demonstrates significant performance improvement.

Risk

Invocation processing logic is the same, just filtering based on the names of the input method calls, and avoiding expensive checks (i.e skipping from the list) when there's no match. There might method name aliasing which could cause dropping some calls, but it's probably fair to expect an exact match e.g. .Bind, .Configure, etc. It would be good to get any feedback/issues filed here.

[ghost]

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Backport of #89226 to release/8.0-preview7

/cc @layomia

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

• The PR target branch is release/X.0-staging, not release/X.0.

• If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author:	github-actions[bot]
Assignees:	-
Labels:	area-Extensions-Configuration, needs-area-label
Milestone:	-

[ericstj]

This was approved over mail last week, but it might be too late to merge at this point. Let's check with @mmitche and @carlossanlop on that.

[ericstj]

Too late to merge for Preview 7

[carlossanlop]

Reopening. The CI passed in the previous run before closing, so we can merge it ASAP. We still have runway.

[github-actions]

Backport of #89226 to release/8.0-preview7

/cc @layomia

Customer Impact

Improves IDE perf when the generator is used. Average time spent in the generator goes from ~2s to ~145ms, using the Roslyn repo as a test. Details in #89226 / https://gist.github.com/layomia/8f51ac107f76853f4f37a6a7c596f67e.

Testing

Existing tests still pass. Manual testing with tracing demonstrates significant performance improvement.

Risk

Invocation processing logic is the same, just filtering based on the names of the input method calls, and avoiding expensive checks (i.e skipping from the list) when there's no match. There might method name aliasing which could cause dropping some calls, but it's probably fair to expect an exact match e.g. .Bind, .Configure, etc. It would be good to get any feedback/issues filed here.

[ghost]

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Backport of #89226 to release/8.0-preview7

/cc @layomia

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

• The PR target branch is release/X.0-staging, not release/X.0.

• If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author:	github-actions[bot]
Assignees:	-
Labels:	area-Extensions-Configuration, needs-area-label
Milestone:	-

[ericstj]

This was approved over mail last week, but it might be too late to merge at this point. Let's check with @mmitche and @carlossanlop on that.

[ericstj]

Too late to merge for Preview 7

[carlossanlop]

Reopening. The CI passed in the previous run before closing, so we can merge it ASAP. We still have runway.

[github-actions]

Backport of #89226 to release/8.0-preview7

/cc @layomia

Customer Impact

Improves IDE perf when the generator is used. Average time spent in the generator goes from ~2s to ~145ms, using the Roslyn repo as a test. Details in #89226 / https://gist.github.com/layomia/8f51ac107f76853f4f37a6a7c596f67e.

Testing

Existing tests still pass. Manual testing with tracing demonstrates significant performance improvement.

Risk

Invocation processing logic is the same, just filtering based on the names of the input method calls, and avoiding expensive checks (i.e skipping from the list) when there's no match. There might method name aliasing which could cause dropping some calls, but it's probably fair to expect an exact match e.g. .Bind, .Configure, etc. It would be good to get any feedback/issues filed here.

[ghost]

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Backport of #89226 to release/8.0-preview7

/cc @layomia

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

• The PR target branch is release/X.0-staging, not release/X.0.

• If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author:	github-actions[bot]
Assignees:	-
Labels:	area-Extensions-Configuration, needs-area-label
Milestone:	-

[ericstj]

This was approved over mail last week, but it might be too late to merge at this point. Let's check with @mmitche and @carlossanlop on that.

[ericstj]

Too late to merge for Preview 7

[carlossanlop]

Reopening. The CI passed in the previous run before closing, so we can merge it ASAP. We still have runway.

[github-actions]

Backport of #89226 to release/8.0-preview7

/cc @layomia

Customer Impact

Improves IDE perf when the generator is used. Average time spent in the generator goes from ~2s to ~145ms, using the Roslyn repo as a test. Details in #89226 / https://gist.github.com/layomia/8f51ac107f76853f4f37a6a7c596f67e.

Testing

Existing tests still pass. Manual testing with tracing demonstrates significant performance improvement.

Risk

Invocation processing logic is the same, just filtering based on the names of the input method calls, and avoiding expensive checks (i.e skipping from the list) when there's no match. There might method name aliasing which could cause dropping some calls, but it's probably fair to expect an exact match e.g. .Bind, .Configure, etc. It would be good to get any feedback/issues filed here.

[ghost]

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Backport of #89226 to release/8.0-preview7

/cc @layomia

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

• The PR target branch is release/X.0-staging, not release/X.0.

• If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author:	github-actions[bot]
Assignees:	-
Labels:	area-Extensions-Configuration, needs-area-label
Milestone:	-

[ericstj]

This was approved over mail last week, but it might be too late to merge at this point. Let's check with @mmitche and @carlossanlop on that.

[ericstj]

Too late to merge for Preview 7

[carlossanlop]

Reopening. The CI passed in the previous run before closing, so we can merge it ASAP. We still have runway.

[github-actions]

Backport of #89226 to release/8.0-preview7

/cc @layomia

Customer Impact

Improves IDE perf when the generator is used. Average time spent in the generator goes from ~2s to ~145ms, using the Roslyn repo as a test. Details in #89226 / https://gist.github.com/layomia/8f51ac107f76853f4f37a6a7c596f67e.

Testing

Existing tests still pass. Manual testing with tracing demonstrates significant performance improvement.

Risk

Invocation processing logic is the same, just filtering based on the names of the input method calls, and avoiding expensive checks (i.e skipping from the list) when there's no match. There might method name aliasing which could cause dropping some calls, but it's probably fair to expect an exact match e.g. .Bind, .Configure, etc. It would be good to get any feedback/issues filed here.

[ghost]

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Backport of #89226 to release/8.0-preview7

/cc @layomia

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

• The PR target branch is release/X.0-staging, not release/X.0.

• If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author:	github-actions[bot]
Assignees:	-
Labels:	area-Extensions-Configuration, needs-area-label
Milestone:	-

[ericstj]

This was approved over mail last week, but it might be too late to merge at this point. Let's check with @mmitche and @carlossanlop on that.

[ericstj]

Too late to merge for Preview 7

[carlossanlop]

Reopening. The CI passed in the previous run before closing, so we can merge it ASAP. We still have runway.