[NativeAOT] Refactor System.Linq.Expressions feature switches

[ivanpovazan]

This PR:

• Removes redundant private feature switches for System.Linq.Expressions.dll: CanCompileToIL and CanCreateArbitraryDelegates as they are now respecting IsDynamicCodeSupported:
  

  runtime/src/libraries/System.Linq.Expressions/src/System/Linq/Expressions/LambdaExpression.cs

  Line 29 in 7982376

  publicstaticboolCanCompileToIL=>RuntimeFeature.IsDynamicCodeSupported;

  
  

  runtime/src/libraries/System.Linq.Expressions/src/System/Linq/Expressions/Interpreter/CallInstruction.cs

  Line 19 in 7982376

  privatestaticboolCanCreateArbitraryDelegates=>RuntimeFeature.IsDynamicCodeSupported;

• Sets the CanEmitObjectArrayDelegate into the RuntimeHostConfigurationOption item so other tools (like ILLink) can can also understand the desired trimming configuration
  • This fixes System.Linq.Expressions support with Xamarin+NativeAOT as CanEmitObjectArrayDelegate gets removed during ILLink trimming due to constant propagation, which makes the property not visible when it reaches ILCompiler during the build process

PS: If desired, I can pull out all the other explicit feature switches to the RuntimeHostConfigurationOption like:

runtime/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets

Line 275 in 7982376

<IlcArgCondition="$(IlcDisableReflection) == 'true'"Include="--feature:System.Reflection.IsReflectionExecutionAvailable=false" />

and friends

---

Fixes#89171

/cc @dotnet/ilc-contrib

[ghost]

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

---

This PR:

• Removes unused private feature switches for System.Linq.Expressions.dll: CanCompileToIL and CanCreateArbitraryDelegates as they are now respecting IsDynamicCodeSupported:
  

  runtime/src/libraries/System.Linq.Expressions/src/System/Linq/Expressions/LambdaExpression.cs

  Line 29 in 7982376

  publicstaticboolCanCompileToIL=>RuntimeFeature.IsDynamicCodeSupported;

  
  

  runtime/src/libraries/System.Linq.Expressions/src/System/Linq/Expressions/Interpreter/CallInstruction.cs

  Line 19 in 7982376

  privatestaticboolCanCreateArbitraryDelegates=>RuntimeFeature.IsDynamicCodeSupported;

• Sets the CanEmitObjectArrayDelegate into the RuntimeHostConfigurationOption item so other tools (like ILLink) can can also understand the desired trimming configuration
  • This fixes System.Linq.Expressions support with Xamarin+NativeAOT as CanEmitObjectArrayDelegate gets removed during ILLink trimming due to constant propagation, which makes the property not visible when it reaches ILCompiler during the build process

PS: If desired, I can pull out all the other explicit feature switches to the RuntimeHostConfigurationOption like:

runtime/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets

Line 275 in 7982376

<IlcArgCondition="$(IlcDisableReflection) == 'true'"Include="--feature:System.Reflection.IsReflectionExecutionAvailable=false" />

and friends

---

Fixes #89171

/cc @dotnet/ilc-contrib

Author:	ivanpovazan
Assignees:	-
Labels:	area-NativeAOT-coreclr
Milestone:	-

[MichalStrehovsky]

PS: If desired, I can pull out all the other explicit feature switches

Let's not do that unless necessary. Promoting this to RuntimeHostConfigurationOption is more lines of code, and also a tiny size regression (the compiler is also required to promote these to AppContext switches at runtime), whereas --feature is only processed at compile time.

[ivanpovazan]

/azp run runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ivanpovazan]

Failures seem unrelated.