Uh oh!
There was an error while loading. Please reload this page.
Fix EventPipe utf8 conversion methods to match between JIT and AOT - #89353
Merged
Conversation
ghost
commented
Jul 22, 2023
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsFollow up on #89036 (comment) Contrary to what the comment says, CoreCLR version of these methods does not allocate the redundant null terminator. Fixing the AOT version of these methods to match.
|
jkotas
commented
Jul 22, 2023
MemberAuthor
(We should switch all runtimes to use the AOT version as part of #87069. There is no reason for having runtime-specific versions of these methods.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #89036 (comment)
Contrary to what the comment says, CoreCLR version of these methods does not allocate the redundant null terminator. Fixing the AOT version of these methods to match.