') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [mono][ios] Enable System.Formats.Cbor test on apple mobile devices by kotlarmilos · Pull Request #89392 · dotnet/runtime · GitHub
Skip to content

[mono][ios] Enable System.Formats.Cbor test on apple mobile devices - #89392

Closed
kotlarmilos wants to merge 1 commit into
dotnet:mainfrom
kotlarmilos:improvement/enable-formats-cbor-test
Closed

[mono][ios] Enable System.Formats.Cbor test on apple mobile devices#89392
kotlarmilos wants to merge 1 commit into
dotnet:mainfrom
kotlarmilos:improvement/enable-formats-cbor-test

Conversation

@kotlarmilos

@kotlarmiloskotlarmilos commented Jul 24, 2023

Copy link
Copy Markdown
Member

This PR enables the CborDocument_Roundtrip test which passed locally on a device.

Fixes#73150

@kotlarmiloskotlarmilos added this to the 8.0.0 milestone Jul 24, 2023
@kotlarmiloskotlarmilos self-assigned this Jul 24, 2023
@ghost

ghost commented Jul 24, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR enables the CborDocument_Roundtrip test which passed locally on a device.

Fixes #73150

Author:kotlarmilos
Assignees:kotlarmilos
Labels:

area-Infrastructure-mono, os-ios

Milestone:8.0.0

@kotlarmilos

kotlarmilos commented Jul 24, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-ioslike

@azure-pipelines

azure-pipelinesBot commented Jul 24, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@steveisok

steveisok commented Jul 24, 2023

Copy link
Copy Markdown
Member

@kotlarmilos if I remember correctly, I experienced the same behavior. It's either tvOS specific or failed on both in CI.

This was referenced Jul 24, 2023
Closed
Closed
@build-analysisbuild-analysisBot mentioned this pull request Jul 25, 2023
Closed
@kotlarmiloskotlarmilos mentioned this pull request Jul 25, 2023
Closed
@kotlarmilos

kotlarmilos commented Jul 25, 2023

Copy link
Copy Markdown
MemberAuthor

@kotlarmilos if I remember correctly, I experienced the same behavior. It's either tvOS specific or failed on both in CI.

How did you get the stack trace in #73150 (comment)? The test is failing with exit code 1 but without any logs.

@build-analysisbuild-analysisBot mentioned this pull request Jul 26, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@steveisoksteveisokAwaiting requested review from steveisok
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
1 more reviewer
@vargazvargazvargaz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@kotlarmiloskotlarmilos

Labels

area-Infrastructure-monoos-iosApple iOS

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[iOS] BigInteger CompareTo crash in CborDocument_Roundtrip test

3 participants

@kotlarmilos@steveisok@vargaz