') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [mono] Disable gsharing when Unsafe.ReadUnaligned/WriteUnaligned () i… by vargaz · Pull Request #89417 · dotnet/runtime · GitHub
Skip to content

[mono] Disable gsharing when Unsafe.ReadUnaligned/WriteUnaligned () i… - #89417

Merged
lewing merged 1 commit into
dotnet:mainfrom
vargaz:fix-89398
Jul 25, 2023
Merged

[mono] Disable gsharing when Unsafe.ReadUnaligned/WriteUnaligned () i…#89417
lewing merged 1 commit into
dotnet:mainfrom
vargaz:fix-89398

Conversation

@vargaz

@vargazvargaz commented Jul 25, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

…s used with generic structures.

Fixes#89398.

For a method like

 static void Write<T>(ref byte b, T value) => Unsafe.WriteUnaligned<T>(ref b, value);

And an instance Write<GStruct<string>>, generic sharing will create a Write<T_INST> instance where T_INST is constrained to GStruct<T_REF>. The JIT currently calls
mini_get_underlying_type () in many places which transform T_INST into GStruct<T_REF>.
This causes problems at runtime in the generic sharing code, which expects to find T_INST.
I.e. inflate_info () can inflate T_INST to GStruct<string>, but it can't inflate
GStruct<T_REF> to GStruct<string>.

As a workaround, disable gsharing in (some) of these cases.

@ghostghost assigned vargazJul 25, 2023
@vargaz

vargaz commented Jul 25, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Jul 25, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@vargaz
[mono] Disable gsharing when Unsafe.ReadUnaligned/WriteUnaligned () i…
bde546d
…s used with generic structures.
Fixesdotnet#89398.
For a method like
```
static void Write<T>(ref byte b, T value) => Unsafe.WriteUnaligned<T>(ref b, value);
```
And an instance ```Write<GStruct<string>>```, generic sharing will create a ```Write<T_INST>```
instance where T_INST is constrained to GStruct<T_REF>. The JIT currently calls
```mini_get_underlying_type ()``` in many places which transform T_INST into GStruct<T_REF>.
This causes problems at runtime in the generic sharing code, which expects to find T_INST.
I.e. ```inflate_info ()``` can inflate ```T_INST``` to ```GStruct<string>```, but it can't inflate
```GStruct<T_REF>``` to ```GStruct<string>```.
As a workaround, disable gsharing in (some) of these cases.
@vargaz

vargaz commented Jul 25, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Jul 25, 2023

Copy link
Copy Markdown

No commit pushedDate could be found for PR 89417 in repo dotnet/runtime

@vargaz

vargaz commented Jul 25, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Jul 25, 2023

Copy link
Copy Markdown

No commit pushedDate could be found for PR 89417 in repo dotnet/runtime

@vargaz

vargaz commented Jul 25, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Jul 25, 2023

Copy link
Copy Markdown

No commit pushedDate could be found for PR 89417 in repo dotnet/runtime

@vargaz

vargaz commented Jul 25, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-wasm

1 similar comment
@vargaz

vargaz commented Jul 25, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Jul 25, 2023

Copy link
Copy Markdown

No commit pushedDate could be found for PR 89417 in repo dotnet/runtime

1 similar comment
@azure-pipelines

azure-pipelinesBot commented Jul 25, 2023

Copy link
Copy Markdown

No commit pushedDate could be found for PR 89417 in repo dotnet/runtime

@lambdageek

lambdageek commented Jul 25, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Is this going to disable sharing for every generic method that has a Span<T> argument? nevermind, I thought this was in method-to-ir, but it's just intrinsics.

Should this be in method-to-ir? this mini_get_underlying_type issue seems like it would show up in other places, too

lambdageek
lambdageek approved these changes Jul 25, 2023
View reviewed changes

@lambdageeklambdageek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vargaz can you make a GH Issue about the general problem. If we get this kind of crash in other situations, it would be good to have something that explains what is happening.

@lewing
lewing merged commit 0be3889 into dotnet:mainJul 25, 2023
@vargaz
vargaz deleted the fix-89398 branch July 25, 2023 21:28
@build-analysisbuild-analysisBot mentioned this pull request Jul 25, 2023
Open
@pavelsavarapavelsavara mentioned this pull request Jul 26, 2023
Merged
@vargazvargaz mentioned this pull request Jul 28, 2023
Open
@ghostghost locked as resolved and limited conversation to collaborators Aug 25, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageeklambdageeklambdageek approved these changes
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT

Assignees

@vargazvargaz

Labels

area-Codegen-JIT-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[wasm] AOT: System.Runtime.CompilerServices.Unsafe.Tests - assertion - src/mono/mono/metadata/object.c:926

3 participants

@vargaz@lambdageek@lewing