Uh oh!
There was an error while loading. Please reload this page.
[mono][interp] Add implicit conversion of floating-point call args - #89428
Merged
Conversation
ghost
commented
Jul 25, 2023
Tagging subscribers to this area: @BrzVlad, @kotlarmilos Issue DetailsThis PR adds explicit conversion of floating-point call args and enables the conversion for inlined methods. Fixes #89385
|
lewing
commented
Jul 25, 2023
Member
the debugger failure is known |
BrzVlad
approved these changes
Jul 26, 2023
This comment was marked as outdated.
This comment was marked as outdated.
kotlarmilos
commented
Jul 26, 2023
MemberAuthor
/azp run runtime-ioslike |
No commit pushedDate could be found for PR 89428 in repo dotnet/runtime |
kotlarmilos
commented
Jul 26, 2023
MemberAuthor
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jul 26, 2023
kotlarmilos
commented
Jul 28, 2023
MemberAuthor
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kotlarmilos
commented
Jul 28, 2023
MemberAuthor
The failures are known and shouldn't be related. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds implicit conversion of floating-point call args and enables the conversion for inlined methods.
Fixes#89385