Uh oh!
There was an error while loading. Please reload this page.
[Mono] Look for Native Signal SIMD Context - #89467
Merged
Merged
Conversation
fanyang-mono
marked this pull request as ready for review
July 25, 2023 19:59
vargaz
reviewed
Jul 25, 2023
Uh oh!
There was an error while loading. Please reload this page.
vargaz
approved these changes
Jul 25, 2023
fanyang-mono
commented
Jul 26, 2023
MemberAuthor
/azp run runtime-extra-platforms |
No commit pushedDate could be found for PR 89467 in repo dotnet/runtime |
fanyang-mono
commented
Jul 26, 2023
MemberAuthor
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lambdageek
requested changes
Jul 26, 2023
Uh oh!
There was an error while loading. Please reload this page.
lambdageek
approved these changes
Jul 26, 2023
fanyang-mono
commented
Jul 26, 2023
MemberAuthor
/azp run runtime-extra-platforms |
No commit pushedDate could be found for PR 89467 in repo dotnet/runtime |
fanyang-mono
commented
Jul 26, 2023
MemberAuthor
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jul 26, 2023
This was referenced Jul 27, 2023
fanyang-mono
commented
Jul 27, 2023
MemberAuthor
Test failures on CI are unrelated. |
fanyang-mono
commented
Jul 27, 2023
MemberAuthor
/backport to release/7.0-staging |
Contributor
Started backporting to release/7.0-staging: https://github.com/dotnet/runtime/actions/runs/5681844886 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add the logic to find the native signal SIMD context, instead of assuming the first one in the array is the one. If not found, it is okay to proceed from the first context as well.
Somehow, when running android arm64 apps on x64 emulators, the SIMD context doesn't exist.
Testing: Followed the reproduction steps provided by the customer using VS 2022 (#62201 (comment))
Fixes#62201