') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); JIT: Set method context for delegate GDV by jakobbotsch · Pull Request #89499 · dotnet/runtime · GitHub
Skip to content

JIT: Set method context for delegate GDV - #89499

Merged
jakobbotsch merged 1 commit into
dotnet:mainfrom
jakobbotsch:gdv-exact-context-delegate
Jul 27, 2023
Merged

JIT: Set method context for delegate GDV#89499
jakobbotsch merged 1 commit into
dotnet:mainfrom
jakobbotsch:gdv-exact-context-delegate

Conversation

@jakobbotsch

@jakobbotschjakobbotsch commented Jul 26, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Instead of passing through the IL context, update the context to be the exact method that was recorded in the delegate (which will include the full instantiation).

Also do a bit of clean up.

Fix#89495

@jakobbotsch
JIT: Set method context for delegate GDV
85c2571
Instead of passing through the IL context, update the method context to
be the exact method that were recorded in the delegate (which will
include the full instantiation).
Also do a bit of clean up.
Fixdotnet#89495
@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 26, 2023
@ghost

ghost commented Jul 26, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Instead of passing through the IL context, update the method context to be the exact method that were recorded in the delegate (which will include the full instantiation).

Also do a bit of clean up.

Fix #89495

Author:jakobbotsch
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@jakobbotsch

jakobbotsch commented Jul 26, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr pgo, runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Jul 26, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

This was referenced Jul 26, 2023
Closed
Closed
EgorBo
EgorBo approved these changes Jul 26, 2023
View reviewed changes

@EgorBoEgorBo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if there are no new crashes on CI/extra-platform

@jakobbotsch
jakobbotsch marked this pull request as ready for review July 26, 2023 19:25
@jakobbotsch

jakobbotsch commented Jul 26, 2023

Copy link
Copy Markdown
MemberAuthor

cc @dotnet/jit-contrib PTAL @EgorBo@AndyAyersMS

Runtime test failure is known according to build analysis. I'm not sure about runtime-extra-platforms -- build analysis doesn't seem to find anything, but it seems very red, so very hard for me to have much confidence.
runtime-coreclr pgo was green.

@jakobbotsch

jakobbotsch commented Jul 26, 2023

Copy link
Copy Markdown
MemberAuthor

Going to kick off pgostress as well for some more testing.

@jakobbotsch

jakobbotsch commented Jul 26, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr pgostress

@azure-pipelines

azure-pipelinesBot commented Jul 26, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 26, 2023
Closed
Closed
Closed
Closed
Closed
Closed
@build-analysisbuild-analysisBot mentioned this pull request Jul 26, 2023
Closed
@jakobbotsch

jakobbotsch commented Jul 27, 2023

Copy link
Copy Markdown
MemberAuthor

The pgostress failures are #88507, #88586, #83658.

@jakobbotsch
jakobbotsch merged commit b9c6d68 into dotnet:mainJul 27, 2023
@jakobbotsch
jakobbotsch deleted the gdv-exact-context-delegate branch July 27, 2023 08:48
@build-analysisbuild-analysisBot mentioned this pull request Jul 27, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Aug 26, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@EgorBoEgorBoEgorBo approved these changes
@AndyAyersMSAndyAyersMSAndyAyersMS approved these changes

Assignees

@jakobbotschjakobbotsch

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JIT: GDV does not handle delegates pointing to generic methods correctly

3 participants

@jakobbotsch@EgorBo@AndyAyersMS