Skip to content

[browser][http] test and compatibility improvements - #89504

Merged
pavelsavara merged 1 commit into
dotnet:mainfrom
pavelsavara:browser_http_tests
Jul 27, 2023
Merged

[browser][http] test and compatibility improvements#89504
pavelsavara merged 1 commit into
dotnet:mainfrom
pavelsavara:browser_http_tests

Conversation

@pavelsavara

@pavelsavarapavelsavara commented Jul 26, 2023

Copy link
Copy Markdown
Member

Fixes#54160

  • fix error propagation for invalid HTTP header on request
  • enable more tests

@pavelsavarapavelsavara added this to the 8.0.0 milestone Jul 26, 2023
@pavelsavarapavelsavara self-assigned this Jul 26, 2023
@ghost

ghost commented Jul 26, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #54160

  • fix error propagation for invalid HTTP header on request
  • enable more tests
Author:pavelsavara
Assignees:pavelsavara
Labels:

arch-wasm, area-System.Net.Http

Milestone:8.0.0

@pavelsavara

pavelsavara commented Jul 26, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Jul 26, 2023

Copy link
Copy Markdown

No commit pushedDate could be found for PR 89504 in repo dotnet/runtime

@pavelsavara

pavelsavara commented Jul 26, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Jul 26, 2023

Copy link
Copy Markdown

No commit pushedDate could be found for PR 89504 in repo dotnet/runtime

@pavelsavara

pavelsavara commented Jul 26, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Jul 26, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
pavelsavara marked this pull request as ready for review July 26, 2023 16:54
This was referenced Jul 26, 2023
Closed
Closed
Closed
Closed
radical
radical reviewed Jul 27, 2023
View reviewed changes
Comment threadsrc/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs
maraf
maraf approved these changes Jul 27, 2023
View reviewed changes

@marafmaraf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@pavelsavara
pavelsavara merged commit a0a8ce6 into dotnet:mainJul 27, 2023
@ghostghost locked as resolved and limited conversation to collaborators Aug 26, 2023
@pavelsavara
pavelsavara deleted the browser_http_tests branch September 2, 2024 15:33
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radicalradicalradical left review comments
@marafmarafmaraf approved these changes
@ilonatommyilonatommyAwaiting requested review from ilonatommy

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-System.Net.Http

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[wasm][http] System.Net.Http.Functional.Tests should throw HttpRequestException

3 participants

@pavelsavara@radical@maraf