Skip to content

Remove unnecessary "return 100"s from tests - #89550

Merged
trylek merged 9 commits into
dotnet:mainfrom
markples:ret100
Aug 22, 2023
Merged

Remove unnecessary "return 100"s from tests#89550
trylek merged 9 commits into
dotnet:mainfrom
markples:ret100

Conversation

@markples

@markplesmarkples commented Jul 27, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Add XUnitWrapperGenerator check for test methods that always return 100 and change them to void.

@ghostghost assigned markplesJul 27, 2023
@ghost

ghost commented Jul 27, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-reflection-metadata
See info in area-owners.md if you want to be subscribed.

Issue Details

Note: contains #89521

Add XUnitWrapperGenerator check for test methods that always return 100 and change them to void.

Author:markples
Assignees:markples
Labels:

area-System.Reflection.Metadata

Milestone:-

@markplesmarkples added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed area-System.Reflection.Metadata labels Jul 27, 2023
@ghost

ghost commented Jul 27, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Note: contains #89521

Add XUnitWrapperGenerator check for test methods that always return 100 and change them to void.

Author:markples
Assignees:markples
Labels:

area-CodeGen-coreclr

Milestone:-

@markplesmarkples mentioned this pull request Jul 27, 2023
Merged
@build-analysisbuild-analysisBot mentioned this pull request Jul 27, 2023
Closed
@markplesmarkples mentioned this pull request Jul 27, 2023
Merged
@markples

markples commented Jul 28, 2023

Copy link
Copy Markdown
ContributorAuthor

This should be ready @trylek@jkoritzinsky@TIHan cc @dotnet/jit-contrib.

The actual change is small. Tests are almost entirely changing to void and very occasionally something related to that. I've scanned the entire diff though of course I'm the author.

@markples
markples marked this pull request as ready for review July 28, 2023 19:38
jkoritzinsky
jkoritzinsky reviewed Jul 28, 2023
View reviewed changes
Comment threadsrc/tests/Common/XUnitWrapperGenerator/XUnitWrapperGenerator.cs Outdated
Comment on lines 153 to 164

@jkoritzinskyjkoritzinskyJul 28, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a future PR, I think it's worthwhile moving these checks into a separate analyzer instead of doing them as part of the source generator. If we do them in an analyzer, we can get better performance at build time and we could use better tools (like the IOperation APIs) to validate these sorts of scenarios.

@markplesmarkplesJul 28, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea but mainly did it this way because I'm unfamiliar with all of this and couldn't easily figure out how to set anything up (primarily copying and pasting in this file). So I'll either need a template for doing so or more time to turn the docs/bing chat into something real.

trylek
trylek approved these changes Jul 28, 2023
View reviewed changes

@trylektrylek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@markples

markples commented Jul 28, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

azure-pipelinesBot commented Jul 28, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@markples

markples commented Aug 8, 2023

Copy link
Copy Markdown
ContributorAuthor

new analyzer means a race condition with newly added tests (audit commits and/or rerun old test jobs)

@markplesmarkples assigned trylek and unassigned markplesAug 8, 2023
@trylek

trylek commented Aug 22, 2023

Copy link
Copy Markdown
Member

I have rebased this against the current main, the change is passing locally for me, I plan to merge it in once I find the lab results reasonable.

@trylek

trylek commented Aug 22, 2023

Copy link
Copy Markdown
Member

/azp run runtime-coreclr outerloop

@trylek

trylek commented Aug 22, 2023

Copy link
Copy Markdown
Member

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Aug 22, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines

azure-pipelinesBot commented Aug 22, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Aug 22, 2023
Closed
Closed
Closed
Closed
Open
@trylek

trylek commented Aug 22, 2023

Copy link
Copy Markdown
Member

Just like in the previous case runtime and outerloop are clean and runtime-extra-platforms, while not clean, doesn't look any worse than in any other runs, merging in.

@trylek
trylek merged commit 5d00fc5 into dotnet:mainAug 22, 2023
@build-analysisbuild-analysisBot mentioned this pull request Aug 22, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Sep 21, 2023
@markples
markples deleted the ret100 branch September 28, 2023 23:34
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinskyjkoritzinskyjkoritzinsky approved these changes
@trylektrylektrylek approved these changes

Assignees

@trylektrylek

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markples@trylek@jkoritzinsky
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Remove unnecessary "return 100"s from tests by markples · Pull Request #89550 · dotnet/runtime · GitHub
Skip to content
Remove unnecessary "return 100"s from tests - #89550
Merged
trylek merged 9 commits into
dotnet:mainfrom 
markples:ret100
Aug 22, 2023
Merged
Remove unnecessary "return 100"s from tests#89550
trylek merged 9 commits into
dotnet:mainfrom 
markples:ret100
Conversation
@markples
@markplesmarkples
commented
Jul 27, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Add XUnitWrapperGenerator check for test methods that always return 100 and change them to void.
@ghostghost
assigned markplesJul 27, 2023
@ghost
ghost
commented
Jul 27, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-reflection-metadata

See info in area-owners.md if you want to be subscribed.
Issue Details
Note: contains #89521
Add XUnitWrapperGenerator check for test methods that always return 100 and change them to void.
Author:markples
Assignees:markples
Labels:
area-System.Reflection.Metadata
Milestone:-
@markplesmarkples
added

area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
and removed

area-System.Reflection.Metadata

labels
Jul 27, 2023
@ghost
ghost
commented
Jul 27, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
Note: contains #89521
Add XUnitWrapperGenerator check for test methods that always return 100 and change them to void.
Author:markples
Assignees:markples
Labels:
area-CodeGen-coreclr
Milestone:-
@markplesmarkples
mentioned this pull request
Jul 27, 2023
 Merged

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 27, 2023

Closed

@markplesmarkples
mentioned this pull request
Jul 27, 2023
 Merged

@markples
markples
commented
Jul 28, 2023

Copy link


Copy Markdown

ContributorAuthor
This should be ready @trylek@jkoritzinsky@TIHan cc @dotnet/jit-contrib.
The actual change is small. Tests are almost entirely changing to void and very occasionally something related to that. I've scanned the entire diff though of course I'm the author.
@markples
markples
marked this pull request as ready for review
July 28, 2023 19:38
jkoritzinsky
jkoritzinsky
reviewed
Jul 28, 2023
View reviewed changes
Comment threadsrc/tests/Common/XUnitWrapperGenerator/XUnitWrapperGenerator.cs
Outdated


Comment on lines

153
 to 
164

@jkoritzinskyjkoritzinskyJul 28, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a future PR, I think it's worthwhile moving these checks into a separate analyzer instead of doing them as part of the source generator. If we do them in an analyzer, we can get better performance at build time and we could use better tools (like the IOperation APIs) to validate these sorts of scenarios.
@markplesmarkplesJul 28, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea but mainly did it this way because I'm unfamiliar with all of this and couldn't easily figure out how to set anything up (primarily copying and pasting in this file). So I'll either need a template for doing so or more time to turn the docs/bing chat into something real.
trylek
trylek
approved these changes
Jul 28, 2023
View reviewed changes
@trylektrylek
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!
@markples
markples
commented
Jul 28, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Jul 28, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
new analyzer means a race condition with newly added tests (audit commits and/or rerun old test jobs)
@markplesmarkples
assigned trylek and unassigned markplesAug 8, 2023
@trylek
trylek
commented
Aug 22, 2023

Copy link


Copy Markdown

Member
I have rebased this against the current main, the change is passing locally for me, I plan to merge it in once I find the lab results reasonable.
@trylek
trylek
commented
Aug 22, 2023

Copy link


Copy Markdown

Member
/azp run runtime-coreclr outerloop
@trylek
trylek
commented
Aug 22, 2023

Copy link


Copy Markdown

Member
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Aug 22, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment

@azure-pipelines
azure-pipelinesBot
commented
Aug 22, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Aug 22, 2023

Closed


Closed


Closed


Closed


Open

@trylek
trylek
commented
Aug 22, 2023

Copy link


Copy Markdown

Member
Just like in the previous case runtime and outerloop are clean and runtime-extra-platforms, while not clean, doesn't look any worse than in any other runs, merging in.
@trylek
trylek
merged commit 5d00fc5
into
dotnet:mainAug 22, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 22, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 21, 2023
@markples
markples
deleted the

ret100

branch
September 28, 2023 23:34
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkoritzinskyjkoritzinskyjkoritzinsky approved these changes
@trylektrylektrylek approved these changes

Assignees

@trylektrylek

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@markples@trylek@jkoritzinsky

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove unnecessary "return 100"s from tests by markples · Pull Request #89550 · dotnet/runtime · GitHub
Skip to content
Remove unnecessary "return 100"s from tests - #89550
Merged
trylek merged 9 commits into
dotnet:mainfrom 
markples:ret100
Aug 22, 2023
Merged
Remove unnecessary "return 100"s from tests#89550
trylek merged 9 commits into
dotnet:mainfrom 
markples:ret100
Conversation
@markples
@markplesmarkples
commented
Jul 27, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Add XUnitWrapperGenerator check for test methods that always return 100 and change them to void.
@ghostghost
assigned markplesJul 27, 2023
@ghost
ghost
commented
Jul 27, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-reflection-metadata

See info in area-owners.md if you want to be subscribed.
Issue Details
Note: contains #89521
Add XUnitWrapperGenerator check for test methods that always return 100 and change them to void.
Author:markples
Assignees:markples
Labels:
area-System.Reflection.Metadata
Milestone:-
@markplesmarkples
added

area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
and removed

area-System.Reflection.Metadata

labels
Jul 27, 2023
@ghost
ghost
commented
Jul 27, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
Note: contains #89521
Add XUnitWrapperGenerator check for test methods that always return 100 and change them to void.
Author:markples
Assignees:markples
Labels:
area-CodeGen-coreclr
Milestone:-
@markplesmarkples
mentioned this pull request
Jul 27, 2023
 Merged

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 27, 2023

Closed

@markplesmarkples
mentioned this pull request
Jul 27, 2023
 Merged

@markples
markples
commented
Jul 28, 2023

Copy link


Copy Markdown

ContributorAuthor
This should be ready @trylek@jkoritzinsky@TIHan cc @dotnet/jit-contrib.
The actual change is small. Tests are almost entirely changing to void and very occasionally something related to that. I've scanned the entire diff though of course I'm the author.
@markples
markples
marked this pull request as ready for review
July 28, 2023 19:38
jkoritzinsky
jkoritzinsky
reviewed
Jul 28, 2023
View reviewed changes
Comment threadsrc/tests/Common/XUnitWrapperGenerator/XUnitWrapperGenerator.cs
Outdated


Comment on lines

153
 to 
164

@jkoritzinskyjkoritzinskyJul 28, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a future PR, I think it's worthwhile moving these checks into a separate analyzer instead of doing them as part of the source generator. If we do them in an analyzer, we can get better performance at build time and we could use better tools (like the IOperation APIs) to validate these sorts of scenarios.
@markplesmarkplesJul 28, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea but mainly did it this way because I'm unfamiliar with all of this and couldn't easily figure out how to set anything up (primarily copying and pasting in this file). So I'll either need a template for doing so or more time to turn the docs/bing chat into something real.
trylek
trylek
approved these changes
Jul 28, 2023
View reviewed changes
@trylektrylek
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!
@markples
markples
commented
Jul 28, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Jul 28, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
new analyzer means a race condition with newly added tests (audit commits and/or rerun old test jobs)
@markplesmarkples
assigned trylek and unassigned markplesAug 8, 2023
@trylek
trylek
commented
Aug 22, 2023

Copy link


Copy Markdown

Member
I have rebased this against the current main, the change is passing locally for me, I plan to merge it in once I find the lab results reasonable.
@trylek
trylek
commented
Aug 22, 2023

Copy link


Copy Markdown

Member
/azp run runtime-coreclr outerloop
@trylek
trylek
commented
Aug 22, 2023

Copy link


Copy Markdown

Member
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Aug 22, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment

@azure-pipelines
azure-pipelinesBot
commented
Aug 22, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Aug 22, 2023

Closed


Closed


Closed


Closed


Open

@trylek
trylek
commented
Aug 22, 2023

Copy link


Copy Markdown

Member
Just like in the previous case runtime and outerloop are clean and runtime-extra-platforms, while not clean, doesn't look any worse than in any other runs, merging in.
@trylek
trylek
merged commit 5d00fc5
into
dotnet:mainAug 22, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 22, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 21, 2023
@markples
markples
deleted the

ret100

branch
September 28, 2023 23:34
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkoritzinskyjkoritzinskyjkoritzinsky approved these changes
@trylektrylektrylek approved these changes

Assignees

@trylektrylek

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@markples@trylek@jkoritzinsky

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove unnecessary "return 100"s from tests by markples · Pull Request #89550 · dotnet/runtime · GitHub
Skip to content
Remove unnecessary "return 100"s from tests - #89550
Merged
trylek merged 9 commits into
dotnet:mainfrom 
markples:ret100
Aug 22, 2023
Merged
Remove unnecessary "return 100"s from tests#89550
trylek merged 9 commits into
dotnet:mainfrom 
markples:ret100
Conversation
@markples
@markplesmarkples
commented
Jul 27, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Add XUnitWrapperGenerator check for test methods that always return 100 and change them to void.
@ghostghost
assigned markplesJul 27, 2023
@ghost
ghost
commented
Jul 27, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-reflection-metadata

See info in area-owners.md if you want to be subscribed.
Issue Details
Note: contains #89521
Add XUnitWrapperGenerator check for test methods that always return 100 and change them to void.
Author:markples
Assignees:markples
Labels:
area-System.Reflection.Metadata
Milestone:-
@markplesmarkples
added

area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
and removed

area-System.Reflection.Metadata

labels
Jul 27, 2023
@ghost
ghost
commented
Jul 27, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
Note: contains #89521
Add XUnitWrapperGenerator check for test methods that always return 100 and change them to void.
Author:markples
Assignees:markples
Labels:
area-CodeGen-coreclr
Milestone:-
@markplesmarkples
mentioned this pull request
Jul 27, 2023
 Merged

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 27, 2023

Closed

@markplesmarkples
mentioned this pull request
Jul 27, 2023
 Merged

@markples
markples
commented
Jul 28, 2023

Copy link


Copy Markdown

ContributorAuthor
This should be ready @trylek@jkoritzinsky@TIHan cc @dotnet/jit-contrib.
The actual change is small. Tests are almost entirely changing to void and very occasionally something related to that. I've scanned the entire diff though of course I'm the author.
@markples
markples
marked this pull request as ready for review
July 28, 2023 19:38
jkoritzinsky
jkoritzinsky
reviewed
Jul 28, 2023
View reviewed changes
Comment threadsrc/tests/Common/XUnitWrapperGenerator/XUnitWrapperGenerator.cs
Outdated


Comment on lines

153
 to 
164

@jkoritzinskyjkoritzinskyJul 28, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a future PR, I think it's worthwhile moving these checks into a separate analyzer instead of doing them as part of the source generator. If we do them in an analyzer, we can get better performance at build time and we could use better tools (like the IOperation APIs) to validate these sorts of scenarios.
@markplesmarkplesJul 28, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea but mainly did it this way because I'm unfamiliar with all of this and couldn't easily figure out how to set anything up (primarily copying and pasting in this file). So I'll either need a template for doing so or more time to turn the docs/bing chat into something real.
trylek
trylek
approved these changes
Jul 28, 2023
View reviewed changes
@trylektrylek
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!
@markples
markples
commented
Jul 28, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Jul 28, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
new analyzer means a race condition with newly added tests (audit commits and/or rerun old test jobs)
@markplesmarkples
assigned trylek and unassigned markplesAug 8, 2023
@trylek
trylek
commented
Aug 22, 2023

Copy link


Copy Markdown

Member
I have rebased this against the current main, the change is passing locally for me, I plan to merge it in once I find the lab results reasonable.
@trylek
trylek
commented
Aug 22, 2023

Copy link


Copy Markdown

Member
/azp run runtime-coreclr outerloop
@trylek
trylek
commented
Aug 22, 2023

Copy link


Copy Markdown

Member
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Aug 22, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment

@azure-pipelines
azure-pipelinesBot
commented
Aug 22, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Aug 22, 2023

Closed


Closed


Closed


Closed


Open

@trylek
trylek
commented
Aug 22, 2023

Copy link


Copy Markdown

Member
Just like in the previous case runtime and outerloop are clean and runtime-extra-platforms, while not clean, doesn't look any worse than in any other runs, merging in.
@trylek
trylek
merged commit 5d00fc5
into
dotnet:mainAug 22, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 22, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 21, 2023
@markples
markples
deleted the

ret100

branch
September 28, 2023 23:34
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkoritzinskyjkoritzinskyjkoritzinsky approved these changes
@trylektrylektrylek approved these changes

Assignees

@trylektrylek

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@markples@trylek@jkoritzinsky

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Remove unnecessary "return 100"s from tests by markples · Pull Request #89550 · dotnet/runtime · GitHub
Skip to content
Remove unnecessary "return 100"s from tests - #89550
Merged
trylek merged 9 commits into
dotnet:mainfrom 
markples:ret100
Aug 22, 2023
Merged
Remove unnecessary "return 100"s from tests#89550
trylek merged 9 commits into
dotnet:mainfrom 
markples:ret100
Conversation
@markples
@markplesmarkples
commented
Jul 27, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Add XUnitWrapperGenerator check for test methods that always return 100 and change them to void.
@ghostghost
assigned markplesJul 27, 2023
@ghost
ghost
commented
Jul 27, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-reflection-metadata

See info in area-owners.md if you want to be subscribed.
Issue Details
Note: contains #89521
Add XUnitWrapperGenerator check for test methods that always return 100 and change them to void.
Author:markples
Assignees:markples
Labels:
area-System.Reflection.Metadata
Milestone:-
@markplesmarkples
added

area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
and removed

area-System.Reflection.Metadata

labels
Jul 27, 2023
@ghost
ghost
commented
Jul 27, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
Note: contains #89521
Add XUnitWrapperGenerator check for test methods that always return 100 and change them to void.
Author:markples
Assignees:markples
Labels:
area-CodeGen-coreclr
Milestone:-
@markplesmarkples
mentioned this pull request
Jul 27, 2023
 Merged

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 27, 2023

Closed

@markplesmarkples
mentioned this pull request
Jul 27, 2023
 Merged

@markples
markples
commented
Jul 28, 2023

Copy link


Copy Markdown

ContributorAuthor
This should be ready @trylek@jkoritzinsky@TIHan cc @dotnet/jit-contrib.
The actual change is small. Tests are almost entirely changing to void and very occasionally something related to that. I've scanned the entire diff though of course I'm the author.
@markples
markples
marked this pull request as ready for review
July 28, 2023 19:38
jkoritzinsky
jkoritzinsky
reviewed
Jul 28, 2023
View reviewed changes
Comment threadsrc/tests/Common/XUnitWrapperGenerator/XUnitWrapperGenerator.cs
Outdated


Comment on lines

153
 to 
164

@jkoritzinskyjkoritzinskyJul 28, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a future PR, I think it's worthwhile moving these checks into a separate analyzer instead of doing them as part of the source generator. If we do them in an analyzer, we can get better performance at build time and we could use better tools (like the IOperation APIs) to validate these sorts of scenarios.
@markplesmarkplesJul 28, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea but mainly did it this way because I'm unfamiliar with all of this and couldn't easily figure out how to set anything up (primarily copying and pasting in this file). So I'll either need a template for doing so or more time to turn the docs/bing chat into something real.
trylek
trylek
approved these changes
Jul 28, 2023
View reviewed changes
@trylektrylek
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!
@markples
markples
commented
Jul 28, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Jul 28, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
new analyzer means a race condition with newly added tests (audit commits and/or rerun old test jobs)
@markplesmarkples
assigned trylek and unassigned markplesAug 8, 2023
@trylek
trylek
commented
Aug 22, 2023

Copy link


Copy Markdown

Member
I have rebased this against the current main, the change is passing locally for me, I plan to merge it in once I find the lab results reasonable.
@trylek
trylek
commented
Aug 22, 2023

Copy link


Copy Markdown

Member
/azp run runtime-coreclr outerloop
@trylek
trylek
commented
Aug 22, 2023

Copy link


Copy Markdown

Member
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Aug 22, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment

@azure-pipelines
azure-pipelinesBot
commented
Aug 22, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Aug 22, 2023

Closed


Closed


Closed


Closed


Open

@trylek
trylek
commented
Aug 22, 2023

Copy link


Copy Markdown

Member
Just like in the previous case runtime and outerloop are clean and runtime-extra-platforms, while not clean, doesn't look any worse than in any other runs, merging in.
@trylek
trylek
merged commit 5d00fc5
into
dotnet:mainAug 22, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 22, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 21, 2023
@markples
markples
deleted the

ret100

branch
September 28, 2023 23:34
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkoritzinskyjkoritzinskyjkoritzinsky approved these changes
@trylektrylektrylek approved these changes

Assignees

@trylektrylek

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@markples@trylek@jkoritzinsky

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove unnecessary "return 100"s from tests by markples · Pull Request #89550 · dotnet/runtime · GitHub
Skip to content
Remove unnecessary "return 100"s from tests - #89550
Merged
trylek merged 9 commits into
dotnet:mainfrom 
markples:ret100
Aug 22, 2023
Merged
Remove unnecessary "return 100"s from tests#89550
trylek merged 9 commits into
dotnet:mainfrom 
markples:ret100
Conversation
@markples
@markplesmarkples
commented
Jul 27, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Add XUnitWrapperGenerator check for test methods that always return 100 and change them to void.
@ghostghost
assigned markplesJul 27, 2023
@ghost
ghost
commented
Jul 27, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-reflection-metadata

See info in area-owners.md if you want to be subscribed.
Issue Details
Note: contains #89521
Add XUnitWrapperGenerator check for test methods that always return 100 and change them to void.
Author:markples
Assignees:markples
Labels:
area-System.Reflection.Metadata
Milestone:-
@markplesmarkples
added

area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
and removed

area-System.Reflection.Metadata

labels
Jul 27, 2023
@ghost
ghost
commented
Jul 27, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
Note: contains #89521
Add XUnitWrapperGenerator check for test methods that always return 100 and change them to void.
Author:markples
Assignees:markples
Labels:
area-CodeGen-coreclr
Milestone:-
@markplesmarkples
mentioned this pull request
Jul 27, 2023
 Merged

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 27, 2023

Closed

@markplesmarkples
mentioned this pull request
Jul 27, 2023
 Merged

@markples
markples
commented
Jul 28, 2023

Copy link


Copy Markdown

ContributorAuthor
This should be ready @trylek@jkoritzinsky@TIHan cc @dotnet/jit-contrib.
The actual change is small. Tests are almost entirely changing to void and very occasionally something related to that. I've scanned the entire diff though of course I'm the author.
@markples
markples
marked this pull request as ready for review
July 28, 2023 19:38
jkoritzinsky
jkoritzinsky
reviewed
Jul 28, 2023
View reviewed changes
Comment threadsrc/tests/Common/XUnitWrapperGenerator/XUnitWrapperGenerator.cs
Outdated


Comment on lines

153
 to 
164

@jkoritzinskyjkoritzinskyJul 28, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a future PR, I think it's worthwhile moving these checks into a separate analyzer instead of doing them as part of the source generator. If we do them in an analyzer, we can get better performance at build time and we could use better tools (like the IOperation APIs) to validate these sorts of scenarios.
@markplesmarkplesJul 28, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea but mainly did it this way because I'm unfamiliar with all of this and couldn't easily figure out how to set anything up (primarily copying and pasting in this file). So I'll either need a template for doing so or more time to turn the docs/bing chat into something real.
trylek
trylek
approved these changes
Jul 28, 2023
View reviewed changes
@trylektrylek
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!
@markples
markples
commented
Jul 28, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Jul 28, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
new analyzer means a race condition with newly added tests (audit commits and/or rerun old test jobs)
@markplesmarkples
assigned trylek and unassigned markplesAug 8, 2023
@trylek
trylek
commented
Aug 22, 2023

Copy link


Copy Markdown

Member
I have rebased this against the current main, the change is passing locally for me, I plan to merge it in once I find the lab results reasonable.
@trylek
trylek
commented
Aug 22, 2023

Copy link


Copy Markdown

Member
/azp run runtime-coreclr outerloop
@trylek
trylek
commented
Aug 22, 2023

Copy link


Copy Markdown

Member
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Aug 22, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment

@azure-pipelines
azure-pipelinesBot
commented
Aug 22, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Aug 22, 2023

Closed


Closed


Closed


Closed


Open

@trylek
trylek
commented
Aug 22, 2023

Copy link


Copy Markdown

Member
Just like in the previous case runtime and outerloop are clean and runtime-extra-platforms, while not clean, doesn't look any worse than in any other runs, merging in.
@trylek
trylek
merged commit 5d00fc5
into
dotnet:mainAug 22, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 22, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 21, 2023
@markples
markples
deleted the

ret100

branch
September 28, 2023 23:34
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkoritzinskyjkoritzinskyjkoritzinsky approved these changes
@trylektrylektrylek approved these changes

Assignees

@trylektrylek

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@markples@trylek@jkoritzinsky

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove unnecessary "return 100"s from tests by markples · Pull Request #89550 · dotnet/runtime · GitHub
Skip to content
Remove unnecessary "return 100"s from tests - #89550
Merged
trylek merged 9 commits into
dotnet:mainfrom 
markples:ret100
Aug 22, 2023
Merged
Remove unnecessary "return 100"s from tests#89550
trylek merged 9 commits into
dotnet:mainfrom 
markples:ret100
Conversation
@markples
@markplesmarkples
commented
Jul 27, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Add XUnitWrapperGenerator check for test methods that always return 100 and change them to void.
@ghostghost
assigned markplesJul 27, 2023
@ghost
ghost
commented
Jul 27, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-reflection-metadata

See info in area-owners.md if you want to be subscribed.
Issue Details
Note: contains #89521
Add XUnitWrapperGenerator check for test methods that always return 100 and change them to void.
Author:markples
Assignees:markples
Labels:
area-System.Reflection.Metadata
Milestone:-
@markplesmarkples
added

area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
and removed

area-System.Reflection.Metadata

labels
Jul 27, 2023
@ghost
ghost
commented
Jul 27, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
Note: contains #89521
Add XUnitWrapperGenerator check for test methods that always return 100 and change them to void.
Author:markples
Assignees:markples
Labels:
area-CodeGen-coreclr
Milestone:-
@markplesmarkples
mentioned this pull request
Jul 27, 2023
 Merged

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 27, 2023

Closed

@markplesmarkples
mentioned this pull request
Jul 27, 2023
 Merged

@markples
markples
commented
Jul 28, 2023

Copy link


Copy Markdown

ContributorAuthor
This should be ready @trylek@jkoritzinsky@TIHan cc @dotnet/jit-contrib.
The actual change is small. Tests are almost entirely changing to void and very occasionally something related to that. I've scanned the entire diff though of course I'm the author.
@markples
markples
marked this pull request as ready for review
July 28, 2023 19:38
jkoritzinsky
jkoritzinsky
reviewed
Jul 28, 2023
View reviewed changes
Comment threadsrc/tests/Common/XUnitWrapperGenerator/XUnitWrapperGenerator.cs
Outdated


Comment on lines

153
 to 
164

@jkoritzinskyjkoritzinskyJul 28, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a future PR, I think it's worthwhile moving these checks into a separate analyzer instead of doing them as part of the source generator. If we do them in an analyzer, we can get better performance at build time and we could use better tools (like the IOperation APIs) to validate these sorts of scenarios.
@markplesmarkplesJul 28, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea but mainly did it this way because I'm unfamiliar with all of this and couldn't easily figure out how to set anything up (primarily copying and pasting in this file). So I'll either need a template for doing so or more time to turn the docs/bing chat into something real.
trylek
trylek
approved these changes
Jul 28, 2023
View reviewed changes
@trylektrylek
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!
@markples
markples
commented
Jul 28, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Jul 28, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
new analyzer means a race condition with newly added tests (audit commits and/or rerun old test jobs)
@markplesmarkples
assigned trylek and unassigned markplesAug 8, 2023
@trylek
trylek
commented
Aug 22, 2023

Copy link


Copy Markdown

Member
I have rebased this against the current main, the change is passing locally for me, I plan to merge it in once I find the lab results reasonable.
@trylek
trylek
commented
Aug 22, 2023

Copy link


Copy Markdown

Member
/azp run runtime-coreclr outerloop
@trylek
trylek
commented
Aug 22, 2023

Copy link


Copy Markdown

Member
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Aug 22, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment

@azure-pipelines
azure-pipelinesBot
commented
Aug 22, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Aug 22, 2023

Closed


Closed


Closed


Closed


Open

@trylek
trylek
commented
Aug 22, 2023

Copy link


Copy Markdown

Member
Just like in the previous case runtime and outerloop are clean and runtime-extra-platforms, while not clean, doesn't look any worse than in any other runs, merging in.
@trylek
trylek
merged commit 5d00fc5
into
dotnet:mainAug 22, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 22, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 21, 2023
@markples
markples
deleted the

ret100

branch
September 28, 2023 23:34
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkoritzinskyjkoritzinskyjkoritzinsky approved these changes
@trylektrylektrylek approved these changes

Assignees

@trylektrylek

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@markples@trylek@jkoritzinsky

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Remove unnecessary "return 100"s from tests by markples · Pull Request #89550 · dotnet/runtime · GitHub
Skip to content
Remove unnecessary "return 100"s from tests - #89550
Merged
trylek merged 9 commits into
dotnet:mainfrom 
markples:ret100
Aug 22, 2023
Merged
Remove unnecessary "return 100"s from tests#89550
trylek merged 9 commits into
dotnet:mainfrom 
markples:ret100
Conversation
@markples
@markplesmarkples
commented
Jul 27, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Add XUnitWrapperGenerator check for test methods that always return 100 and change them to void.
@ghostghost
assigned markplesJul 27, 2023
@ghost
ghost
commented
Jul 27, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-reflection-metadata

See info in area-owners.md if you want to be subscribed.
Issue Details
Note: contains #89521
Add XUnitWrapperGenerator check for test methods that always return 100 and change them to void.
Author:markples
Assignees:markples
Labels:
area-System.Reflection.Metadata
Milestone:-
@markplesmarkples
added

area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
and removed

area-System.Reflection.Metadata

labels
Jul 27, 2023
@ghost
ghost
commented
Jul 27, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
Note: contains #89521
Add XUnitWrapperGenerator check for test methods that always return 100 and change them to void.
Author:markples
Assignees:markples
Labels:
area-CodeGen-coreclr
Milestone:-
@markplesmarkples
mentioned this pull request
Jul 27, 2023
 Merged

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 27, 2023

Closed

@markplesmarkples
mentioned this pull request
Jul 27, 2023
 Merged

@markples
markples
commented
Jul 28, 2023

Copy link


Copy Markdown

ContributorAuthor
This should be ready @trylek@jkoritzinsky@TIHan cc @dotnet/jit-contrib.
The actual change is small. Tests are almost entirely changing to void and very occasionally something related to that. I've scanned the entire diff though of course I'm the author.
@markples
markples
marked this pull request as ready for review
July 28, 2023 19:38
jkoritzinsky
jkoritzinsky
reviewed
Jul 28, 2023
View reviewed changes
Comment threadsrc/tests/Common/XUnitWrapperGenerator/XUnitWrapperGenerator.cs
Outdated


Comment on lines

153
 to 
164

@jkoritzinskyjkoritzinskyJul 28, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a future PR, I think it's worthwhile moving these checks into a separate analyzer instead of doing them as part of the source generator. If we do them in an analyzer, we can get better performance at build time and we could use better tools (like the IOperation APIs) to validate these sorts of scenarios.
@markplesmarkplesJul 28, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea but mainly did it this way because I'm unfamiliar with all of this and couldn't easily figure out how to set anything up (primarily copying and pasting in this file). So I'll either need a template for doing so or more time to turn the docs/bing chat into something real.
trylek
trylek
approved these changes
Jul 28, 2023
View reviewed changes
@trylektrylek
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!
@markples
markples
commented
Jul 28, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Jul 28, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
new analyzer means a race condition with newly added tests (audit commits and/or rerun old test jobs)
@markplesmarkples
assigned trylek and unassigned markplesAug 8, 2023
@trylek
trylek
commented
Aug 22, 2023

Copy link


Copy Markdown

Member
I have rebased this against the current main, the change is passing locally for me, I plan to merge it in once I find the lab results reasonable.
@trylek
trylek
commented
Aug 22, 2023

Copy link


Copy Markdown

Member
/azp run runtime-coreclr outerloop
@trylek
trylek
commented
Aug 22, 2023

Copy link


Copy Markdown

Member
/azp run runtime-extra-platforms
@azure-pipelines
azure-pipelinesBot
commented
Aug 22, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment

@azure-pipelines
azure-pipelinesBot
commented
Aug 22, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Aug 22, 2023

Closed


Closed


Closed


Closed


Open

@trylek
trylek
commented
Aug 22, 2023

Copy link


Copy Markdown

Member
Just like in the previous case runtime and outerloop are clean and runtime-extra-platforms, while not clean, doesn't look any worse than in any other runs, merging in.
@trylek
trylek
merged commit 5d00fc5
into
dotnet:mainAug 22, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 22, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 21, 2023
@markples
markples
deleted the

ret100

branch
September 28, 2023 23:34
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkoritzinskyjkoritzinskyjkoritzinsky approved these changes
@trylektrylektrylek approved these changes

Assignees

@trylektrylek

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@markples@trylek@jkoritzinsky