') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Fix FrozenCollection tests failing in Native AOT by eiriktsarpalis · Pull Request #89569 · dotnet/runtime · GitHub
Skip to content

Fix FrozenCollection tests failing in Native AOT - #89569

Merged
eiriktsarpalis merged 1 commit into
dotnet:mainfrom
eiriktsarpalis:fix/aot-frozen-collections
Jul 27, 2023
Merged

Fix FrozenCollection tests failing in Native AOT#89569
eiriktsarpalis merged 1 commit into
dotnet:mainfrom
eiriktsarpalis:fix/aot-frozen-collections

Conversation

@eiriktsarpalis

@eiriktsarpaliseiriktsarpalis commented Jul 27, 2023

Copy link
Copy Markdown
Member

Fix#88628.

@eiriktsarpaliseiriktsarpalis added this to the 8.0.0 milestone Jul 27, 2023
@eiriktsarpaliseiriktsarpalis self-assigned this Jul 27, 2023
@ghost

ghost commented Jul 27, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-collections
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #88628.

Author:eiriktsarpalis
Assignees:eiriktsarpalis
Labels:

area-System.Collections

Milestone:8.0.0

@eiriktsarpalis

eiriktsarpalis commented Jul 27, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Jul 27, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

eerhardt
eerhardt approved these changes Jul 27, 2023
View reviewed changes

@eerhardteerhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the tests pass now - LGTM

Comment threadsrc/libraries/System.Collections.Immutable/tests/default.rd.xml
</Method>
</Type>

<Type Name="Xunit.Sdk.AssertEqualityComparer`1[[System.Collections.Generic.HashSet`1[[System.Collections.Generic.KeyValuePair`2[[System.SByte, System.Private.CoreLib],[System.SByte, System.Private.CoreLib]],System.Private.CoreLib]],System.Private.CoreLib]]" Dynamic="Required All">

@eerhardteerhardtJul 27, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agocke, do you have a timeline when we will have Xunit asserts that work in NativeAOT?

@agockeagockeJul 27, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have it in a branch locally, and just keep getting interrupted by other stuff. I will likely work on it more after we shut down the platform, as infra will be more important then.

@eiriktsarpalis
eiriktsarpalis merged commit c02a026 into dotnet:mainJul 27, 2023
@eiriktsarpalis
eiriktsarpalis deleted the fix/aot-frozen-collections branch July 27, 2023 17:58
This was referenced Jul 27, 2023
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
Closed
@ghostghost locked as resolved and limited conversation to collaborators Aug 26, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@agockeagockeagocke left review comments
@eerhardteerhardteerhardt approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovsky

Assignees

@eiriktsarpaliseiriktsarpalis

Labels

area-System.Collections

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Frozen collection tests fail on NativeAOT

3 participants

@eiriktsarpalis@agocke@eerhardt